From: Josh Durgin <josh.durgin@inktank.com>
To: Alex Elder <elder@inktank.com>
Cc: ceph-devel@vger.kernel.org
Subject: Re: [PATCH 2/2] rbd: fix read-only option name
Date: Wed, 24 Oct 2012 10:02:13 -0700 [thread overview]
Message-ID: <50881F15.6040207@inktank.com> (raw)
In-Reply-To: <50857809.2010303@inktank.com>
Reviewed-by: Josh Durgin <josh.durgin@inktank.com>
On 10/22/2012 09:44 AM, Alex Elder wrote:
> The name of the "read-only" mapping option was inadvertently changed
> in this commit:
>
> f84344f3 rbd: separate mapping info in rbd_dev
>
> Revert that hunk to return it to what it should be.
>
> Signed-off-by: Alex Elder <elder@inktank.com>
> ---
> drivers/block/rbd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
> index 65e9f1f..d032883 100644
> --- a/drivers/block/rbd.c
> +++ b/drivers/block/rbd.c
> @@ -397,7 +397,7 @@ enum {
> static match_table_t rbd_opts_tokens = {
> /* int args above */
> /* string args above */
> - {Opt_read_only, "mapping.read_only"},
> + {Opt_read_only, "read_only"},
> {Opt_read_only, "ro"}, /* Alternate spelling */
> {Opt_read_write, "read_write"},
> {Opt_read_write, "rw"}, /* Alternate spelling */
>
prev parent reply other threads:[~2012-10-24 17:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-22 16:43 [PATCH 0/2] rbd: two bugs Alex Elder
2012-10-22 16:44 ` [PATCH 1/2] rbd: zero return code in rbd_dev_image_id() Alex Elder
2012-10-22 17:18 ` Dan Mick
2012-10-22 20:00 ` Dan Mick
2012-10-24 16:59 ` Josh Durgin
2012-10-22 16:44 ` [PATCH 2/2] rbd: fix read-only option name Alex Elder
2012-10-24 17:02 ` Josh Durgin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50881F15.6040207@inktank.com \
--to=josh.durgin@inktank.com \
--cc=ceph-devel@vger.kernel.org \
--cc=elder@inktank.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.