All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/5] cpu_single_env cleanup
Date: Wed, 31 Oct 2012 04:59:14 +0100	[thread overview]
Message-ID: <5090A212.4020001@suse.de> (raw)
In-Reply-To: <cover.1351436501.git.blauwirbel@gmail.com>

Am 28.10.2012 16:03, schrieb Blue Swirl:
> In some cases it's pretty easy to avoid using global
> cpu_single_env since a local version is available.
> 
> Blue Swirl (5):
>   disas: avoid using cpu_single_env
>   kvm: avoid using cpu_single_env
>   target-unicore32: avoid using cpu_single_env
>   target-xtensa: avoid using cpu_single_env
>   target-i386: avoid using cpu_single_env

Each of these has been reviewed by at least a second pair of eyes now. I
recently stumbled over cpu_single_env as an obstacle to actually using
CPUState somewhere, so I'm happy about removing some occurrences.

Have you considered using FooCPU arguments in target-specific code
(e.g., last three) and decided against it?

I checked that they build bisectably and still apply on top of my PULL;
you being a committer, are you planning to apply these directly, or
should I queue them for the next CPU pull and fix the messages myself?

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

      parent reply	other threads:[~2012-10-31  3:59 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-28 15:03 [Qemu-devel] [PATCH 0/5] cpu_single_env cleanup Blue Swirl
2012-10-28 15:03 ` [Qemu-devel] [PATCH 1/5] disas: avoid using cpu_single_env Blue Swirl
2012-10-29  4:45   ` Richard Henderson
2012-10-29  9:06   ` Andreas Färber
2012-10-29 14:36   ` Aurelien Jarno
     [not found]   ` <92f1e4fe1bf16c76d53eef0dcf9389865a66e0dd.1351436501.git.blauwirbel@gm ail.com>
2012-10-31  4:20     ` guanxuetao
2012-10-28 15:03 ` [PATCH 2/5] kvm: " Blue Swirl
2012-10-28 15:03   ` [Qemu-devel] " Blue Swirl
2012-10-31  3:25   ` Andreas Färber
2012-10-31  3:25     ` Andreas Färber
2012-10-28 15:03 ` [Qemu-devel] [PATCH 3/5] target-unicore32: " Blue Swirl
     [not found]   ` <5cd15b325c56b2b7fe0b315c52a9b5094ce73633.1351436501.git.blauwirbel@gm ail.com>
2012-10-31  2:55     ` guanxuetao
2012-10-31  3:26   ` Andreas Färber
2012-10-28 15:03 ` [Qemu-devel] [PATCH 4/5] target-xtensa: " Blue Swirl
2012-10-29  5:58   ` Max Filippov
2012-10-31  3:28   ` Andreas Färber
2012-10-28 15:03 ` [Qemu-devel] [PATCH 5/5] target-i386: " Blue Swirl
2012-10-31  3:41   ` Andreas Färber
2012-10-31  3:59 ` Andreas Färber [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5090A212.4020001@suse.de \
    --to=afaerber@suse.de \
    --cc=blauwirbel@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.