* [PATCH 1/5] staging: rtl8712: avoid camelcase variable name 'bPowerOn'
[not found] <cover.1553327467.git.payal.s.kshirsagar.98@gmail.com>
@ 2019-03-23 7:58 ` Payal Kshirsagar
2019-03-23 8:13 ` [Outreachy kernel] " Julia Lawall
2019-03-23 7:58 ` [PATCH 2/5] staging: rtl8712: avoid camelcase variable name 'bResult' Payal Kshirsagar
` (3 subsequent siblings)
4 siblings, 1 reply; 10+ messages in thread
From: Payal Kshirsagar @ 2019-03-23 7:58 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Payal Kshirsagar, pkbehappyallthetime
Eliminate camelcase variable names to fix the style issue – ‘avoid
camelcase’
Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
---
drivers/staging/rtl8712/rtl8712_efuse.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl8712_efuse.c b/drivers/staging/rtl8712/rtl8712_efuse.c
index 00babd0..3275f7a 100644
--- a/drivers/staging/rtl8712/rtl8712_efuse.c
+++ b/drivers/staging/rtl8712/rtl8712_efuse.c
@@ -23,11 +23,11 @@
/* reserve 3 bytes for HW stop read */
static int efuse_available_max_size = EFUSE_MAX_SIZE - 3 /*0x1FD*/;
-static void efuse_reg_ctrl(struct _adapter *padapter, u8 bPowerOn)
+static void efuse_reg_ctrl(struct _adapter *padapter, u8 power_on)
{
u8 tmpu8 = 0;
- if (bPowerOn) {
+ if (power_on) {
/* -----------------e-fuse pwr & clk reg ctrl ---------------
* Enable LDOE25 Macro Block
*/
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 2/5] staging: rtl8712: avoid camelcase variable name 'bResult'
[not found] <cover.1553327467.git.payal.s.kshirsagar.98@gmail.com>
2019-03-23 7:58 ` [PATCH 1/5] staging: rtl8712: avoid camelcase variable name 'bPowerOn' Payal Kshirsagar
@ 2019-03-23 7:58 ` Payal Kshirsagar
2019-03-23 7:58 ` [PATCH 3/5] staging: rtl8712: avoid camelcase variable name 'bRead' Payal Kshirsagar
` (2 subsequent siblings)
4 siblings, 0 replies; 10+ messages in thread
From: Payal Kshirsagar @ 2019-03-23 7:58 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Payal Kshirsagar, pkbehappyallthetime
Eliminate camelcase variable names to fix the style issue – ‘avoid
camelcase’
Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
---
drivers/staging/rtl8712/rtl8712_efuse.c | 42 ++++++++++++++++-----------------
1 file changed, 21 insertions(+), 21 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl8712_efuse.c b/drivers/staging/rtl8712/rtl8712_efuse.c
index 3275f7a..1a6cd42 100644
--- a/drivers/staging/rtl8712/rtl8712_efuse.c
+++ b/drivers/staging/rtl8712/rtl8712_efuse.c
@@ -65,7 +65,7 @@ void r8712_efuse_reg_uninit(struct _adapter *padapter)
static u8 efuse_one_byte_read(struct _adapter *padapter, u16 addr, u8 *data)
{
- u8 tmpidx = 0, bResult;
+ u8 tmpidx = 0, result;
/* -----------------e-fuse reg ctrl --------------------------------- */
r8712_write8(padapter, EFUSE_CTRL + 1, (u8)(addr & 0xFF)); /* address */
@@ -78,17 +78,17 @@ static u8 efuse_one_byte_read(struct _adapter *padapter, u16 addr, u8 *data)
tmpidx++;
if (tmpidx < 100) {
*data = r8712_read8(padapter, EFUSE_CTRL);
- bResult = true;
+ result = true;
} else {
*data = 0xff;
- bResult = false;
+ result = false;
}
- return bResult;
+ return result;
}
static u8 efuse_one_byte_write(struct _adapter *padapter, u16 addr, u8 data)
{
- u8 tmpidx = 0, bResult;
+ u8 tmpidx = 0, result;
/* -----------------e-fuse reg ctrl -------------------------------- */
r8712_write8(padapter, EFUSE_CTRL + 1, (u8)(addr & 0xFF)); /* address */
@@ -101,16 +101,16 @@ static u8 efuse_one_byte_write(struct _adapter *padapter, u16 addr, u8 data)
(tmpidx < 100))
tmpidx++;
if (tmpidx < 100)
- bResult = true;
+ result = true;
else
- bResult = false;
- return bResult;
+ result = false;
+ return result;
}
static u8 efuse_one_byte_rw(struct _adapter *padapter, u8 bRead, u16 addr,
u8 *data)
{
- u8 tmpidx = 0, tmpv8 = 0, bResult;
+ u8 tmpidx = 0, tmpv8 = 0, result;
/* -----------------e-fuse reg ctrl --------------------------------- */
r8712_write8(padapter, EFUSE_CTRL + 1, (u8)(addr & 0xFF)); /* address */
@@ -124,10 +124,10 @@ static u8 efuse_one_byte_rw(struct _adapter *padapter, u8 bRead, u16 addr,
tmpidx++;
if (tmpidx < 100) {
*data = r8712_read8(padapter, EFUSE_CTRL);
- bResult = true;
+ result = true;
} else {
*data = 0;
- bResult = false;
+ result = false;
}
} else {
r8712_write8(padapter, EFUSE_CTRL, *data); /* data */
@@ -136,11 +136,11 @@ static u8 efuse_one_byte_rw(struct _adapter *padapter, u8 bRead, u16 addr,
(tmpidx < 100))
tmpidx++;
if (tmpidx < 100)
- bResult = true;
+ result = true;
else
- bResult = false;
+ result = false;
}
- return bResult;
+ return result;
}
static u8 efuse_is_empty(struct _adapter *padapter, u8 *empty)
@@ -360,7 +360,7 @@ u8 r8712_efuse_pg_packet_write(struct _adapter *padapter, const u8 offset,
u8 efuse_data, target_word_cnts = 0;
int repeat_times;
int sub_repeat;
- u8 bResult = true;
+ u8 result = true;
/* check if E-Fuse Clock Enable and E-Fuse Clock is 40M */
efuse_data = r8712_read8(padapter, EFUSE_CLK_CTRL);
@@ -382,7 +382,7 @@ u8 r8712_efuse_pg_packet_write(struct _adapter *padapter, const u8 offset,
while (!efuse_one_byte_read(padapter, efuse_addr,
&efuse_data)) {
if (++sub_repeat > _REPEAT_THRESHOLD_) {
- bResult = false; /* continue to blind write */
+ result = false; /* continue to blind write */
break; /* continue to blind write */
}
}
@@ -400,16 +400,16 @@ u8 r8712_efuse_pg_packet_write(struct _adapter *padapter, const u8 offset,
if (!efuse_one_byte_read(padapter,
efuse_addr + i,
&efuse_data))
- bResult = false;
+ result = false;
else if (*(data + i) != efuse_data) /* fail */
- bResult = false;
+ result = false;
}
break;
}
/* write header fail */
- bResult = false;
+ result = false;
if (efuse_data == 0xFF)
- return bResult; /* nothing damaged. */
+ return result; /* nothing damaged. */
/* call rescue procedure */
if (!fix_header(padapter, efuse_data, efuse_addr))
return false; /* rescue fail */
@@ -418,7 +418,7 @@ u8 r8712_efuse_pg_packet_write(struct _adapter *padapter, const u8 offset,
break;
/* otherwise, take another risk... */
}
- return bResult;
+ return result;
}
u8 r8712_efuse_access(struct _adapter *padapter, u8 bRead, u16 start_addr,
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 3/5] staging: rtl8712: avoid camelcase variable name 'bRead'
[not found] <cover.1553327467.git.payal.s.kshirsagar.98@gmail.com>
2019-03-23 7:58 ` [PATCH 1/5] staging: rtl8712: avoid camelcase variable name 'bPowerOn' Payal Kshirsagar
2019-03-23 7:58 ` [PATCH 2/5] staging: rtl8712: avoid camelcase variable name 'bResult' Payal Kshirsagar
@ 2019-03-23 7:58 ` Payal Kshirsagar
2019-03-23 7:58 ` [PATCH 4/5] staging: rtl8712: avoid camelcase variable name 'bContinual' Payal Kshirsagar
2019-03-23 7:58 ` [PATCH 5/5] staging: rtl8712: Lines should not end with a parenthesis Payal Kshirsagar
4 siblings, 0 replies; 10+ messages in thread
From: Payal Kshirsagar @ 2019-03-23 7:58 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Payal Kshirsagar, pkbehappyallthetime
Eliminate camelcase variable names to fix the style issue – ‘avoid
camelcase’
Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
---
drivers/staging/rtl8712/rtl8712_efuse.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl8712_efuse.c b/drivers/staging/rtl8712/rtl8712_efuse.c
index 1a6cd42..dd007280 100644
--- a/drivers/staging/rtl8712/rtl8712_efuse.c
+++ b/drivers/staging/rtl8712/rtl8712_efuse.c
@@ -107,7 +107,7 @@ static u8 efuse_one_byte_write(struct _adapter *padapter, u16 addr, u8 data)
return result;
}
-static u8 efuse_one_byte_rw(struct _adapter *padapter, u8 bRead, u16 addr,
+static u8 efuse_one_byte_rw(struct _adapter *padapter, u8 read, u16 addr,
u8 *data)
{
u8 tmpidx = 0, tmpv8 = 0, result;
@@ -117,7 +117,7 @@ static u8 efuse_one_byte_rw(struct _adapter *padapter, u8 bRead, u16 addr,
tmpv8 = ((u8)((addr >> 8) & 0x03)) |
(r8712_read8(padapter, EFUSE_CTRL + 2) & 0xFC);
r8712_write8(padapter, EFUSE_CTRL + 2, tmpv8);
- if (bRead) {
+ if (read) {
r8712_write8(padapter, EFUSE_CTRL + 3, 0x72); /* read cmd */
while (!(0x80 & r8712_read8(padapter, EFUSE_CTRL + 3)) &&
(tmpidx < 100))
@@ -421,7 +421,7 @@ u8 r8712_efuse_pg_packet_write(struct _adapter *padapter, const u8 offset,
return result;
}
-u8 r8712_efuse_access(struct _adapter *padapter, u8 bRead, u16 start_addr,
+u8 r8712_efuse_access(struct _adapter *padapter, u8 read, u16 start_addr,
u16 cnts, u8 *data)
{
int i;
@@ -429,10 +429,10 @@ u8 r8712_efuse_access(struct _adapter *padapter, u8 bRead, u16 start_addr,
if (start_addr > EFUSE_MAX_SIZE)
return false;
- if (!bRead && ((start_addr + cnts) >
+ if (!read && ((start_addr + cnts) >
efuse_available_max_size))
return false;
- if (!bRead && !r8712_efuse_reg_init(padapter))
+ if (!read && !r8712_efuse_reg_init(padapter))
return false;
/* -----------------e-fuse one byte read / write ---------------------*/
for (i = 0; i < cnts; i++) {
@@ -440,12 +440,12 @@ u8 r8712_efuse_access(struct _adapter *padapter, u8 bRead, u16 start_addr,
res = false;
break;
}
- res = efuse_one_byte_rw(padapter, bRead, start_addr + i,
+ res = efuse_one_byte_rw(padapter, read, start_addr + i,
data + i);
- if (!bRead && !res)
+ if (!read && !res)
break;
}
- if (!bRead)
+ if (!read)
r8712_efuse_reg_uninit(padapter);
return res;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 4/5] staging: rtl8712: avoid camelcase variable name 'bContinual'
[not found] <cover.1553327467.git.payal.s.kshirsagar.98@gmail.com>
` (2 preceding siblings ...)
2019-03-23 7:58 ` [PATCH 3/5] staging: rtl8712: avoid camelcase variable name 'bRead' Payal Kshirsagar
@ 2019-03-23 7:58 ` Payal Kshirsagar
2019-03-23 7:58 ` [PATCH 5/5] staging: rtl8712: Lines should not end with a parenthesis Payal Kshirsagar
4 siblings, 0 replies; 10+ messages in thread
From: Payal Kshirsagar @ 2019-03-23 7:58 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Payal Kshirsagar, pkbehappyallthetime
Eliminate camelcase variable names to fix the style issue – ‘avoid
camelcase’
Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
---
drivers/staging/rtl8712/rtl8712_efuse.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl8712_efuse.c b/drivers/staging/rtl8712/rtl8712_efuse.c
index dd007280..34341bf 100644
--- a/drivers/staging/rtl8712/rtl8712_efuse.c
+++ b/drivers/staging/rtl8712/rtl8712_efuse.c
@@ -208,12 +208,12 @@ static void pgpacket_copy_data(const u8 word_en, const u8 *sourdata,
u16 r8712_efuse_get_current_size(struct _adapter *padapter)
{
- int bContinual = true;
+ int continual = true;
u16 efuse_addr = 0;
u8 hworden = 0;
u8 efuse_data, word_cnts = 0;
- while (bContinual && efuse_one_byte_read(padapter, efuse_addr,
+ while (continual && efuse_one_byte_read(padapter, efuse_addr,
&efuse_data) && (efuse_addr < efuse_available_max_size)) {
if (efuse_data != 0xFF) {
hworden = efuse_data & 0x0F;
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 5/5] staging: rtl8712: Lines should not end with a parenthesis
[not found] <cover.1553327467.git.payal.s.kshirsagar.98@gmail.com>
` (3 preceding siblings ...)
2019-03-23 7:58 ` [PATCH 4/5] staging: rtl8712: avoid camelcase variable name 'bContinual' Payal Kshirsagar
@ 2019-03-23 7:58 ` Payal Kshirsagar
4 siblings, 0 replies; 10+ messages in thread
From: Payal Kshirsagar @ 2019-03-23 7:58 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Payal Kshirsagar, pkbehappyallthetime
Adjust code to fix the style issue- ‘Lines should not end with a
parenthesis’.
Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
---
drivers/staging/rtl8712/rtl8712_efuse.c | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl8712_efuse.c b/drivers/staging/rtl8712/rtl8712_efuse.c
index 34341bf..3ff64e2 100644
--- a/drivers/staging/rtl8712/rtl8712_efuse.c
+++ b/drivers/staging/rtl8712/rtl8712_efuse.c
@@ -300,16 +300,14 @@ static u8 fix_header(struct _adapter *padapter, u8 header, u16 header_addr)
for (i = 0; i < PGPKG_MAX_WORDS; i++) {
if (BIT(i) & word_en) {
if (BIT(i) & pkt.word_en) {
- if (efuse_one_byte_read(
- padapter, addr,
- &value))
+ if (efuse_one_byte_read(padapter, addr,
+ &value))
pkt.data[i * 2] = value;
else
return false;
- if (efuse_one_byte_read(
- padapter,
- addr + 1,
- &value))
+ if (efuse_one_byte_read(padapter,
+ addr + 1,
+ &value))
pkt.data[i * 2 + 1] =
value;
else
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [Outreachy kernel] [PATCH 1/5] staging: rtl8712: avoid camelcase variable name 'bPowerOn'
2019-03-23 7:58 ` [PATCH 1/5] staging: rtl8712: avoid camelcase variable name 'bPowerOn' Payal Kshirsagar
@ 2019-03-23 8:13 ` Julia Lawall
2019-03-23 8:25 ` Payal Kshirsagar
0 siblings, 1 reply; 10+ messages in thread
From: Julia Lawall @ 2019-03-23 8:13 UTC (permalink / raw)
To: Payal Kshirsagar; +Cc: outreachy-kernel, pkbehappyallthetime
[-- Attachment #1: Type: text/plain, Size: 2361 bytes --]
When you make a series, it is nice to make a cover letter as well, so that
one can see the scope of the changes all at once. see the tutorial if you
don't know how to do this.
On Sat, 23 Mar 2019, Payal Kshirsagar wrote:
> Eliminate camelcase variable names to fix the style issue – ‘avoid
> camelcase’
>
> Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
> ---
> drivers/staging/rtl8712/rtl8712_efuse.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8712/rtl8712_efuse.c b/drivers/staging/rtl8712/rtl8712_efuse.c
> index 00babd0..3275f7a 100644
> --- a/drivers/staging/rtl8712/rtl8712_efuse.c
> +++ b/drivers/staging/rtl8712/rtl8712_efuse.c
> @@ -23,11 +23,11 @@
> /* reserve 3 bytes for HW stop read */
> static int efuse_available_max_size = EFUSE_MAX_SIZE - 3 /*0x1FD*/;
>
> -static void efuse_reg_ctrl(struct _adapter *padapter, u8 bPowerOn)
> +static void efuse_reg_ctrl(struct _adapter *padapter, u8 power_on)
It seems that bPowerOn always has a boolean value. It would be nice to
add other patches to the series that declare the variables as type bool
instead of u8 (or int in one case).
Actually, this particular function is only called once and only called
with the argument false. The function that looks like it should call this
one with the argument true currently just returns true, I don't know if
this function should be specialized to the false case and then inlined
into the call site, or if it is considered that the true case gives useful
information about the device, even if the code is not used.
julia
> {
> u8 tmpu8 = 0;
>
> - if (bPowerOn) {
> + if (power_on) {
> /* -----------------e-fuse pwr & clk reg ctrl ---------------
> * Enable LDOE25 Macro Block
> */
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/6b2beffe41d8256284179eda6eadd8b9cf0a24fb.1553327467.git.payal.s.kshirsagar.98%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Outreachy kernel] [PATCH 1/5] staging: rtl8712: avoid camelcase variable name 'bPowerOn'
2019-03-23 8:13 ` [Outreachy kernel] " Julia Lawall
@ 2019-03-23 8:25 ` Payal Kshirsagar
2019-03-23 8:42 ` Julia Lawall
0 siblings, 1 reply; 10+ messages in thread
From: Payal Kshirsagar @ 2019-03-23 8:25 UTC (permalink / raw)
To: Julia Lawall; +Cc: outreachy-kernel, pkbehappyallthetime
[-- Attachment #1: Type: text/plain, Size: 3276 bytes --]
On Sat, 23 Mar 2019 at 13:43, Julia Lawall <julia.lawall@lip6.fr> wrote:
> When you make a series, it is nice to make a cover letter as well, so that
> one can see the scope of the changes all at once. see the tutorial if you
> don't know how to do this.
>
> Sending.
On Sat, 23 Mar 2019, Payal Kshirsagar wrote:
>
> > Eliminate camelcase variable names to fix the style issue – ‘avoid
> > camelcase’
> >
> > Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
> > ---
> > drivers/staging/rtl8712/rtl8712_efuse.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8712/rtl8712_efuse.c
> b/drivers/staging/rtl8712/rtl8712_efuse.c
> > index 00babd0..3275f7a 100644
> > --- a/drivers/staging/rtl8712/rtl8712_efuse.c
> > +++ b/drivers/staging/rtl8712/rtl8712_efuse.c
> > @@ -23,11 +23,11 @@
> > /* reserve 3 bytes for HW stop read */
> > static int efuse_available_max_size = EFUSE_MAX_SIZE - 3 /*0x1FD*/;
> >
> > -static void efuse_reg_ctrl(struct _adapter *padapter, u8 bPowerOn)
> > +static void efuse_reg_ctrl(struct _adapter *padapter, u8 power_on)
>
> It seems that bPowerOn always has a boolean value. It would be nice to
> add other patches to the series that declare the variables as type bool
> instead of u8 (or int in one case).
>
> Actually, this particular function is only called once and only called
> with the argument false. The function that looks like it should call this
> one with the argument true currently just returns true, I don't know if
> this function should be specialized to the false case and then inlined
> into the call site, or if it is considered that the true case gives useful
> information about the device, even if the code is not used.
>
>
Do you want me to do further changes?
thanks,
payal
> julia
>
> > {
> > u8 tmpu8 = 0;
> >
> > - if (bPowerOn) {
> > + if (power_on) {
> > /* -----------------e-fuse pwr & clk reg ctrl
> ---------------
> > * Enable LDOE25 Macro Block
> > */
> > --
> > 2.7.4
> >
> > --
> > You received this message because you are subscribed to the Google
> Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send
> an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit
> https://groups.google.com/d/msgid/outreachy-kernel/6b2beffe41d8256284179eda6eadd8b9cf0a24fb.1553327467.git.payal.s.kshirsagar.98%40gmail.com
> .
> > For more options, visit https://groups.google.com/d/optout.
> >
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/outreachy-kernel/alpine.DEB.2.21.1903230910120.2537%40hadrien
> .
> For more options, visit https://groups.google.com/d/optout.
>
[-- Attachment #2: Type: text/html, Size: 5064 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Outreachy kernel] [PATCH 1/5] staging: rtl8712: avoid camelcase variable name 'bPowerOn'
2019-03-23 8:25 ` Payal Kshirsagar
@ 2019-03-23 8:42 ` Julia Lawall
2019-03-23 8:47 ` Payal Kshirsagar
0 siblings, 1 reply; 10+ messages in thread
From: Julia Lawall @ 2019-03-23 8:42 UTC (permalink / raw)
To: Payal Kshirsagar; +Cc: outreachy-kernel, pkbehappyallthetime
[-- Attachment #1: Type: text/plain, Size: 4423 bytes --]
On Sat, 23 Mar 2019, Payal Kshirsagar wrote:
>
>
> On Sat, 23 Mar 2019 at 13:43, Julia Lawall <julia.lawall@lip6.fr> wrote:
> When you make a series, it is nice to make a cover letter as
> well, so that
> one can see the scope of the changes all at once. see the
> tutorial if you
> don't know how to do this.
>
> Sending.
>
> On Sat, 23 Mar 2019, Payal Kshirsagar wrote:
>
> > Eliminate camelcase variable names to fix the style issue –
> ‘avoid
> > camelcase’
> >
> > Signed-off-by: Payal Kshirsagar
> <payal.s.kshirsagar.98@gmail.com>
> > ---
> > drivers/staging/rtl8712/rtl8712_efuse.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8712/rtl8712_efuse.c
> b/drivers/staging/rtl8712/rtl8712_efuse.c
> > index 00babd0..3275f7a 100644
> > --- a/drivers/staging/rtl8712/rtl8712_efuse.c
> > +++ b/drivers/staging/rtl8712/rtl8712_efuse.c
> > @@ -23,11 +23,11 @@
> > /* reserve 3 bytes for HW stop read */
> > static int efuse_available_max_size = EFUSE_MAX_SIZE - 3
> /*0x1FD*/;
> >
> > -static void efuse_reg_ctrl(struct _adapter *padapter, u8
> bPowerOn)
> > +static void efuse_reg_ctrl(struct _adapter *padapter, u8
> power_on)
>
> It seems that bPowerOn always has a boolean value. It would be
> nice to
> add other patches to the series that declare the variables as
> type bool
> instead of u8 (or int in one case).
>
> Actually, this particular function is only called once and only
> called
> with the argument false. The function that looks like it should
> call this
> one with the argument true currently just returns true, I don't
> know if
> this function should be specialized to the false case and then
> inlined
> into the call site, or if it is considered that the true case
> gives useful
> information about the device, even if the code is not used.
>
>
> Do you want me to do further changes?
Please do the change from u8 to bool.
julia
> thanks,
> payal
> julia
>
> > {
> > u8 tmpu8 = 0;
> >
> > - if (bPowerOn) {
> > + if (power_on) {
> > /* -----------------e-fuse pwr & clk reg ctrl
> ---------------
> > * Enable LDOE25 Macro Block
> > */
> > --
> > 2.7.4
> >
> > --
> > You received this message because you are subscribed to the
> Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from
> it, send an email to
> outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to
> outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/6b2beffe41d8256284179eda
> 6eadd8b9cf0a24fb.1553327467.git.payal.s.kshirsagar.98%40gmail.com.
> > For more options, visit https://groups.google.com/d/optout.
> >
>
> --
> You received this message because you are subscribed to the
> Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from
> it, send an email to
> outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to
> outreachy-kernel@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/alpine.DEB.2.21.19032309
> 10120.2537%40hadrien.
> For more options, visit https://groups.google.com/d/optout.
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/CANTOzWFyaovbYWFXJZhwL3L
> ygV-As8CTbWOKR7K0eY50uj8ryg%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Outreachy kernel] [PATCH 1/5] staging: rtl8712: avoid camelcase variable name 'bPowerOn'
2019-03-23 8:42 ` Julia Lawall
@ 2019-03-23 8:47 ` Payal Kshirsagar
2019-03-23 16:22 ` Payal Kshirsagar
0 siblings, 1 reply; 10+ messages in thread
From: Payal Kshirsagar @ 2019-03-23 8:47 UTC (permalink / raw)
To: Julia Lawall; +Cc: outreachy-kernel
[-- Attachment #1: Type: text/plain, Size: 5405 bytes --]
On Sat, Mar 23, 2019, 2:12 PM Julia Lawall <julia.lawall@lip6.fr> wrote:
>
>
> On Sat, 23 Mar 2019, Payal Kshirsagar wrote:
>
> >
> >
> > On Sat, 23 Mar 2019 at 13:43, Julia Lawall <julia.lawall@lip6.fr> wrote:
> > When you make a series, it is nice to make a cover letter as
> > well, so that
> > one can see the scope of the changes all at once. see the
> > tutorial if you
> > don't know how to do this.
> >
> > Sending.
> >
> > On Sat, 23 Mar 2019, Payal Kshirsagar wrote:
> >
> > > Eliminate camelcase variable names to fix the style issue –
> > ‘avoid
> > > camelcase’
> > >
> > > Signed-off-by: Payal Kshirsagar
> > <payal.s.kshirsagar.98@gmail.com>
> > > ---
> > > drivers/staging/rtl8712/rtl8712_efuse.c | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/staging/rtl8712/rtl8712_efuse.c
> > b/drivers/staging/rtl8712/rtl8712_efuse.c
> > > index 00babd0..3275f7a 100644
> > > --- a/drivers/staging/rtl8712/rtl8712_efuse.c
> > > +++ b/drivers/staging/rtl8712/rtl8712_efuse.c
> > > @@ -23,11 +23,11 @@
> > > /* reserve 3 bytes for HW stop read */
> > > static int efuse_available_max_size = EFUSE_MAX_SIZE - 3
> > /*0x1FD*/;
> > >
> > > -static void efuse_reg_ctrl(struct _adapter *padapter, u8
> > bPowerOn)
> > > +static void efuse_reg_ctrl(struct _adapter *padapter, u8
> > power_on)
> >
> > It seems that bPowerOn always has a boolean value. It would be
> > nice to
> > add other patches to the series that declare the variables as
> > type bool
> > instead of u8 (or int in one case).
> >
> > Actually, this particular function is only called once and only
> > called
> > with the argument false. The function that looks like it should
> > call this
> > one with the argument true currently just returns true, I don't
> > know if
> > this function should be specialized to the false case and then
> > inlined
> > into the call site, or if it is considered that the true case
> > gives useful
> > information about the device, even if the code is not used.
> >
> >
> > Do you want me to do further changes?
>
> Please do the change from u8 to bool.
> Okay I will change and resend it.
Thanks,
Payal
julia
>
> > thanks,
> > payal
> > julia
> >
> > > {
> > > u8 tmpu8 = 0;
> > >
> > > - if (bPowerOn) {
> > > + if (power_on) {
> > > /* -----------------e-fuse pwr & clk reg ctrl
> > ---------------
> > > * Enable LDOE25 Macro Block
> > > */
> > > --
> > > 2.7.4
> > >
> > > --
> > > You received this message because you are subscribed to the
> > Google Groups "outreachy-kernel" group.
> > > To unsubscribe from this group and stop receiving emails from
> > it, send an email to
> > outreachy-kernel+unsubscribe@googlegroups.com.
> > > To post to this group, send email to
> > outreachy-kernel@googlegroups.com.
> > > To view this discussion on the web visithttps://
> groups.google.com/d/msgid/outreachy-kernel/6b2beffe41d8256284179eda
> > 6eadd8b9cf0a24fb.1553327467.git.payal.s.kshirsagar.98%40gmail.com.
> > > For more options, visit https://groups.google.com/d/optout.
> > >
> >
> > --
> > You received this message because you are subscribed to the
> > Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from
> > it, send an email to
> > outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to
> > outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visithttps://
> groups.google.com/d/msgid/outreachy-kernel/alpine.DEB.2.21.19032309
> > 10120.2537%40hadrien.
> > For more options, visit https://groups.google.com/d/optout.
> >
> > --
> > You received this message because you are subscribed to the Google Groups
> > "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an
> > email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visithttps://
> groups.google.com/d/msgid/outreachy-kernel/CANTOzWFyaovbYWFXJZhwL3L
> > ygV-As8CTbWOKR7K0eY50uj8ryg%40mail.gmail.com.
> > For more options, visit https://groups.google.com/d/optout.
> >
> >
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/outreachy-kernel/alpine.DEB.2.21.1903230942200.2537%40hadrien
> .
> For more options, visit https://groups.google.com/d/optout.
>
[-- Attachment #2: Type: text/html, Size: 9146 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Outreachy kernel] [PATCH 1/5] staging: rtl8712: avoid camelcase variable name 'bPowerOn'
2019-03-23 8:47 ` Payal Kshirsagar
@ 2019-03-23 16:22 ` Payal Kshirsagar
0 siblings, 0 replies; 10+ messages in thread
From: Payal Kshirsagar @ 2019-03-23 16:22 UTC (permalink / raw)
To: Julia Lawall; +Cc: outreachy-kernel
[-- Attachment #1: Type: text/plain, Size: 5790 bytes --]
On Sat, 23 Mar 2019 at 14:17, Payal Kshirsagar <
payal.s.kshirsagar.98@gmail.com> wrote:
>
>
> On Sat, Mar 23, 2019, 2:12 PM Julia Lawall <julia.lawall@lip6.fr> wrote:
>
>>
>>
>> On Sat, 23 Mar 2019, Payal Kshirsagar wrote:
>>
>> >
>> >
>> > On Sat, 23 Mar 2019 at 13:43, Julia Lawall <julia.lawall@lip6.fr>
>> wrote:
>> > When you make a series, it is nice to make a cover letter as
>> > well, so that
>> > one can see the scope of the changes all at once. see the
>> > tutorial if you
>> > don't know how to do this.
>> >
>> > Sending.
>> >
>> > On Sat, 23 Mar 2019, Payal Kshirsagar wrote:
>> >
>> > > Eliminate camelcase variable names to fix the style issue –
>> > ‘avoid
>> > > camelcase’
>> > >
>> > > Signed-off-by: Payal Kshirsagar
>> > <payal.s.kshirsagar.98@gmail.com>
>> > > ---
>> > > drivers/staging/rtl8712/rtl8712_efuse.c | 4 ++--
>> > > 1 file changed, 2 insertions(+), 2 deletions(-)
>> > >
>> > > diff --git a/drivers/staging/rtl8712/rtl8712_efuse.c
>> > b/drivers/staging/rtl8712/rtl8712_efuse.c
>> > > index 00babd0..3275f7a 100644
>> > > --- a/drivers/staging/rtl8712/rtl8712_efuse.c
>> > > +++ b/drivers/staging/rtl8712/rtl8712_efuse.c
>> > > @@ -23,11 +23,11 @@
>> > > /* reserve 3 bytes for HW stop read */
>> > > static int efuse_available_max_size = EFUSE_MAX_SIZE - 3
>> > /*0x1FD*/;
>> > >
>> > > -static void efuse_reg_ctrl(struct _adapter *padapter, u8
>> > bPowerOn)
>> > > +static void efuse_reg_ctrl(struct _adapter *padapter, u8
>> > power_on)
>> >
>> > It seems that bPowerOn always has a boolean value. It would be
>> > nice to
>> > add other patches to the series that declare the variables as
>> > type bool
>> > instead of u8 (or int in one case).
>> >
>> > Actually, this particular function is only called once and only
>> > called
>> > with the argument false. The function that looks like it should
>> > call this
>> > one with the argument true currently just returns true, I don't
>> > know if
>> > this function should be specialized to the false case and then
>> > inlined
>> > into the call site, or if it is considered that the true case
>> > gives useful
>> > information about the device, even if the code is not used.
>> >
>> >
>> > Do you want me to do further changes?
>>
>> Please do the change from u8 to bool.
>
>
>> Okay I will change and resend it.
> Thanks,
> Payal
>
Can I send this change in new patch?, because subject will be
different than this patchset.
Regards payal.
>
> julia
>>
>> > thanks,
>> > payal
>> > julia
>> >
>> > > {
>> > > u8 tmpu8 = 0;
>> > >
>> > > - if (bPowerOn) {
>> > > + if (power_on) {
>> > > /* -----------------e-fuse pwr & clk reg ctrl
>> > ---------------
>> > > * Enable LDOE25 Macro Block
>> > > */
>> > > --
>> > > 2.7.4
>> > >
>> > > --
>> > > You received this message because you are subscribed to the
>> > Google Groups "outreachy-kernel" group.
>> > > To unsubscribe from this group and stop receiving emails from
>> > it, send an email to
>> > outreachy-kernel+unsubscribe@googlegroups.com.
>> > > To post to this group, send email to
>> > outreachy-kernel@googlegroups.com.
>> > > To view this discussion on the web visithttps://
>> groups.google.com/d/msgid/outreachy-kernel/6b2beffe41d8256284179eda
>> > 6eadd8b9cf0a24fb.1553327467.git.payal.s.kshirsagar.98%40gmail.com
>> .
>> > > For more options, visit https://groups.google.com/d/optout.
>> > >
>> >
>> > --
>> > You received this message because you are subscribed to the
>> > Google Groups "outreachy-kernel" group.
>> > To unsubscribe from this group and stop receiving emails from
>> > it, send an email to
>> > outreachy-kernel+unsubscribe@googlegroups.com.
>> > To post to this group, send email to
>> > outreachy-kernel@googlegroups.com.
>> > To view this discussion on the web visithttps://
>> groups.google.com/d/msgid/outreachy-kernel/alpine.DEB.2.21.19032309
>> > 10120.2537%40hadrien.
>> > For more options, visit https://groups.google.com/d/optout.
>> >
>> > --
>> > You received this message because you are subscribed to the Google
>> Groups
>> > "outreachy-kernel" group.
>> > To unsubscribe from this group and stop receiving emails from it, send
>> an
>> > email to outreachy-kernel+unsubscribe@googlegroups.com.
>> > To post to this group, send email to outreachy-kernel@googlegroups.com.
>> > To view this discussion on the web visithttps://
>> groups.google.com/d/msgid/outreachy-kernel/CANTOzWFyaovbYWFXJZhwL3L
>> > ygV-As8CTbWOKR7K0eY50uj8ryg%40mail.gmail.com.
>> > For more options, visit https://groups.google.com/d/optout.
>> >
>> >
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "outreachy-kernel" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to outreachy-kernel+unsubscribe@googlegroups.com.
>> To post to this group, send email to outreachy-kernel@googlegroups.com.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/outreachy-kernel/alpine.DEB.2.21.1903230942200.2537%40hadrien
>> .
>> For more options, visit https://groups.google.com/d/optout.
>>
>
[-- Attachment #2: Type: text/html, Size: 9964 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2019-03-23 16:22 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <cover.1553327467.git.payal.s.kshirsagar.98@gmail.com>
2019-03-23 7:58 ` [PATCH 1/5] staging: rtl8712: avoid camelcase variable name 'bPowerOn' Payal Kshirsagar
2019-03-23 8:13 ` [Outreachy kernel] " Julia Lawall
2019-03-23 8:25 ` Payal Kshirsagar
2019-03-23 8:42 ` Julia Lawall
2019-03-23 8:47 ` Payal Kshirsagar
2019-03-23 16:22 ` Payal Kshirsagar
2019-03-23 7:58 ` [PATCH 2/5] staging: rtl8712: avoid camelcase variable name 'bResult' Payal Kshirsagar
2019-03-23 7:58 ` [PATCH 3/5] staging: rtl8712: avoid camelcase variable name 'bRead' Payal Kshirsagar
2019-03-23 7:58 ` [PATCH 4/5] staging: rtl8712: avoid camelcase variable name 'bContinual' Payal Kshirsagar
2019-03-23 7:58 ` [PATCH 5/5] staging: rtl8712: Lines should not end with a parenthesis Payal Kshirsagar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.