* [PATCH] net-ipv6: change %8s to %s for rt->dst.dev->name in seq_printf of rt6_info_route
@ 2012-11-02 8:55 Chen Gang
2012-11-02 9:28 ` Chen Gang
2012-11-02 12:18 ` [PATCH] net: ipv6: " Chen Gang
0 siblings, 2 replies; 7+ messages in thread
From: Chen Gang @ 2012-11-02 8:55 UTC (permalink / raw)
To: Eric Dumazet; +Cc: netdev
Hello Eric Dumazet:
1) This time (the first time):
A) I have done according to what you have suggested.
i) git clone git://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git
ii) format with `git format-patch -s --summary --stat`
iii) cc to netdev@vger.kernel.org (not to linux-kernle@vger.kernel.org)
B) please check the 'Main Contents' (below of this mail).
C) thank you for your original information again, they are truly useful for me.
2) Next time (if also for net/ipv6):
A) I will send mail according to MAINTAINERS (which also you suggested)
M: "David S. Miller" <davem@davemloft.net>
M: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
M: James Morris <jmorris@namei.org>
M: Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>
M: Patrick McHardy <kaber@trash.net>
L: netdev@vger.kernel.org
T: git git://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git
B) Only have 'Main Content' in next time.
Main Contents:
-----------------------------------------------------------------------------------
From: Chen Gang <gang.chen@asianux.com>
Date: Fri, 2 Nov 2012 16:02:11 +0800
Subject: [PATCH] net-ipv6: change %8s to %s for rt->dst.dev->name in seq_printf of rt6_info_route
the length of rt->dst.dev->name is 16 (IFNAMSIZ)
in seq_printf, it is not suitable to use %8s for rt->dst.dev->name.
so change it to %s, since each line has not been solid any more.
additional information:
%8s limit the width, not for the original string output length
if name length is more than 8, it still can be fully displayed.
if name length is less than 8, the ' ' will be filled before name.
%.8s truly limit the original string output length (precision)
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
net/ipv6/route.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index c42650c..b60bc52 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -2835,7 +2835,7 @@ static int rt6_info_route(struct rt6_info *rt, void *p_arg)
} else {
seq_puts(m, "00000000000000000000000000000000");
}
- seq_printf(m, " %08x %08x %08x %08x %8s\n",
+ seq_printf(m, " %08x %08x %08x %08x %s\n",
rt->rt6i_metric, atomic_read(&rt->dst.__refcnt),
rt->dst.__use, rt->rt6i_flags,
rt->dst.dev ? rt->dst.dev->name : "");
--
1.7.9.5
--
Chen Gang
Asianux Corporation
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] net-ipv6: change %8s to %s for rt->dst.dev->name in seq_printf of rt6_info_route
2012-11-02 8:55 [PATCH] net-ipv6: change %8s to %s for rt->dst.dev->name in seq_printf of rt6_info_route Chen Gang
@ 2012-11-02 9:28 ` Chen Gang
2012-11-02 12:18 ` [PATCH] net: ipv6: " Chen Gang
1 sibling, 0 replies; 7+ messages in thread
From: Chen Gang @ 2012-11-02 9:28 UTC (permalink / raw)
To: Eric Dumazet, netdev
Hello Eric Dumazet:
1) This time (the first time):
A) I have done according to what you have suggested.
i) git clone git://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git
ii) format with `git format-patch -s --summary --stat`
iii) cc to netdev@vger.kernel.org (not to linux-kernle@vger.kernel.org)
B) please check the 'Main Contents' (below of this mail).
C) thank you for your original information again, they are truly useful for me.
2) Next time (if also for net/ipv6):
A) I will send mail according to MAINTAINERS (which also you suggested)
M: "David S. Miller" <davem@davemloft.net>
M: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
M: James Morris <jmorris@namei.org>
M: Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>
M: Patrick McHardy <kaber@trash.net>
L: netdev@vger.kernel.org
T: git git://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git
B) Only have 'Main Content' in next time.
Main Contents:
-----------------------------------------------------------------------------------
From: Chen Gang <gang.chen@asianux.com>
Date: Fri, 2 Nov 2012 16:02:11 +0800
Subject: [PATCH] net-ipv6: change %8s to %s for rt->dst.dev->name in seq_printf of rt6_info_route
the length of rt->dst.dev->name is 16 (IFNAMSIZ)
in seq_printf, it is not suitable to use %8s for rt->dst.dev->name.
so change it to %s, since each line has not been solid any more.
additional information:
%8s limit the width, not for the original string output length
if name length is more than 8, it still can be fully displayed.
if name length is less than 8, the ' ' will be filled before name.
%.8s truly limit the original string output length (precision)
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
net/ipv6/route.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index c42650c..b60bc52 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -2835,7 +2835,7 @@ static int rt6_info_route(struct rt6_info *rt, void *p_arg)
} else {
seq_puts(m, "00000000000000000000000000000000");
}
- seq_printf(m, " %08x %08x %08x %08x %8s\n",
+ seq_printf(m, " %08x %08x %08x %08x %s\n",
rt->rt6i_metric, atomic_read(&rt->dst.__refcnt),
rt->dst.__use, rt->rt6i_flags,
rt->dst.dev ? rt->dst.dev->name : "");
--
1.7.9.5
--
Chen Gang
Asianux Corporation
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] net: ipv6: change %8s to %s for rt->dst.dev->name in seq_printf of rt6_info_route
2012-11-02 8:55 [PATCH] net-ipv6: change %8s to %s for rt->dst.dev->name in seq_printf of rt6_info_route Chen Gang
2012-11-02 9:28 ` Chen Gang
@ 2012-11-02 12:18 ` Chen Gang
2012-11-02 15:40 ` Shan Wei
1 sibling, 1 reply; 7+ messages in thread
From: Chen Gang @ 2012-11-02 12:18 UTC (permalink / raw)
To: davem, kuznet, jmorris, yoshfuji, kaber; +Cc: netdev
the length of rt->dst.dev->name is 16 (IFNAMSIZ)
in seq_printf, it is not suitable to use %8s for rt->dst.dev->name.
so change it to %s, since each line has not been solid any more.
additional information:
%8s limit the width, not for the original string output length
if name length is more than 8, it still can be fully displayed.
if name length is less than 8, the ' ' will be filled before name.
%.8s truly limit the original string output length (precision)
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
net/ipv6/route.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index c42650c..b60bc52 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -2835,7 +2835,7 @@ static int rt6_info_route(struct rt6_info *rt, void *p_arg)
} else {
seq_puts(m, "00000000000000000000000000000000");
}
- seq_printf(m, " %08x %08x %08x %08x %8s\n",
+ seq_printf(m, " %08x %08x %08x %08x %s\n",
rt->rt6i_metric, atomic_read(&rt->dst.__refcnt),
rt->dst.__use, rt->rt6i_flags,
rt->dst.dev ? rt->dst.dev->name : "");
--
1.7.9.5
--
Chen Gang
Asianux Corporation
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] net: ipv6: change %8s to %s for rt->dst.dev->name in seq_printf of rt6_info_route
2012-11-02 12:18 ` [PATCH] net: ipv6: " Chen Gang
@ 2012-11-02 15:40 ` Shan Wei
2012-11-05 3:02 ` Chen Gang
0 siblings, 1 reply; 7+ messages in thread
From: Shan Wei @ 2012-11-02 15:40 UTC (permalink / raw)
To: Chen Gang; +Cc: davem, kuznet, jmorris, yoshfuji, kaber, netdev
Chen Gang said, at 2012/11/2 20:18:
>
> the length of rt->dst.dev->name is 16 (IFNAMSIZ)
> in seq_printf, it is not suitable to use %8s for rt->dst.dev->name.
> so change it to %s, since each line has not been solid any more.
>
> additional information:
>
> %8s limit the width, not for the original string output length
> if name length is more than 8, it still can be fully displayed.
> if name length is less than 8, the ' ' will be filled before name.
>
> %.8s truly limit the original string output length (precision)
>
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
1. not to send same patch triple times.
2. config your email client,because tab is changed to space.
you can read Documentation/email-clients.txt.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] net: ipv6: change %8s to %s for rt->dst.dev->name in seq_printf of rt6_info_route
2012-11-02 15:40 ` Shan Wei
@ 2012-11-05 3:02 ` Chen Gang
2012-11-05 5:50 ` David Miller
0 siblings, 1 reply; 7+ messages in thread
From: Chen Gang @ 2012-11-05 3:02 UTC (permalink / raw)
To: Shan Wei; +Cc: davem, kuznet, jmorris, yoshfuji, kaber, netdev
>
> 1. not to send same patch triple times.
thanks, I shall notice, next time.
(I shall 'believe' another members).
> 2. config your email client,because tab is changed to space.
> you can read Documentation/email-clients.txt.
1) thanks. I shall notice, next time.
2) now, I get gvim as extention editor for thounderbird
3) the patch is generated by `git format-patch -s --summary --stat`
it use "' '\t" as head, I do not touch it, maybe it is correct.
welcome any members to giving additional suggestions and completions.
thanks
the modified contents are below,
-----------------------------------------------------------------------------------
the length of rt->dst.dev->name is 16 (IFNAMSIZ)
in seq_printf, it is not suitable to use %8s for rt->dst.dev->name.
so change it to %s, since each line has not been solid any more.
additional information:
%8s limit the width, not for the original string output length
if name length is more than 8, it still can be fully displayed.
if name length is less than 8, the ' ' will be filled before name.
%.8s truly limit the original string output length (precision)
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
net/ipv6/route.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index c42650c..b60bc52 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -2835,7 +2835,7 @@ static int rt6_info_route(struct rt6_info *rt, void *p_arg)
} else {
seq_puts(m, "00000000000000000000000000000000");
}
- seq_printf(m, " %08x %08x %08x %08x %8s\n",
+ seq_printf(m, " %08x %08x %08x %08x %s\n",
rt->rt6i_metric, atomic_read(&rt->dst.__refcnt),
rt->dst.__use, rt->rt6i_flags,
rt->dst.dev ? rt->dst.dev->name : "");
--
1.7.9.5
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] net: ipv6: change %8s to %s for rt->dst.dev->name in seq_printf of rt6_info_route
2012-11-05 3:02 ` Chen Gang
@ 2012-11-05 5:50 ` David Miller
2012-11-05 6:02 ` Chen Gang
0 siblings, 1 reply; 7+ messages in thread
From: David Miller @ 2012-11-05 5:50 UTC (permalink / raw)
To: gang.chen; +Cc: shanwei88, kuznet, jmorris, yoshfuji, kaber, netdev
From: Chen Gang <gang.chen@asianux.com>
Date: Mon, 05 Nov 2012 11:02:48 +0800
>>
>> 1. not to send same patch triple times.
>
> thanks, I shall notice, next time.
> (I shall 'believe' another members).
>
>> 2. config your email client,because tab is changed to space.
>> you can read Documentation/email-clients.txt.
>
> 1) thanks. I shall notice, next time.
> 2) now, I get gvim as extention editor for thounderbird
> 3) the patch is generated by `git format-patch -s --summary --stat`
> it use "' '\t" as head, I do not touch it, maybe it is correct.
>
> welcome any members to giving additional suggestions and completions.
>
> thanks
>
> the modified contents are below,
Post new versions of a patch as fresh postings, not as replies
to other emails.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] net: ipv6: change %8s to %s for rt->dst.dev->name in seq_printf of rt6_info_route
2012-11-05 5:50 ` David Miller
@ 2012-11-05 6:02 ` Chen Gang
0 siblings, 0 replies; 7+ messages in thread
From: Chen Gang @ 2012-11-05 6:02 UTC (permalink / raw)
To: David Miller; +Cc: shanwei88, kuznet, jmorris, yoshfuji, kaber, netdev
于 2012年11月05日 13:50, David Miller 写道:
>
> Post new versions of a patch as fresh postings, not as replies
> to other emails.
>
>
thanks, I shall notice, next time.
if truly need sending it again (5th time), please tell me, thanks.
(since, it has been posted "4 times", which has almost been 'spam')
--
Chen Gang
Asianux Corporation
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2012-11-05 6:01 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-11-02 8:55 [PATCH] net-ipv6: change %8s to %s for rt->dst.dev->name in seq_printf of rt6_info_route Chen Gang
2012-11-02 9:28 ` Chen Gang
2012-11-02 12:18 ` [PATCH] net: ipv6: " Chen Gang
2012-11-02 15:40 ` Shan Wei
2012-11-05 3:02 ` Chen Gang
2012-11-05 5:50 ` David Miller
2012-11-05 6:02 ` Chen Gang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.