All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>,
	linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH 3/3] ARM: OMAP: Remove plat-omap/common.c
Date: Mon, 5 Nov 2012 10:04:41 +0200	[thread overview]
Message-ID: <50977319.9070902@ti.com> (raw)
In-Reply-To: <20121102185453.GY15766@atomide.com>

[-- Attachment #1: Type: text/plain, Size: 1230 bytes --]

On 2012-11-02 20:54, Tony Lindgren wrote:
>> * Santosh Shilimkar <santosh.shilimkar@ti.com> [121102 01:56]:
>>> On Friday 02 November 2012 02:19 PM, Tomi Valkeinen wrote:
>>>> On 2012-11-02 08:38, Santosh Shilimkar wrote:
>>>>>
>>>>> Lets not move this in DMA code since the above is really related
>>>>> to frame buffer. It reserves more DMA area for dma_alloc_coherent()
>>>>> etc than default 2 MB. Infact, we should no longer need this with
>>>>> CMA and memblock in place.
>>>>>
>>>>> Tomi,
>>>>> Can we not get rid of the above memory reservation ?
>>>>
>>>> Yes, I think so. This one is only used for the old omapfb, i.e. omap1,
>>>> and I have no means to test it out, though. But below is a patch to
>>>> remove it. I also attached the patch, as it looks like thunderbird wants
>>>> to reformat the pasted patch... I'll remove the
>>>> CONFIG_FB_OMAP_CONSISTENT_DMA_SIZE from the omapfb driver's Kconfig file
>>>> in my tree later.
> 
> Hmm actually, is it safe to remove for omap1, or should we
> still keep it around for omap1?

Why wouldn't it be safe? Do you mean that CMA doesn't work on omap1,
or...? I'm no expert on CMA, but as far as I can see with it's ARM
generic stuff.

 Tomi



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 897 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: tomi.valkeinen@ti.com (Tomi Valkeinen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] ARM: OMAP: Remove plat-omap/common.c
Date: Mon, 5 Nov 2012 10:04:41 +0200	[thread overview]
Message-ID: <50977319.9070902@ti.com> (raw)
In-Reply-To: <20121102185453.GY15766@atomide.com>

On 2012-11-02 20:54, Tony Lindgren wrote:
>> * Santosh Shilimkar <santosh.shilimkar@ti.com> [121102 01:56]:
>>> On Friday 02 November 2012 02:19 PM, Tomi Valkeinen wrote:
>>>> On 2012-11-02 08:38, Santosh Shilimkar wrote:
>>>>>
>>>>> Lets not move this in DMA code since the above is really related
>>>>> to frame buffer. It reserves more DMA area for dma_alloc_coherent()
>>>>> etc than default 2 MB. Infact, we should no longer need this with
>>>>> CMA and memblock in place.
>>>>>
>>>>> Tomi,
>>>>> Can we not get rid of the above memory reservation ?
>>>>
>>>> Yes, I think so. This one is only used for the old omapfb, i.e. omap1,
>>>> and I have no means to test it out, though. But below is a patch to
>>>> remove it. I also attached the patch, as it looks like thunderbird wants
>>>> to reformat the pasted patch... I'll remove the
>>>> CONFIG_FB_OMAP_CONSISTENT_DMA_SIZE from the omapfb driver's Kconfig file
>>>> in my tree later.
> 
> Hmm actually, is it safe to remove for omap1, or should we
> still keep it around for omap1?

Why wouldn't it be safe? Do you mean that CMA doesn't work on omap1,
or...? I'm no expert on CMA, but as far as I can see with it's ARM
generic stuff.

 Tomi


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 897 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20121105/106f3a2e/attachment.sig>

  reply	other threads:[~2012-11-05  8:04 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-01 22:48 [PATCH 0/3] more omap clean-up for ARCH_MULTIPLATFORM Tony Lindgren
2012-11-01 22:48 ` Tony Lindgren
2012-11-01 22:48 ` [PATCH 1/3] ARM: OMAP: Remove unnecessary mach and plat includes Tony Lindgren
2012-11-01 22:48   ` Tony Lindgren
2012-11-01 22:48 ` [PATCH 2/3] ARM: OMAP: Remove NEED_MACH_GPIO_H Tony Lindgren
2012-11-01 22:48   ` Tony Lindgren
2012-11-02 14:25   ` Mark Brown
2012-11-02 14:25     ` Mark Brown
2012-11-01 22:48 ` [PATCH 3/3] ARM: OMAP: Remove plat-omap/common.c Tony Lindgren
2012-11-01 22:48   ` Tony Lindgren
2012-11-01 23:14   ` Tony Lindgren
2012-11-01 23:14     ` Tony Lindgren
2012-11-02  6:37   ` Santosh Shilimkar
2012-11-02  6:37     ` Santosh Shilimkar
2012-11-02  6:38   ` Santosh Shilimkar
2012-11-02  6:38     ` Santosh Shilimkar
2012-11-02  8:49     ` Tomi Valkeinen
2012-11-02  8:49       ` Tomi Valkeinen
2012-11-02  8:55       ` Santosh Shilimkar
2012-11-02  8:55         ` Santosh Shilimkar
2012-11-02 15:49         ` Tony Lindgren
2012-11-02 15:49           ` Tony Lindgren
2012-11-02 18:54           ` Tony Lindgren
2012-11-02 18:54             ` Tony Lindgren
2012-11-05  8:04             ` Tomi Valkeinen [this message]
2012-11-05  8:04               ` Tomi Valkeinen
2012-11-05 15:36               ` Tony Lindgren
2012-11-05 15:36                 ` Tony Lindgren
2012-11-05 15:48                 ` Tomi Valkeinen
2012-11-05 15:48                   ` Tomi Valkeinen
2012-11-05 16:12                   ` Tony Lindgren
2012-11-05 16:12                     ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50977319.9070902@ti.com \
    --to=tomi.valkeinen@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=santosh.shilimkar@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.