All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
Cc: gmbnomis-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
	jm-Pj/HzkgeCk7QXOPxS62xeg@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>
Subject: Re: [PATCH 1/3] gpio: Add simple poweroff-gpio driver
Date: Sun, 11 Nov 2012 15:03:49 -0700	[thread overview]
Message-ID: <50A020C5.4070506@wwwdotorg.org> (raw)
In-Reply-To: <1352650891-18356-2-git-send-email-andrew-g2DYL2Zd6BY@public.gmane.org>

On 11/11/2012 09:21 AM, Andrew Lunn wrote:
> From: Jamie Lentin <jm-Pj/HzkgeCk7QXOPxS62xeg@public.gmane.org>
> 
> Given appropriate devicetree bindings, this driver registers a
> pm_power_off function to set a GPIO line high/low to power down
> your board.

This feature will be useful for the Tegra TrimSlice board too.

> diff --git a/Documentation/devicetree/bindings/gpio/gpio-poweroff.txt b/Documentation/devicetree/bindings/gpio/gpio-poweroff.txt

> +Required properties:
> +- compatible : should be "gpio-poweroff".
> +- gpios : The GPIO to set high/low, see "gpios property" in
> +  Documentation/devicetree/bindings/gpio/gpio.txt. If the pin should be
> +  low to power down the board set it to "Active Low", otherwise set
> +  gpio to "Active High".

Unfortunately, not all GPIO bindings support active high/low flags in
the GPIO specifier. As such, the flags there are basically useless.
Other bindings (e.g. IIRC the fixed-regulator binding) have added a
separate active-high property to indicate the GPIO polarity. This
binding should probably follow suite.

WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] gpio: Add simple poweroff-gpio driver
Date: Sun, 11 Nov 2012 15:03:49 -0700	[thread overview]
Message-ID: <50A020C5.4070506@wwwdotorg.org> (raw)
In-Reply-To: <1352650891-18356-2-git-send-email-andrew@lunn.ch>

On 11/11/2012 09:21 AM, Andrew Lunn wrote:
> From: Jamie Lentin <jm@lentin.co.uk>
> 
> Given appropriate devicetree bindings, this driver registers a
> pm_power_off function to set a GPIO line high/low to power down
> your board.

This feature will be useful for the Tegra TrimSlice board too.

> diff --git a/Documentation/devicetree/bindings/gpio/gpio-poweroff.txt b/Documentation/devicetree/bindings/gpio/gpio-poweroff.txt

> +Required properties:
> +- compatible : should be "gpio-poweroff".
> +- gpios : The GPIO to set high/low, see "gpios property" in
> +  Documentation/devicetree/bindings/gpio/gpio.txt. If the pin should be
> +  low to power down the board set it to "Active Low", otherwise set
> +  gpio to "Active High".

Unfortunately, not all GPIO bindings support active high/low flags in
the GPIO specifier. As such, the flags there are basically useless.
Other bindings (e.g. IIRC the fixed-regulator binding) have added a
separate active-high property to indicate the GPIO polarity. This
binding should probably follow suite.

  parent reply	other threads:[~2012-11-11 22:03 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-11 16:21 [PATCH 0/3] GPIO driver to turn power off Andrew Lunn
2012-11-11 16:21 ` Andrew Lunn
     [not found] ` <1352650891-18356-1-git-send-email-andrew-g2DYL2Zd6BY@public.gmane.org>
2012-11-11 16:21   ` [PATCH 1/3] gpio: Add simple poweroff-gpio driver Andrew Lunn
2012-11-11 16:21     ` Andrew Lunn
     [not found]     ` <1352650891-18356-2-git-send-email-andrew-g2DYL2Zd6BY@public.gmane.org>
2012-11-11 22:03       ` Stephen Warren [this message]
2012-11-11 22:03         ` Stephen Warren
     [not found]         ` <50A020C5.4070506-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-11-12  8:25           ` Andrew Lunn
2012-11-12  8:25             ` Andrew Lunn
     [not found]             ` <20121112082546.GU22029-g2DYL2Zd6BY@public.gmane.org>
2012-11-12 16:17               ` Stephen Warren
2012-11-12 16:17                 ` Stephen Warren
     [not found]                 ` <50A1212C.2080601-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-11-12 18:19                   ` Andrew Lunn
2012-11-12 18:19                     ` Andrew Lunn
     [not found]                     ` <20121112181947.GS24583-g2DYL2Zd6BY@public.gmane.org>
2012-11-12 18:43                       ` Anton Vorontsov
2012-11-12 18:43                         ` Anton Vorontsov
2012-11-12 18:58                         ` Stephen Warren
2012-11-12 18:58                           ` Stephen Warren
     [not found]                           ` <50A146E7.2040608-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-11-12 19:17                             ` Anton Vorontsov
2012-11-12 19:17                               ` Anton Vorontsov
2012-11-15 10:35                             ` Linus Walleij
2012-11-15 10:35                               ` Linus Walleij
     [not found]                               ` <CACRpkdb=ra9NwqEneyMoM5YnOFTVQoBxPATjUN6anooXVLiCjw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-11-15 10:59                                 ` Anton Vorontsov
2012-11-15 10:59                                   ` Anton Vorontsov
2012-11-15 11:10                                   ` Linus Walleij
2012-11-15 11:10                                     ` Linus Walleij
     [not found]                                     ` <CACRpkdZ_4C2XA1c2U_E8GnbfiXZk67MYR7JzgwXf1iVwHCde2Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-11-21 13:17                                       ` Grant Likely
2012-11-21 13:17                                         ` Grant Likely
2012-11-15 18:00                                   ` Stephen Warren
2012-11-15 18:00                                     ` Stephen Warren
2012-11-12  1:00       ` Linus Walleij
2012-11-12  1:00         ` Linus Walleij
     [not found]         ` <CACRpkdZvHBjFQTrQnxvc3WCOb2CqGbjYJxyQ5qQkSbU+UWHYZA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-11-12  1:12           ` Anton Vorontsov
2012-11-12  1:12             ` Anton Vorontsov
2012-11-12  6:07             ` Andrew Lunn
2012-11-12  6:07               ` Andrew Lunn
     [not found]               ` <20121112060740.GR24583-g2DYL2Zd6BY@public.gmane.org>
2012-11-12  6:53                 ` Anton Vorontsov
2012-11-12  6:53                   ` Anton Vorontsov
2012-11-15 18:05       ` Grant Likely
2012-11-15 18:05         ` Grant Likely
2012-11-15 18:11         ` Jamie Lentin
2012-11-15 18:11           ` Jamie Lentin
     [not found]           ` <alpine.DEB.2.00.1211151810050.25381-5X291BYdrx55rAo4AelP/Ydd74u8MsAO@public.gmane.org>
2012-11-15 18:21             ` Grant Likely
2012-11-15 18:21               ` Grant Likely
     [not found]               ` <CACxGe6tgNVH9zeafMRKXcRUZmQjQXrAy_QtvhxpTT74200Hnxg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-11-21 13:20                 ` Grant Likely
2012-11-21 13:20                   ` Grant Likely
2012-11-11 16:21   ` [PATCH 2/3] ARM: Kirkwood: Convert DNSKW to use gpio-poweroff Andrew Lunn
2012-11-11 16:21     ` Andrew Lunn
2012-11-11 16:21 ` [PATCH 3/3] ARM: Kirkwood: Convert IB62x0 " Andrew Lunn
2012-11-11 16:21   ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50A020C5.4070506@wwwdotorg.org \
    --to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
    --cc=andrew-g2DYL2Zd6BY@public.gmane.org \
    --cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    --cc=gmbnomis-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org \
    --cc=jm-Pj/HzkgeCk7QXOPxS62xeg@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.