Re: [Qemu-devel] Virtio refactoring.

["KONRAD Frédéric" <fred.konrad@greensocs.com>]

Hi,

On 13/11/2012 19:09, Cornelia Huck wrote:
> On Tue, 13 Nov 2012 17:31:40 +0100
> KONRAD Frédéric <fred.konrad@greensocs.com> wrote:
>>
>> We'd go from
>>
>> system bus
>> -> virtio transport bridge dev (virtio-xxx-bridge)
>>      -> virtio transport bus (virtio-xxx-bus)
>>         -> virtio transport dev (virtio-<type>-xxx)
>>
>> to
>>
>> system bus
>> -> virtio transport bridge dev (virtio-bridge-xxx)
>>      -> virtio bus (virtio-bus-xxx)
>>         -> virtio dev (virtio-<type>-xxx)
>>
>> ?
>> I'm not sure of what you mean,.. do you mean for s390 ?
>>
>> for the moment we have e.g : virtio-blk-pci ( in virtio-pci.c )
>>
>> and we want virtio-pci -> virtio-bus -> virtio-blk.
>>
>> ( or virtio-mmio -> virtio-bus -> virtio-blk. for pci-less system. )
> I meant the structure you see in 'info qtree'. We might be talking
> about the same thing :)
For the qtree structure we have eg for virtio block :

bus: main-system-bus
   type System
   dev: pcihost, id ""
     bus: pci.0
       type PCI
       dev: virtio-blk-pci, id ""
         ...

And it would become :

bus: main-system-bus
   type System
   dev: pcihost, id ""
     bus: pci.0
       type PCI
       dev: virtio-pci, id ""
         bus: virtio.0
           type VIRTIO
           dev: virtio-blk, id ""
             ...

>
>>>> Is it the right approach ? Do I miss something ?
>>> What of the alias handling? Can this be killed once everything has been
>>> converted?
>> Which alias ?
> The alias stuff in hw/qdev-monitor.c that lets you specify either
> virtio-<type>-<transport> or virtio-<type>.
>
So it would break the alias, we must find a solution for that.

Fred