[PATCH] infiniband-diags/ibportstate.c: Fix PortInfo sets with extended speeds

[PATCH] infiniband-diags/ibportstate.c: Fix PortInfo sets with extended speeds

[Hal Rosenstock]

Attribute Modifier bit 31 should be on (set to 1) in this case

Signed-off-by: Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
---
diff --git a/src/ibportstate.c b/src/ibportstate.c
index 1d8dc81..053b0a2 100644
--- a/src/ibportstate.c
+++ b/src/ibportstate.c
@@ -236,7 +236,12 @@ static void show_port_info(ib_portid_t * dest, uint8_t * data, int portnum,
 static void set_port_info(ib_portid_t * dest, uint8_t * data, int portnum,
 			  int espeed_cap, int is_switch)
 {
-	if (!smp_set_via(data, dest, IB_ATTR_PORT_INFO, portnum, 0, srcport))
+	unsigned mod;
+
+	mod = portnum;
+	if (espeed_cap)
+		mod |= 1<<31;
+	if (!smp_set_via(data, dest, IB_ATTR_PORT_INFO, mod, 0, srcport))
 		IBERROR("smp set portinfo failed");
 
 	printf("\nAfter PortInfo set:\n");
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] infiniband-diags/ibportstate.c: Fix PortInfo sets with extended speeds

[Ira Weiny]

On Fri, 14 Dec 2012 09:11:14 -0500
Hal Rosenstock <hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org> wrote:

> 
> Attribute Modifier bit 31 should be on (set to 1) in this case
> 
> Signed-off-by: Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

Applied, thanks,
Ira

> ---
> diff --git a/src/ibportstate.c b/src/ibportstate.c
> index 1d8dc81..053b0a2 100644
> --- a/src/ibportstate.c
> +++ b/src/ibportstate.c
> @@ -236,7 +236,12 @@ static void show_port_info(ib_portid_t * dest, uint8_t * data, int portnum,
>  static void set_port_info(ib_portid_t * dest, uint8_t * data, int portnum,
>  			  int espeed_cap, int is_switch)
>  {
> -	if (!smp_set_via(data, dest, IB_ATTR_PORT_INFO, portnum, 0, srcport))
> +	unsigned mod;
> +
> +	mod = portnum;
> +	if (espeed_cap)
> +		mod |= 1<<31;
> +	if (!smp_set_via(data, dest, IB_ATTR_PORT_INFO, mod, 0, srcport))
>  		IBERROR("smp set portinfo failed");
>  
>  	printf("\nAfter PortInfo set:\n");
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


-- 
Ira Weiny
Member of Technical Staff
Lawrence Livermore National Lab
925-423-8008
weiny2-i2BcT+NCU+M@public.gmane.org
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html