All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Documentation/git: add missing info about --git-dir command-line option
@ 2012-12-12 17:04 Manlio Perillo
  2012-12-12 19:35 ` Junio C Hamano
  0 siblings, 1 reply; 4+ messages in thread
From: Manlio Perillo @ 2012-12-12 17:04 UTC (permalink / raw)
  To: git

The Documentation/git.txt file, in the GIT_DIR environment variable
section, did not mentioned that this value can also be set using the
--git-dir command line option.
---
 Documentation/git.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/git.txt b/Documentation/git.txt
index e643683..60db292 100644
--- a/Documentation/git.txt
+++ b/Documentation/git.txt
@@ -650,6 +650,7 @@ git so take care if using Cogito etc.
 	If the 'GIT_DIR' environment variable is set then it
 	specifies a path to use instead of the default `.git`
 	for the base of the repository.
+	The '--git-dir' command-line option also sets this value.
  'GIT_WORK_TREE'::
 	Set the path to the working tree.  The value will not be
-- 
1.8.0.1.347.gf94c325.dirty

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] Documentation/git: add missing info about --git-dir command-line option
  2012-12-12 17:04 [PATCH] Documentation/git: add missing info about --git-dir command-line option Manlio Perillo
@ 2012-12-12 19:35 ` Junio C Hamano
  2012-12-13 18:00   ` Manlio Perillo
  2012-12-14 17:26   ` Manlio Perillo
  0 siblings, 2 replies; 4+ messages in thread
From: Junio C Hamano @ 2012-12-12 19:35 UTC (permalink / raw)
  To: Manlio Perillo; +Cc: git

Manlio Perillo <manlio.perillo@gmail.com> writes:

> The Documentation/git.txt file, in the GIT_DIR environment variable
> section, did not mentioned that this value can also be set using the
> --git-dir command line option.
> ---

s/mentioned/mention/; Also it may help to say

	Unlike other environment variables (e.g. GIT_WORK_TREE,
	GIT_NAMESPACE),

somewhere in the description.

Please sign-off your patch (see Documentation/SubmittingPatches).

Thanks.

>  Documentation/git.txt | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/git.txt b/Documentation/git.txt
> index e643683..60db292 100644
> --- a/Documentation/git.txt
> +++ b/Documentation/git.txt
> @@ -650,6 +650,7 @@ git so take care if using Cogito etc.
>  	If the 'GIT_DIR' environment variable is set then it
>  	specifies a path to use instead of the default `.git`
>  	for the base of the repository.
> +	The '--git-dir' command-line option also sets this value.
>   'GIT_WORK_TREE'::
>  	Set the path to the working tree.  The value will not be

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Documentation/git: add missing info about --git-dir command-line option
  2012-12-12 19:35 ` Junio C Hamano
@ 2012-12-13 18:00   ` Manlio Perillo
  2012-12-14 17:26   ` Manlio Perillo
  1 sibling, 0 replies; 4+ messages in thread
From: Manlio Perillo @ 2012-12-13 18:00 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: git

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Il 12/12/2012 20:35, Junio C Hamano ha scritto:
> Manlio Perillo <manlio.perillo@gmail.com> writes:
> 
>> The Documentation/git.txt file, in the GIT_DIR environment variable
>> section, did not mentioned that this value can also be set using the
>> --git-dir command line option.
>> ---
> 
> s/mentioned/mention/; Also it may help to say
> 
> 	Unlike other environment variables (e.g. GIT_WORK_TREE,
> 	GIT_NAMESPACE),
> 
> somewhere in the description.
> 
> Please sign-off your patch (see Documentation/SubmittingPatches).
> 
> Thanks.
> 

Thanks to you.

I have sent the updated patch, let me know if is ok.



Manlio Perillo
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAlDKF9YACgkQscQJ24LbaUQyHwCcDiaJjFZ5vwHzxjHyhEBCyFdd
GnIAn34MjoWmQOcLKJEl/EpE0ImeQBLG
=yrux
-----END PGP SIGNATURE-----

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Documentation/git: add missing info about --git-dir command-line option
  2012-12-12 19:35 ` Junio C Hamano
  2012-12-13 18:00   ` Manlio Perillo
@ 2012-12-14 17:26   ` Manlio Perillo
  1 sibling, 0 replies; 4+ messages in thread
From: Manlio Perillo @ 2012-12-14 17:26 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: git

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Il 12/12/2012 20:35, Junio C Hamano ha scritto:
> Manlio Perillo <manlio.perillo@gmail.com> writes:
> 
>> The Documentation/git.txt file, in the GIT_DIR environment variable
>> section, did not mentioned that this value can also be set using the
>> --git-dir command line option.
>> ---
> 
> s/mentioned/mention/; Also it may help to say
> 
> 	Unlike other environment variables (e.g. GIT_WORK_TREE,
> 	GIT_NAMESPACE),
> 

I'm sorry, I just copied this text "as is" (I'm lazy) in the commit
message failing to notice the use of the tab character.

When I checked the patch email message, my editor rendered the tab
character as a single space...


That's the reason why I have all my editors configured to never ever use
tabs.


Manlio Perillo
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAlDLYUMACgkQscQJ24LbaUTUPACcDhufXkawZZPBV0p/af1GFu1D
/BcAnjPARpeTi4EdyM/3wV0eI9U9Fu51
=rSfl
-----END PGP SIGNATURE-----

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2012-12-14 17:27 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-12-12 17:04 [PATCH] Documentation/git: add missing info about --git-dir command-line option Manlio Perillo
2012-12-12 19:35 ` Junio C Hamano
2012-12-13 18:00   ` Manlio Perillo
2012-12-14 17:26   ` Manlio Perillo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.