* [PATCH] OMAP: DSS: add FEAT_DPI_USES_VDDS_DSI to omap3630_dss_feat_list
@ 2012-12-15 21:08 NeilBrown
2012-12-17 11:58 ` Tomi Valkeinen
0 siblings, 1 reply; 3+ messages in thread
From: NeilBrown @ 2012-12-15 21:08 UTC (permalink / raw)
To: Tomi Valkeinen, Chandrabhanu Mahapatra; +Cc: linux-omap
[-- Attachment #1: Type: text/plain, Size: 1060 bytes --]
commit 195e672a76056478cc79f5c48343164c9237852e
OMAPDSS: DPI: Remove cpu_is_xxxx checks
made the mistake of assuming that cpu_is_omap34xx() is exclusive of
other cpu_is_* predicates whereas it includes cpu_is_omap3630().
So on an omap3630, code that was previously enabled by
if (cpu_is_omap34xx())
is now disabled as
dss_has_feature(FEAT_DPI_USES_VDDS_DSI)
fails.
So add FEAT_DPI_USES_VDDS_DSI to omap3630_dss_feat_list.
Cc: Chandrabhanu Mahapatra <cmahapatra@ti.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
Signed-off-by: NeilBrown <neilb@suse.de>
diff --git a/drivers/video/omap2/dss/dss_features.c b/drivers/video/omap2/dss/dss_features.c
index acbc1e1..aaf3c3f 100644
--- a/drivers/video/omap2/dss/dss_features.c
+++ b/drivers/video/omap2/dss/dss_features.c
@@ -546,6 +546,7 @@ static const enum dss_feat_id omap3630_dss_feat_list[] = {
FEAT_ALPHA_FIXED_ZORDER,
FEAT_FIFO_MERGE,
FEAT_OMAP3_DSI_FIFO_BUG,
+ FEAT_DPI_USES_VDDS_DSI,
};
static const enum dss_feat_id omap4430_es1_0_dss_feat_list[] = {
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] OMAP: DSS: add FEAT_DPI_USES_VDDS_DSI to omap3630_dss_feat_list
2012-12-15 21:08 [PATCH] OMAP: DSS: add FEAT_DPI_USES_VDDS_DSI to omap3630_dss_feat_list NeilBrown
@ 2012-12-17 11:58 ` Tomi Valkeinen
2012-12-17 20:27 ` NeilBrown
0 siblings, 1 reply; 3+ messages in thread
From: Tomi Valkeinen @ 2012-12-17 11:58 UTC (permalink / raw)
To: NeilBrown; +Cc: Chandrabhanu Mahapatra, linux-omap
[-- Attachment #1: Type: text/plain, Size: 1274 bytes --]
On 2012-12-15 23:08, NeilBrown wrote:
>
> commit 195e672a76056478cc79f5c48343164c9237852e
> OMAPDSS: DPI: Remove cpu_is_xxxx checks
>
> made the mistake of assuming that cpu_is_omap34xx() is exclusive of
> other cpu_is_* predicates whereas it includes cpu_is_omap3630().
>
> So on an omap3630, code that was previously enabled by
> if (cpu_is_omap34xx())
> is now disabled as
> dss_has_feature(FEAT_DPI_USES_VDDS_DSI)
> fails.
>
> So add FEAT_DPI_USES_VDDS_DSI to omap3630_dss_feat_list.
>
> Cc: Chandrabhanu Mahapatra <cmahapatra@ti.com>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Signed-off-by: NeilBrown <neilb@suse.de>
>
> diff --git a/drivers/video/omap2/dss/dss_features.c b/drivers/video/omap2/dss/dss_features.c
> index acbc1e1..aaf3c3f 100644
> --- a/drivers/video/omap2/dss/dss_features.c
> +++ b/drivers/video/omap2/dss/dss_features.c
> @@ -546,6 +546,7 @@ static const enum dss_feat_id omap3630_dss_feat_list[] = {
> FEAT_ALPHA_FIXED_ZORDER,
> FEAT_FIFO_MERGE,
> FEAT_OMAP3_DSI_FIFO_BUG,
> + FEAT_DPI_USES_VDDS_DSI,
> };
>
> static const enum dss_feat_id omap4430_es1_0_dss_feat_list[] = {
>
Thanks, looks correct. Did you encounter a bug related to this, or just
happened to notice?
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 899 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] OMAP: DSS: add FEAT_DPI_USES_VDDS_DSI to omap3630_dss_feat_list
2012-12-17 11:58 ` Tomi Valkeinen
@ 2012-12-17 20:27 ` NeilBrown
0 siblings, 0 replies; 3+ messages in thread
From: NeilBrown @ 2012-12-17 20:27 UTC (permalink / raw)
To: Tomi Valkeinen; +Cc: Chandrabhanu Mahapatra, linux-omap
[-- Attachment #1: Type: text/plain, Size: 1819 bytes --]
On Mon, 17 Dec 2012 13:58:59 +0200 Tomi Valkeinen <tomi.valkeinen@ti.com>
wrote:
> On 2012-12-15 23:08, NeilBrown wrote:
> >
> > commit 195e672a76056478cc79f5c48343164c9237852e
> > OMAPDSS: DPI: Remove cpu_is_xxxx checks
> >
> > made the mistake of assuming that cpu_is_omap34xx() is exclusive of
> > other cpu_is_* predicates whereas it includes cpu_is_omap3630().
> >
> > So on an omap3630, code that was previously enabled by
> > if (cpu_is_omap34xx())
> > is now disabled as
> > dss_has_feature(FEAT_DPI_USES_VDDS_DSI)
> > fails.
> >
> > So add FEAT_DPI_USES_VDDS_DSI to omap3630_dss_feat_list.
> >
> > Cc: Chandrabhanu Mahapatra <cmahapatra@ti.com>
> > Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> > Signed-off-by: NeilBrown <neilb@suse.de>
> >
> > diff --git a/drivers/video/omap2/dss/dss_features.c b/drivers/video/omap2/dss/dss_features.c
> > index acbc1e1..aaf3c3f 100644
> > --- a/drivers/video/omap2/dss/dss_features.c
> > +++ b/drivers/video/omap2/dss/dss_features.c
> > @@ -546,6 +546,7 @@ static const enum dss_feat_id omap3630_dss_feat_list[] = {
> > FEAT_ALPHA_FIXED_ZORDER,
> > FEAT_FIFO_MERGE,
> > FEAT_OMAP3_DSI_FIFO_BUG,
> > + FEAT_DPI_USES_VDDS_DSI,
> > };
> >
> > static const enum dss_feat_id omap4430_es1_0_dss_feat_list[] = {
> >
>
> Thanks, looks correct. Did you encounter a bug related to this, or just
> happened to notice?
>
When I tried 3.7 on my gta04 phone the display had a slightly greenish (or
maybe yellowish) tinge, particularly when viewed at an angle.
I at first thought it might be related to the changes in the panel
configuration (I have an out-of-tree panel driver) but making changes there
had no effect.
So I bit the bullet and did a git-bisect, and that is how I found that
problem.
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-12-17 20:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-12-15 21:08 [PATCH] OMAP: DSS: add FEAT_DPI_USES_VDDS_DSI to omap3630_dss_feat_list NeilBrown
2012-12-17 11:58 ` Tomi Valkeinen
2012-12-17 20:27 ` NeilBrown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.