* [oe][meta-oe][PATCH] kernel.bbclass: kernel_do_install fails with 2.6 kernel recipes
@ 2013-01-07 13:39 Marco Cavallini
2013-01-07 16:11 ` Darren Hart
0 siblings, 1 reply; 4+ messages in thread
From: Marco Cavallini @ 2013-01-07 13:39 UTC (permalink / raw)
To: openembedded-core; +Cc: Marco Cavallini
* old 2.6.x kernels don't have $kerneldir/tools directory
* so we got this error:
* sed: can't read ...SNIP...linux/2.6.30-r0/image/usr/src/kernel/tools/perf/Makefile: No such file or directory
* ERROR: Function failed: do_install
Signed-off-by: Marco Cavallini <m.cavallini@koansoftware.com>
---
meta/classes/kernel.bbclass | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
index aee8a77..06b23e0 100644
--- a/meta/classes/kernel.bbclass
+++ b/meta/classes/kernel.bbclass
@@ -204,8 +204,10 @@ kernel_do_install() {
rm -f $kerneldir/$entry
done
- # Fix SLANG_INC for slang.h
- sed -i 's#-I/usr/include/slang#-I=/usr/include/slang#g' $kerneldir/tools/perf/Makefile
+ if [ -f $kerneldir/tools/perf/Makefile ]; then
+ # Fix SLANG_INC for slang.h
+ sed -i 's#-I/usr/include/slang#-I=/usr/include/slang#g' $kerneldir/tools/perf/Makefile
+ fi
}
sysroot_stage_all_append() {
--
1.8.0.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [oe][meta-oe][PATCH] kernel.bbclass: kernel_do_install fails with 2.6 kernel recipes
2013-01-07 13:39 [oe][meta-oe][PATCH] kernel.bbclass: kernel_do_install fails with 2.6 kernel recipes Marco Cavallini
@ 2013-01-07 16:11 ` Darren Hart
2013-01-07 17:10 ` Marco
0 siblings, 1 reply; 4+ messages in thread
From: Darren Hart @ 2013-01-07 16:11 UTC (permalink / raw)
To: Marco Cavallini; +Cc: Marco Cavallini, openembedded-core
Hi Marco,
On 01/07/2013 05:39 AM, Marco Cavallini wrote:
> * old 2.6.x kernels don't have $kerneldir/tools directory
> * so we got this error:
> * sed: can't read ...SNIP...linux/2.6.30-r0/image/usr/src/kernel/tools/perf/Makefile: No such file or directory
> * ERROR: Function failed: do_install
>
> Signed-off-by: Marco Cavallini <m.cavallini@koansoftware.com>
> ---
> meta/classes/kernel.bbclass | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index aee8a77..06b23e0 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -204,8 +204,10 @@ kernel_do_install() {
> rm -f $kerneldir/$entry
> done
>
> - # Fix SLANG_INC for slang.h
> - sed -i 's#-I/usr/include/slang#-I=/usr/include/slang#g' $kerneldir/tools/perf/Makefile
Please include a comment here describing why this was needed. Something
like:
# Linux 2.6.x kernels don't have a tools directory
(Replace .x with the appropriate version of course)
Otherwise, looks good to me. Thanks!
> + if [ -f $kerneldir/tools/perf/Makefile ]; then
> + # Fix SLANG_INC for slang.h
> + sed -i 's#-I/usr/include/slang#-I=/usr/include/slang#g' $kerneldir/tools/perf/Makefile
> + fi
> }
>
> sysroot_stage_all_append() {
>
--
Darren Hart
Intel Open Source Technology Center
Yocto Project - Technical Lead - Linux Kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [oe][meta-oe][PATCH] kernel.bbclass: kernel_do_install fails with 2.6 kernel recipes
2013-01-07 16:11 ` Darren Hart
@ 2013-01-07 17:10 ` Marco
2013-01-07 17:19 ` Darren Hart
0 siblings, 1 reply; 4+ messages in thread
From: Marco @ 2013-01-07 17:10 UTC (permalink / raw)
To: Darren Hart; +Cc: openembedded-core
Il 07/01/2013 17:11, Darren Hart ha scritto:
> Hi Marco,
>
> On 01/07/2013 05:39 AM, Marco Cavallini wrote:
>> * old 2.6.x kernels don't have $kerneldir/tools directory
>> * so we got this error:
>> * sed: can't read ...SNIP...linux/2.6.30-r0/image/usr/src/kernel/tools/perf/Makefile: No such file or directory
>> * ERROR: Function failed: do_install
>>
>> Signed-off-by: Marco Cavallini <m.cavallini@koansoftware.com>
>> ---
>> meta/classes/kernel.bbclass | 6 ++++--
>> 1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
>> index aee8a77..06b23e0 100644
>> --- a/meta/classes/kernel.bbclass
>> +++ b/meta/classes/kernel.bbclass
>> @@ -204,8 +204,10 @@ kernel_do_install() {
>> rm -f $kerneldir/$entry
>> done
>>
>> - # Fix SLANG_INC for slang.h
>> - sed -i 's#-I/usr/include/slang#-I=/usr/include/slang#g' $kerneldir/tools/perf/Makefile
>
> Please include a comment here describing why this was needed. Something
> like:
>
> # Linux 2.6.x kernels don't have a tools directory
>
> (Replace .x with the appropriate version of course)
>
> Otherwise, looks good to me. Thanks!
>
>> + if [ -f $kerneldir/tools/perf/Makefile ]; then
>> + # Fix SLANG_INC for slang.h
>> + sed -i 's#-I/usr/include/slang#-I=/usr/include/slang#g' $kerneldir/tools/perf/Makefile
>> + fi
>> }
>>
>> sysroot_stage_all_append() {
>>
>
Hi Darren,
the comment describing why this was needed was in the patch header, is
in these four lines:
* old 2.6.x kernels don't have $kerneldir/tools directory
* so we got this error:
* sed: can't read
...SNIP...linux/2.6.30-r0/image/usr/src/kernel/tools/perf/Makefile: No
such file or directory
* ERROR: Function failed: do_install
I haven't specified the 2.6 version because I thought that all 2.6
version don't have a 'tools' directory.
BTW I patched it because with 2.6.28 and 2.6.30 it failed.
Cordiali Saluti / Kindest Regards / Mit freundlichen Grüßen
--
Marco Cavallini | KOAN sas | Bergamo - Italia
embedded and real-time software engineering
Phone:+39-035-255.235 - Fax:+39-178-22.39.748
http://www.KoanSoftware.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [oe][meta-oe][PATCH] kernel.bbclass: kernel_do_install fails with 2.6 kernel recipes
2013-01-07 17:10 ` Marco
@ 2013-01-07 17:19 ` Darren Hart
0 siblings, 0 replies; 4+ messages in thread
From: Darren Hart @ 2013-01-07 17:19 UTC (permalink / raw)
To: koansoftware; +Cc: openembedded-core
On 01/07/2013 09:10 AM, Marco wrote:
> Il 07/01/2013 17:11, Darren Hart ha scritto:
>> Hi Marco,
>>
>> On 01/07/2013 05:39 AM, Marco Cavallini wrote:
>>> * old 2.6.x kernels don't have $kerneldir/tools directory
>>> * so we got this error:
>>> * sed: can't read ...SNIP...linux/2.6.30-r0/image/usr/src/kernel/tools/perf/Makefile: No such file or directory
>>> * ERROR: Function failed: do_install
>>>
>>> Signed-off-by: Marco Cavallini <m.cavallini@koansoftware.com>
>>> ---
>>> meta/classes/kernel.bbclass | 6 ++++--
>>> 1 file changed, 4 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
>>> index aee8a77..06b23e0 100644
>>> --- a/meta/classes/kernel.bbclass
>>> +++ b/meta/classes/kernel.bbclass
>>> @@ -204,8 +204,10 @@ kernel_do_install() {
>>> rm -f $kerneldir/$entry
>>> done
>>>
>>> - # Fix SLANG_INC for slang.h
>>> - sed -i 's#-I/usr/include/slang#-I=/usr/include/slang#g' $kerneldir/tools/perf/Makefile
>>
>> Please include a comment here describing why this was needed. Something
>> like:
>>
>> # Linux 2.6.x kernels don't have a tools directory
>>
>> (Replace .x with the appropriate version of course)
>>
>> Otherwise, looks good to me. Thanks!
>>
>>> + if [ -f $kerneldir/tools/perf/Makefile ]; then
>>> + # Fix SLANG_INC for slang.h
>>> + sed -i 's#-I/usr/include/slang#-I=/usr/include/slang#g' $kerneldir/tools/perf/Makefile
>>> + fi
>>> }
>>>
>>> sysroot_stage_all_append() {
>>>
>>
>
>
> Hi Darren,
> the comment describing why this was needed was in the patch header, is
> in these four lines:
>
> * old 2.6.x kernels don't have $kerneldir/tools directory
> * so we got this error:
> * sed: can't read
> ...SNIP...linux/2.6.30-r0/image/usr/src/kernel/tools/perf/Makefile: No
> such file or directory
> * ERROR: Function failed: do_install
>
Yes :-) The point being that it should be in the code itself so someone
reading the code can understand why the test is there without having to
use git blame and git log to discover it.
--
Darren
> I haven't specified the 2.6 version because I thought that all 2.6
> version don't have a 'tools' directory.
> BTW I patched it because with 2.6.28 and 2.6.30 it failed.
>
>
> Cordiali Saluti / Kindest Regards / Mit freundlichen Grüßen
>
--
Darren Hart
Intel Open Source Technology Center
Yocto Project - Technical Lead - Linux Kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-01-07 17:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-07 13:39 [oe][meta-oe][PATCH] kernel.bbclass: kernel_do_install fails with 2.6 kernel recipes Marco Cavallini
2013-01-07 16:11 ` Darren Hart
2013-01-07 17:10 ` Marco
2013-01-07 17:19 ` Darren Hart
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.