All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Clark <rob@ti.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: <linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <arm@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 15/15] staging/omapdrm: don't build on multiplatform
Date: Mon, 21 Jan 2013 12:39:31 -0600	[thread overview]
Message-ID: <50FD8B63.1060506@ti.com> (raw)
In-Reply-To: <201301211741.11875.arnd@arndb.de>

On 01/21/2013 11:41 AM, Arnd Bergmann wrote:
> On Monday 21 January 2013, Rob Clark wrote:
>> Are you sure OMAP2_DSS requires ARCH_OMAP2PLUS?  I don't see this, and
>> it at least used to not depend on ARCH_OMAP2PLUS.  If it does now, I
>> think the correct fix would be to remove the dependency in OMAP2_DSS.  I
>> don't think removing ARCH_MULTIPLATFORM support in omapdrm is the
>> correct solution.
> At least it says so in drivers/video/omap2/Kconfig, which contains
>
> if ARCH_OMAP2PLUS
> source drivers/video/omap2/dss/Kconfig
> endif

ahh, ok, I see.. the if ARCH_OMAP2PLUS bit looks like it came in 
recently (770b6cb)

what about changing this to 'if ARCH_OMAP2PLUS || ARCH_MULTIPLATFORM'?

BR,
-R

> We can probably change this, but until we do, we should not select
> OMAP2_DSS from something that doesn't also depend on ARCH_OMAP2PLUS.
>   
>>> drivers/video/omap2/dss/dss.c: In function 'dss_calc_clock_div':
>>> drivers/video/omap2/dss/dss.c:572:20: error: 'CONFIG_OMAP2_DSS_MIN_FCK_PER_PCK' undeclared (first use in this function)
>>> drivers/video/omap2/dss/dss.c:572:20: note: each undeclared identifier is reported only once for each function it appears in
>>> drivers/staging/omapdrm/omap_connector.c: In function 'omap_connector_dpms':
>>> drivers/staging/omapdrm/omap_connector.c:116:8: error: 'OMAP_DSS_DISPLAY_SUSPENDED' undeclared (first use in this function)
>>> drivers/staging/omapdrm/omap_connector.c:116:8: note: each undeclared identifier is reported only once for each function it appears in
>>
>> This was an unrelated build break which should be fixed in latest master
>> after 'staging: drm/omap: use omapdss low level API'
> Ok, it seems the message is stale then, I created the patch some time ago, but
> only today wrote rest of the explanation for the changeset text.
>
> With all the other patches from my series applied, allyesconfig still gives me
>
> drivers/video/omap2/dss/dss.c:572:20: error: 'CONFIG_OMAP2_DSS_MIN_FCK_PER_PCK' undeclared
>
> because that symbol is only defined when OMAP2_DSS is enabled rather than
> selected. Changing drivers/video/omap2/Kconfig to not depend on OMAP seems
> to work as well, but that seems a little intrusive for v3.8, because it would
> let a lot of people build that code that have no use for it.
>
> 	Arnd


WARNING: multiple messages have this Message-ID (diff)
From: rob@ti.com (Rob Clark)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 15/15] staging/omapdrm: don't build on multiplatform
Date: Mon, 21 Jan 2013 12:39:31 -0600	[thread overview]
Message-ID: <50FD8B63.1060506@ti.com> (raw)
In-Reply-To: <201301211741.11875.arnd@arndb.de>

On 01/21/2013 11:41 AM, Arnd Bergmann wrote:
> On Monday 21 January 2013, Rob Clark wrote:
>> Are you sure OMAP2_DSS requires ARCH_OMAP2PLUS?  I don't see this, and
>> it at least used to not depend on ARCH_OMAP2PLUS.  If it does now, I
>> think the correct fix would be to remove the dependency in OMAP2_DSS.  I
>> don't think removing ARCH_MULTIPLATFORM support in omapdrm is the
>> correct solution.
> At least it says so in drivers/video/omap2/Kconfig, which contains
>
> if ARCH_OMAP2PLUS
> source drivers/video/omap2/dss/Kconfig
> endif

ahh, ok, I see.. the if ARCH_OMAP2PLUS bit looks like it came in 
recently (770b6cb)

what about changing this to 'if ARCH_OMAP2PLUS || ARCH_MULTIPLATFORM'?

BR,
-R

> We can probably change this, but until we do, we should not select
> OMAP2_DSS from something that doesn't also depend on ARCH_OMAP2PLUS.
>   
>>> drivers/video/omap2/dss/dss.c: In function 'dss_calc_clock_div':
>>> drivers/video/omap2/dss/dss.c:572:20: error: 'CONFIG_OMAP2_DSS_MIN_FCK_PER_PCK' undeclared (first use in this function)
>>> drivers/video/omap2/dss/dss.c:572:20: note: each undeclared identifier is reported only once for each function it appears in
>>> drivers/staging/omapdrm/omap_connector.c: In function 'omap_connector_dpms':
>>> drivers/staging/omapdrm/omap_connector.c:116:8: error: 'OMAP_DSS_DISPLAY_SUSPENDED' undeclared (first use in this function)
>>> drivers/staging/omapdrm/omap_connector.c:116:8: note: each undeclared identifier is reported only once for each function it appears in
>>
>> This was an unrelated build break which should be fixed in latest master
>> after 'staging: drm/omap: use omapdss low level API'
> Ok, it seems the message is stale then, I created the patch some time ago, but
> only today wrote rest of the explanation for the changeset text.
>
> With all the other patches from my series applied, allyesconfig still gives me
>
> drivers/video/omap2/dss/dss.c:572:20: error: 'CONFIG_OMAP2_DSS_MIN_FCK_PER_PCK' undeclared
>
> because that symbol is only defined when OMAP2_DSS is enabled rather than
> selected. Changing drivers/video/omap2/Kconfig to not depend on OMAP seems
> to work as well, but that seems a little intrusive for v3.8, because it would
> let a lot of people build that code that have no use for it.
>
> 	Arnd

  reply	other threads:[~2013-01-21 18:39 UTC|newest]

Thread overview: 155+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-21 17:15 [PATCH 00/15] ARM build regressions in v3.8 Arnd Bergmann
2013-01-21 17:15 ` Arnd Bergmann
2013-01-21 17:15 ` [PATCH 01/15] ARM: compressed/head.S: work around new binutils warning Arnd Bergmann
2013-01-21 17:15   ` Arnd Bergmann
2013-01-21 17:15 ` [PATCH 02/15] ARM: mvebu: build coherency_ll.S for arch=armv7-a Arnd Bergmann
2013-01-21 17:15   ` Arnd Bergmann
2013-01-21 19:03   ` Tony Lindgren
2013-01-21 19:03     ` Tony Lindgren
2013-01-21 20:16     ` Arnd Bergmann
2013-01-21 20:16       ` Arnd Bergmann
2013-01-21 17:15 ` [PATCH 03/15] ARM: samsung: fix assembly syntax for new gas Arnd Bergmann
2013-01-21 17:15   ` Arnd Bergmann
2013-01-21 17:15 ` [PATCH 04/15] ARM: w90x900: fix legacy assembly syntax Arnd Bergmann
2013-01-21 17:15   ` Arnd Bergmann
2013-01-21 17:15 ` [PATCH 05/15] ASoC: fsl: fiq and dma cannot both be modules Arnd Bergmann
2013-01-21 17:15   ` Arnd Bergmann
2013-01-21 17:15   ` Arnd Bergmann
2013-01-22  3:50   ` Shawn Guo
2013-01-22  3:50     ` Shawn Guo
2013-01-22  3:50     ` Shawn Guo
2013-01-22  6:33     ` Mark Brown
2013-01-22  6:33       ` Mark Brown
2013-01-22  8:21       ` Arnd Bergmann
2013-01-22  8:21         ` Arnd Bergmann
2013-02-05 16:21       ` Arnd Bergmann
2013-02-05 16:21         ` Arnd Bergmann
2013-02-05 16:42         ` [PATCH] ASoC: fsl: fix allyesconfig build for imx-pcm Arnd Bergmann
2013-02-05 16:42           ` Arnd Bergmann
2013-02-06  4:02           ` Shawn Guo
2013-02-06  4:02             ` Shawn Guo
2013-02-06  4:02             ` Shawn Guo
2013-02-06  8:58             ` Arnd Bergmann
2013-02-06  8:58               ` Arnd Bergmann
2013-01-21 17:15 ` [PATCH 06/15] clk: export __clk_get_name Arnd Bergmann
2013-01-21 17:15   ` Arnd Bergmann
2013-01-21 20:51   ` Ulf Hansson
2013-01-21 20:51     ` Ulf Hansson
2013-01-22 10:54   ` Fabio Estevam
2013-01-22 10:54     ` Fabio Estevam
2013-01-22 15:43     ` Arnd Bergmann
2013-01-22 15:43       ` Arnd Bergmann
2013-02-14 17:41       ` Arnd Bergmann
2013-02-14 17:41         ` Arnd Bergmann
2013-01-21 17:16 ` [PATCH 07/15] drm/exynos: don't include plat/gpio-cfg.h Arnd Bergmann
2013-01-21 17:16   ` Arnd Bergmann
2013-01-21 17:16 ` [PATCH 08/15] drm/exynos: fimd and ipp are broken on multiplatform Arnd Bergmann
2013-01-21 17:16   ` Arnd Bergmann
2013-01-21 17:16   ` Arnd Bergmann
2013-01-22  1:26   ` Inki Dae
2013-01-22  1:26     ` Inki Dae
2013-01-21 17:16 ` [PATCH 09/15] media: coda: don't build " Arnd Bergmann
2013-01-21 17:16   ` Arnd Bergmann
2013-01-22  3:54   ` Shawn Guo
2013-01-22  3:54     ` Shawn Guo
2013-01-22 12:32     ` Mauro Carvalho Chehab
2013-01-22 12:32       ` Mauro Carvalho Chehab
2013-01-22 12:34       ` Mauro Carvalho Chehab
2013-01-22 12:34         ` Mauro Carvalho Chehab
2013-01-22  8:21   ` Sascha Hauer
2013-01-22  8:21     ` Sascha Hauer
2013-01-22 15:41     ` Arnd Bergmann
2013-01-22 15:41       ` Arnd Bergmann
2013-01-21 17:16 ` [PATCH 10/15] mfd/vexpress: export vexpress_config_func_{put,get} Arnd Bergmann
2013-01-21 17:16   ` Arnd Bergmann
2013-01-21 17:23   ` Pawel Moll
2013-01-21 17:23     ` Pawel Moll
2013-01-21 17:16 ` [PATCH 11/15] mtd: davinci_nand: fix OF support Arnd Bergmann
2013-01-21 17:16   ` Arnd Bergmann
2013-01-21 21:37   ` Heiko Schocher
2013-01-21 21:37     ` Heiko Schocher
2013-01-21 21:50     ` Arnd Bergmann
2013-01-21 21:50       ` Arnd Bergmann
2013-01-21 17:16 ` [PATCH 12/15] USB: gadget/freescale: disable non-multiplatform drivers Arnd Bergmann
2013-01-21 17:16   ` Arnd Bergmann
2013-01-21 18:41   ` Felipe Balbi
2013-01-21 18:41     ` Felipe Balbi
2013-01-21 18:57     ` Greg Kroah-Hartman
2013-01-21 18:57       ` Greg Kroah-Hartman
2013-01-21 19:00       ` Felipe Balbi
2013-01-21 19:00         ` Felipe Balbi
2013-01-21 20:15       ` Arnd Bergmann
2013-01-21 20:15         ` Arnd Bergmann
2013-02-05 16:27       ` Arnd Bergmann
2013-02-05 16:27         ` Arnd Bergmann
2013-02-05 17:00         ` Greg Kroah-Hartman
2013-02-05 17:00           ` Greg Kroah-Hartman
2013-02-05 21:37           ` Felipe Balbi
2013-02-05 21:37             ` Felipe Balbi
2013-02-05 22:54             ` Arnd Bergmann
2013-02-05 22:54               ` Arnd Bergmann
2013-02-06  1:55               ` Greg Kroah-Hartman
2013-02-06  1:55                 ` Greg Kroah-Hartman
2013-02-06  7:06                 ` Felipe Balbi
2013-02-06  7:06                   ` Felipe Balbi
2013-01-21 17:16 ` [PATCH 13/15] USB: ehci: make orion and mxc bus glues coexist Arnd Bergmann
2013-01-21 17:16   ` Arnd Bergmann
2013-01-21 18:42   ` Felipe Balbi
2013-01-21 18:42     ` Felipe Balbi
2013-01-21 20:11     ` Alan Stern
2013-01-21 20:11       ` Alan Stern
2013-01-21 21:37       ` Arnd Bergmann
2013-01-21 21:37         ` Arnd Bergmann
2013-01-22  6:11         ` Shawn Guo
2013-01-22  6:11           ` Shawn Guo
2013-01-22  6:14           ` Shawn Guo
2013-01-22  6:14             ` Shawn Guo
2013-01-22 15:30           ` Alan Stern
2013-01-22 15:30             ` Alan Stern
2013-01-21 20:14     ` Arnd Bergmann
2013-01-21 20:14       ` Arnd Bergmann
2013-01-21 20:35       ` Alan Stern
2013-01-21 20:35         ` Alan Stern
2013-01-21 21:49         ` Arnd Bergmann
2013-01-21 21:49           ` Arnd Bergmann
2013-01-22  3:39           ` Alan Stern
2013-01-22  3:39             ` Alan Stern
2013-01-22  4:13             ` Manjunath Goudar
2013-01-22 15:19               ` Alan Stern
2013-01-22 15:19                 ` Alan Stern
2013-01-22 15:38                 ` Arnd Bergmann
2013-01-22 15:38                   ` Arnd Bergmann
2013-01-22 21:00                   ` Sascha Hauer
2013-01-22 21:00                     ` Sascha Hauer
2013-01-23 15:22                     ` Alan Stern
2013-01-23 15:22                       ` Alan Stern
2013-01-21 17:16 ` [PATCH 14/15] samples/seccomp: be less stupid about cross compiling Arnd Bergmann
2013-01-21 17:16   ` Arnd Bergmann
2013-01-22 21:20   ` Kees Cook
2013-01-22 21:20     ` Kees Cook
2013-01-28 14:26     ` Will Drewry
2013-01-28 14:26       ` Will Drewry
2013-01-21 17:16 ` [PATCH 15/15] staging/omapdrm: don't build on multiplatform Arnd Bergmann
2013-01-21 17:16   ` Arnd Bergmann
2013-01-21 17:26   ` Rob Clark
2013-01-21 17:26     ` Rob Clark
2013-01-21 17:29     ` Rob Clark
2013-01-21 17:29       ` Rob Clark
2013-01-21 17:41     ` Arnd Bergmann
2013-01-21 17:41       ` Arnd Bergmann
2013-01-21 18:39       ` Rob Clark [this message]
2013-01-21 18:39         ` Rob Clark
2013-01-21 20:09         ` Arnd Bergmann
2013-01-21 20:09           ` Arnd Bergmann
2013-01-22 16:53         ` Greg Kroah-Hartman
2013-01-22 16:53           ` Greg Kroah-Hartman
2013-01-22 16:57           ` Rob Clark
2013-01-22 16:57             ` Rob Clark
2013-01-22 17:30             ` Greg Kroah-Hartman
2013-01-22 17:30               ` Greg Kroah-Hartman
2013-01-22 17:47               ` Arnd Bergmann
2013-01-22 17:47                 ` Arnd Bergmann
2013-01-22 18:16                 ` Rob Clark
2013-01-22 18:16                   ` Rob Clark
2013-01-22 21:07                   ` Arnd Bergmann
2013-01-22 21:07                     ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50FD8B63.1060506@ti.com \
    --to=rob@ti.com \
    --cc=arm@kernel.org \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.