* [PATCH] Dove: activate GPIO interrupts in DT
@ 2013-01-22 10:28 Jean-Francois Moine
2013-01-22 19:40 ` Sebastian Hesselbarth
0 siblings, 1 reply; 2+ messages in thread
From: Jean-Francois Moine @ 2013-01-22 10:28 UTC (permalink / raw)
To: linux-arm-kernel
In a DT, the interrupts of an interrupt-controller are not usable when
#interrupt-cells is missing.
This patch activates the interrupts of the GPIOs 0 and 1 for the Marvell
Dove SoC.
Signed-off-by: Jean-Fran?ois Moine <moinejf@free.fr>
diff --git a/arch/arm/boot/dts/dove.dtsi b/arch/arm/boot/dts/dove.dtsi
index 42eac1f..287fb12 100644
--- a/arch/arm/boot/dts/dove.dtsi
+++ b/arch/arm/boot/dts/dove.dtsi
@@ -93,6 +93,7 @@
reg = <0xd0400 0x20>;
ngpios = <32>;
interrupt-controller;
+ #interrupt-cells = <1>;
interrupts = <12>, <13>, <14>, <60>;
};
@@ -103,6 +104,7 @@
reg = <0xd0420 0x20>;
ngpios = <32>;
interrupt-controller;
+ #interrupt-cells = <1>;
interrupts = <61>;
};
--
Ken ar c'henta? | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] Dove: activate GPIO interrupts in DT
2013-01-22 10:28 [PATCH] Dove: activate GPIO interrupts in DT Jean-Francois Moine
@ 2013-01-22 19:40 ` Sebastian Hesselbarth
0 siblings, 0 replies; 2+ messages in thread
From: Sebastian Hesselbarth @ 2013-01-22 19:40 UTC (permalink / raw)
To: linux-arm-kernel
On 01/22/2013 11:28 AM, Jean-Francois Moine wrote:
> In a DT, the interrupts of an interrupt-controller are not usable when
> #interrupt-cells is missing.
>
> This patch activates the interrupts of the GPIOs 0 and 1 for the Marvell
> Dove SoC.
>
> Signed-off-by: Jean-Fran?ois Moine<moinejf@free.fr>
>
> diff --git a/arch/arm/boot/dts/dove.dtsi b/arch/arm/boot/dts/dove.dtsi
> index 42eac1f..287fb12 100644
> --- a/arch/arm/boot/dts/dove.dtsi
> +++ b/arch/arm/boot/dts/dove.dtsi
> @@ -93,6 +93,7 @@
> reg =<0xd0400 0x20>;
> ngpios =<32>;
> interrupt-controller;
> + #interrupt-cells =<1>;
> interrupts =<12>,<13>,<14>,<60>;
> };
>
> @@ -103,6 +104,7 @@
> reg =<0xd0420 0x20>;
> ngpios =<32>;
> interrupt-controller;
> + #interrupt-cells =<1>;
> interrupts =<61>;
> };
>
Jean-Francois,
first thanks for sending the patch!
I checked Documentation/devicetree/bindings/gpio/gpio-mvebu.txt and there
#interrupt-cells is specified to be set to two. Further, I checked kirkwood.dtsi
and it is also missing the #interrupt-cells.
Can you please update your patch to have #interrupt-cells set to two? When you
resend v2 of the patch please Cc at least all I added.
I will send another patch fixing kirkwood.dtsi.
Sebastian
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-01-22 19:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-22 10:28 [PATCH] Dove: activate GPIO interrupts in DT Jean-Francois Moine
2013-01-22 19:40 ` Sebastian Hesselbarth
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.