* [Intel-gfx] [PATCH] drm/i915/execlists: Select arb on/off around batches based on preemption @ 2019-12-13 15:13 Chris Wilson 2019-12-13 19:03 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork ` (2 more replies) 0 siblings, 3 replies; 4+ messages in thread From: Chris Wilson @ 2019-12-13 15:13 UTC (permalink / raw) To: intel-gfx Decide whether or not we need to disable arbitration within user batches based on our intel_engine_has_preemption() flag. Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com> --- drivers/gpu/drm/i915/gt/intel_lrc.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c index 929f6bae4eba..983e0e6e909b 100644 --- a/drivers/gpu/drm/i915/gt/intel_lrc.c +++ b/drivers/gpu/drm/i915/gt/intel_lrc.c @@ -3263,9 +3263,9 @@ static void execlists_reset_finish(struct intel_engine_cs *engine) atomic_read(&execlists->tasklet.count)); } -static int gen8_emit_bb_start(struct i915_request *rq, - u64 offset, u32 len, - const unsigned int flags) +static int gen8_emit_bb_start_noarb(struct i915_request *rq, + u64 offset, u32 len, + const unsigned int flags) { u32 *cs; @@ -3299,7 +3299,7 @@ static int gen8_emit_bb_start(struct i915_request *rq, return 0; } -static int gen9_emit_bb_start(struct i915_request *rq, +static int gen8_emit_bb_start(struct i915_request *rq, u64 offset, u32 len, const unsigned int flags) { @@ -3774,6 +3774,11 @@ void intel_execlists_set_default_submission(struct intel_engine_cs *engine) if (INTEL_GEN(engine->i915) >= 12) engine->flags |= I915_ENGINE_HAS_RELATIVE_MMIO; + + if (intel_engine_has_preemption(engine)) + engine->emit_bb_start = gen8_emit_bb_start; + else + engine->emit_bb_start = gen8_emit_bb_start_noarb; } static void execlists_shutdown(struct intel_engine_cs *engine) @@ -3827,10 +3832,6 @@ logical_ring_default_vfuncs(struct intel_engine_cs *engine) * until a more refined solution exists. */ } - if (IS_GEN(engine->i915, 8)) - engine->emit_bb_start = gen8_emit_bb_start; - else - engine->emit_bb_start = gen9_emit_bb_start; } static inline void -- 2.24.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/execlists: Select arb on/off around batches based on preemption 2019-12-13 15:13 [Intel-gfx] [PATCH] drm/i915/execlists: Select arb on/off around batches based on preemption Chris Wilson @ 2019-12-13 19:03 ` Patchwork 2019-12-14 14:06 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2019-12-20 11:26 ` [Intel-gfx] [PATCH] " Tvrtko Ursulin 2 siblings, 0 replies; 4+ messages in thread From: Patchwork @ 2019-12-13 19:03 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx == Series Details == Series: drm/i915/execlists: Select arb on/off around batches based on preemption URL : https://patchwork.freedesktop.org/series/70885/ State : success == Summary == CI Bug Log - changes from CI_DRM_7560 -> Patchwork_15748 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15748/index.html Known issues ------------ Here are the changes found in Patchwork_15748 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_close_race@basic-threads: - fi-byt-j1900: [PASS][1] -> [TIMEOUT][2] ([i915#816]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7560/fi-byt-j1900/igt@gem_close_race@basic-threads.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15748/fi-byt-j1900/igt@gem_close_race@basic-threads.html * igt@gem_exec_gttfill@basic: - fi-tgl-y: [PASS][3] -> [INCOMPLETE][4] ([fdo#111593]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7560/fi-tgl-y/igt@gem_exec_gttfill@basic.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15748/fi-tgl-y/igt@gem_exec_gttfill@basic.html * igt@i915_module_load@reload-no-display: - fi-skl-lmem: [PASS][5] -> [DMESG-WARN][6] ([i915#592]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7560/fi-skl-lmem/igt@i915_module_load@reload-no-display.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15748/fi-skl-lmem/igt@i915_module_load@reload-no-display.html #### Possible fixes #### * igt@gem_close_race@basic-threads: - fi-byt-n2820: [TIMEOUT][7] ([i915#816]) -> [PASS][8] [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7560/fi-byt-n2820/igt@gem_close_race@basic-threads.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15748/fi-byt-n2820/igt@gem_close_race@basic-threads.html * igt@i915_selftest@live_blt: - fi-bsw-n3050: [DMESG-FAIL][9] ([i915#723]) -> [PASS][10] [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7560/fi-bsw-n3050/igt@i915_selftest@live_blt.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15748/fi-bsw-n3050/igt@i915_selftest@live_blt.html - fi-hsw-4770: [DMESG-FAIL][11] ([i915#725]) -> [PASS][12] [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7560/fi-hsw-4770/igt@i915_selftest@live_blt.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15748/fi-hsw-4770/igt@i915_selftest@live_blt.html #### Warnings #### * igt@i915_selftest@live_blt: - fi-hsw-4770r: [DMESG-FAIL][13] -> [DMESG-FAIL][14] ([i915#563]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7560/fi-hsw-4770r/igt@i915_selftest@live_blt.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15748/fi-hsw-4770r/igt@i915_selftest@live_blt.html * igt@kms_busy@basic-flip-pipe-b: - fi-kbl-x1275: [DMESG-WARN][15] ([i915#62] / [i915#92]) -> [DMESG-WARN][16] ([i915#62] / [i915#92] / [i915#95]) +7 similar issues [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7560/fi-kbl-x1275/igt@kms_busy@basic-flip-pipe-b.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15748/fi-kbl-x1275/igt@kms_busy@basic-flip-pipe-b.html * igt@kms_flip@basic-flip-vs-modeset: - fi-kbl-x1275: [DMESG-WARN][17] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][18] ([i915#62] / [i915#92]) +3 similar issues [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7560/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-modeset.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15748/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-modeset.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#111593]: https://bugs.freedesktop.org/show_bug.cgi?id=111593 [i915#476]: https://gitlab.freedesktop.org/drm/intel/issues/476 [i915#563]: https://gitlab.freedesktop.org/drm/intel/issues/563 [i915#592]: https://gitlab.freedesktop.org/drm/intel/issues/592 [i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62 [i915#723]: https://gitlab.freedesktop.org/drm/intel/issues/723 [i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725 [i915#816]: https://gitlab.freedesktop.org/drm/intel/issues/816 [i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92 [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95 Participating hosts (55 -> 47) ------------------------------ Missing (8): fi-icl-1065g7 fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_7560 -> Patchwork_15748 CI-20190529: 20190529 CI_DRM_7560: c093691eb61cb4680e44a339660e9443e728ef67 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5349: 048f58513d8b8ec6bb307a939f0ac959bc0f0e10 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_15748: efcd0ed4aa703c9f8482c41b6d9be11ee121093b @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == efcd0ed4aa70 drm/i915/execlists: Select arb on/off around batches based on preemption == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15748/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/execlists: Select arb on/off around batches based on preemption 2019-12-13 15:13 [Intel-gfx] [PATCH] drm/i915/execlists: Select arb on/off around batches based on preemption Chris Wilson 2019-12-13 19:03 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork @ 2019-12-14 14:06 ` Patchwork 2019-12-20 11:26 ` [Intel-gfx] [PATCH] " Tvrtko Ursulin 2 siblings, 0 replies; 4+ messages in thread From: Patchwork @ 2019-12-14 14:06 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx == Series Details == Series: drm/i915/execlists: Select arb on/off around batches based on preemption URL : https://patchwork.freedesktop.org/series/70885/ State : success == Summary == CI Bug Log - changes from CI_DRM_7560_full -> Patchwork_15748_full ==================================================== Summary ------- **SUCCESS** No regressions found. Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_15748_full: ### IGT changes ### #### Suppressed #### The following results come from untrusted machines, tests, or statuses. They do not affect the overall result. * {igt@gen7_exec_parse@cmd-crossing-page}: - shard-tglb: NOTRUN -> [SKIP][1] +4 similar issues [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15748/shard-tglb3/igt@gen7_exec_parse@cmd-crossing-page.html * {igt@gen9_exec_parse@batch-invalid-length}: - shard-iclb: NOTRUN -> [SKIP][2] [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15748/shard-iclb6/igt@gen9_exec_parse@batch-invalid-length.html Known issues ------------ Here are the changes found in Patchwork_15748_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_ctx_persistence@vcs1-mixed-process: - shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#109276] / [fdo#112080]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7560/shard-iclb2/igt@gem_ctx_persistence@vcs1-mixed-process.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15748/shard-iclb6/igt@gem_ctx_persistence@vcs1-mixed-process.html * igt@gem_exec_gttfill@basic: - shard-tglb: [PASS][5] -> [INCOMPLETE][6] ([fdo#111593]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7560/shard-tglb2/igt@gem_exec_gttfill@basic.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15748/shard-tglb3/igt@gem_exec_gttfill@basic.html * igt@gem_exec_parallel@basic: - shard-tglb: [PASS][7] -> [INCOMPLETE][8] ([i915#476]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7560/shard-tglb9/igt@gem_exec_parallel@basic.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15748/shard-tglb9/igt@gem_exec_parallel@basic.html * igt@gem_exec_schedule@preempt-queue-bsd2: - shard-iclb: [PASS][9] -> [SKIP][10] ([fdo#109276]) +4 similar issues [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7560/shard-iclb2/igt@gem_exec_schedule@preempt-queue-bsd2.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15748/shard-iclb6/igt@gem_exec_schedule@preempt-queue-bsd2.html * igt@gem_exec_schedule@preempt-queue-contexts-bsd2: - shard-tglb: [PASS][11] -> [INCOMPLETE][12] ([fdo#111606] / [fdo#111677]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7560/shard-tglb5/igt@gem_exec_schedule@preempt-queue-contexts-bsd2.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15748/shard-tglb6/igt@gem_exec_schedule@preempt-queue-contexts-bsd2.html * igt@gem_ppgtt@flink-and-close-vma-leak: - shard-glk: [PASS][13] -> [FAIL][14] ([i915#644]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7560/shard-glk3/igt@gem_ppgtt@flink-and-close-vma-leak.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15748/shard-glk7/igt@gem_ppgtt@flink-and-close-vma-leak.html * igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy: - shard-snb: [PASS][15] -> [DMESG-WARN][16] ([fdo#111870]) +2 similar issues [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7560/shard-snb6/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15748/shard-snb4/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html * igt@i915_pm_rpm@system-suspend-execbuf: - shard-tglb: [PASS][17] -> [INCOMPLETE][18] ([i915#456] / [i915#460]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7560/shard-tglb9/igt@i915_pm_rpm@system-suspend-execbuf.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15748/shard-tglb7/igt@i915_pm_rpm@system-suspend-execbuf.html * igt@i915_suspend@forcewake: - shard-snb: [PASS][19] -> [DMESG-WARN][20] ([i915#42]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7560/shard-snb2/igt@i915_suspend@forcewake.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15748/shard-snb2/igt@i915_suspend@forcewake.html * igt@kms_color@pipe-a-ctm-0-25: - shard-skl: [PASS][21] -> [DMESG-WARN][22] ([i915#109]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7560/shard-skl1/igt@kms_color@pipe-a-ctm-0-25.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15748/shard-skl4/igt@kms_color@pipe-a-ctm-0-25.html * igt@kms_cursor_crc@pipe-b-cursor-64x21-onscreen: - shard-skl: [PASS][23] -> [FAIL][24] ([i915#54]) +1 similar issue [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7560/shard-skl6/igt@kms_cursor_crc@pipe-b-cursor-64x21-onscreen.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15748/shard-skl6/igt@kms_cursor_crc@pipe-b-cursor-64x21-onscreen.html * igt@kms_flip@flip-vs-expired-vblank-interruptible: - shard-skl: [PASS][25] -> [FAIL][26] ([i915#79]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7560/shard-skl5/igt@kms_flip@flip-vs-expired-vblank-interruptible.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15748/shard-skl5/igt@kms_flip@flip-vs-expired-vblank-interruptible.html * igt@kms_frontbuffer_tracking@fbc-suspend: - shard-tglb: [PASS][27] -> [INCOMPLETE][28] ([i915#456] / [i915#460] / [i915#474]) [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7560/shard-tglb6/igt@kms_frontbuffer_tracking@fbc-suspend.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15748/shard-tglb1/igt@kms_frontbuffer_tracking@fbc-suspend.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw: - shard-tglb: [PASS][29] -> [FAIL][30] ([i915#49]) [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7560/shard-tglb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15748/shard-tglb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-move: - shard-tglb: [PASS][31] -> [INCOMPLETE][32] ([i915#474] / [i915#667]) [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7560/shard-tglb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-move.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15748/shard-tglb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-move.html * igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-render: - shard-skl: [PASS][33] -> [FAIL][34] ([i915#49]) [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7560/shard-skl7/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-render.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15748/shard-skl9/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-render.html * igt@kms_plane@pixel-format-pipe-b-planes: - shard-kbl: [PASS][35] -> [INCOMPLETE][36] ([fdo#103665] / [i915#648] / [i915#667]) [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7560/shard-kbl4/igt@kms_plane@pixel-format-pipe-b-planes.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15748/shard-kbl7/igt@kms_plane@pixel-format-pipe-b-planes.html * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes: - shard-kbl: [PASS][37] -> [DMESG-WARN][38] ([i915#180]) +4 similar issues [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7560/shard-kbl7/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15748/shard-kbl1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html * igt@kms_setmode@basic: - shard-apl: [PASS][39] -> [FAIL][40] ([i915#31]) [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7560/shard-apl7/igt@kms_setmode@basic.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15748/shard-apl6/igt@kms_setmode@basic.html - shard-glk: [PASS][41] -> [FAIL][42] ([i915#31]) [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7560/shard-glk2/igt@kms_setmode@basic.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15748/shard-glk3/igt@kms_setmode@basic.html * igt@perf_pmu@busy-check-all-vcs1: - shard-iclb: [PASS][43] -> [SKIP][44] ([fdo#112080]) [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7560/shard-iclb4/igt@perf_pmu@busy-check-all-vcs1.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15748/shard-iclb3/igt@perf_pmu@busy-check-all-vcs1.html #### Possible fixes #### * igt@gem_eio@suspend: - shard-tglb: [INCOMPLETE][45] ([i915#460]) -> [PASS][46] [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7560/shard-tglb4/igt@gem_eio@suspend.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15748/shard-tglb7/igt@gem_eio@suspend.html * igt@gem_exec_parallel@contexts: - shard-tglb: [INCOMPLETE][47] ([i915#470]) -> [PASS][48] +1 similar issue [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7560/shard-tglb6/igt@gem_exec_parallel@contexts.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15748/shard-tglb1/igt@gem_exec_parallel@contexts.html * igt@gem_exec_schedule@in-order-bsd: - shard-iclb: [SKIP][49] ([fdo#112146]) -> [PASS][50] +2 similar issues [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7560/shard-iclb2/igt@gem_exec_schedule@in-order-bsd.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15748/shard-iclb6/igt@gem_exec_schedule@in-order-bsd.html * igt@gem_exec_schedule@preempt-queue-chain-render: - shard-tglb: [INCOMPLETE][51] ([fdo#111606] / [fdo#111677]) -> [PASS][52] [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7560/shard-tglb6/igt@gem_exec_schedule@preempt-queue-chain-render.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15748/shard-tglb5/igt@gem_exec_schedule@preempt-queue-chain-render.html * igt@gem_persistent_relocs@forked-interruptible-thrashing: - shard-apl: [FAIL][53] ([i915#520]) -> [PASS][54] [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7560/shard-apl2/igt@gem_persistent_relocs@forked-interruptible-thrashing.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15748/shard-apl2/igt@gem_persistent_relocs@forked-interruptible-thrashing.html * igt@gem_ppgtt@flink-and-close-vma-leak: - shard-skl: [FAIL][55] ([i915#644]) -> [PASS][56] [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7560/shard-skl5/igt@gem_ppgtt@flink-and-close-vma-leak.html [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15748/shard-skl5/igt@gem_ppgtt@flink-and-close-vma-leak.html * igt@gem_tiled_blits@interruptible: - shard-hsw: [FAIL][57] ([i915#818]) -> [PASS][58] [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7560/shard-hsw5/igt@gem_tiled_blits@interruptible.html [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15748/shard-hsw4/igt@gem_tiled_blits@interruptible.html * igt@gem_userptr_blits@sync-unmap-cycles: - shard-snb: [DMESG-WARN][59] ([fdo#111870]) -> [PASS][60] [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7560/shard-snb1/igt@gem_userptr_blits@sync-unmap-cycles.html [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15748/shard-snb5/igt@gem_userptr_blits@sync-unmap-cycles.html * igt@gem_workarounds@suspend-resume-context: - shard-apl: [DMESG-WARN][61] ([i915#180]) -> [PASS][62] [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7560/shard-apl1/igt@gem_workarounds@suspend-resume-context.html [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15748/shard-apl7/igt@gem_workarounds@suspend-resume-context.html * {igt@gen7_exec_parse@basic-allocation}: - shard-hsw: [FAIL][63] -> [PASS][64] [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7560/shard-hsw7/igt@gen7_exec_parse@basic-allocation.html [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15748/shard-hsw8/igt@gen7_exec_parse@basic-allocation.html * {igt@gen9_exec_parse@allowed-single}: - shard-skl: [DMESG-WARN][65] -> [PASS][66] [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7560/shard-skl7/igt@gen9_exec_parse@allowed-single.html [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15748/shard-skl9/igt@gen9_exec_parse@allowed-single.html * igt@kms_cursor_crc@pipe-a-cursor-suspend: - shard-kbl: [DMESG-WARN][67] ([i915#180]) -> [PASS][68] +5 similar issues [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7560/shard-kbl6/igt@kms_cursor_crc@pipe-a-cursor-suspend.html [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15748/shard-kbl7/igt@kms_cursor_crc@pipe-a-cursor-suspend.html * igt@kms_cursor_crc@pipe-c-cursor-256x85-sliding: - shard-skl: [FAIL][69] ([i915#54]) -> [PASS][70] [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7560/shard-skl1/igt@kms_cursor_crc@pipe-c-cursor-256x85-sliding.html [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15748/shard-skl10/igt@kms_cursor_crc@pipe-c-cursor-256x85-sliding.html * igt@kms_flip@flip-vs-expired-vblank: - shard-skl: [FAIL][71] ([i915#79]) -> [PASS][72] [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7560/shard-skl1/igt@kms_flip@flip-vs-expired-vblank.html [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15748/shard-skl4/igt@kms_flip@flip-vs-expired-vblank.html * igt@kms_flip@flip-vs-suspend: - shard-skl: [INCOMPLETE][73] ([i915#221]) -> [PASS][74] [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7560/shard-skl7/igt@kms_flip@flip-vs-suspend.html [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15748/shard-skl3/igt@kms_flip@flip-vs-suspend.html - shard-hsw: [INCOMPLETE][75] ([i915#61]) -> [PASS][76] [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7560/shard-hsw4/igt@kms_flip@flip-vs-suspend.html [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15748/shard-hsw8/igt@kms_flip@flip-vs-suspend.html * igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite: - shard-tglb: [FAIL][77] ([i915#49]) -> [PASS][78] [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7560/shard-tglb1/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite.html [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15748/shard-tglb1/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite.html * igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-mmap-cpu: - shard-skl: [FAIL][79] ([i915#49]) -> [PASS][80] [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7560/shard-skl3/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-mmap-cpu.html [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15748/shard-skl4/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-mmap-cpu.html * igt@kms_plane@pixel-format-pipe-b-planes-source-clamping: - shard-skl: [INCOMPLETE][81] ([fdo#112347] / [fdo#112391] / [i915#648] / [i915#667]) -> [PASS][82] [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7560/shard-skl5/igt@kms_plane@pixel-format-pipe-b-planes-source-clamping.html [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15748/shard-skl5/igt@kms_plane@pixel-format-pipe-b-planes-source-clamping.html * igt@kms_psr@psr2_sprite_mmap_gtt: - shard-iclb: [SKIP][83] ([fdo#109441]) -> [PASS][84] +1 similar issue [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7560/shard-iclb4/igt@kms_psr@psr2_sprite_mmap_gtt.html [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15748/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html * igt@kms_psr@psr2_suspend: - shard-tglb: [INCOMPLETE][85] ([i915#456] / [i915#460]) -> [PASS][86] [85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7560/shard-tglb7/igt@kms_psr@psr2_suspend.html [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15748/shard-tglb4/igt@kms_psr@psr2_suspend.html * igt@kms_setmode@basic: - shard-hsw: [FAIL][87] ([i915#31]) -> [PASS][88] [87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7560/shard-hsw8/igt@kms_setmode@basic.html [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15748/shard-hsw7/igt@kms_setmode@basic.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665 [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#111593]: https://bugs.freedesktop.org/show_bug.cgi?id=111593 [fdo#111606]: https://bugs.freedesktop.org/show_bug.cgi?id=111606 [fdo#111677]: https://bugs.freedesktop.org/show_bug.cgi?id=111677 [fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870 [fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080 [fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146 [fdo#112347]: https://bugs.freedesktop.org/show_bug.cgi?id=112347 [fdo#112391]: https://bugs.freedesktop.org/show_bug.cgi?id=112391 [i915#109]: https://gitlab.freedesktop.org/drm/intel/issues/109 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#221]: https://gitlab.freedesktop.org/drm/intel/issues/221 [i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31 [i915#42]: https://gitlab.freedesktop.org/drm/intel/issues/42 [i915#456]: https://gitlab.freedesktop.org/drm/intel/issues/456 [i915#460]: https://gitlab.freedesktop.org/drm/intel/issues/460 [i915#470]: https://gitlab.freedesktop.org/drm/intel/issues/470 [i915#474]: https://gitlab.freedesktop.org/drm/intel/issues/474 [i915#476]: https://gitlab.freedesktop.org/drm/intel/issues/476 [i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49 [i915#520]: https://gitlab.freedesktop.org/drm/intel/issues/520 [i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54 [i915#61]: https://gitlab.freedesktop.org/drm/intel/issues/61 [i915#644]: https://gitlab.freedesktop.org/drm/intel/issues/644 [i915#648]: https://gitlab.freedesktop.org/drm/intel/issues/648 [i915#667]: https://gitlab.freedesktop.org/drm/intel/issues/667 [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79 [i915#818]: https://gitlab.freedesktop.org/drm/intel/issues/818 Participating hosts (11 -> 10) ------------------------------ Missing (1): pig-hsw-4770r Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_7560 -> Patchwork_15748 CI-20190529: 20190529 CI_DRM_7560: c093691eb61cb4680e44a339660e9443e728ef67 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5349: 048f58513d8b8ec6bb307a939f0ac959bc0f0e10 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_15748: efcd0ed4aa703c9f8482c41b6d9be11ee121093b @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15748/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/execlists: Select arb on/off around batches based on preemption 2019-12-13 15:13 [Intel-gfx] [PATCH] drm/i915/execlists: Select arb on/off around batches based on preemption Chris Wilson 2019-12-13 19:03 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork 2019-12-14 14:06 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork @ 2019-12-20 11:26 ` Tvrtko Ursulin 2 siblings, 0 replies; 4+ messages in thread From: Tvrtko Ursulin @ 2019-12-20 11:26 UTC (permalink / raw) To: Chris Wilson, intel-gfx On 13/12/2019 15:13, Chris Wilson wrote: > Decide whether or not we need to disable arbitration within user batches > based on our intel_engine_has_preemption() flag. > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com> > --- > drivers/gpu/drm/i915/gt/intel_lrc.c | 17 +++++++++-------- > 1 file changed, 9 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c > index 929f6bae4eba..983e0e6e909b 100644 > --- a/drivers/gpu/drm/i915/gt/intel_lrc.c > +++ b/drivers/gpu/drm/i915/gt/intel_lrc.c > @@ -3263,9 +3263,9 @@ static void execlists_reset_finish(struct intel_engine_cs *engine) > atomic_read(&execlists->tasklet.count)); > } > > -static int gen8_emit_bb_start(struct i915_request *rq, > - u64 offset, u32 len, > - const unsigned int flags) > +static int gen8_emit_bb_start_noarb(struct i915_request *rq, > + u64 offset, u32 len, > + const unsigned int flags) > { > u32 *cs; > > @@ -3299,7 +3299,7 @@ static int gen8_emit_bb_start(struct i915_request *rq, > return 0; > } > > -static int gen9_emit_bb_start(struct i915_request *rq, > +static int gen8_emit_bb_start(struct i915_request *rq, > u64 offset, u32 len, > const unsigned int flags) > { > @@ -3774,6 +3774,11 @@ void intel_execlists_set_default_submission(struct intel_engine_cs *engine) > > if (INTEL_GEN(engine->i915) >= 12) > engine->flags |= I915_ENGINE_HAS_RELATIVE_MMIO; > + > + if (intel_engine_has_preemption(engine)) > + engine->emit_bb_start = gen8_emit_bb_start; > + else > + engine->emit_bb_start = gen8_emit_bb_start_noarb; > } > > static void execlists_shutdown(struct intel_engine_cs *engine) > @@ -3827,10 +3832,6 @@ logical_ring_default_vfuncs(struct intel_engine_cs *engine) > * until a more refined solution exists. > */ > } > - if (IS_GEN(engine->i915, 8)) > - engine->emit_bb_start = gen8_emit_bb_start; > - else > - engine->emit_bb_start = gen9_emit_bb_start; > } > > static inline void > Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Regards, Tvrtko _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-12-20 11:26 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-12-13 15:13 [Intel-gfx] [PATCH] drm/i915/execlists: Select arb on/off around batches based on preemption Chris Wilson 2019-12-13 19:03 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork 2019-12-14 14:06 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2019-12-20 11:26 ` [Intel-gfx] [PATCH] " Tvrtko Ursulin
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.