[meta-oe][PATCH v2] stm32flash: add recipe

[meta-oe][PATCH v2] stm32flash: add recipe

[Richard Leitner]

Add recipe for version 0.5 of stm32flash, an open source flash program for
STM32 using the ST serial bootloader.

Signed-off-by: Richard Leitner <richard.leitner@skidata.com>
---
 meta-oe/recipes-support/stm32flash/stm32flash_0.5.bb | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
 create mode 100644 meta-oe/recipes-support/stm32flash/stm32flash_0.5.bb

diff --git a/meta-oe/recipes-support/stm32flash/stm32flash_0.5.bb b/meta-oe/recipes-support/stm32flash/stm32flash_0.5.bb
new file mode 100644
index 000000000..7f1a7823a
--- /dev/null
+++ b/meta-oe/recipes-support/stm32flash/stm32flash_0.5.bb
@@ -0,0 +1,16 @@
+SUMMARY = "Open source flash program for STM32 using the ST serial bootloader"
+HOMEPAGE = "https://sourceforge.net/projects/stm32flash/"
+BUGTRACKER = "https://sourceforge.net/p/stm32flash/tickets/"
+LICENSE = "GPLv2"
+LIC_FILES_CHKSUM = "file://gpl-2.0.txt;md5=b234ee4d69f5fce4486a80fdaf4a4263"
+
+inherit autotools-brokensep
+
+EXTRA_OEMAKE = "PREFIX=${prefix}"
+
+S = "${WORKDIR}/${PN}"
+
+SRC_URI = "https://prdownloads.sourceforge.net/stm32flash/stm32flash-${PV}.tar.gz"
+
+SRC_URI[md5sum] = "40f673502949f3bb655d2bcc539d7b6a"
+SRC_URI[sha256sum] = "97aa9422ef02e82f7da9039329e21a437decf972cb3919ad817f70ac9a49e306"
-- 
2.11.0

Re: [meta-oe][PATCH v2] stm32flash: add recipe

[Peter Kjellerstedt]

We have had our own recipe for stm32flash for a few years, so I 
have a couple of comments to improve this recipe.

> -----Original Message-----
> From: openembedded-devel-bounces@lists.openembedded.org
> [mailto:openembedded-devel-bounces@lists.openembedded.org] On Behalf Of
> Richard Leitner
> Sent: den 18 maj 2018 09:50
> To: openembedded-devel@lists.openembedded.org
> Subject: [oe] [meta-oe][PATCH v2] stm32flash: add recipe
> 
> Add recipe for version 0.5 of stm32flash, an open source flash program for
> STM32 using the ST serial bootloader.
> 
> Signed-off-by: Richard Leitner <richard.leitner@skidata.com>
> ---
>  meta-oe/recipes-support/stm32flash/stm32flash_0.5.bb | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>  create mode 100644 meta-oe/recipes-support/stm32flash/stm32flash_0.5.bb
> 
> diff --git a/meta-oe/recipes-support/stm32flash/stm32flash_0.5.bb b/meta-oe/recipes-support/stm32flash/stm32flash_0.5.bb
> new file mode 100644
> index 000000000..7f1a7823a
> --- /dev/null
> +++ b/meta-oe/recipes-support/stm32flash/stm32flash_0.5.bb
> @@ -0,0 +1,16 @@
> +SUMMARY = "Open source flash program for STM32 using the ST serial bootloader"
> +HOMEPAGE = "https://sourceforge.net/projects/stm32flash/"
> +BUGTRACKER = "https://sourceforge.net/p/stm32flash/tickets/"
> +LICENSE = "GPLv2"

The license is GPLv2 or later, so change this to:

LICENSE = "GPL-2.0+"

> +LIC_FILES_CHKSUM = "file://gpl-2.0.txt;md5=b234ee4d69f5fce4486a80fdaf4a4263"
> +
> +inherit autotools-brokensep

Remove the inherit of autotools-brokensep. This is not an 
autotools-based package.

> +
> +EXTRA_OEMAKE = "PREFIX=${prefix}"

Remove this as well (see below).

> +
> +S = "${WORKDIR}/${PN}"
> +
> +SRC_URI = "https://prdownloads.sourceforge.net/stm32flash/stm32flash-${PV}.tar.gz"

Replace with:

SRC_URI = "${SOURCEFORGE_MIRROR}/${BPN}/${BP}.tar.gz"

> +
> +SRC_URI[md5sum] = "40f673502949f3bb655d2bcc539d7b6a"
> +SRC_URI[sha256sum] = "97aa9422ef02e82f7da9039329e21a437decf972cb3919ad817f70ac9a49e306"

Add:

do_install() {
	oe_runmake install DESTDIR=${D} PREFIX=${prefix}
}

//Peter

Re: [meta-oe][PATCH v2] stm32flash: add recipe

[Richard Leitner]

Hi,

On 05/18/2018 07:20 PM, Peter Kjellerstedt wrote:
> We have had our own recipe for stm32flash for a few years, so I 
> have a couple of comments to improve this recipe.
> 
>> -----Original Message-----
>> From: openembedded-devel-bounces@lists.openembedded.org
>> [mailto:openembedded-devel-bounces@lists.openembedded.org] On Behalf Of
>> Richard Leitner
>> Sent: den 18 maj 2018 09:50
>> To: openembedded-devel@lists.openembedded.org
>> Subject: [oe] [meta-oe][PATCH v2] stm32flash: add recipe
>>
>> Add recipe for version 0.5 of stm32flash, an open source flash program for
>> STM32 using the ST serial bootloader.
>>
>> Signed-off-by: Richard Leitner <richard.leitner@skidata.com>
>> ---
>>  meta-oe/recipes-support/stm32flash/stm32flash_0.5.bb | 16 ++++++++++++++++
>>  1 file changed, 16 insertions(+)
>>  create mode 100644 meta-oe/recipes-support/stm32flash/stm32flash_0.5.bb
>>
>> diff --git a/meta-oe/recipes-support/stm32flash/stm32flash_0.5.bb b/meta-oe/recipes-support/stm32flash/stm32flash_0.5.bb
>> new file mode 100644
>> index 000000000..7f1a7823a
>> --- /dev/null
>> +++ b/meta-oe/recipes-support/stm32flash/stm32flash_0.5.bb
>> @@ -0,0 +1,16 @@
>> +SUMMARY = "Open source flash program for STM32 using the ST serial bootloader"
>> +HOMEPAGE = "https://sourceforge.net/projects/stm32flash/"
>> +BUGTRACKER = "https://sourceforge.net/p/stm32flash/tickets/"
>> +LICENSE = "GPLv2"
> 
> The license is GPLv2 or later, so change this to:
> 
> LICENSE = "GPL-2.0+"
> 
>> +LIC_FILES_CHKSUM = "file://gpl-2.0.txt;md5=b234ee4d69f5fce4486a80fdaf4a4263"
>> +
>> +inherit autotools-brokensep
> 
> Remove the inherit of autotools-brokensep. This is not an 
> autotools-based package.
> 
>> +
>> +EXTRA_OEMAKE = "PREFIX=${prefix}"
> 
> Remove this as well (see below).
> 
>> +
>> +S = "${WORKDIR}/${PN}"
>> +
>> +SRC_URI = "https://prdownloads.sourceforge.net/stm32flash/stm32flash-${PV}.tar.gz"
> 
> Replace with:
> 
> SRC_URI = "${SOURCEFORGE_MIRROR}/${BPN}/${BP}.tar.gz"
> 
>> +
>> +SRC_URI[md5sum] = "40f673502949f3bb655d2bcc539d7b6a"
>> +SRC_URI[sha256sum] = "97aa9422ef02e82f7da9039329e21a437decf972cb3919ad817f70ac9a49e306"
> 
> Add:
> 
> do_install() {
> 	oe_runmake install DESTDIR=${D} PREFIX=${prefix}
> }

Thank you for your feedback. I'm fine with all of these changes and will
send a v3 asap!

> 
> //Peter
> 

regards;Richard.L

Re: [meta-oe][PATCH v2] stm32flash: add recipe

[Richard Leitner]

Hi again Peter,

On 05/21/2018 11:07 PM, Richard Leitner wrote:
> Hi,
> 
> On 05/18/2018 07:20 PM, Peter Kjellerstedt wrote:
>> We have had our own recipe for stm32flash for a few years, so I 
>> have a couple of comments to improve this recipe.

...

> 
> Thank you for your feedback. I'm fine with all of these changes and will
> send a v3 asap!
> 

I just saw that my v2 patch was already merged to master... So do you
want to send a patch with your improvements yourself? IMHO in the end
you should be listed as the author of them ;-)

regards;Richard.L

Re: [meta-oe][PATCH v2] stm32flash: add recipe

[Khem Raj]

On Mon, May 21, 2018 at 5:21 PM Richard Leitner <richard.leitner@skidata.com>
wrote:

> Hi again Peter,
>
> On 05/21/2018 11:07 PM, Richard Leitner wrote:
> > Hi,
> >
> > On 05/18/2018 07:20 PM, Peter Kjellerstedt wrote:
> >> We have had our own recipe for stm32flash for a few years, so I
> >> have a couple of comments to improve this recipe.
>
> ...
>
> >
> > Thank you for your feedback. I'm fine with all of these changes and will
> > send a v3 asap!
> >
>
> I just saw that my v2 patch was already merged to master... So do you
> want to send a patch with your improvements yourself? IMHO in the end
> you should be listed as the author of them ;-)
>

No worries I have staged the needed changes

>
> regards;Richard.L
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>

Re: [meta-oe][PATCH v2] stm32flash: add recipe

[Richard Leitner]

On 05/22/2018 03:04 AM, Khem Raj wrote> On Mon, May 21, 2018 at 5:21 PM Richard Leitner <richard.leitner@skidata.com <mailto:richard.leitner@skidata.com>> wrote:
> 
>     Hi again Peter,
> 
>     On 05/21/2018 11:07 PM, Richard Leitner wrote:
>     > Hi,
>     >
>     > On 05/18/2018 07:20 PM, Peter Kjellerstedt wrote:
>     >> We have had our own recipe for stm32flash for a few years, so I
>     >> have a couple of comments to improve this recipe.
> 
>     ...
> 
>     >
>     > Thank you for your feedback. I'm fine with all of these changes and will
>     > send a v3 asap!
>     >
> 
>     I just saw that my v2 patch was already merged to master... So do you
>     want to send a patch with your improvements yourself? IMHO in the end
>     you should be listed as the author of them ;-)
> 
> 
> No worries I have staged the needed changes

Thank you!

regards;Richard.L