From: <Mario.Limonciello@dell.com> To: <kai.heng.feng@canonical.com>, <mjg59@srcf.ucam.org>, <pali.rohar@gmail.com>, <dvhart@infradead.org>, <andy@infradead.org>, <tiwai@suse.com> Cc: <platform-driver-x86@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <alsa-devel@alsa-project.org> Subject: RE: [PATCH 1/2] dell-led: Change dell-led.h to dell-common.h Date: Thu, 8 Mar 2018 07:31:54 +0000 [thread overview] Message-ID: <50d4e281b7644399bc85aa16a1eacb8f@ausx13mpc124.AMER.DELL.COM> (raw) In-Reply-To: <20180308071207.19850-1-kai.heng.feng@canonical.com> > -----Original Message----- > From: Kai-Heng Feng [mailto:kai.heng.feng@canonical.com] > Sent: Thursday, March 8, 2018 3:12 PM > To: mjg59@srcf.ucam.org; pali.rohar@gmail.com; dvhart@infradead.org; > andy@infradead.org; Limonciello, Mario <Mario_Limonciello@Dell.com>; > tiwai@suse.com > Cc: platform-driver-x86@vger.kernel.org; linux-kernel@vger.kernel.org; alsa- > devel@alsa-project.org; Kai-Heng Feng <kai.heng.feng@canonical.com> > Subject: [PATCH 1/2] dell-led: Change dell-led.h to dell-common.h > > This header will be used for more than just led. Change it to a more > generic name. > > Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> Reviewed-by: Mario Limonciello <mario.limonciello@dell.com> > --- > drivers/platform/x86/dell-laptop.c | 2 +- > include/linux/{dell-led.h => dell-common.h} | 4 ++-- > sound/pci/hda/dell_wmi_helper.c | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) > rename include/linux/{dell-led.h => dell-common.h} (61%) > > diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c > index c52c6723374b..8ba820e6c3d0 100644 > --- a/drivers/platform/x86/dell-laptop.c > +++ b/drivers/platform/x86/dell-laptop.c > @@ -29,7 +29,7 @@ > #include <linux/mm.h> > #include <linux/i8042.h> > #include <linux/debugfs.h> > -#include <linux/dell-led.h> > +#include <linux/dell-common.h> > #include <linux/seq_file.h> > #include <acpi/video.h> > #include "dell-rbtn.h" > diff --git a/include/linux/dell-led.h b/include/linux/dell-common.h > similarity index 61% > rename from include/linux/dell-led.h > rename to include/linux/dell-common.h > index 92521471517f..37e4b614dd74 100644 > --- a/include/linux/dell-led.h > +++ b/include/linux/dell-common.h > @@ -1,6 +1,6 @@ > /* SPDX-License-Identifier: GPL-2.0 */ > -#ifndef __DELL_LED_H__ > -#define __DELL_LED_H__ > +#ifndef __DELL_COMMON_H__ > +#define __DELL_COMMON_H__ > > int dell_micmute_led_set(int on); > > diff --git a/sound/pci/hda/dell_wmi_helper.c b/sound/pci/hda/dell_wmi_helper.c > index 1b48a8c19d28..56050cc3c0ee 100644 > --- a/sound/pci/hda/dell_wmi_helper.c > +++ b/sound/pci/hda/dell_wmi_helper.c > @@ -4,7 +4,7 @@ > */ > > #if IS_ENABLED(CONFIG_DELL_LAPTOP) > -#include <linux/dell-led.h> > +#include <linux/dell-common.h> > > enum { > MICMUTE_LED_ON, > -- > 2.15.1
WARNING: multiple messages have this Message-ID (diff)
From: <Mario.Limonciello@dell.com> To: kai.heng.feng@canonical.com, mjg59@srcf.ucam.org, pali.rohar@gmail.com, dvhart@infradead.org, andy@infradead.org, tiwai@suse.com Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Subject: RE: [PATCH 1/2] dell-led: Change dell-led.h to dell-common.h Date: Thu, 8 Mar 2018 07:31:54 +0000 [thread overview] Message-ID: <50d4e281b7644399bc85aa16a1eacb8f@ausx13mpc124.AMER.DELL.COM> (raw) In-Reply-To: <20180308071207.19850-1-kai.heng.feng@canonical.com> > -----Original Message----- > From: Kai-Heng Feng [mailto:kai.heng.feng@canonical.com] > Sent: Thursday, March 8, 2018 3:12 PM > To: mjg59@srcf.ucam.org; pali.rohar@gmail.com; dvhart@infradead.org; > andy@infradead.org; Limonciello, Mario <Mario_Limonciello@Dell.com>; > tiwai@suse.com > Cc: platform-driver-x86@vger.kernel.org; linux-kernel@vger.kernel.org; alsa- > devel@alsa-project.org; Kai-Heng Feng <kai.heng.feng@canonical.com> > Subject: [PATCH 1/2] dell-led: Change dell-led.h to dell-common.h > > This header will be used for more than just led. Change it to a more > generic name. > > Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> Reviewed-by: Mario Limonciello <mario.limonciello@dell.com> > --- > drivers/platform/x86/dell-laptop.c | 2 +- > include/linux/{dell-led.h => dell-common.h} | 4 ++-- > sound/pci/hda/dell_wmi_helper.c | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) > rename include/linux/{dell-led.h => dell-common.h} (61%) > > diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c > index c52c6723374b..8ba820e6c3d0 100644 > --- a/drivers/platform/x86/dell-laptop.c > +++ b/drivers/platform/x86/dell-laptop.c > @@ -29,7 +29,7 @@ > #include <linux/mm.h> > #include <linux/i8042.h> > #include <linux/debugfs.h> > -#include <linux/dell-led.h> > +#include <linux/dell-common.h> > #include <linux/seq_file.h> > #include <acpi/video.h> > #include "dell-rbtn.h" > diff --git a/include/linux/dell-led.h b/include/linux/dell-common.h > similarity index 61% > rename from include/linux/dell-led.h > rename to include/linux/dell-common.h > index 92521471517f..37e4b614dd74 100644 > --- a/include/linux/dell-led.h > +++ b/include/linux/dell-common.h > @@ -1,6 +1,6 @@ > /* SPDX-License-Identifier: GPL-2.0 */ > -#ifndef __DELL_LED_H__ > -#define __DELL_LED_H__ > +#ifndef __DELL_COMMON_H__ > +#define __DELL_COMMON_H__ > > int dell_micmute_led_set(int on); > > diff --git a/sound/pci/hda/dell_wmi_helper.c b/sound/pci/hda/dell_wmi_helper.c > index 1b48a8c19d28..56050cc3c0ee 100644 > --- a/sound/pci/hda/dell_wmi_helper.c > +++ b/sound/pci/hda/dell_wmi_helper.c > @@ -4,7 +4,7 @@ > */ > > #if IS_ENABLED(CONFIG_DELL_LAPTOP) > -#include <linux/dell-led.h> > +#include <linux/dell-common.h> > > enum { > MICMUTE_LED_ON, > -- > 2.15.1
next prev parent reply other threads:[~2018-03-08 7:31 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-03-08 7:12 [PATCH 1/2] dell-led: Change dell-led.h to dell-common.h Kai-Heng Feng 2018-03-08 7:12 ` [PATCH 2/2] platform/x86: dell-*: Add interface for switchable graphics status query Kai-Heng Feng 2018-03-08 7:34 ` Mario.Limonciello 2018-03-08 7:34 ` Mario.Limonciello 2018-03-08 8:20 ` Kai Heng Feng 2018-03-08 8:20 ` Kai Heng Feng 2018-03-08 8:35 ` Mario.Limonciello 2018-03-08 8:35 ` Mario.Limonciello 2018-03-08 7:23 ` [PATCH 1/2] dell-led: Change dell-led.h to dell-common.h Takashi Iwai 2018-03-08 7:23 ` Takashi Iwai 2018-03-08 7:31 ` Mario.Limonciello [this message] 2018-03-08 7:31 ` Mario.Limonciello
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=50d4e281b7644399bc85aa16a1eacb8f@ausx13mpc124.AMER.DELL.COM \ --to=mario.limonciello@dell.com \ --cc=alsa-devel@alsa-project.org \ --cc=andy@infradead.org \ --cc=dvhart@infradead.org \ --cc=kai.heng.feng@canonical.com \ --cc=linux-kernel@vger.kernel.org \ --cc=mjg59@srcf.ucam.org \ --cc=pali.rohar@gmail.com \ --cc=platform-driver-x86@vger.kernel.org \ --cc=tiwai@suse.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.