* [PATCH v2] target/tricore: Remove unused fields from CPUTriCoreState
@ 2023-01-18 9:33 Philippe Mathieu-Daudé
2023-01-18 19:01 ` Richard Henderson
0 siblings, 1 reply; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-01-18 9:33 UTC (permalink / raw)
To: qemu-devel
Cc: qemu-trivial, Bastian Koppelmann, Philippe Mathieu-Daudé,
Richard Henderson
Remove dead code:
- unused fields in CPUTriCoreState
- (unexisting) tricore_def_t structure
- forward declaration of tricore_boot_info structure
(declared in "hw/tricore/tricore.h", used once in
hw/tricore/tricore_testboard.c).
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
v2: Do not remove 'hflags' in case it used:
https://lore.kernel.org/qemu-devel/20230118090319.32n4uto7ogy3gfr6@schnipp.zuhause/
---
target/tricore/cpu.h | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/target/tricore/cpu.h b/target/tricore/cpu.h
index 3b9c533a7c..4f6d936824 100644
--- a/target/tricore/cpu.h
+++ b/target/tricore/cpu.h
@@ -25,10 +25,6 @@
#include "qemu/cpu-float.h"
#include "tricore-defs.h"
-struct tricore_boot_info;
-
-typedef struct tricore_def_t tricore_def_t;
-
typedef struct CPUArchState {
/* GPR Register */
uint32_t gpr_a[16];
@@ -180,15 +176,10 @@ typedef struct CPUArchState {
/* Floating Point Registers */
float_status fp_status;
/* QEMU */
- int error_code;
uint32_t hflags; /* CPU State */
/* Internal CPU feature flags. */
uint64_t features;
-
- const tricore_def_t *cpu_model;
- void *irq[8];
- struct QEMUTimer *timer; /* Internal timer */
} CPUTriCoreState;
/**
--
2.38.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] target/tricore: Remove unused fields from CPUTriCoreState
2023-01-18 9:33 [PATCH v2] target/tricore: Remove unused fields from CPUTriCoreState Philippe Mathieu-Daudé
@ 2023-01-18 19:01 ` Richard Henderson
2023-01-19 7:20 ` Bastian Koppelmann
0 siblings, 1 reply; 3+ messages in thread
From: Richard Henderson @ 2023-01-18 19:01 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel; +Cc: qemu-trivial, Bastian Koppelmann
On 1/17/23 23:33, Philippe Mathieu-Daudé wrote:
> Remove dead code:
> - unused fields in CPUTriCoreState
> - (unexisting) tricore_def_t structure
> - forward declaration of tricore_boot_info structure
> (declared in "hw/tricore/tricore.h", used once in
> hw/tricore/tricore_testboard.c).
>
> Reviewed-by: Richard Henderson<richard.henderson@linaro.org>
> Reviewed-by: Bastian Koppelmann<kbastian@mail.uni-paderborn.de>
> Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org>
> ---
> v2: Do not remove 'hflags' in case it used:
> https://lore.kernel.org/qemu-devel/20230118090319.32n4uto7ogy3gfr6@schnipp.zuhause/
No, remove it, I don't expect it would ever be used.
r~
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] target/tricore: Remove unused fields from CPUTriCoreState
2023-01-18 19:01 ` Richard Henderson
@ 2023-01-19 7:20 ` Bastian Koppelmann
0 siblings, 0 replies; 3+ messages in thread
From: Bastian Koppelmann @ 2023-01-19 7:20 UTC (permalink / raw)
To: Richard Henderson; +Cc: Philippe Mathieu-Daudé, qemu-devel, qemu-trivial
On Wed, Jan 18, 2023 at 09:01:48AM -1000, Richard Henderson wrote:
> On 1/17/23 23:33, Philippe Mathieu-Daudé wrote:
> > Remove dead code:
> > - unused fields in CPUTriCoreState
> > - (unexisting) tricore_def_t structure
> > - forward declaration of tricore_boot_info structure
> > (declared in "hw/tricore/tricore.h", used once in
> > hw/tricore/tricore_testboard.c).
> >
> > Reviewed-by: Richard Henderson<richard.henderson@linaro.org>
> > Reviewed-by: Bastian Koppelmann<kbastian@mail.uni-paderborn.de>
> > Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org>
> > ---
> > v2: Do not remove 'hflags' in case it used:
> > https://lore.kernel.org/qemu-devel/20230118090319.32n4uto7ogy3gfr6@schnipp.zuhause/
>
> No, remove it, I don't expect it would ever be used.
Agreed, patch v1 is fine.
Cheers,
Bastian
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-19 7:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-18 9:33 [PATCH v2] target/tricore: Remove unused fields from CPUTriCoreState Philippe Mathieu-Daudé
2023-01-18 19:01 ` Richard Henderson
2023-01-19 7:20 ` Bastian Koppelmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.