* Security Kconfig is not common
@ 2013-01-23 13:28 winton
2013-01-23 16:30 ` Casey Schaufler
0 siblings, 1 reply; 3+ messages in thread
From: winton @ 2013-01-23 13:28 UTC (permalink / raw)
To: james.l.morris; +Cc: linux-security-module, linux-kbuild
[-- Attachment #1: Type: text/plain, Size: 401 bytes --]
Hi James,
Please help to review this patch.
When I analysis Kconfig files, I searched the keywork "source" and
then follow double quotations. The Kconfig in security is missing.
That's because security/Kconfig source keyword didn't using double
quotations.
Although that's may be not necessary. But I think the same as other
Kconfig files will be better.
Best regards,
Winton.Liu
[-- Attachment #2: 0001-Security-Kconfig-not-common.patch --]
[-- Type: text/x-patch, Size: 1715 bytes --]
From ccd2d4ddc01076570f23d3f4bfa5b3845a71524e Mon Sep 17 00:00:00 2001
From: "winton.liu" <newtonliuwen@gmail.com>
Date: Wed, 23 Jan 2013 21:08:33 +0800
Subject: [PATCH] Security Kconfig not common
Add dobule quotations in Kconfig source keyword.
That makes Kconfig files the same as other Kconfig.
It's more common.
Signed-off-by: winton.liu <newtonliuwen@gmail.com>
---
security/Kconfig | 12 ++++++------
security/integrity/Kconfig | 4 ++--
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/security/Kconfig b/security/Kconfig
index ccc61f8..e6936f2 100644
--- a/security/Kconfig
+++ b/security/Kconfig
@@ -183,13 +183,13 @@ config LSM_MMAP_MIN_ADDR
this low address space will need the permission specific to the
systems running LSM.
-source security/selinux/Kconfig
-source security/smack/Kconfig
-source security/tomoyo/Kconfig
-source security/apparmor/Kconfig
-source security/yama/Kconfig
+source "security/selinux/Kconfig"
+source "security/smack/Kconfig"
+source "security/tomoyo/Kconfig"
+source "security/apparmor/Kconfig"
+source "security/yama/Kconfig"
-source security/integrity/Kconfig
+source "security/integrity/Kconfig"
choice
prompt "Default security module"
diff --git a/security/integrity/Kconfig b/security/integrity/Kconfig
index 5bd1cc1..ba9147d 100644
--- a/security/integrity/Kconfig
+++ b/security/integrity/Kconfig
@@ -17,5 +17,5 @@ config INTEGRITY_SIGNATURE
This is useful for evm and module keyrings, when keys are
usually only added from initramfs.
-source security/integrity/ima/Kconfig
-source security/integrity/evm/Kconfig
+source "security/integrity/ima/Kconfig"
+source "security/integrity/evm/Kconfig"
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: Security Kconfig is not common
2013-01-23 13:28 Security Kconfig is not common winton
@ 2013-01-23 16:30 ` Casey Schaufler
2013-01-24 10:26 ` winton
0 siblings, 1 reply; 3+ messages in thread
From: Casey Schaufler @ 2013-01-23 16:30 UTC (permalink / raw)
To: winton; +Cc: james.l.morris, linux-security-module, linux-kbuild
On 1/23/2013 5:28 AM, winton wrote:
> Hi James,
>
> Please help to review this patch.
> When I analysis Kconfig files, I searched the keywork "source" and
> then follow double quotations. The Kconfig in security is missing.
> That's because security/Kconfig source keyword didn't using double
> quotations.
> Although that's may be not necessary. But I think the same as
> other Kconfig files will be better.
>
> Best regards,
> Winton.Liu
The practice of quoting the source pathnames is usual, but far from
universal. There are several examples in the arch and drivers directories.
If you believe this is significant, see if the checkpatch maintainer is
interested in adding a check.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Security Kconfig is not common
2013-01-23 16:30 ` Casey Schaufler
@ 2013-01-24 10:26 ` winton
0 siblings, 0 replies; 3+ messages in thread
From: winton @ 2013-01-24 10:26 UTC (permalink / raw)
To: Casey Schaufler; +Cc: james.l.morris, linux-security-module, linux-kbuild
On 01/24/2013 12:30 AM, Casey Schaufler wrote:
> On 1/23/2013 5:28 AM, winton wrote:
>> Hi James,
>>
>> Please help to review this patch.
>> When I analysis Kconfig files, I searched the keywork "source" and
>> then follow double quotations. The Kconfig in security is missing.
>> That's because security/Kconfig source keyword didn't using double
>> quotations.
>> Although that's may be not necessary. But I think the same as
>> other Kconfig files will be better.
>>
>> Best regards,
>> Winton.Liu
> The practice of quoting the source pathnames is usual, but far from
> universal. There are several examples in the arch and drivers directories.
> If you believe this is significant, see if the checkpatch maintainer is
> interested in adding a check.
>
>
Dear Casey,
Thank you for your explanations. Indeed that's now universal right now.
That's the result I calculate (from the newest kenerl) :
Only 9 Kconfig doesn't contains quotations as belowing:
./arch/cris/arch-v32/Kconfig
./arch/cris/arch-v32/drivers/Kconfig
./security/integrity/Kconfig
./security/Kconfig
./drivers/crypto/Kconfig
./drivers/pps/Kconfig
./drivers/hwmon/Kconfig
./drivers/i2c/Kconfig
./drivers/w1/Kconfig
There are 967 Kconfig in kernel
There are 159 Kconfig containning source keyword
I hope that would be universal one day. Just 9, not so much.
Best regards,
Winton.Liu
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-01-24 10:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-23 13:28 Security Kconfig is not common winton
2013-01-23 16:30 ` Casey Schaufler
2013-01-24 10:26 ` winton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.