[PATCH 0/4] 0/4] ARM: dts: add support for hdmi to exynos4412

[PATCH 0/4] 0/4] ARM: dts: add support for hdmi to exynos4412

[Rahul Sharma]

This patch enables hdmi support for Samsung Exynos4412 soc based Origen Board.

This set is base on "for next" branch at
git.kernel.org/?p=linux/kernel/git/kgene/linux-samsung.git

Rahul Sharma (4):
  ARM: dts: add support for hdmi to exynos4
  ARM: dts: add support for mixer to exynos4
  ARM: dts: add support for hdmi-ddc to exynos4412-origen
  ARM: dts: add support for hdmi-phy to exynos4412

 arch/arm/boot/dts/exynos4.dtsi          | 24 +++++++++++++++++++++++-
 arch/arm/boot/dts/exynos4412-origen.dts | 13 +++++++++++++
 arch/arm/boot/dts/exynos4412.dtsi       | 11 +++++++++++
 arch/arm/mach-exynos/mach-exynos4-dt.c  |  6 ++++++
 4 files changed, 53 insertions(+), 1 deletion(-)
 mode change 100644 => 100755 arch/arm/boot/dts/exynos4.dtsi

-- 
1.8.0

[PATCH 1/4] ARM: dts: add support for hdmi to exynos4

[Rahul Sharma]

Signed-off-by: Rahul Sharma <rahul.sharma@samsung.com>

Conflicts:
	arch/arm/mach-exynos/mach-exynos4-dt.c
---
 arch/arm/boot/dts/exynos4.dtsi         | 7 +++++++
 arch/arm/mach-exynos/mach-exynos4-dt.c | 2 ++
 2 files changed, 9 insertions(+)

diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
index e1347fc..6c2c79d 100644
--- a/arch/arm/boot/dts/exynos4.dtsi
+++ b/arch/arm/boot/dts/exynos4.dtsi
@@ -289,4 +289,11 @@
 			interrupts = <0 34 0>;
 		};
 	};
+
+	hdmi {
+		compatible = "samsung,exynos4-hdmi14";
+		reg = <0x12D00000 0x70000>;
+		interrupts = <0 95 0>;
+		hpd-gpio = <&gpx3 7 0xf 1 3>;
+	};
 };
diff --git a/arch/arm/mach-exynos/mach-exynos4-dt.c b/arch/arm/mach-exynos/mach-exynos4-dt.c
index ab1dacc..24f72a5 100644
--- a/arch/arm/mach-exynos/mach-exynos4-dt.c
+++ b/arch/arm/mach-exynos/mach-exynos4-dt.c
@@ -80,6 +80,8 @@ static const struct of_dev_auxdata exynos4_auxdata_lookup[] __initconst = {
 	OF_DEV_AUXDATA("arm,pl330", EXYNOS4_PA_MDMA1, "dma-pl330.2", NULL),
 	OF_DEV_AUXDATA("samsung,exynos4210-tmu", EXYNOS4_PA_TMU,
 				"exynos-tmu", NULL),
+	OF_DEV_AUXDATA("samsung,exynos4-hdmi14", EXYNOS4_PA_HDMI,
+				"exynos4-hdmi", NULL),
 	{},
 };
 
-- 
1.8.0

[PATCH 2/4] ARM: dts: add support for mixer to exynos4

[Rahul Sharma]

Signed-off-by: Rahul Sharma <rahul.sharma@samsung.com>

Conflicts:
	arch/arm/boot/dts/exynos4.dtsi
---
 arch/arm/boot/dts/exynos4.dtsi         | 8 ++++++++
 arch/arm/mach-exynos/mach-exynos4-dt.c | 2 ++
 2 files changed, 10 insertions(+)

diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
index 6c2c79d..07cb7d4 100644
--- a/arch/arm/boot/dts/exynos4.dtsi
+++ b/arch/arm/boot/dts/exynos4.dtsi
@@ -296,4 +296,12 @@
 		interrupts = <0 95 0>;
 		hpd-gpio = <&gpx3 7 0xf 1 3>;
 	};
+
+	mixer: mixer {
+		compatible = "samsung,exynos4-mixer";
+		reg = 	<0x12c10000 0x10000>,
+			<0x12c00000 0x10000>;
+		interrupts = <0 91 0>;
+		samsung,power-domain = <&pd_tv>;
+	};
 };
diff --git a/arch/arm/mach-exynos/mach-exynos4-dt.c b/arch/arm/mach-exynos/mach-exynos4-dt.c
index 24f72a5..f3b85b64 100644
--- a/arch/arm/mach-exynos/mach-exynos4-dt.c
+++ b/arch/arm/mach-exynos/mach-exynos4-dt.c
@@ -82,6 +82,8 @@ static const struct of_dev_auxdata exynos4_auxdata_lookup[] __initconst = {
 				"exynos-tmu", NULL),
 	OF_DEV_AUXDATA("samsung,exynos4-hdmi14", EXYNOS4_PA_HDMI,
 				"exynos4-hdmi", NULL),
+	OF_DEV_AUXDATA("samsung,exynos4-mixer", EXYNOS4_PA_MIXER,
+				"s5p-mixer", NULL),
 	{},
 };
 
-- 
1.8.0

[PATCH 3/4] ARM: dts: add support for hdmi-ddc to exynos4412-origen

[Rahul Sharma]

Signed-off-by: Rahul Sharma <rahul.sharma@samsung.com>
---
 arch/arm/boot/dts/exynos4.dtsi          |  1 -
 arch/arm/boot/dts/exynos4412-origen.dts | 13 +++++++++++++
 2 files changed, 13 insertions(+), 1 deletion(-)
 mode change 100644 => 100755 arch/arm/boot/dts/exynos4412.dtsi

diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
index 07cb7d4..a75e2f5 100644
--- a/arch/arm/boot/dts/exynos4.dtsi
+++ b/arch/arm/boot/dts/exynos4.dtsi
@@ -219,7 +219,6 @@
 		compatible = "samsung,s3c2440-i2c";
 		reg = <0x138C0000 0x100>;
 		interrupts = <0 64 0>;
-		status = "disabled";
 	};
 
 	i2c_7: i2c@138D0000 {
diff --git a/arch/arm/boot/dts/exynos4412-origen.dts b/arch/arm/boot/dts/exynos4412-origen.dts
index 4eba374..6299f1b 100644
--- a/arch/arm/boot/dts/exynos4412-origen.dts
+++ b/arch/arm/boot/dts/exynos4412-origen.dts
@@ -59,4 +59,17 @@
 	serial@13830000 {
 		status = "okay";
 	};
+
+	i2c_6: i2c@138C0000 {
+		samsung,i2c-sda-delay = <100>;
+		samsung,i2c-max-bus-freq = <66000>;
+
+		pinctrl-0 = <&i2c6_bus>;
+		pinctrl-names = "default";
+
+		hdmiddc@50 {
+			compatible = "samsung,exynos4-hdmiddc";
+			reg = <0x50>;
+		};
+	};
 };
diff --git a/arch/arm/boot/dts/exynos4412.dtsi b/arch/arm/boot/dts/exynos4412.dtsi
old mode 100644
new mode 100755
-- 
1.8.0

[PATCH 4/4] ARM: dts: add support for hdmi-phy to exynos4412

[Rahul Sharma]

Signed-off-by: Rahul Sharma <rahul.sharma@samsung.com>
---
 arch/arm/boot/dts/exynos4.dtsi         |  8 ++++++++
 arch/arm/boot/dts/exynos4412.dtsi      | 11 +++++++++++
 arch/arm/mach-exynos/mach-exynos4-dt.c |  2 ++
 3 files changed, 21 insertions(+)
 mode change 100644 => 100755 arch/arm/boot/dts/exynos4.dtsi
 mode change 100755 => 100644 arch/arm/boot/dts/exynos4412.dtsi

diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
old mode 100644
new mode 100755
index a75e2f5..b0b13c9
--- a/arch/arm/boot/dts/exynos4.dtsi
+++ b/arch/arm/boot/dts/exynos4.dtsi
@@ -230,6 +230,14 @@
 		status = "disabled";
 	};
 
+	i2c_8: i2c@138E0000 {
+		#address-cells = <1>;
+		#size-cells = <0>;
+		compatible = "samsung,s3c2440-hdmiphy-i2c";
+		reg = <0x138E0000 0x100>;
+		interrupts = <0 93 0>;
+	};
+
 	spi_0: spi@13920000 {
 		compatible = "samsung,exynos4210-spi";
 		reg = <0x13920000 0x100>;
diff --git a/arch/arm/boot/dts/exynos4412.dtsi b/arch/arm/boot/dts/exynos4412.dtsi
old mode 100755
new mode 100644
index d7dfe31..f4f6ce7
--- a/arch/arm/boot/dts/exynos4412.dtsi
+++ b/arch/arm/boot/dts/exynos4412.dtsi
@@ -25,4 +25,15 @@
 	gic:interrupt-controller@10490000 {
 		cpu-offset = <0x4000>;
 	};
+
+	i2c_8: i2c@138E0000 {
+		samsung,i2c-sda-delay = <100>;
+		samsung,i2c-max-bus-freq = <100000>;
+		samsung,i2c-slave-addr = <16>;
+
+		hdmiphy@38 {
+			compatible = "samsung,exynos4-hdmiphy";
+			reg = <0x38>;
+		};
+	};
 };
diff --git a/arch/arm/mach-exynos/mach-exynos4-dt.c b/arch/arm/mach-exynos/mach-exynos4-dt.c
index f3b85b64..796957e 100644
--- a/arch/arm/mach-exynos/mach-exynos4-dt.c
+++ b/arch/arm/mach-exynos/mach-exynos4-dt.c
@@ -69,6 +69,8 @@ static const struct of_dev_auxdata exynos4_auxdata_lookup[] __initconst = {
 				"s3c2440-i2c.6", NULL),
 	OF_DEV_AUXDATA("samsung,s3c2440-i2c", EXYNOS4_PA_IIC(7),
 				"s3c2440-i2c.7", NULL),
+	OF_DEV_AUXDATA("samsung,s3c2440-hdmiphy-i2c", EXYNOS4_PA_IIC_HDMIPHY,
+				"s3c2440-hdmiphy-i2c", NULL),
 	OF_DEV_AUXDATA("samsung,exynos4210-spi", EXYNOS4_PA_SPI0,
 				"exynos4210-spi.0", NULL),
 	OF_DEV_AUXDATA("samsung,exynos4210-spi", EXYNOS4_PA_SPI1,
-- 
1.8.0

Re: [PATCH 1/4] ARM: dts: add support for hdmi to exynos4

[Thomas Abraham]

On 25 January 2013 02:39, Rahul Sharma <rahul.sharma-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
> Signed-off-by: Rahul Sharma <rahul.sharma-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
>
> Conflicts:
>         arch/arm/mach-exynos/mach-exynos4-dt.c
> ---
>  arch/arm/boot/dts/exynos4.dtsi         | 7 +++++++
>  arch/arm/mach-exynos/mach-exynos4-dt.c | 2 ++
>  2 files changed, 9 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
> index e1347fc..6c2c79d 100644
> --- a/arch/arm/boot/dts/exynos4.dtsi
> +++ b/arch/arm/boot/dts/exynos4.dtsi
> @@ -289,4 +289,11 @@
>                         interrupts = <0 34 0>;
>                 };
>         };
> +
> +       hdmi {
> +               compatible = "samsung,exynos4-hdmi14";
> +               reg = <0x12D00000 0x70000>;
> +               interrupts = <0 95 0>;
> +               hpd-gpio = <&gpx3 7 0xf 1 3>;

This is using the older gpio dt bindings but exynos4 has started using
the pinctrl bindings. So this is not sufficient to do the
pinmux/pinconfig settings on Exynos4.

Thanks,
Thomas.

> +       };
>  };
> diff --git a/arch/arm/mach-exynos/mach-exynos4-dt.c b/arch/arm/mach-exynos/mach-exynos4-dt.c
> index ab1dacc..24f72a5 100644
> --- a/arch/arm/mach-exynos/mach-exynos4-dt.c
> +++ b/arch/arm/mach-exynos/mach-exynos4-dt.c
> @@ -80,6 +80,8 @@ static const struct of_dev_auxdata exynos4_auxdata_lookup[] __initconst = {
>         OF_DEV_AUXDATA("arm,pl330", EXYNOS4_PA_MDMA1, "dma-pl330.2", NULL),
>         OF_DEV_AUXDATA("samsung,exynos4210-tmu", EXYNOS4_PA_TMU,
>                                 "exynos-tmu", NULL),
> +       OF_DEV_AUXDATA("samsung,exynos4-hdmi14", EXYNOS4_PA_HDMI,
> +                               "exynos4-hdmi", NULL),
>         {},
>  };
>
> --
> 1.8.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/4] ARM: dts: add support for hdmi-ddc to exynos4412-origen

[Sylwester Nawrocki]

Hi,

On 01/25/2013 11:39 AM, Rahul Sharma wrote:
> Signed-off-by: Rahul Sharma<rahul.sharma@samsung.com>

Please explain why this patch is needed, in more detail...

> ---
>   arch/arm/boot/dts/exynos4.dtsi          |  1 -
>   arch/arm/boot/dts/exynos4412-origen.dts | 13 +++++++++++++
>   2 files changed, 13 insertions(+), 1 deletion(-)
>   mode change 100644 =>  100755 arch/arm/boot/dts/exynos4412.dtsi
>
> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
> index 07cb7d4..a75e2f5 100644
> --- a/arch/arm/boot/dts/exynos4.dtsi
> +++ b/arch/arm/boot/dts/exynos4.dtsi
> @@ -219,7 +219,6 @@
>   		compatible = "samsung,s3c2440-i2c";
>   		reg =<0x138C0000 0x100>;
>   		interrupts =<0 64 0>;
> -		status = "disabled";

No, it's not how it is supposed to be done. If you want to enable
this specific I2C controller on your board, just add status = "okay";
line in its node in the board-specific dts file. Please see below.

>   	};
>
>   	i2c_7: i2c@138D0000 {
> diff --git a/arch/arm/boot/dts/exynos4412-origen.dts b/arch/arm/boot/dts/exynos4412-origen.dts
> index 4eba374..6299f1b 100644
> --- a/arch/arm/boot/dts/exynos4412-origen.dts
> +++ b/arch/arm/boot/dts/exynos4412-origen.dts
> @@ -59,4 +59,17 @@
>   	serial@13830000 {
>   		status = "okay";
>   	};
> +
> +	i2c_6: i2c@138C0000 {
> +		samsung,i2c-sda-delay =<100>;
> +		samsung,i2c-max-bus-freq =<66000>;
> +
> +		pinctrl-0 =<&i2c6_bus>;
> +		pinctrl-names = "default";

		status = "okay";

> +		hdmiddc@50 {
> +			compatible = "samsung,exynos4-hdmiddc";
> +			reg =<0x50>;
> +		};
> +	};
>   };
> diff --git a/arch/arm/boot/dts/exynos4412.dtsi b/arch/arm/boot/dts/exynos4412.dtsi
> old mode 100644
> new mode 100755

Are you sure you need to add all these execute permissions ?
Do you think these values are more sane than the previous ones ?
I'm afraid there is something going wrong with the file permissions
in your environment...

--

Thanks,
Sylwester

Re: [PATCH 0/4] 0/4] ARM: dts: add support for hdmi to exynos4412

[Sylwester Nawrocki]

Hi,

On 01/25/2013 11:39 AM, Rahul Sharma wrote:
> This patch enables hdmi support for Samsung Exynos4412 soc based Origen Board.
>
> This set is base on "for next" branch at
> git.kernel.org/?p=linux/kernel/git/kgene/linux-samsung.git
>
> Rahul Sharma (4):
>    ARM: dts: add support for hdmi to exynos4
>    ARM: dts: add support for mixer to exynos4
>    ARM: dts: add support for hdmi-ddc to exynos4412-origen
>    ARM: dts: add support for hdmi-phy to exynos4412
>
>   arch/arm/boot/dts/exynos4.dtsi          | 24 +++++++++++++++++++++++-
>   arch/arm/boot/dts/exynos4412-origen.dts | 13 +++++++++++++
>   arch/arm/boot/dts/exynos4412.dtsi       | 11 +++++++++++
>   arch/arm/mach-exynos/mach-exynos4-dt.c  |  6 ++++++

Is the device tree bindings documentation related to this patch
series available somewhere else ?

>   4 files changed, 53 insertions(+), 1 deletion(-)
>   mode change 100644 =>  100755 arch/arm/boot/dts/exynos4.dtsi

Please make sure you don't change the file permissions to random
values.

--

Thanks,
Sylwester

Re: [PATCH 1/4] ARM: dts: add support for hdmi to exynos4

[Sylwester Nawrocki]

On 01/25/2013 11:39 AM, Rahul Sharma wrote:
> Signed-off-by: Rahul Sharma<rahul.sharma@samsung.com>

Please provide proper commit text.

> Conflicts:
> 	arch/arm/mach-exynos/mach-exynos4-dt.c

And make sure things like this are removed when submitting patches.

> ---
>   arch/arm/boot/dts/exynos4.dtsi         | 7 +++++++
>   arch/arm/mach-exynos/mach-exynos4-dt.c | 2 ++
>   2 files changed, 9 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
> index e1347fc..6c2c79d 100644
> --- a/arch/arm/boot/dts/exynos4.dtsi
> +++ b/arch/arm/boot/dts/exynos4.dtsi
> @@ -289,4 +289,11 @@
>   			interrupts =<0 34 0>;
>   		};
>   	};
> +
> +	hdmi {
> +		compatible = "samsung,exynos4-hdmi14";

What "-hdmi14" signifies here ? And to which Exynos4 SoC revisions this
compatible property is supposed to apply ?

> +		reg =<0x12D00000 0x70000>;
> +		interrupts =<0 95 0>;
> +		hpd-gpio =<&gpx3 7 0xf 1 3>;
> +	};

New bindings need to be documented in Documentation/devicetree/bindings/.

--

Thanks,
Sylwester

Re: [PATCH 2/4] ARM: dts: add support for mixer to exynos4

[Sylwester Nawrocki]

On 01/25/2013 11:39 AM, Rahul Sharma wrote:
> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
> index 6c2c79d..07cb7d4 100644
> --- a/arch/arm/boot/dts/exynos4.dtsi
> +++ b/arch/arm/boot/dts/exynos4.dtsi
> @@ -296,4 +296,12 @@
>   		interrupts =<0 95 0>;
>   		hpd-gpio =<&gpx3 7 0xf 1 3>;
>   	};
> +
> +	mixer: mixer {
> +		compatible = "samsung,exynos4-mixer";

I'm afraid this compatible property it too generic. Is the video mixer IP
really identical an all the Exynos4 series SoCs ?

> +		reg = 	<0x12c10000 0x10000>,
> +			<0x12c00000 0x10000>;
> +		interrupts =<0 91 0>;
> +		samsung,power-domain =<&pd_tv>;
> +	};
>   };

Is there documentation for these new bindings available somewhere ?

--

Thanks,
Sylwester

Re: [PATCH 1/4] ARM: dts: add support for hdmi to exynos4

[Rahul Sharma]

Hi Sylwester,

On Mon, Jan 28, 2013 at 2:24 AM, Sylwester Nawrocki
<sylvester.nawrocki@gmail.com> wrote:
> On 01/25/2013 11:39 AM, Rahul Sharma wrote:
>>
>> Signed-off-by: Rahul Sharma<rahul.sharma@samsung.com>
>
>
> Please provide proper commit text.
>
>> Conflicts:
>>         arch/arm/mach-exynos/mach-exynos4-dt.c
>
>
> And make sure things like this are removed when submitting patches.
>

I will take care.
>
>> ---
>>   arch/arm/boot/dts/exynos4.dtsi         | 7 +++++++
>>   arch/arm/mach-exynos/mach-exynos4-dt.c | 2 ++
>>   2 files changed, 9 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos4.dtsi
>> b/arch/arm/boot/dts/exynos4.dtsi
>> index e1347fc..6c2c79d 100644
>> --- a/arch/arm/boot/dts/exynos4.dtsi
>> +++ b/arch/arm/boot/dts/exynos4.dtsi
>> @@ -289,4 +289,11 @@
>>                         interrupts =<0 34 0>;
>>                 };
>>         };
>> +
>> +       hdmi {
>> +               compatible = "samsung,exynos4-hdmi14";
>
>
> What "-hdmi14" signifies here ? And to which Exynos4 SoC revisions this
> compatible property is supposed to apply ?
>

-hdmi14 signifies 1.4 compliant Hdmi IP like in Exynos4412, while
Exynos4210 has 1.3
compliant HDMI block. I have done a mistake here. I should have kept
it in 4412.dtsi. OR
I can move it to 4x12.dtsi but not sure whether all 4x12 socs have 1.4 hdmi.

>
>> +               reg =<0x12D00000 0x70000>;
>> +               interrupts =<0 95 0>;
>> +               hpd-gpio =<&gpx3 7 0xf 1 3>;
>> +       };
>
>
> New bindings need to be documented in Documentation/devicetree/bindings/.
>
It is present at Documentation/devicetree/bindings/drm/exynos/hdmi.txt.

Regards,
Rahul Sharma.

> --
>
> Thanks,
> Sylwester

Re: [PATCH 2/4] ARM: dts: add support for mixer to exynos4

[Rahul Sharma]

On Mon, Jan 28, 2013 at 2:34 AM, Sylwester Nawrocki
<sylvester.nawrocki@gmail.com> wrote:
> On 01/25/2013 11:39 AM, Rahul Sharma wrote:
>>
>> diff --git a/arch/arm/boot/dts/exynos4.dtsi
>> b/arch/arm/boot/dts/exynos4.dtsi
>> index 6c2c79d..07cb7d4 100644
>> --- a/arch/arm/boot/dts/exynos4.dtsi
>> +++ b/arch/arm/boot/dts/exynos4.dtsi
>> @@ -296,4 +296,12 @@
>>                 interrupts =<0 95 0>;
>>                 hpd-gpio =<&gpx3 7 0xf 1 3>;
>>         };
>> +
>> +       mixer: mixer {
>> +               compatible = "samsung,exynos4-mixer";
>
>
> I'm afraid this compatible property it too generic. Is the video mixer IP
> really identical an all the Exynos4 series SoCs ?
>

It is same in Exynos4210, 4212 and 4412.

>
>> +               reg =   <0x12c10000 0x10000>,
>> +                       <0x12c00000 0x10000>;
>> +               interrupts =<0 91 0>;
>> +               samsung,power-domain =<&pd_tv>;
>> +       };
>>   };
>
>
> Is there documentation for these new bindings available somewhere ?
>

it is there at Documentation/devicetree/bindings/drm/exynos/mixer.txt.
Probably I
need to add details for power domain node property.

regards,
Rahul Sharma.

> --
>
> Thanks,
> Sylwester

Re: [PATCH 1/4] ARM: dts: add support for hdmi to exynos4

[Rahul Sharma]

Hi Thomas,

On Fri, Jan 25, 2013 at 11:10 PM, Thomas Abraham
<thomas.abraham@linaro.org> wrote:
> On 25 January 2013 02:39, Rahul Sharma <rahul.sharma@samsung.com> wrote:
>> Signed-off-by: Rahul Sharma <rahul.sharma@samsung.com>
>>
>> Conflicts:
>>         arch/arm/mach-exynos/mach-exynos4-dt.c
>> ---
>>  arch/arm/boot/dts/exynos4.dtsi         | 7 +++++++
>>  arch/arm/mach-exynos/mach-exynos4-dt.c | 2 ++
>>  2 files changed, 9 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
>> index e1347fc..6c2c79d 100644
>> --- a/arch/arm/boot/dts/exynos4.dtsi
>> +++ b/arch/arm/boot/dts/exynos4.dtsi
>> @@ -289,4 +289,11 @@
>>                         interrupts = <0 34 0>;
>>                 };
>>         };
>> +
>> +       hdmi {
>> +               compatible = "samsung,exynos4-hdmi14";
>> +               reg = <0x12D00000 0x70000>;
>> +               interrupts = <0 95 0>;
>> +               hpd-gpio = <&gpx3 7 0xf 1 3>;
>
> This is using the older gpio dt bindings but exynos4 has started using
> the pinctrl bindings. So this is not sufficient to do the
> pinmux/pinconfig settings on Exynos4.
>
> Thanks,
> Thomas.
>

I have chosen this as exynos5 DT using it in same way and parsed by common code
in driver for exy4 and 5. Secondly, one-time initial configuration is
sufficient for
hdmi hpd-gpio. Please share your opinion.

regards,
Rahul Sharma.

>> +       };
>>  };
>> diff --git a/arch/arm/mach-exynos/mach-exynos4-dt.c b/arch/arm/mach-exynos/mach-exynos4-dt.c
>> index ab1dacc..24f72a5 100644
>> --- a/arch/arm/mach-exynos/mach-exynos4-dt.c
>> +++ b/arch/arm/mach-exynos/mach-exynos4-dt.c
>> @@ -80,6 +80,8 @@ static const struct of_dev_auxdata exynos4_auxdata_lookup[] __initconst = {
>>         OF_DEV_AUXDATA("arm,pl330", EXYNOS4_PA_MDMA1, "dma-pl330.2", NULL),
>>         OF_DEV_AUXDATA("samsung,exynos4210-tmu", EXYNOS4_PA_TMU,
>>                                 "exynos-tmu", NULL),
>> +       OF_DEV_AUXDATA("samsung,exynos4-hdmi14", EXYNOS4_PA_HDMI,
>> +                               "exynos4-hdmi", NULL),
>>         {},
>>  };
>>
>> --
>> 1.8.0
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/4] ARM: dts: add support for mixer to exynos4

[Tomasz Figa]

Hi Rahul, Sylwester,

On Monday 28 of January 2013 12:14:38 Rahul Sharma wrote:
> On Mon, Jan 28, 2013 at 2:34 AM, Sylwester Nawrocki
> 
> <sylvester.nawrocki@gmail.com> wrote:
> > On 01/25/2013 11:39 AM, Rahul Sharma wrote:
> >> diff --git a/arch/arm/boot/dts/exynos4.dtsi
> >> b/arch/arm/boot/dts/exynos4.dtsi
> >> index 6c2c79d..07cb7d4 100644
> >> --- a/arch/arm/boot/dts/exynos4.dtsi
> >> +++ b/arch/arm/boot/dts/exynos4.dtsi
> >> @@ -296,4 +296,12 @@
> >> 
> >>                 interrupts =<0 95 0>;
> >>                 hpd-gpio =<&gpx3 7 0xf 1 3>;
> >>         
> >>         };
> >> 
> >> +
> >> +       mixer: mixer {
> >> +               compatible = "samsung,exynos4-mixer";
> > 
> > I'm afraid this compatible property it too generic. Is the video mixer
> > IP really identical an all the Exynos4 series SoCs ?
> 
> It is same in Exynos4210, 4212 and 4412.

The convention is to use the name of SoC on which this IP version appeared 
first. In this case it would be samsung,exynos4210-mixer.

Best regards,
Tomasz

Re: [PATCH 1/4] ARM: dts: add support for hdmi to exynos4

[Tomasz Figa]

Hi Rahul,

On Monday 28 of January 2013 12:25:27 Rahul Sharma wrote:
> Hi Thomas,
> 
> On Fri, Jan 25, 2013 at 11:10 PM, Thomas Abraham
> 
> <thomas.abraham@linaro.org> wrote:
> > On 25 January 2013 02:39, Rahul Sharma <rahul.sharma@samsung.com> 
wrote:
> >> Signed-off-by: Rahul Sharma <rahul.sharma@samsung.com>
> >> 
> >> Conflicts:
> >>         arch/arm/mach-exynos/mach-exynos4-dt.c
> >> 
> >> ---
> >> 
> >>  arch/arm/boot/dts/exynos4.dtsi         | 7 +++++++
> >>  arch/arm/mach-exynos/mach-exynos4-dt.c | 2 ++
> >>  2 files changed, 9 insertions(+)
> >> 
> >> diff --git a/arch/arm/boot/dts/exynos4.dtsi
> >> b/arch/arm/boot/dts/exynos4.dtsi index e1347fc..6c2c79d 100644
> >> --- a/arch/arm/boot/dts/exynos4.dtsi
> >> +++ b/arch/arm/boot/dts/exynos4.dtsi
> >> @@ -289,4 +289,11 @@
> >> 
> >>                         interrupts = <0 34 0>;
> >>                 
> >>                 };
> >>         
> >>         };
> >> 
> >> +
> >> +       hdmi {
> >> +               compatible = "samsung,exynos4-hdmi14";
> >> +               reg = <0x12D00000 0x70000>;
> >> +               interrupts = <0 95 0>;
> >> +               hpd-gpio = <&gpx3 7 0xf 1 3>;
> > 
> > This is using the older gpio dt bindings but exynos4 has started using
> > the pinctrl bindings. So this is not sufficient to do the
> > pinmux/pinconfig settings on Exynos4.
> > 
> > Thanks,
> > Thomas.
> 
> I have chosen this as exynos5 DT using it in same way and parsed by
> common code in driver for exy4 and 5. Secondly, one-time initial
> configuration is sufficient for
> hdmi hpd-gpio. Please share your opinion.

Exynos4 SoCs use pin control for pin mux configuration, which implies 
different GPIO specifiers than what you used. On Exynos4 generic GPIO 
specifiers are used:

<&gpio-controller pin flags>

As you can see, it does not contain pin mux configuration, which must be 
configured if special function is to be used. In case of EINTs and 
input/output functions, they are configured automatically, respectively by 
request_irq (with appropriate interrupt trigger flag) and gpio_direction_*.

Keep in mind that Exynos5 will be eventually moved to pin control as well 
and its old GPIO bindings will be dropped as they are only temporary.

Best regards,
Tomasz

Re: [PATCH 1/4] ARM: dts: add support for hdmi to exynos4

[Rahul Sharma]

Hi Tomasz,

On Mon, Jan 28, 2013 at 2:14 PM, Tomasz Figa <tomasz.figa@gmail.com> wrote:
> Hi Rahul,
>
> On Monday 28 of January 2013 12:25:27 Rahul Sharma wrote:
>> Hi Thomas,
>>
>> On Fri, Jan 25, 2013 at 11:10 PM, Thomas Abraham
>>
>> <thomas.abraham@linaro.org> wrote:
>> > On 25 January 2013 02:39, Rahul Sharma <rahul.sharma@samsung.com>
> wrote:
>> >> Signed-off-by: Rahul Sharma <rahul.sharma@samsung.com>
>> >>
>> >> Conflicts:
>> >>         arch/arm/mach-exynos/mach-exynos4-dt.c
>> >>
>> >> ---
>> >>
>> >>  arch/arm/boot/dts/exynos4.dtsi         | 7 +++++++
>> >>  arch/arm/mach-exynos/mach-exynos4-dt.c | 2 ++
>> >>  2 files changed, 9 insertions(+)
>> >>
>> >> diff --git a/arch/arm/boot/dts/exynos4.dtsi
>> >> b/arch/arm/boot/dts/exynos4.dtsi index e1347fc..6c2c79d 100644
>> >> --- a/arch/arm/boot/dts/exynos4.dtsi
>> >> +++ b/arch/arm/boot/dts/exynos4.dtsi
>> >> @@ -289,4 +289,11 @@
>> >>
>> >>                         interrupts = <0 34 0>;
>> >>
>> >>                 };
>> >>
>> >>         };
>> >>
>> >> +
>> >> +       hdmi {
>> >> +               compatible = "samsung,exynos4-hdmi14";
>> >> +               reg = <0x12D00000 0x70000>;
>> >> +               interrupts = <0 95 0>;
>> >> +               hpd-gpio = <&gpx3 7 0xf 1 3>;
>> >
>> > This is using the older gpio dt bindings but exynos4 has started using
>> > the pinctrl bindings. So this is not sufficient to do the
>> > pinmux/pinconfig settings on Exynos4.
>> >
>> > Thanks,
>> > Thomas.
>>
>> I have chosen this as exynos5 DT using it in same way and parsed by
>> common code in driver for exy4 and 5. Secondly, one-time initial
>> configuration is sufficient for
>> hdmi hpd-gpio. Please share your opinion.
>
> Exynos4 SoCs use pin control for pin mux configuration, which implies
> different GPIO specifiers than what you used. On Exynos4 generic GPIO
> specifiers are used:
>
> <&gpio-controller pin flags>
>
> As you can see, it does not contain pin mux configuration, which must be
> configured if special function is to be used. In case of EINTs and
> input/output functions, they are configured automatically, respectively by
> request_irq (with appropriate interrupt trigger flag) and gpio_direction_*.
>
> Keep in mind that Exynos5 will be eventually moved to pin control as well
> and its old GPIO bindings will be dropped as they are only temporary.
>
> Best regards,
> Tomasz
>

Since Exynos5 pinctrl is not yet merged, either I need to add "hpd-
gpio" in non-pinctrl way and keep the parsing code (in driver) same
for exynos4 and 5, as I have done in posted patch. This is same for
exynos5.
Or, I need to parse gpio information in a two different manners for
the two SoC series.

It will remain as a special case till we have exynos5 pinctrl driver. IMO,
above code looks better till I can provide same solution for both,
exynos4 & exynos5.

regards,
Rahul Sharma.

Re: [PATCH 1/4] ARM: dts: add support for hdmi to exynos4

[Tomasz Figa]

On Monday 28 of January 2013 14:53:10 Rahul Sharma wrote:
> Hi Tomasz,
> 
> On Mon, Jan 28, 2013 at 2:14 PM, Tomasz Figa <tomasz.figa@gmail.com> 
wrote:
> > Hi Rahul,
> > 
> > On Monday 28 of January 2013 12:25:27 Rahul Sharma wrote:
> >> Hi Thomas,
> >> 
> >> On Fri, Jan 25, 2013 at 11:10 PM, Thomas Abraham
> >> 
> >> <thomas.abraham@linaro.org> wrote:
> >> > On 25 January 2013 02:39, Rahul Sharma <rahul.sharma@samsung.com>
> > 
> > wrote:
> >> >> Signed-off-by: Rahul Sharma <rahul.sharma@samsung.com>
> >> >> 
> >> >> Conflicts:
> >> >>         arch/arm/mach-exynos/mach-exynos4-dt.c
> >> >> 
> >> >> ---
> >> >> 
> >> >>  arch/arm/boot/dts/exynos4.dtsi         | 7 +++++++
> >> >>  arch/arm/mach-exynos/mach-exynos4-dt.c | 2 ++
> >> >>  2 files changed, 9 insertions(+)
> >> >> 
> >> >> diff --git a/arch/arm/boot/dts/exynos4.dtsi
> >> >> b/arch/arm/boot/dts/exynos4.dtsi index e1347fc..6c2c79d 100644
> >> >> --- a/arch/arm/boot/dts/exynos4.dtsi
> >> >> +++ b/arch/arm/boot/dts/exynos4.dtsi
> >> >> @@ -289,4 +289,11 @@
> >> >> 
> >> >>                         interrupts = <0 34 0>;
> >> >>                 
> >> >>                 };
> >> >>         
> >> >>         };
> >> >> 
> >> >> +
> >> >> +       hdmi {
> >> >> +               compatible = "samsung,exynos4-hdmi14";
> >> >> +               reg = <0x12D00000 0x70000>;
> >> >> +               interrupts = <0 95 0>;
> >> >> +               hpd-gpio = <&gpx3 7 0xf 1 3>;
> >> > 
> >> > This is using the older gpio dt bindings but exynos4 has started
> >> > using
> >> > the pinctrl bindings. So this is not sufficient to do the
> >> > pinmux/pinconfig settings on Exynos4.
> >> > 
> >> > Thanks,
> >> > Thomas.
> >> 
> >> I have chosen this as exynos5 DT using it in same way and parsed by
> >> common code in driver for exy4 and 5. Secondly, one-time initial
> >> configuration is sufficient for
> >> hdmi hpd-gpio. Please share your opinion.
> > 
> > Exynos4 SoCs use pin control for pin mux configuration, which implies
> > different GPIO specifiers than what you used. On Exynos4 generic GPIO
> > specifiers are used:
> > 
> > <&gpio-controller pin flags>
> > 
> > As you can see, it does not contain pin mux configuration, which must
> > be
> > configured if special function is to be used. In case of EINTs and
> > input/output functions, they are configured automatically, respectively
> > by request_irq (with appropriate interrupt trigger flag) and
> > gpio_direction_*.
> > 
> > Keep in mind that Exynos5 will be eventually moved to pin control as
> > well and its old GPIO bindings will be dropped as they are only
> > temporary.
> > 
> > Best regards,
> > Tomasz
> 
> Since Exynos5 pinctrl is not yet merged, either I need to add "hpd-
> gpio" in non-pinctrl way and keep the parsing code (in driver) same
> for exynos4 and 5, as I have done in posted patch. This is same for
> exynos5.
> Or, I need to parse gpio information in a two different manners for
> the two SoC series.
> 
> It will remain as a special case till we have exynos5 pinctrl driver.
> IMO, above code looks better till I can provide same solution for both,
> exynos4 & exynos5.

Well, it might look better, but it is incorrect, so I don't see the point 
of merging it. Please either provide a patch which handles Exynos4 properly 
or wait until Exynos5 pin control support gets merged.

You can look at sdhci-s3c driver for an example how to handle multiple pin 
mux configuration methods.

Best regards,
Tomasz

Re: [PATCH 2/4] ARM: dts: add support for mixer to exynos4

[Sylwester Nawrocki]

Hi,

On 01/28/2013 09:38 AM, Tomasz Figa wrote:
>>>> +
>>>> +       mixer: mixer {
>>>> +               compatible = "samsung,exynos4-mixer";
>>>
>>> I'm afraid this compatible property it too generic. Is the video mixer
>>> IP really identical an all the Exynos4 series SoCs ?
>>
>> It is same in Exynos4210, 4212 and 4412.
>
> The convention is to use the name of SoC on which this IP version appeared
> first. In this case it would be samsung,exynos4210-mixer.

And I believe this is a good convention to stick with. I'm going to have
a look at the documentation, as it seems unlikely these IPs are exactly 
same
across those SoC revisions. I'm not saying this isn't possible though. :)

--

Thanks,
Sylwester

Re: [PATCH 2/4] ARM: dts: add support for mixer to exynos4

[Sylwester Nawrocki]

Hi,

On 01/28/2013 07:44 AM, Rahul Sharma wrote:
>>> +
>>> +       mixer: mixer {
>>> +               compatible = "samsung,exynos4-mixer";
>>
>>
>> I'm afraid this compatible property it too generic. Is the video mixer IP
>> really identical an all the Exynos4 series SoCs ?
>>
>
> It is same in Exynos4210, 4212 and 4412.
>
>>
>>> +               reg =<0x12c10000 0x10000>,
>>> +<0x12c00000 0x10000>;
>>> +               interrupts =<0 91 0>;
>>> +               samsung,power-domain =<&pd_tv>;
>>> +       };
>>>    };
>>
>>
>> Is there documentation for these new bindings available somewhere ?
>>
>
> it is there at Documentation/devicetree/bindings/drm/exynos/mixer.txt.
> Probably I need to add details for power domain node property.

Sorry, I can't see anything for Exynos4 there, it's only for exynos5 SoCs.
I think the need for the 'samsung,power-domain' property (I guess that
should be optional) needs to be documented for completeness.

Getting back to the bindings documentation,
Documentation/devicetree/bindings/drm/exynos/ seems not exactly right
place for me, but that's a minor issue. There is also a V4L2 driver
for the HDMI and TV output devices in drivers/media/platform/s5p-tv.
So Documentation/devicetree/bindings/video or
Documentation/devicetree/bindings/media might be a better home for that
bindings documentation. These IPs are not specific to DRM at all.

--

Thanks,
Sylwester

Re: [PATCH 1/4] ARM: dts: add support for hdmi to exynos4

[Sylwester Nawrocki]

Hi Rahul,

On 01/28/2013 07:19 AM, Rahul Sharma wrote:
>>> --- a/arch/arm/boot/dts/exynos4.dtsi
>>> +++ b/arch/arm/boot/dts/exynos4.dtsi
>>> @@ -289,4 +289,11 @@
>>>                          interrupts =<0 34 0>;
>>>                  };
>>>          };
>>> +
>>> +       hdmi {
>>> +               compatible = "samsung,exynos4-hdmi14";
>>
>>
>> What "-hdmi14" signifies here ? And to which Exynos4 SoC revisions this
>> compatible property is supposed to apply ?
>>
>
> -hdmi14 signifies 1.4 compliant Hdmi IP like in Exynos4412, while
> Exynos4210 has 1.3
> compliant HDMI block. I have done a mistake here. I should have kept
> it in 4412.dtsi. OR
> I can move it to 4x12.dtsi but not sure whether all 4x12 socs have 1.4 hdmi.

Exynos4210 also have the HDMI IP. I'm not sure how much common those 
IP's are
among Exynos4 series SoCs. I suppose it makes sense to create a hdmi node in
exynos4.dtsi and override what's required either in exynos4x12.dtsi or
exynos4412.dtsi file.

What is worring me is that you're trying to just append the supported
HDMI standard version to the string, and there might be more differences
in the IPs across all Exynos4 SoC series. What if there are two different
SoCs that support e.g. HDMI v1.4 but there are some differences in the
HDMI IPs ? You would likely need to invent new properties and pass them
to the driver. Appending specific SoC name to the compatible string looks
like a better alternative to me.

>>> +               reg =<0x12D00000 0x70000>;
>>> +               interrupts =<0 95 0>;
>>> +               hpd-gpio =<&gpx3 7 0xf 1 3>;
>>> +       };
>>
>>
>> New bindings need to be documented in Documentation/devicetree/bindings/.
>>
> It is present at Documentation/devicetree/bindings/drm/exynos/hdmi.txt.

Thanks. Sorry, I've missed that. But it seems to be only for exynos5 SoCs ?
Also the location is a bit unexpected to me, if we want to have Exynos4 and
Exynos5 specific IP documented in this file. As I mentioned in previous
e-mail this IP is not only handled by the DRM API.

--

Regards,
Sylwester

Re: [PATCH 1/4] ARM: dts: add support for hdmi to exynos4

[Rahul Sharma]

Thanks Sylwester,

On Wed, Jan 30, 2013 at 2:12 AM, Sylwester Nawrocki
<sylvester.nawrocki@gmail.com> wrote:
> Hi Rahul,
>
>
> On 01/28/2013 07:19 AM, Rahul Sharma wrote:
>>>>
>>>> --- a/arch/arm/boot/dts/exynos4.dtsi
>>>> +++ b/arch/arm/boot/dts/exynos4.dtsi
>>>> @@ -289,4 +289,11 @@
>>>>                          interrupts =<0 34 0>;
>>>>                  };
>>>>          };
>>>> +
>>>> +       hdmi {
>>>> +               compatible = "samsung,exynos4-hdmi14";
>>>
>>>
>>>
>>> What "-hdmi14" signifies here ? And to which Exynos4 SoC revisions this
>>> compatible property is supposed to apply ?
>>>
>>
>> -hdmi14 signifies 1.4 compliant Hdmi IP like in Exynos4412, while
>> Exynos4210 has 1.3
>> compliant HDMI block. I have done a mistake here. I should have kept
>> it in 4412.dtsi. OR
>> I can move it to 4x12.dtsi but not sure whether all 4x12 socs have 1.4
>> hdmi.
>
>
> Exynos4210 also have the HDMI IP. I'm not sure how much common those IP's
> are
> among Exynos4 series SoCs. I suppose it makes sense to create a hdmi node in
> exynos4.dtsi and override what's required either in exynos4x12.dtsi or
> exynos4412.dtsi file.
>
> What is worring me is that you're trying to just append the supported
> HDMI standard version to the string, and there might be more differences
> in the IPs across all Exynos4 SoC series. What if there are two different
> SoCs that support e.g. HDMI v1.4 but there are some differences in the
> HDMI IPs ? You would likely need to invent new properties and pass them
> to the driver. Appending specific SoC name to the compatible string looks
> like a better alternative to me.
>

I agree to it. Putting compatible string with first soc having the IP,
is a better
approach altogether. I will incorporate the change in next version.

regards,
Rahul Sharma.

>
>>>> +               reg =<0x12D00000 0x70000>;
>>>> +               interrupts =<0 95 0>;
>>>> +               hpd-gpio =<&gpx3 7 0xf 1 3>;
>>>> +       };
>>>
>>>
>>>
>>> New bindings need to be documented in Documentation/devicetree/bindings/.
>>>
>> It is present at Documentation/devicetree/bindings/drm/exynos/hdmi.txt.
>
>
> Thanks. Sorry, I've missed that. But it seems to be only for exynos5 SoCs ?
> Also the location is a bit unexpected to me, if we want to have Exynos4 and
> Exynos5 specific IP documented in this file. As I mentioned in previous
> e-mail this IP is not only handled by the DRM API.
>
> --
>
> Regards,
> Sylwester

Re: [PATCH 2/4] ARM: dts: add support for mixer to exynos4

[Rahul Sharma]

On Wed, Jan 30, 2013 at 1:54 AM, Sylwester Nawrocki
<sylvester.nawrocki@gmail.com> wrote:
> Hi,
>
>
> On 01/28/2013 07:44 AM, Rahul Sharma wrote:
>>>>
>>>> +
>>>> +       mixer: mixer {
>>>> +               compatible = "samsung,exynos4-mixer";
>>>
>>>
>>>
>>> I'm afraid this compatible property it too generic. Is the video mixer IP
>>> really identical an all the Exynos4 series SoCs ?
>>>
>>
>> It is same in Exynos4210, 4212 and 4412.
>>
>>>
>>>> +               reg =<0x12c10000 0x10000>,
>>>> +<0x12c00000 0x10000>;
>>>> +               interrupts =<0 91 0>;
>>>> +               samsung,power-domain =<&pd_tv>;
>>>> +       };
>>>>    };
>>>
>>>
>>>
>>> Is there documentation for these new bindings available somewhere ?
>>>
>>
>> it is there at Documentation/devicetree/bindings/drm/exynos/mixer.txt.
>> Probably I need to add details for power domain node property.
>
>
> Sorry, I can't see anything for Exynos4 there, it's only for exynos5 SoCs.
> I think the need for the 'samsung,power-domain' property (I guess that
> should be optional) needs to be documented for completeness.
>
> Getting back to the bindings documentation,
> Documentation/devicetree/bindings/drm/exynos/ seems not exactly right
> place for me, but that's a minor issue. There is also a V4L2 driver
> for the HDMI and TV output devices in drivers/media/platform/s5p-tv.
> So Documentation/devicetree/bindings/video or
> Documentation/devicetree/bindings/media might be a better home for that
> bindings documentation. These IPs are not specific to DRM at all.
>

Make sense. I will move the documentation file to Documentation/
devicetree/ bindings/video and add exynos4 compatible types in next
version.

regards,
Rahul Sharma.

> --
>
> Thanks,
> Sylwester

RE: [PATCH 1/4] ARM: dts: add support for hdmi to exynos4

[Kukjin Kim]

Rahul Sharma wrote:

[...]

> >>>> +       hdmi {
> >>>> +               compatible = "samsung,exynos4-hdmi14";
> >>>
> >>>
> >>>
> >>> What "-hdmi14" signifies here ? And to which Exynos4 SoC revisions
this
> >>> compatible property is supposed to apply ?
> >>>
> >>
> >> -hdmi14 signifies 1.4 compliant Hdmi IP like in Exynos4412, while
> >> Exynos4210 has 1.3
> >> compliant HDMI block. I have done a mistake here. I should have kept
> >> it in 4412.dtsi. OR
> >> I can move it to 4x12.dtsi but not sure whether all 4x12 socs have 1.4
> >> hdmi.
> >
> >
> > Exynos4210 also have the HDMI IP. I'm not sure how much common those
> IP's
> > are
> > among Exynos4 series SoCs. I suppose it makes sense to create a hdmi
> node in
> > exynos4.dtsi and override what's required either in exynos4x12.dtsi or
> > exynos4412.dtsi file.
> >
> > What is worring me is that you're trying to just append the supported
> > HDMI standard version to the string, and there might be more differences
> > in the IPs across all Exynos4 SoC series. What if there are two
different
> > SoCs that support e.g. HDMI v1.4 but there are some differences in the
> > HDMI IPs ? You would likely need to invent new properties and pass them
> > to the driver. Appending specific SoC name to the compatible string
looks
> > like a better alternative to me.
> >
> 
> I agree to it. Putting compatible string with first soc having the IP,
> is a better
> approach altogether. I will incorporate the change in next version.
> 
Well, in this case, why should we use the SoC name? If just we need specific
name here. I think, putting SoC name in compatible is a way to identify and
when the version of IP is available, we can the version instead...like
following, as some guy said before.

compatible = "samsung,hdmi-1.4"

If there is for hdmi 1.4a,

compatible = "samsung,hdmi-1.4a"

Thanks.

- Kukjin

Re: [PATCH 1/4] ARM: dts: add support for hdmi to exynos4

[Rahul Sharma]

On Fri, Feb 1, 2013 at 3:55 AM, Kukjin Kim <kgene.kim@samsung.com> wrote:
> Rahul Sharma wrote:
>
> [...]
>
>> >>>> +       hdmi {
>> >>>> +               compatible = "samsung,exynos4-hdmi14";
>> >>>
>> >>>
>> >>>
>> >>> What "-hdmi14" signifies here ? And to which Exynos4 SoC revisions
> this
>> >>> compatible property is supposed to apply ?
>> >>>
>> >>
>> >> -hdmi14 signifies 1.4 compliant Hdmi IP like in Exynos4412, while
>> >> Exynos4210 has 1.3
>> >> compliant HDMI block. I have done a mistake here. I should have kept
>> >> it in 4412.dtsi. OR
>> >> I can move it to 4x12.dtsi but not sure whether all 4x12 socs have 1.4
>> >> hdmi.
>> >
>> >
>> > Exynos4210 also have the HDMI IP. I'm not sure how much common those
>> IP's
>> > are
>> > among Exynos4 series SoCs. I suppose it makes sense to create a hdmi
>> node in
>> > exynos4.dtsi and override what's required either in exynos4x12.dtsi or
>> > exynos4412.dtsi file.
>> >
>> > What is worring me is that you're trying to just append the supported
>> > HDMI standard version to the string, and there might be more differences
>> > in the IPs across all Exynos4 SoC series. What if there are two
> different
>> > SoCs that support e.g. HDMI v1.4 but there are some differences in the
>> > HDMI IPs ? You would likely need to invent new properties and pass them
>> > to the driver. Appending specific SoC name to the compatible string
> looks
>> > like a better alternative to me.
>> >
>>
>> I agree to it. Putting compatible string with first soc having the IP,
>> is a better
>> approach altogether. I will incorporate the change in next version.
>>
> Well, in this case, why should we use the SoC name? If just we need specific
> name here. I think, putting SoC name in compatible is a way to identify and
> when the version of IP is available, we can the version instead...like
> following, as some guy said before.
>
> compatible = "samsung,hdmi-1.4"
>
> If there is for hdmi 1.4a,
>
> compatible = "samsung,hdmi-1.4a"
>
> Thanks.
>
> - Kukjin
>

Hi Mr. Kim,

Putting hdmi version in compatible string is safe only if we are
sure that there will not be any changes in HDMI IPs for a given
hdmi version number in all upcoming exynos family SoCs. But
it seems unlikely to happen.

This point is getting discussed in details in the following thread.
https://patchwork.kernel.org/patch/1948061/

-- 
Regards,
Rahul Sharma,
email to: rahul.sharma@samsung.com
Samsung India.