Re: [dpdk-dev] [EXT] Re: [PATCH v1 2/7] eal/interrupts: implement get set APIs

[Thomas Monjalon <thomas@monjalon.net>]

14/10/2021 12:44, Harman Kalra:
> > > But just for understanding, as David suggested that we preserve keep
> > > this flag then why not use it, have rte_malloc and malloc bits  and make a
> > decision.
> > > Let driver has the flexibility to choose. Do you see any harm in this?
> > 
> > Which flag?
> 
> In V2, I have replaced the bool arg with an 32bit flag in alloc api:
> struct rte_intr_handle *rte_intr_instance_alloc(uint32_t flags);
> 
> Declared some flags which can be passed by the consumer
> /** Interrupt instance allocation flags
>  * @see rte_intr_instance_alloc
>  */
> /** Allocate interrupt instance from traditional heap */
> #define RTE_INTR_ALLOC_TRAD_HEAP        0x00000000
> /** Allocate interrupt instance using DPDK memory management APIs */
> #define RTE_INTR_ALLOC_DPDK_ALLOCATOR   0x00000001
> 
> As a future enhancement, if more options to the allocation is required by user,
> new flags can be added. 

I am not sure we need such flag.