Re: [dpdk-dev] [PATCH v6 9/9] interrupts: extend event list

[David Marchand <david.marchand@redhat.com>]

On Mon, Oct 25, 2021 at 12:49 PM Dmitry Kozlyuk
<dmitry.kozliuk@gmail.com> wrote:
> > diff --git a/lib/eal/common/eal_common_interrupts.c b/lib/eal/common/eal_common_interrupts.c
> > index 3285c4335f..7feb9da8fa 100644
> > --- a/lib/eal/common/eal_common_interrupts.c
> > +++ b/lib/eal/common/eal_common_interrupts.c
> [...]
> >  int rte_intr_fd_set(struct rte_intr_handle *intr_handle, int fd)
> > @@ -239,6 +330,12 @@ int rte_intr_efds_index_get(const struct rte_intr_handle *intr_handle,
> >  {
> >       CHECK_VALID_INTR_HANDLE(intr_handle);
> >
> > +     if (intr_handle->efds == NULL) {
> > +             RTE_LOG(ERR, EAL, "Event fd list not allocated\n");
> > +             rte_errno = EFAULT;
> > +             goto fail;
> > +     }
> > +
>
> Here and below:
> The check for `nb_intr` will already catch not allocated `efds`,
> because `nb_intr` is necessarily 0 in this case.

+1.
Thanks Dmitry.


-- 
David Marchand