* [PATCH] net/cadence: don't build by default
@ 2013-01-31 18:26 Riccardo Magliocchetti
2013-01-31 18:57 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Riccardo Magliocchetti @ 2013-01-31 18:26 UTC (permalink / raw)
To: Nicolas Ferre; +Cc: netdev, Riccardo Magliocchetti
No need to build net/cadence driver by default.
Signed-off-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
---
drivers/net/ethernet/cadence/Kconfig | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/cadence/Kconfig b/drivers/net/ethernet/cadence/Kconfig
index ceb0de0..8901951 100644
--- a/drivers/net/ethernet/cadence/Kconfig
+++ b/drivers/net/ethernet/cadence/Kconfig
@@ -5,13 +5,12 @@
config NET_CADENCE
bool "Cadence devices"
depends on HAS_IOMEM
- default y
---help---
If you have a network (Ethernet) card belonging to this class, say Y.
Make sure you know the name of your card. Read the Ethernet-HOWTO,
available from <http://www.tldp.org/docs.html#howto>.
- If unsure, say Y.
+ If unsure, say N.
Note that the answer to this question doesn't directly affect the
kernel: saying N will just cause the configurator to skip all
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net/cadence: don't build by default
2013-01-31 18:26 [PATCH] net/cadence: don't build by default Riccardo Magliocchetti
@ 2013-01-31 18:57 ` David Miller
2013-01-31 19:03 ` Riccardo Magliocchetti
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2013-01-31 18:57 UTC (permalink / raw)
To: riccardo.magliocchetti; +Cc: nicolas.ferre, netdev
From: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
Date: Thu, 31 Jan 2013 19:26:55 +0100
> No need to build net/cadence driver by default.
>
> Signed-off-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
Vendor guards are set yes on purpose, because it mimicks for compatability
the behavior that existed before the vendor guards were in place.
These checks guard families of drivers from being offered, rather than
the drivers themselves.
I'm not applying this patch.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net/cadence: don't build by default
2013-01-31 18:57 ` David Miller
@ 2013-01-31 19:03 ` Riccardo Magliocchetti
0 siblings, 0 replies; 3+ messages in thread
From: Riccardo Magliocchetti @ 2013-01-31 19:03 UTC (permalink / raw)
To: David Miller; +Cc: nicolas.ferre, netdev
Il 31/01/2013 19:57, David Miller ha scritto:
> From: Riccardo Magliocchetti<riccardo.magliocchetti@gmail.com>
> Date: Thu, 31 Jan 2013 19:26:55 +0100
>
>> No need to build net/cadence driver by default.
>>
>> Signed-off-by: Riccardo Magliocchetti<riccardo.magliocchetti@gmail.com>
>
> Vendor guards are set yes on purpose, because it mimicks for compatability
> the behavior that existed before the vendor guards were in place.
>
> These checks guard families of drivers from being offered, rather than
> the drivers themselves.
>
> I'm not applying this patch.
Indeed, seen the default Y during make oldconfig and overreacted. Sorry
for the noise.
riccardo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-01-31 19:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-31 18:26 [PATCH] net/cadence: don't build by default Riccardo Magliocchetti
2013-01-31 18:57 ` David Miller
2013-01-31 19:03 ` Riccardo Magliocchetti
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.