* [dm-crypt] [PATCH] fix portability issues encountered while building against musl libc
@ 2013-01-31 19:15 John Spencer
2013-02-01 7:45 ` Milan Broz
0 siblings, 1 reply; 3+ messages in thread
From: John Spencer @ 2013-01-31 19:15 UTC (permalink / raw)
To: dm-crypt
[-- Attachment #1: Type: text/plain, Size: 298 bytes --]
2 header inclusions were missing, one for PATH_MAX (limits.h) and one
for FD_ZERO, FD_SET, ... (sys/select.h)
on glibc, those headers are erroneusly (namespace pollution) pulled in
through other headers, so the author didnt notice.
Signed-Off-By: John Spencer <maillist-cryptsetup@barfooze.de>
[-- Attachment #2: cryptsetup-devpath.patch --]
[-- Type: text/x-patch, Size: 328 bytes --]
--- cryptsetup-1.6.0.org/lib/utils_devpath.c 2013-01-30 19:45:47.142000003 +0000
+++ cryptsetup-1.6.0/lib/utils_devpath.c 2013-01-30 19:46:23.918000003 +0000
@@ -28,6 +28,7 @@
#include <dirent.h>
#include <fcntl.h>
#include <errno.h>
+#include <limits.h>
#include <sys/stat.h>
#include <sys/types.h>
#include "utils_dm.h"
[-- Attachment #3: cryptsetup-random.patch --]
[-- Type: text/x-patch, Size: 301 bytes --]
--- cryptsetup-1.6.0.org/lib/random.c 2013-01-30 19:45:47.143000003 +0000
+++ cryptsetup-1.6.0/lib/random.c 2013-01-30 19:49:16.064000003 +0000
@@ -23,6 +23,7 @@
#include <fcntl.h>
#include <errno.h>
#include <assert.h>
+#include <sys/select.h>
#include "libcryptsetup.h"
#include "internal.h"
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dm-crypt] [PATCH] fix portability issues encountered while building against musl libc
2013-01-31 19:15 [dm-crypt] [PATCH] fix portability issues encountered while building against musl libc John Spencer
@ 2013-02-01 7:45 ` Milan Broz
2013-02-01 17:15 ` John Spencer
0 siblings, 1 reply; 3+ messages in thread
From: Milan Broz @ 2013-02-01 7:45 UTC (permalink / raw)
To: John Spencer; +Cc: dm-crypt
On 01/31/2013 08:15 PM, John Spencer wrote:
> 2 header inclusions were missing, one for PATH_MAX (limits.h) and one
> for FD_ZERO, FD_SET, ... (sys/select.h)
>
> on glibc, those headers are erroneusly (namespace pollution) pulled in
> through other headers, so the author didnt notice.
Both patches applied, thanks.
BTW which environment (libc) are you using?
Milan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dm-crypt] [PATCH] fix portability issues encountered while building against musl libc
2013-02-01 7:45 ` Milan Broz
@ 2013-02-01 17:15 ` John Spencer
0 siblings, 0 replies; 3+ messages in thread
From: John Spencer @ 2013-02-01 17:15 UTC (permalink / raw)
To: dm-crypt
On 02/01/2013 08:45 AM, Milan Broz wrote:
> On 01/31/2013 08:15 PM, John Spencer wrote:
>> 2 header inclusions were missing, one for PATH_MAX (limits.h) and one
>> for FD_ZERO, FD_SET, ... (sys/select.h)
>>
>> on glibc, those headers are erroneusly (namespace pollution) pulled in
>> through other headers, so the author didnt notice.
>
> Both patches applied, thanks.
thanks!
>
> BTW which environment (libc) are you using?
musl libc: http://www.musl-libc.org/
best regards,
--JS
>
> Milan
> _______________________________________________
> dm-crypt mailing list
> dm-crypt@saout.de
> http://www.saout.de/mailman/listinfo/dm-crypt
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-02-01 17:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-31 19:15 [dm-crypt] [PATCH] fix portability issues encountered while building against musl libc John Spencer
2013-02-01 7:45 ` Milan Broz
2013-02-01 17:15 ` John Spencer
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.