From: Pankaj Gupta <pagupta@redhat.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: cohuck@redhat.com, Jan Kara <jack@suse.cz>,
KVM list <kvm@vger.kernel.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>, david <david@fromorbit.com>,
Qemu Developers <qemu-devel@nongnu.org>,
virtualization@lists.linux-foundation.org,
Andreas Dilger <adilger.kernel@dilger.ca>,
Ross Zwisler <zwisler@kernel.org>,
Andrea Arcangeli <aarcange@redhat.com>,
linux-nvdimm <linux-nvdimm@lists.01.org>,
David Hildenbrand <david@redhat.com>,
Matthew Wilcox <willy@infradead.org>,
Christoph Hellwig <hch@infradead.org>,
Linux ACPI <linux-acpi@vger.kernel.org>,
linux-ext4 <linux-ext4@vger.kernel.org>,
Len Brown <lenb@kernel.org>,
kilobyte@angband.pl, Rik van Riel <riel@surriel.com>,
yuval shaia <yuval.shaia@oracle.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
lcapitulino@redhat.com, Kevin Wolf <kwolf@redhat.com>,
Nitesh Narayan Lal <nilal@redhat.com>,
Theodore Ts'o <tytso@mit.edu>,
Xiao Guangrong <xiaoguangrong.eric@gmail.com>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-xfs <linux-xfs@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Igor Mammedov <imammedo@redhat.com>
Subject: Re: [PATCH v7 3/6] libnvdimm: add dax_dev sync flag
Date: Thu, 9 May 2019 08:24:24 -0400 (EDT) [thread overview]
Message-ID: <511098535.27565704.1557404664499.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <CAPcyv4hRdvypEj4LBTMfUFm80BdpRYbOugrkkj-3Kk_LErXPqQ@mail.gmail.com>
> >
> > This patch adds 'DAXDEV_SYNC' flag which is set
> > for nd_region doing synchronous flush. This later
> > is used to disable MAP_SYNC functionality for
> > ext4 & xfs filesystem for devices don't support
> > synchronous flush.
> >
> > Signed-off-by: Pankaj Gupta <pagupta@redhat.com>
> [..]
> > diff --git a/include/linux/dax.h b/include/linux/dax.h
> > index 0dd316a74a29..c97fc0cc7167 100644
> > --- a/include/linux/dax.h
> > +++ b/include/linux/dax.h
> > @@ -7,6 +7,9 @@
> > #include <linux/radix-tree.h>
> > #include <asm/pgtable.h>
> >
> > +/* Flag for synchronous flush */
> > +#define DAXDEV_F_SYNC true
>
> I'd feel better, i.e. it reads more canonically, if this was defined
> as (1UL << 0) and the argument to alloc_dax() was changed to 'unsigned
> long flags' rather than a bool.
Sure, Will send a v8 with suggested changes.
Thank You,
Pankaj
>
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Pankaj Gupta <pagupta@redhat.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-nvdimm <linux-nvdimm@lists.01.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
virtualization@lists.linux-foundation.org,
KVM list <kvm@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Linux ACPI <linux-acpi@vger.kernel.org>,
Qemu Developers <qemu-devel@nongnu.org>,
linux-ext4 <linux-ext4@vger.kernel.org>,
linux-xfs <linux-xfs@vger.kernel.org>,
Ross Zwisler <zwisler@kernel.org>,
Vishal L Verma <vishal.l.verma@intel.com>,
Dave Jiang <dave.jiang@intel.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
Matthew Wilcox <willy@infradead.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Christoph Hellwig <hch@infradead.org>,
Len Brown <lenb@kernel.org>, Jan Kara <jack@suse.cz>,
Theodore Ts'o <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
lcapitulino@redhat.com, Kevin Wolf <kwolf@redhat.com>,
Igor Mammedov <imammedo@redhat.com>, jmoyer <jmoyer@redhat.com>,
Nitesh Narayan Lal <nilal@redhat.com>,
Rik van Riel <riel@surriel.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Andrea Arcangeli <aarcange@redhat.com>,
David Hildenbrand <david@redhat.com>, david <david@fromorbit.com>,
cohuck@redhat.com, Xiao Guangrong <xiaoguangrong.eric@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>,
kilobyte@angband.pl, yuval shaia <yuval.shaia@oracle.com>
Subject: Re: [PATCH v7 3/6] libnvdimm: add dax_dev sync flag
Date: Thu, 9 May 2019 08:24:24 -0400 (EDT) [thread overview]
Message-ID: <511098535.27565704.1557404664499.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <CAPcyv4hRdvypEj4LBTMfUFm80BdpRYbOugrkkj-3Kk_LErXPqQ@mail.gmail.com>
> >
> > This patch adds 'DAXDEV_SYNC' flag which is set
> > for nd_region doing synchronous flush. This later
> > is used to disable MAP_SYNC functionality for
> > ext4 & xfs filesystem for devices don't support
> > synchronous flush.
> >
> > Signed-off-by: Pankaj Gupta <pagupta@redhat.com>
> [..]
> > diff --git a/include/linux/dax.h b/include/linux/dax.h
> > index 0dd316a74a29..c97fc0cc7167 100644
> > --- a/include/linux/dax.h
> > +++ b/include/linux/dax.h
> > @@ -7,6 +7,9 @@
> > #include <linux/radix-tree.h>
> > #include <asm/pgtable.h>
> >
> > +/* Flag for synchronous flush */
> > +#define DAXDEV_F_SYNC true
>
> I'd feel better, i.e. it reads more canonically, if this was defined
> as (1UL << 0) and the argument to alloc_dax() was changed to 'unsigned
> long flags' rather than a bool.
Sure, Will send a v8 with suggested changes.
Thank You,
Pankaj
>
WARNING: multiple messages have this Message-ID (diff)
From: Pankaj Gupta <pagupta@redhat.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: cohuck@redhat.com, Jan Kara <jack@suse.cz>,
KVM list <kvm@vger.kernel.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>, david <david@fromorbit.com>,
Qemu Developers <qemu-devel@nongnu.org>,
virtualization@lists.linux-foundation.org,
Andreas Dilger <adilger.kernel@dilger.ca>,
Ross Zwisler <zwisler@kernel.org>,
Andrea Arcangeli <aarcange@redhat.com>,
Dave Jiang <dave.jiang@intel.com>,
linux-nvdimm <linux-nvdimm@lists.01.org>,
Vishal L Verma <vishal.l.verma@intel.com>,
David Hildenbrand <david@redhat.com>,
Matthew Wilcox <willy@infradead.org>,
Christoph Hellwig <hch@infradead.org>,
Linux ACPI <linux-acpi@vger.kernel.org>,
jmoyer <jmoyer@redhat.com>,
linux-ext4 <linux-ext4@vger.kernel.org>,
Len Brown <lenb@kernel.org>,
kilobyte@angband.pl, Rik van Riel <riel@surriel.com>,
yuval shaia <yuval.shaia@oracle.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
lcapitulino@redhat.com, Kevin Wolf <kwolf@redhat.com>,
Nitesh Narayan Lal <nilal@redhat.com>,
Theodore Ts'o <tytso@mit.edu>,
Xiao Guangrong <xiaoguangrong.eric@gmail.com>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-xfs <linux-xfs@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Igor Mammedov <imammedo@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v7 3/6] libnvdimm: add dax_dev sync flag
Date: Thu, 9 May 2019 08:24:24 -0400 (EDT) [thread overview]
Message-ID: <511098535.27565704.1557404664499.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <CAPcyv4hRdvypEj4LBTMfUFm80BdpRYbOugrkkj-3Kk_LErXPqQ@mail.gmail.com>
> >
> > This patch adds 'DAXDEV_SYNC' flag which is set
> > for nd_region doing synchronous flush. This later
> > is used to disable MAP_SYNC functionality for
> > ext4 & xfs filesystem for devices don't support
> > synchronous flush.
> >
> > Signed-off-by: Pankaj Gupta <pagupta@redhat.com>
> [..]
> > diff --git a/include/linux/dax.h b/include/linux/dax.h
> > index 0dd316a74a29..c97fc0cc7167 100644
> > --- a/include/linux/dax.h
> > +++ b/include/linux/dax.h
> > @@ -7,6 +7,9 @@
> > #include <linux/radix-tree.h>
> > #include <asm/pgtable.h>
> >
> > +/* Flag for synchronous flush */
> > +#define DAXDEV_F_SYNC true
>
> I'd feel better, i.e. it reads more canonically, if this was defined
> as (1UL << 0) and the argument to alloc_dax() was changed to 'unsigned
> long flags' rather than a bool.
Sure, Will send a v8 with suggested changes.
Thank You,
Pankaj
>
next prev parent reply other threads:[~2019-05-09 12:24 UTC|newest]
Thread overview: 107+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-26 5:00 [PATCH v7 0/6] virtio pmem driver Pankaj Gupta
2019-04-26 5:00 ` [Qemu-devel] " Pankaj Gupta
2019-04-26 5:00 ` Pankaj Gupta
2019-04-26 5:00 ` Pankaj Gupta
2019-04-26 5:00 ` [PATCH v7 1/6] libnvdimm: nd_region flush callback support Pankaj Gupta
2019-04-26 5:00 ` [Qemu-devel] " Pankaj Gupta
2019-04-26 5:00 ` Pankaj Gupta
2019-04-26 5:00 ` Pankaj Gupta
2019-04-26 5:00 ` Pankaj Gupta
2019-04-26 5:00 ` [PATCH v7 2/6] virtio-pmem: Add virtio pmem driver Pankaj Gupta
2019-04-26 5:00 ` Pankaj Gupta
2019-04-26 5:00 ` [Qemu-devel] " Pankaj Gupta
2019-04-26 5:00 ` Pankaj Gupta
2019-04-26 5:00 ` Pankaj Gupta
[not found] ` <20190426050039.17460-3-pagupta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2019-04-30 5:53 ` [Qemu-devel] " Yuval Shaia
2019-04-30 5:53 ` Yuval Shaia
2019-04-30 5:53 ` Yuval Shaia
2019-04-30 6:06 ` Pankaj Gupta
2019-04-30 6:06 ` Pankaj Gupta
2019-04-30 6:06 ` Pankaj Gupta
2019-04-30 6:06 ` Pankaj Gupta
2019-04-30 5:53 ` Yuval Shaia
2019-05-07 15:35 ` Dan Williams
2019-05-07 15:35 ` Dan Williams
2019-05-07 15:35 ` [Qemu-devel] " Dan Williams
2019-05-07 15:35 ` Dan Williams
2019-05-07 15:35 ` Dan Williams
[not found] ` <CAPcyv4hdT5bbgv0Gy1r0Xb3RMfE_Zpe7DV10a=F1PFeTeEt+Fw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-05-08 11:19 ` [Qemu-devel] " Pankaj Gupta
2019-05-08 11:19 ` Pankaj Gupta
2019-05-08 11:19 ` Pankaj Gupta
2019-05-10 23:33 ` Dan Williams
2019-05-10 23:33 ` Dan Williams
2019-05-10 23:33 ` Dan Williams
2019-05-10 23:33 ` Dan Williams
2019-05-11 1:26 ` Pankaj Gupta
2019-05-11 1:26 ` Pankaj Gupta
2019-05-11 1:26 ` Pankaj Gupta
2019-05-11 1:26 ` Pankaj Gupta
2019-05-08 11:19 ` Pankaj Gupta
2019-05-07 20:25 ` Jakub Staroń
2019-05-07 20:25 ` Jakub Staroń via Qemu-devel
2019-05-08 11:12 ` Pankaj Gupta
2019-05-08 11:12 ` Pankaj Gupta
2019-05-08 11:12 ` Pankaj Gupta
2019-05-08 11:12 ` Pankaj Gupta
2019-05-08 15:23 ` Pankaj Gupta
2019-05-08 15:23 ` Pankaj Gupta
2019-05-08 15:23 ` Pankaj Gupta
2019-05-08 15:23 ` Pankaj Gupta
2019-05-08 19:05 ` Jakub Staroń
2019-05-08 19:05 ` Jakub Staroń via Qemu-devel
2019-05-08 19:05 ` Jakub Staroń
2019-05-08 19:05 ` Jakub Staroń via Virtualization
2019-05-07 20:25 ` Jakub Staroń via Virtualization
2019-04-26 5:00 ` [PATCH v7 3/6] libnvdimm: add dax_dev sync flag Pankaj Gupta
2019-04-26 5:00 ` [Qemu-devel] " Pankaj Gupta
2019-04-26 5:00 ` Pankaj Gupta
2019-04-26 5:00 ` Pankaj Gupta
2019-05-07 15:40 ` Dan Williams
2019-05-07 15:40 ` [Qemu-devel] " Dan Williams
2019-05-07 15:40 ` Dan Williams
2019-05-07 15:40 ` Dan Williams
2019-05-09 12:24 ` Pankaj Gupta [this message]
2019-05-09 12:24 ` [Qemu-devel] " Pankaj Gupta
2019-05-09 12:24 ` Pankaj Gupta
2019-05-09 12:24 ` Pankaj Gupta
2019-05-07 15:40 ` Dan Williams
2019-04-26 5:00 ` Pankaj Gupta
2019-04-26 5:00 ` [PATCH v7 4/6] dax: check synchronous mapping is supported Pankaj Gupta
2019-04-26 5:00 ` Pankaj Gupta
2019-04-26 5:00 ` [Qemu-devel] " Pankaj Gupta
2019-04-26 5:00 ` Pankaj Gupta
2019-04-26 5:00 ` Pankaj Gupta
2019-04-26 5:00 ` Pankaj Gupta
2019-05-07 19:24 ` [Qemu-devel] " Jakub Staroń via Virtualization
2019-05-07 19:24 ` Jakub Staroń
2019-05-07 19:24 ` Jakub Staroń via Qemu-devel
2019-05-07 19:24 ` Jakub Staroń
2019-05-08 5:31 ` Pankaj Gupta
2019-05-08 5:31 ` Pankaj Gupta
2019-05-08 5:31 ` Pankaj Gupta
2019-05-08 5:31 ` Pankaj Gupta
2019-05-08 5:31 ` Pankaj Gupta
2019-04-26 5:00 ` [PATCH v7 5/6] ext4: disable map_sync for async flush Pankaj Gupta
2019-04-26 5:00 ` [Qemu-devel] " Pankaj Gupta
2019-04-26 5:00 ` Pankaj Gupta
2019-04-26 5:00 ` Pankaj Gupta
2019-04-26 5:00 ` Pankaj Gupta
2019-04-26 5:00 ` [PATCH v7 6/6] xfs: " Pankaj Gupta
2019-04-26 5:00 ` [Qemu-devel] " Pankaj Gupta
2019-04-26 5:00 ` Pankaj Gupta
2019-04-26 5:00 ` Pankaj Gupta
2019-05-07 15:37 ` Dan Williams
2019-05-07 15:37 ` Dan Williams
2019-05-07 15:37 ` [Qemu-devel] " Dan Williams
2019-05-07 15:37 ` Dan Williams
2019-05-07 15:37 ` Dan Williams
2019-05-07 16:17 ` Darrick J. Wong
2019-05-07 16:17 ` [Qemu-devel] " Darrick J. Wong
2019-05-07 16:17 ` Darrick J. Wong
2019-05-07 16:17 ` Darrick J. Wong
2019-05-08 5:49 ` [Qemu-devel] " Pankaj Gupta
2019-05-08 5:49 ` Pankaj Gupta
2019-05-08 5:49 ` Pankaj Gupta
2019-05-08 5:49 ` Pankaj Gupta
2019-05-08 5:49 ` Pankaj Gupta
2019-04-26 5:00 ` Pankaj Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=511098535.27565704.1557404664499.JavaMail.zimbra@redhat.com \
--to=pagupta@redhat.com \
--cc=aarcange@redhat.com \
--cc=adilger.kernel@dilger.ca \
--cc=cohuck@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=david@redhat.com \
--cc=hch@infradead.org \
--cc=imammedo@redhat.com \
--cc=jack@suse.cz \
--cc=jasowang@redhat.com \
--cc=kilobyte@angband.pl \
--cc=kvm@vger.kernel.org \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mst@redhat.com \
--cc=nilal@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=riel@surriel.com \
--cc=rjw@rjwysocki.net \
--cc=stefanha@redhat.com \
--cc=tytso@mit.edu \
--cc=virtualization@lists.linux-foundation.org \
--cc=willy@infradead.org \
--cc=xiaoguangrong.eric@gmail.com \
--cc=yuval.shaia@oracle.com \
--cc=zwisler@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.