From: Alexander Holler <holler@ahsoftware.de> To: Greg KH <gregkh@linuxfoundation.org> Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, Florian Tobias Schandinat <FlorianSchandinat@gmx.de>, Bernie Thompson <bernie@plugable.com>, Steve Glendinning <steve.glendinning@shawell.net>, stable@vger.kernel.org Subject: Re: [PATCH 2/3 v2] fb: udlfb: fix hang at disconnect Date: Tue, 05 Feb 2013 18:36:29 +0100 [thread overview] Message-ID: <5111431D.8070906@ahsoftware.de> (raw) In-Reply-To: <20130205172245.GA1426@kroah.com> Am 05.02.2013 18:22, schrieb Greg KH: > On Tue, Feb 05, 2013 at 08:08:28AM +0100, Alexander Holler wrote: >> Am 04.02.2013 20:25, schrieb Greg KH: >>> Where was that urb when the disconnect happened? The USB core should >>> call your urb callback for any outstanding urbs at that point in time, >>> with the proper error flag being set, are you handling that properly? >> >> I don't know where that urb is as I don't handle it. > > What do you mean by that? The urb is being sent back to your driver, > right? If not, that's a bug, but please be sure that your urb callback > isn't really being called. I meant it isn't _my_ driver. ;) I'm just trying to add some würgarounds without having the need to rewrite the whole driver. In regard to that "urb missing problem", I think I've just named it wrong and the actual problem is a race-condition between the semaphore handling (which is used to keep track of the urbs) and the urb handling inside the driver. But I've just switched to udl (instead of udlfb) and will see if I can fix the bugs there to make it usable as a console. udl is a rewrite of udlfb with some additional features (e.g. drm), so hopefully fixing the remaining problems there will require less work. Regards, Alexander
WARNING: multiple messages have this Message-ID (diff)
From: Alexander Holler <holler@ahsoftware.de> To: Greg KH <gregkh@linuxfoundation.org> Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, Florian Tobias Schandinat <FlorianSchandinat@gmx.de>, Bernie Thompson <bernie@plugable.com>, Steve Glendinning <steve.glendinning@shawell.net>, stable@vger.kernel.org Subject: Re: [PATCH 2/3 v2] fb: udlfb: fix hang at disconnect Date: Tue, 05 Feb 2013 17:36:29 +0000 [thread overview] Message-ID: <5111431D.8070906@ahsoftware.de> (raw) In-Reply-To: <20130205172245.GA1426@kroah.com> Am 05.02.2013 18:22, schrieb Greg KH: > On Tue, Feb 05, 2013 at 08:08:28AM +0100, Alexander Holler wrote: >> Am 04.02.2013 20:25, schrieb Greg KH: >>> Where was that urb when the disconnect happened? The USB core should >>> call your urb callback for any outstanding urbs at that point in time, >>> with the proper error flag being set, are you handling that properly? >> >> I don't know where that urb is as I don't handle it. > > What do you mean by that? The urb is being sent back to your driver, > right? If not, that's a bug, but please be sure that your urb callback > isn't really being called. I meant it isn't _my_ driver. ;) I'm just trying to add some würgarounds without having the need to rewrite the whole driver. In regard to that "urb missing problem", I think I've just named it wrong and the actual problem is a race-condition between the semaphore handling (which is used to keep track of the urbs) and the urb handling inside the driver. But I've just switched to udl (instead of udlfb) and will see if I can fix the bugs there to make it usable as a console. udl is a rewrite of udlfb with some additional features (e.g. drm), so hopefully fixing the remaining problems there will require less work. Regards, Alexander
next prev parent reply other threads:[~2013-02-05 17:36 UTC|newest] Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-01-12 13:20 [PATCH] fb: udlfb: fix hang at disconnect Alexander Holler 2013-01-12 13:20 ` Alexander Holler 2013-01-12 22:22 ` Bernie Thompson 2013-01-12 22:22 ` Bernie Thompson 2013-01-13 12:05 ` Alexander Holler 2013-01-13 12:05 ` Alexander Holler 2013-01-13 12:24 ` Alexander Holler 2013-01-13 12:24 ` Alexander Holler 2013-01-25 18:49 ` [PATCH 1/3] semaphore: introduce down_timeout_killable() Alexander Holler 2013-01-25 18:49 ` Alexander Holler 2013-01-25 18:49 ` [PATCH 2/3 v2] fb: udlfb: fix hang at disconnect Alexander Holler 2013-01-25 18:49 ` Alexander Holler 2013-01-29 0:22 ` Andrew Morton 2013-01-29 0:22 ` Andrew Morton 2013-01-29 0:56 ` Alexander Holler 2013-01-29 0:56 ` Alexander Holler 2013-01-29 10:35 ` Alexander Holler 2013-01-29 10:35 ` Alexander Holler 2013-01-29 11:11 ` Alexander Holler 2013-01-29 11:11 ` Alexander Holler 2013-01-29 15:51 ` Alexander Holler 2013-01-29 15:51 ` Alexander Holler 2013-01-29 20:35 ` Alexander Holler 2013-01-29 20:35 ` Alexander Holler 2013-01-29 20:56 ` Alexander Holler 2013-01-29 20:56 ` Alexander Holler 2013-02-04 1:14 ` Greg KH 2013-02-04 1:14 ` Greg KH 2013-02-04 12:05 ` Alexander Holler 2013-02-04 12:05 ` Alexander Holler 2013-02-04 19:17 ` Alexander Holler 2013-02-04 19:17 ` Alexander Holler 2013-02-04 19:25 ` Greg KH 2013-02-04 19:25 ` Greg KH 2013-02-05 7:08 ` Alexander Holler 2013-02-05 7:08 ` Alexander Holler 2013-02-05 17:22 ` Greg KH 2013-02-05 17:22 ` Greg KH 2013-02-05 17:36 ` Alexander Holler [this message] 2013-02-05 17:36 ` Alexander Holler 2013-02-08 4:07 ` Dave Airlie 2013-02-08 4:07 ` Dave Airlie 2013-02-08 9:53 ` Alexander Holler 2013-02-08 9:53 ` Alexander Holler 2013-01-25 18:49 ` [PATCH 3/3] fb: smscufx: " Alexander Holler 2013-01-25 18:49 ` Alexander Holler
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5111431D.8070906@ahsoftware.de \ --to=holler@ahsoftware.de \ --cc=FlorianSchandinat@gmx.de \ --cc=akpm@linux-foundation.org \ --cc=bernie@plugable.com \ --cc=gregkh@linuxfoundation.org \ --cc=linux-fbdev@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=stable@vger.kernel.org \ --cc=steve.glendinning@shawell.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.