* Re: [PATCH] ARM: dts: moving dt binding documents for video devices to common place
2013-02-06 14:57 [PATCH] ARM: dts: moving dt binding documents for video devices to common place Rahul Sharma
@ 2013-02-06 14:50 ` Sylwester Nawrocki
2013-02-07 3:10 ` Rahul Sharma
0 siblings, 1 reply; 5+ messages in thread
From: Sylwester Nawrocki @ 2013-02-06 14:50 UTC (permalink / raw)
To: Rahul Sharma
Cc: linux-samsung-soc, devicetree-discuss, dri-devel, kgene.kim,
sw0312.kim, inki.dae, joshi, r.sh.open
Hi Rahul,
On 02/06/2013 03:57 PM, Rahul Sharma wrote:
> Binding Documents for drm-devices are placed in
> Documentation/devicetree/bindings/drm/*. But these devices are common
> for v4l framework, hence moved to a common place
> Documentation/devicetree/bindings/video/. 'exynos_' prefix is added to
> associate them with exynos soc series.
It looks good to me, I would just use 'exynos-' prefix instead,
this seems to be more common across existing files. Sorry for
the nitpicking..
I suppose you should address the patch to and base on the tree of
the device tree maintainers.
Thanks,
Sylwester
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ARM: dts: moving dt binding documents for video devices to common place
@ 2013-02-06 14:57 Rahul Sharma
2013-02-06 14:50 ` Sylwester Nawrocki
0 siblings, 1 reply; 5+ messages in thread
From: Rahul Sharma @ 2013-02-06 14:57 UTC (permalink / raw)
To: linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ
Cc: kgene.kim-Sze3O3UU22JBDgjK7y7TUQ,
sw0312.kim-Sze3O3UU22JBDgjK7y7TUQ, joshi-Sze3O3UU22JBDgjK7y7TUQ,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
inki.dae-Sze3O3UU22JBDgjK7y7TUQ,
s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ,
r.sh.open-Re5JQEeQqe8AvxtiuMwx3w
Binding Documents for drm-devices are placed in
Documentation/devicetree/bindings/drm/*. But these devices are common
for v4l framework, hence moved to a common place
Documentation/devicetree/bindings/video/. 'exynos_' prefix is added to
associate them with exynos soc series.
Signed-off-by: Rahul Sharma <rahul.sharma-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
---
It is base on for-next branch of
git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git
.../devicetree/bindings/drm/exynos/hdmi.txt | 22 ----------------------
.../devicetree/bindings/drm/exynos/hdmiddc.txt | 12 ------------
.../devicetree/bindings/drm/exynos/hdmiphy.txt | 12 ------------
.../devicetree/bindings/drm/exynos/mixer.txt | 15 ---------------
.../devicetree/bindings/video/exynos_hdmi.txt | 22 ++++++++++++++++++++++
.../devicetree/bindings/video/exynos_hdmiddc.txt | 12 ++++++++++++
.../devicetree/bindings/video/exynos_hdmiphy.txt | 12 ++++++++++++
.../devicetree/bindings/video/exynos_mixer.txt | 15 +++++++++++++++
8 files changed, 61 insertions(+), 61 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/drm/exynos/hdmi.txt
delete mode 100644 Documentation/devicetree/bindings/drm/exynos/hdmiddc.txt
delete mode 100644 Documentation/devicetree/bindings/drm/exynos/hdmiphy.txt
delete mode 100644 Documentation/devicetree/bindings/drm/exynos/mixer.txt
create mode 100644 Documentation/devicetree/bindings/video/exynos_hdmi.txt
create mode 100644 Documentation/devicetree/bindings/video/exynos_hdmiddc.txt
create mode 100644 Documentation/devicetree/bindings/video/exynos_hdmiphy.txt
create mode 100644 Documentation/devicetree/bindings/video/exynos_mixer.txt
diff --git a/Documentation/devicetree/bindings/drm/exynos/hdmi.txt b/Documentation/devicetree/bindings/drm/exynos/hdmi.txt
deleted file mode 100644
index 589edee..0000000
--- a/Documentation/devicetree/bindings/drm/exynos/hdmi.txt
+++ /dev/null
@@ -1,22 +0,0 @@
-Device-Tree bindings for drm hdmi driver
-
-Required properties:
-- compatible: value should be "samsung,exynos5-hdmi".
-- reg: physical base address of the hdmi and length of memory mapped
- region.
-- interrupts: interrupt number to the cpu.
-- hpd-gpio: following information about the hotplug gpio pin.
- a) phandle of the gpio controller node.
- b) pin number within the gpio controller.
- c) pin function mode.
- d) optional flags and pull up/down.
- e) drive strength.
-
-Example:
-
- hdmi {
- compatible = "samsung,exynos5-hdmi";
- reg = <0x14530000 0x100000>;
- interrupts = <0 95 0>;
- hpd-gpio = <&gpx3 7 0xf 1 3>;
- };
diff --git a/Documentation/devicetree/bindings/drm/exynos/hdmiddc.txt b/Documentation/devicetree/bindings/drm/exynos/hdmiddc.txt
deleted file mode 100644
index fa166d9..0000000
--- a/Documentation/devicetree/bindings/drm/exynos/hdmiddc.txt
+++ /dev/null
@@ -1,12 +0,0 @@
-Device-Tree bindings for hdmiddc driver
-
-Required properties:
-- compatible: value should be "samsung,exynos5-hdmiddc".
-- reg: I2C address of the hdmiddc device.
-
-Example:
-
- hdmiddc {
- compatible = "samsung,exynos5-hdmiddc";
- reg = <0x50>;
- };
diff --git a/Documentation/devicetree/bindings/drm/exynos/hdmiphy.txt b/Documentation/devicetree/bindings/drm/exynos/hdmiphy.txt
deleted file mode 100644
index 858f4f9..0000000
--- a/Documentation/devicetree/bindings/drm/exynos/hdmiphy.txt
+++ /dev/null
@@ -1,12 +0,0 @@
-Device-Tree bindings for hdmiphy driver
-
-Required properties:
-- compatible: value should be "samsung,exynos5-hdmiphy".
-- reg: I2C address of the hdmiphy device.
-
-Example:
-
- hdmiphy {
- compatible = "samsung,exynos5-hdmiphy";
- reg = <0x38>;
- };
diff --git a/Documentation/devicetree/bindings/drm/exynos/mixer.txt b/Documentation/devicetree/bindings/drm/exynos/mixer.txt
deleted file mode 100644
index 9b2ea03..0000000
--- a/Documentation/devicetree/bindings/drm/exynos/mixer.txt
+++ /dev/null
@@ -1,15 +0,0 @@
-Device-Tree bindings for mixer driver
-
-Required properties:
-- compatible: value should be "samsung,exynos5-mixer".
-- reg: physical base address of the mixer and length of memory mapped
- region.
-- interrupts: interrupt number to the cpu.
-
-Example:
-
- mixer {
- compatible = "samsung,exynos5-mixer";
- reg = <0x14450000 0x10000>;
- interrupts = <0 94 0>;
- };
diff --git a/Documentation/devicetree/bindings/video/exynos_hdmi.txt b/Documentation/devicetree/bindings/video/exynos_hdmi.txt
new file mode 100644
index 0000000..4c48a83
--- /dev/null
+++ b/Documentation/devicetree/bindings/video/exynos_hdmi.txt
@@ -0,0 +1,22 @@
+Device-Tree bindings for hdmi driver
+
+Required properties:
+- compatible: value should be "samsung,exynos5-hdmi".
+- reg: physical base address of the hdmi and length of memory mapped
+ region.
+- interrupts: interrupt number to the cpu.
+- hpd-gpio: following information about the hotplug gpio pin.
+ a) phandle of the gpio controller node.
+ b) pin number within the gpio controller.
+ c) pin function mode.
+ d) optional flags and pull up/down.
+ e) drive strength.
+
+Example:
+
+ hdmi {
+ compatible = "samsung,exynos5-hdmi";
+ reg = <0x14530000 0x100000>;
+ interrupts = <0 95 0>;
+ hpd-gpio = <&gpx3 7 0xf 1 3>;
+ };
diff --git a/Documentation/devicetree/bindings/video/exynos_hdmiddc.txt b/Documentation/devicetree/bindings/video/exynos_hdmiddc.txt
new file mode 100644
index 0000000..fa166d9
--- /dev/null
+++ b/Documentation/devicetree/bindings/video/exynos_hdmiddc.txt
@@ -0,0 +1,12 @@
+Device-Tree bindings for hdmiddc driver
+
+Required properties:
+- compatible: value should be "samsung,exynos5-hdmiddc".
+- reg: I2C address of the hdmiddc device.
+
+Example:
+
+ hdmiddc {
+ compatible = "samsung,exynos5-hdmiddc";
+ reg = <0x50>;
+ };
diff --git a/Documentation/devicetree/bindings/video/exynos_hdmiphy.txt b/Documentation/devicetree/bindings/video/exynos_hdmiphy.txt
new file mode 100644
index 0000000..858f4f9
--- /dev/null
+++ b/Documentation/devicetree/bindings/video/exynos_hdmiphy.txt
@@ -0,0 +1,12 @@
+Device-Tree bindings for hdmiphy driver
+
+Required properties:
+- compatible: value should be "samsung,exynos5-hdmiphy".
+- reg: I2C address of the hdmiphy device.
+
+Example:
+
+ hdmiphy {
+ compatible = "samsung,exynos5-hdmiphy";
+ reg = <0x38>;
+ };
diff --git a/Documentation/devicetree/bindings/video/exynos_mixer.txt b/Documentation/devicetree/bindings/video/exynos_mixer.txt
new file mode 100644
index 0000000..9b2ea03
--- /dev/null
+++ b/Documentation/devicetree/bindings/video/exynos_mixer.txt
@@ -0,0 +1,15 @@
+Device-Tree bindings for mixer driver
+
+Required properties:
+- compatible: value should be "samsung,exynos5-mixer".
+- reg: physical base address of the mixer and length of memory mapped
+ region.
+- interrupts: interrupt number to the cpu.
+
+Example:
+
+ mixer {
+ compatible = "samsung,exynos5-mixer";
+ reg = <0x14450000 0x10000>;
+ interrupts = <0 94 0>;
+ };
--
1.8.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: dts: moving dt binding documents for video devices to common place
2013-02-06 14:50 ` Sylwester Nawrocki
@ 2013-02-07 3:10 ` Rahul Sharma
0 siblings, 0 replies; 5+ messages in thread
From: Rahul Sharma @ 2013-02-07 3:10 UTC (permalink / raw)
To: Sylwester Nawrocki
Cc: Rahul Sharma, linux-samsung-soc, devicetree-discuss, dri-devel,
kgene.kim, sw0312.kim, inki.dae, joshi
Hi Sylwester,
On Wed, Feb 6, 2013 at 8:20 PM, Sylwester Nawrocki
<s.nawrocki@samsung.com> wrote:
> Hi Rahul,
>
> On 02/06/2013 03:57 PM, Rahul Sharma wrote:
>> Binding Documents for drm-devices are placed in
>> Documentation/devicetree/bindings/drm/*. But these devices are common
>> for v4l framework, hence moved to a common place
>> Documentation/devicetree/bindings/video/. 'exynos_' prefix is added to
>> associate them with exynos soc series.
>
> It looks good to me, I would just use 'exynos-' prefix instead,
> this seems to be more common across existing files. Sorry for
> the nitpicking..
>
> I suppose you should address the patch to and base on the tree of
> the device tree maintainers.
>
> Thanks,
> Sylwester
I mentioned it in the patch. Please let me know if it needs to be re-based
to some other tree.
> Signed-off-by: Rahul Sharma <rahul.sharma@samsung.com>
> ---
> It is base on for-next branch of
> git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git
>
> .../devicetree/bindings/drm/exynos/hdmi.txt | 22 ----------------------
> .../devicetree/bindings/drm/exynos/hdmiddc.txt | 12 ------------
> .../devicetree/bindings/drm/exynos/hdmiphy.txt | 12 ------------
>
> --
Regards,
Rahul Sharma,
email to: rahul.sharma@samsung.com
Samsung India.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: dts: moving dt binding documents for video devices to common place
[not found] ` <1360162299-8893-1-git-send-email-rahul.sharma-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
@ 2013-03-04 3:51 ` Grant Likely
0 siblings, 0 replies; 5+ messages in thread
From: Grant Likely @ 2013-03-04 3:51 UTC (permalink / raw)
To: Rahul Sharma, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ
Cc: kgene.kim-Sze3O3UU22JBDgjK7y7TUQ,
sw0312.kim-Sze3O3UU22JBDgjK7y7TUQ, joshi-Sze3O3UU22JBDgjK7y7TUQ,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
inki.dae-Sze3O3UU22JBDgjK7y7TUQ,
s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ,
r.sh.open-Re5JQEeQqe8AvxtiuMwx3w
On Wed, 06 Feb 2013 09:51:39 -0500, Rahul Sharma <rahul.sharma-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
> Binding Documents for drm-devices are placed in
> Documentation/devicetree/bindings/drm/*. But these devices are common
> for v4l framework, hence moved to a common place at
> Documentation/devicetree/bindings/video/. 'exynos_' prefix is added to
> associate them with exynos soc series.
>
> Signed-off-by: Rahul Sharma <rahul.sharma-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Applied, thanks.
A tip however, if you use the "-M" flag when posting patches it will
show the files as moved instead of delete the old copy and create a new.
It makes my life easier when that is done.
g.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ARM: dts: moving dt binding documents for video devices to common place
@ 2013-02-06 14:51 Rahul Sharma
[not found] ` <1360162299-8893-1-git-send-email-rahul.sharma-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
0 siblings, 1 reply; 5+ messages in thread
From: Rahul Sharma @ 2013-02-06 14:51 UTC (permalink / raw)
To: linux-samsung-soc, devicetree-discuss
Cc: dri-devel, kgene.kim, sw0312.kim, inki.dae, s.nawrocki, joshi, r.sh.open
Binding Documents for drm-devices are placed in
Documentation/devicetree/bindings/drm/*. But these devices are common
for v4l framework, hence moved to a common place at
Documentation/devicetree/bindings/video/. 'exynos_' prefix is added to
associate them with exynos soc series.
Signed-off-by: Rahul Sharma <rahul.sharma@samsung.com>
---
It is base on for-next branch of
git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git
.../devicetree/bindings/drm/exynos/hdmi.txt | 22 ----------------------
.../devicetree/bindings/drm/exynos/hdmiddc.txt | 12 ------------
.../devicetree/bindings/drm/exynos/hdmiphy.txt | 12 ------------
.../devicetree/bindings/drm/exynos/mixer.txt | 15 ---------------
.../devicetree/bindings/video/exynos_hdmi.txt | 22 ++++++++++++++++++++++
.../devicetree/bindings/video/exynos_hdmiddc.txt | 12 ++++++++++++
.../devicetree/bindings/video/exynos_hdmiphy.txt | 12 ++++++++++++
.../devicetree/bindings/video/exynos_mixer.txt | 15 +++++++++++++++
8 files changed, 61 insertions(+), 61 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/drm/exynos/hdmi.txt
delete mode 100644 Documentation/devicetree/bindings/drm/exynos/hdmiddc.txt
delete mode 100644 Documentation/devicetree/bindings/drm/exynos/hdmiphy.txt
delete mode 100644 Documentation/devicetree/bindings/drm/exynos/mixer.txt
create mode 100644 Documentation/devicetree/bindings/video/exynos_hdmi.txt
create mode 100644 Documentation/devicetree/bindings/video/exynos_hdmiddc.txt
create mode 100644 Documentation/devicetree/bindings/video/exynos_hdmiphy.txt
create mode 100644 Documentation/devicetree/bindings/video/exynos_mixer.txt
diff --git a/Documentation/devicetree/bindings/drm/exynos/hdmi.txt b/Documentation/devicetree/bindings/drm/exynos/hdmi.txt
deleted file mode 100644
index 589edee..0000000
--- a/Documentation/devicetree/bindings/drm/exynos/hdmi.txt
+++ /dev/null
@@ -1,22 +0,0 @@
-Device-Tree bindings for drm hdmi driver
-
-Required properties:
-- compatible: value should be "samsung,exynos5-hdmi".
-- reg: physical base address of the hdmi and length of memory mapped
- region.
-- interrupts: interrupt number to the cpu.
-- hpd-gpio: following information about the hotplug gpio pin.
- a) phandle of the gpio controller node.
- b) pin number within the gpio controller.
- c) pin function mode.
- d) optional flags and pull up/down.
- e) drive strength.
-
-Example:
-
- hdmi {
- compatible = "samsung,exynos5-hdmi";
- reg = <0x14530000 0x100000>;
- interrupts = <0 95 0>;
- hpd-gpio = <&gpx3 7 0xf 1 3>;
- };
diff --git a/Documentation/devicetree/bindings/drm/exynos/hdmiddc.txt b/Documentation/devicetree/bindings/drm/exynos/hdmiddc.txt
deleted file mode 100644
index fa166d9..0000000
--- a/Documentation/devicetree/bindings/drm/exynos/hdmiddc.txt
+++ /dev/null
@@ -1,12 +0,0 @@
-Device-Tree bindings for hdmiddc driver
-
-Required properties:
-- compatible: value should be "samsung,exynos5-hdmiddc".
-- reg: I2C address of the hdmiddc device.
-
-Example:
-
- hdmiddc {
- compatible = "samsung,exynos5-hdmiddc";
- reg = <0x50>;
- };
diff --git a/Documentation/devicetree/bindings/drm/exynos/hdmiphy.txt b/Documentation/devicetree/bindings/drm/exynos/hdmiphy.txt
deleted file mode 100644
index 858f4f9..0000000
--- a/Documentation/devicetree/bindings/drm/exynos/hdmiphy.txt
+++ /dev/null
@@ -1,12 +0,0 @@
-Device-Tree bindings for hdmiphy driver
-
-Required properties:
-- compatible: value should be "samsung,exynos5-hdmiphy".
-- reg: I2C address of the hdmiphy device.
-
-Example:
-
- hdmiphy {
- compatible = "samsung,exynos5-hdmiphy";
- reg = <0x38>;
- };
diff --git a/Documentation/devicetree/bindings/drm/exynos/mixer.txt b/Documentation/devicetree/bindings/drm/exynos/mixer.txt
deleted file mode 100644
index 9b2ea03..0000000
--- a/Documentation/devicetree/bindings/drm/exynos/mixer.txt
+++ /dev/null
@@ -1,15 +0,0 @@
-Device-Tree bindings for mixer driver
-
-Required properties:
-- compatible: value should be "samsung,exynos5-mixer".
-- reg: physical base address of the mixer and length of memory mapped
- region.
-- interrupts: interrupt number to the cpu.
-
-Example:
-
- mixer {
- compatible = "samsung,exynos5-mixer";
- reg = <0x14450000 0x10000>;
- interrupts = <0 94 0>;
- };
diff --git a/Documentation/devicetree/bindings/video/exynos_hdmi.txt b/Documentation/devicetree/bindings/video/exynos_hdmi.txt
new file mode 100644
index 0000000..589edee
--- /dev/null
+++ b/Documentation/devicetree/bindings/video/exynos_hdmi.txt
@@ -0,0 +1,22 @@
+Device-Tree bindings for drm hdmi driver
+
+Required properties:
+- compatible: value should be "samsung,exynos5-hdmi".
+- reg: physical base address of the hdmi and length of memory mapped
+ region.
+- interrupts: interrupt number to the cpu.
+- hpd-gpio: following information about the hotplug gpio pin.
+ a) phandle of the gpio controller node.
+ b) pin number within the gpio controller.
+ c) pin function mode.
+ d) optional flags and pull up/down.
+ e) drive strength.
+
+Example:
+
+ hdmi {
+ compatible = "samsung,exynos5-hdmi";
+ reg = <0x14530000 0x100000>;
+ interrupts = <0 95 0>;
+ hpd-gpio = <&gpx3 7 0xf 1 3>;
+ };
diff --git a/Documentation/devicetree/bindings/video/exynos_hdmiddc.txt b/Documentation/devicetree/bindings/video/exynos_hdmiddc.txt
new file mode 100644
index 0000000..fa166d9
--- /dev/null
+++ b/Documentation/devicetree/bindings/video/exynos_hdmiddc.txt
@@ -0,0 +1,12 @@
+Device-Tree bindings for hdmiddc driver
+
+Required properties:
+- compatible: value should be "samsung,exynos5-hdmiddc".
+- reg: I2C address of the hdmiddc device.
+
+Example:
+
+ hdmiddc {
+ compatible = "samsung,exynos5-hdmiddc";
+ reg = <0x50>;
+ };
diff --git a/Documentation/devicetree/bindings/video/exynos_hdmiphy.txt b/Documentation/devicetree/bindings/video/exynos_hdmiphy.txt
new file mode 100644
index 0000000..858f4f9
--- /dev/null
+++ b/Documentation/devicetree/bindings/video/exynos_hdmiphy.txt
@@ -0,0 +1,12 @@
+Device-Tree bindings for hdmiphy driver
+
+Required properties:
+- compatible: value should be "samsung,exynos5-hdmiphy".
+- reg: I2C address of the hdmiphy device.
+
+Example:
+
+ hdmiphy {
+ compatible = "samsung,exynos5-hdmiphy";
+ reg = <0x38>;
+ };
diff --git a/Documentation/devicetree/bindings/video/exynos_mixer.txt b/Documentation/devicetree/bindings/video/exynos_mixer.txt
new file mode 100644
index 0000000..9b2ea03
--- /dev/null
+++ b/Documentation/devicetree/bindings/video/exynos_mixer.txt
@@ -0,0 +1,15 @@
+Device-Tree bindings for mixer driver
+
+Required properties:
+- compatible: value should be "samsung,exynos5-mixer".
+- reg: physical base address of the mixer and length of memory mapped
+ region.
+- interrupts: interrupt number to the cpu.
+
+Example:
+
+ mixer {
+ compatible = "samsung,exynos5-mixer";
+ reg = <0x14450000 0x10000>;
+ interrupts = <0 94 0>;
+ };
--
1.8.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-03-04 3:51 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-06 14:57 [PATCH] ARM: dts: moving dt binding documents for video devices to common place Rahul Sharma
2013-02-06 14:50 ` Sylwester Nawrocki
2013-02-07 3:10 ` Rahul Sharma
-- strict thread matches above, loose matches on Subject: below --
2013-02-06 14:51 Rahul Sharma
[not found] ` <1360162299-8893-1-git-send-email-rahul.sharma-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-03-04 3:51 ` Grant Likely
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.