From: Ben Greear <greearb@candelatech.com> To: Cong Ding <dinggnu@gmail.com> Cc: Johannes Berg <johannes@sipsolutions.net>, "John W. Linville" <linville@tuxdriver.com>, "David S. Miller" <davem@davemloft.net>, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: mac80211/cfg.c: fix error using of sizeof() Date: Wed, 06 Feb 2013 09:58:18 -0800 [thread overview] Message-ID: <511299BA.905@candelatech.com> (raw) In-Reply-To: <1360167826-29265-1-git-send-email-dinggnu@gmail.com> On 02/06/2013 08:23 AM, Cong Ding wrote: > Using 'sizeof' on array given as function argument returns size of a pointer > rather than the size of array. > > Signed-off-by: Cong Ding <dinggnu@gmail.com> > --- > net/mac80211/cfg.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/net/mac80211/cfg.c b/net/mac80211/cfg.c > index 661b878..af561d5 100644 > --- a/net/mac80211/cfg.c > +++ b/net/mac80211/cfg.c > @@ -2058,7 +2058,8 @@ static int ieee80211_set_mcast_rate(struct wiphy *wiphy, struct net_device *dev, > { > struct ieee80211_sub_if_data *sdata = IEEE80211_DEV_TO_SUB_IF(dev); > > - memcpy(sdata->vif.bss_conf.mcast_rate, rate, sizeof(rate)); > + memcpy(sdata->vif.bss_conf.mcast_rate, rate, > + sizeof(int) * IEEE80211_NUM_BANDS); Should it perhaps be: sizeof(*rate) * IEEE80211_NUM_BANDS just in case the type ever changes? Thanks, Ben > > return 0; > } > -- Ben Greear <greearb@candelatech.com> Candela Technologies Inc http://www.candelatech.com
WARNING: multiple messages have this Message-ID (diff)
From: Ben Greear <greearb-my8/4N5VtI7c+919tysfdA@public.gmane.org> To: Cong Ding <dinggnu-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Cc: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>, "John W. Linville" <linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>, "David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>, linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: Re: [PATCH] net: mac80211/cfg.c: fix error using of sizeof() Date: Wed, 06 Feb 2013 09:58:18 -0800 [thread overview] Message-ID: <511299BA.905@candelatech.com> (raw) In-Reply-To: <1360167826-29265-1-git-send-email-dinggnu-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> On 02/06/2013 08:23 AM, Cong Ding wrote: > Using 'sizeof' on array given as function argument returns size of a pointer > rather than the size of array. > > Signed-off-by: Cong Ding <dinggnu-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > --- > net/mac80211/cfg.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/net/mac80211/cfg.c b/net/mac80211/cfg.c > index 661b878..af561d5 100644 > --- a/net/mac80211/cfg.c > +++ b/net/mac80211/cfg.c > @@ -2058,7 +2058,8 @@ static int ieee80211_set_mcast_rate(struct wiphy *wiphy, struct net_device *dev, > { > struct ieee80211_sub_if_data *sdata = IEEE80211_DEV_TO_SUB_IF(dev); > > - memcpy(sdata->vif.bss_conf.mcast_rate, rate, sizeof(rate)); > + memcpy(sdata->vif.bss_conf.mcast_rate, rate, > + sizeof(int) * IEEE80211_NUM_BANDS); Should it perhaps be: sizeof(*rate) * IEEE80211_NUM_BANDS just in case the type ever changes? Thanks, Ben > > return 0; > } > -- Ben Greear <greearb-my8/4N5VtI7c+919tysfdA@public.gmane.org> Candela Technologies Inc http://www.candelatech.com -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-02-06 17:58 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-02-06 16:23 [PATCH] net: mac80211/cfg.c: fix error using of sizeof() Cong Ding 2013-02-06 16:27 ` Johannes Berg 2013-02-06 17:54 ` Ben Greear 2013-02-06 17:59 ` Ben Greear 2013-02-06 17:58 ` Ben Greear [this message] 2013-02-06 17:58 ` Ben Greear 2013-02-06 18:33 ` David Miller 2013-02-06 19:28 ` Johannes Berg
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=511299BA.905@candelatech.com \ --to=greearb@candelatech.com \ --cc=davem@davemloft.net \ --cc=dinggnu@gmail.com \ --cc=johannes@sipsolutions.net \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-wireless@vger.kernel.org \ --cc=linville@tuxdriver.com \ --cc=netdev@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.