From: Stephen Warren <swarren@wwwdotorg.org> To: Sylwester Nawrocki <s.nawrocki@samsung.com> Cc: linux-media@vger.kernel.org, kyungmin.park@samsung.com, kgene.kim@samsung.com, rob.herring@calxeda.com, prabhakar.lad@ti.com, devicetree-discuss@lists.ozlabs.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 02/10] s5p-fimc: Add device tree support for FIMC devices Date: Wed, 06 Feb 2013 16:40:31 -0700 [thread overview] Message-ID: <5112E9EF.8090908@wwwdotorg.org> (raw) In-Reply-To: <1359745771-23684-3-git-send-email-s.nawrocki@samsung.com> On 02/01/2013 12:09 PM, Sylwester Nawrocki wrote: > This patch adds support for FIMC devices instantiated from devicetree > for S5PV210 and Exynos4 SoCs. The FIMC IP features include colorspace > conversion and scaling (mem-to-mem) and parallel/MIPI CSI2 bus video > capture interface. > > Multiple SoC revisions specific parameters are defined statically in > the driver and are used for both dt and non-dt. The driver's static > data is selected based on the compatible property. Previously the > platform device name was used to match driver data and a specific > SoC/IP version. > > Aliases are used to determine an index of the IP which is essential > for linking FIMC IP with other entities, like MIPI-CSIS (the MIPI > CSI-2 bus frontend) or FIMC-LITE and FIMC-IS ISP. > diff --git a/Documentation/devicetree/bindings/media/soc/samsung-fimc.txt b/Documentation/devicetree/bindings/media/soc/samsung-fimc.txt > +Samsung S5P/EXYNOS SoC Camera Subsystem (FIMC) > +---------------------------------------------- > + > +The Exynos Camera subsystem comprises of multiple sub-devices that are > +represented by separate platform devices. Some of the IPs come in different "platform devices" is a rather Linux-centric term, and DT bindings should be OS-agnostic. Perhaps use "device tree nodes" here? > +variants across the SoC revisions (FIMC) and some remain mostly unchanged > +(MIPI CSIS, FIMC-LITE). > + > +All those sub-subdevices are defined as parent nodes of the common device s/parent nodes/child node/ I think? > +For every fimc node a numbered alias should be present in the aliases node. > +Aliases are of the form fimc<n>, where <n> is an integer (0...N) specifying > +the IP's instance index. Why? Isn't it up to the DT author whether they care if each fimc node is assigned a specific identification v.s. whether identification is assigned automatically? > +Optional properties > + > + - clock-frequency - maximum FIMC local clock (LCLK) frequency Again, I'd expect a clocks property here instead.
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v4 02/10] s5p-fimc: Add device tree support for FIMC devices Date: Wed, 06 Feb 2013 16:40:31 -0700 [thread overview] Message-ID: <5112E9EF.8090908@wwwdotorg.org> (raw) In-Reply-To: <1359745771-23684-3-git-send-email-s.nawrocki@samsung.com> On 02/01/2013 12:09 PM, Sylwester Nawrocki wrote: > This patch adds support for FIMC devices instantiated from devicetree > for S5PV210 and Exynos4 SoCs. The FIMC IP features include colorspace > conversion and scaling (mem-to-mem) and parallel/MIPI CSI2 bus video > capture interface. > > Multiple SoC revisions specific parameters are defined statically in > the driver and are used for both dt and non-dt. The driver's static > data is selected based on the compatible property. Previously the > platform device name was used to match driver data and a specific > SoC/IP version. > > Aliases are used to determine an index of the IP which is essential > for linking FIMC IP with other entities, like MIPI-CSIS (the MIPI > CSI-2 bus frontend) or FIMC-LITE and FIMC-IS ISP. > diff --git a/Documentation/devicetree/bindings/media/soc/samsung-fimc.txt b/Documentation/devicetree/bindings/media/soc/samsung-fimc.txt > +Samsung S5P/EXYNOS SoC Camera Subsystem (FIMC) > +---------------------------------------------- > + > +The Exynos Camera subsystem comprises of multiple sub-devices that are > +represented by separate platform devices. Some of the IPs come in different "platform devices" is a rather Linux-centric term, and DT bindings should be OS-agnostic. Perhaps use "device tree nodes" here? > +variants across the SoC revisions (FIMC) and some remain mostly unchanged > +(MIPI CSIS, FIMC-LITE). > + > +All those sub-subdevices are defined as parent nodes of the common device s/parent nodes/child node/ I think? > +For every fimc node a numbered alias should be present in the aliases node. > +Aliases are of the form fimc<n>, where <n> is an integer (0...N) specifying > +the IP's instance index. Why? Isn't it up to the DT author whether they care if each fimc node is assigned a specific identification v.s. whether identification is assigned automatically? > +Optional properties > + > + - clock-frequency - maximum FIMC local clock (LCLK) frequency Again, I'd expect a clocks property here instead.
next prev parent reply other threads:[~2013-02-06 23:40 UTC|newest] Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-02-01 19:09 [PATCH v4 00/10] Device tree support for Exynos SoC camera subsystem Sylwester Nawrocki 2013-02-01 19:09 ` Sylwester Nawrocki 2013-02-01 19:09 ` [PATCH v4 01/10] s5p-csis: Add device tree support Sylwester Nawrocki 2013-02-01 19:09 ` Sylwester Nawrocki 2013-02-06 23:36 ` Stephen Warren 2013-02-06 23:36 ` Stephen Warren 2013-02-08 22:29 ` Sylwester Nawrocki 2013-02-08 22:29 ` Sylwester Nawrocki 2013-02-08 23:27 ` Stephen Warren 2013-02-08 23:27 ` Stephen Warren 2013-02-09 0:31 ` Sylwester Nawrocki 2013-02-09 0:31 ` Sylwester Nawrocki 2013-02-01 19:09 ` [PATCH v4 02/10] s5p-fimc: Add device tree support for FIMC devices Sylwester Nawrocki 2013-02-01 19:09 ` Sylwester Nawrocki 2013-02-06 23:40 ` Stephen Warren [this message] 2013-02-06 23:40 ` Stephen Warren 2013-02-08 23:16 ` Sylwester Nawrocki 2013-02-08 23:16 ` Sylwester Nawrocki 2013-02-08 23:21 ` Stephen Warren 2013-02-08 23:21 ` Stephen Warren 2013-02-09 0:05 ` Sylwester Nawrocki 2013-02-09 0:05 ` Sylwester Nawrocki 2013-02-09 0:32 ` Stephen Warren 2013-02-09 0:32 ` Stephen Warren 2013-02-09 22:29 ` Sylwester Nawrocki 2013-02-09 22:29 ` Sylwester Nawrocki 2013-02-09 22:52 ` Sylwester Nawrocki 2013-02-09 22:52 ` Sylwester Nawrocki 2013-02-11 21:50 ` Stephen Warren 2013-02-11 21:50 ` Stephen Warren 2013-02-12 22:39 ` Sylwester Nawrocki 2013-02-12 22:39 ` Sylwester Nawrocki 2013-02-13 20:42 ` Stephen Warren 2013-02-13 20:42 ` Stephen Warren 2013-02-14 23:03 ` Sylwester Nawrocki 2013-02-14 23:03 ` Sylwester Nawrocki 2013-02-01 19:09 ` [PATCH v4 03/10] s5p-fimc: Add device tree support for FIMC-LITE devices Sylwester Nawrocki 2013-02-01 19:09 ` Sylwester Nawrocki 2013-02-01 19:09 ` [PATCH v4 04/10] s5p-fimc: Add device tree support for the main media device driver Sylwester Nawrocki 2013-02-01 19:09 ` Sylwester Nawrocki 2013-02-01 19:09 ` [PATCH v4 05/10] s5p-fimc: Add device tree based sensors registration Sylwester Nawrocki 2013-02-01 19:09 ` Sylwester Nawrocki 2013-02-06 23:42 ` Stephen Warren 2013-02-06 23:42 ` Stephen Warren 2013-02-08 23:26 ` Sylwester Nawrocki 2013-02-08 23:26 ` Sylwester Nawrocki 2013-02-01 19:09 ` [PATCH v4 06/10] s5p-fimc: Use pinctrl API for camera ports configuration Sylwester Nawrocki 2013-02-01 19:09 ` Sylwester Nawrocki 2013-02-06 23:44 ` Stephen Warren 2013-02-06 23:44 ` Stephen Warren 2013-02-08 23:30 ` Sylwester Nawrocki 2013-02-08 23:30 ` Sylwester Nawrocki 2013-02-01 19:09 ` [PATCH v4 07/10] ARM: dts: Add camera to node exynos4.dtsi Sylwester Nawrocki 2013-02-01 19:09 ` Sylwester Nawrocki 2013-02-01 19:09 ` [PATCH v4 08/10] ARM: dts: Add ISP power domain node for Exynos4x12 Sylwester Nawrocki 2013-02-01 19:09 ` Sylwester Nawrocki 2013-02-01 19:09 ` [PATCH v4 09/10] ARM: dts: Add FIMC and MIPI CSIS device nodes " Sylwester Nawrocki 2013-02-01 19:09 ` Sylwester Nawrocki 2013-02-01 19:09 ` [PATCH v4 10/10] ARM: dts: Correct camera pinctrl nodes for Exynos4x12 SoCs Sylwester Nawrocki 2013-02-01 19:09 ` Sylwester Nawrocki
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5112E9EF.8090908@wwwdotorg.org \ --to=swarren@wwwdotorg.org \ --cc=devicetree-discuss@lists.ozlabs.org \ --cc=kgene.kim@samsung.com \ --cc=kyungmin.park@samsung.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-media@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=prabhakar.lad@ti.com \ --cc=rob.herring@calxeda.com \ --cc=s.nawrocki@samsung.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.