All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Yury Norov <ynorov@caviumnetworks.com>
Cc: catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, pinskia@gmail.com,
	Prasun.Kapoor@caviumnetworks.com, schwab@suse.de,
	Nathan_Lynch@mentor.com, agraf@suse.de, klimov.linux@gmail.com,
	broonie@kernel.org, jan.dakinevich@gmail.com,
	ddaney.cavm@gmail.com, bamvor.zhangjian@huawei.com,
	philipp.tomsich@theobroma-systems.com, joseph@codesourcery.com,
	christoph.muellner@theobroma-systems.com
Subject: Re: [PATCH v6 11/21] arm64: ilp32: introduce binfmt_ilp32.c
Date: Fri, 08 Jan 2016 10:08:44 +0100	[thread overview]
Message-ID: <5115829.mX1Uk4EoYk@wuerfel> (raw)
In-Reply-To: <1452209679-19445-12-git-send-email-ynorov@caviumnetworks.com>

On Friday 08 January 2016 02:34:29 Yury Norov wrote:
> +
> +#include "../../../fs/compat_binfmt_elf.c"
> 

This is the wrong file, you have to include fs/binfmt_elf.c, otherwise
you pick up the same definitions that you have for the other one.

Alternatively, you can also change binfmt_elf32.c to include fs/binfmt_elf.c
and use fs/compat_binfmt_elf.c here if that makes the code nicer, you
just can use the compat file for both or things get ugly because of
the extra indirections.

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 11/21] arm64: ilp32: introduce binfmt_ilp32.c
Date: Fri, 08 Jan 2016 10:08:44 +0100	[thread overview]
Message-ID: <5115829.mX1Uk4EoYk@wuerfel> (raw)
In-Reply-To: <1452209679-19445-12-git-send-email-ynorov@caviumnetworks.com>

On Friday 08 January 2016 02:34:29 Yury Norov wrote:
> +
> +#include "../../../fs/compat_binfmt_elf.c"
> 

This is the wrong file, you have to include fs/binfmt_elf.c, otherwise
you pick up the same definitions that you have for the other one.

Alternatively, you can also change binfmt_elf32.c to include fs/binfmt_elf.c
and use fs/compat_binfmt_elf.c here if that makes the code nicer, you
just can use the compat file for both or things get ugly because of
the extra indirections.

	Arnd

  parent reply	other threads:[~2016-01-08  9:09 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-07 23:34 [RFC4 PATCH v6 00/21] ILP32 for ARM64 Yury Norov
2016-01-07 23:34 ` Yury Norov
2016-01-07 23:34 ` [PATCH v6 01/21] arm64: ilp32: add documentation on the ILP32 ABI " Yury Norov
2016-01-07 23:34   ` Yury Norov
2016-01-07 23:34 ` [PATCH v6 02/21] arm64: ensure the kernel is compiled for LP64 Yury Norov
2016-01-07 23:34   ` Yury Norov
2016-01-07 23:34 ` [PATCH v6 03/21] arm64: rename COMPAT to AARCH32_EL0 in Kconfig Yury Norov
2016-01-07 23:34   ` Yury Norov
2016-01-07 23:34 ` [PATCH v6 04/21] arm64: change some CONFIG_COMPAT over to use CONFIG_AARCH32_EL0 instead Yury Norov
2016-01-07 23:34   ` Yury Norov
2016-01-07 23:34 ` [PATCH v6 05/21] arm64: compat: fix wrong dependency Yury Norov
2016-01-07 23:34   ` Yury Norov
2016-01-08  8:49   ` Arnd Bergmann
2016-01-08  8:49     ` Arnd Bergmann
2016-01-07 23:34 ` [PATCH v6 06/21] arm64:uapi: set __BITS_PER_LONG correctly for ILP32 and LP64 Yury Norov
2016-01-07 23:34   ` Yury Norov
2016-01-07 23:34 ` [PATCH v6 07/21] thread: move thread bits accessors to separated file Yury Norov
2016-01-07 23:34   ` Yury Norov
2016-01-07 23:34 ` [PATCH v6 08/21] arm64: introduce is_a32_task and is_a32_thread (for AArch32 compat) Yury Norov
2016-01-07 23:34   ` Yury Norov
2016-01-07 23:34 ` [PATCH v6 09/21] arm64: ilp32: add is_ilp32_compat_{task,thread} and TIF_32BIT_AARCH64 Yury Norov
2016-01-07 23:34   ` [PATCH v6 09/21] arm64: ilp32: add is_ilp32_compat_{task, thread} " Yury Norov
2016-01-07 23:34 ` [PATCH v6 10/21] arm64: introduce binfmt_elf32.c Yury Norov
2016-01-07 23:34   ` Yury Norov
2016-01-07 23:34 ` [PATCH v6 11/21] arm64: ilp32: introduce binfmt_ilp32.c Yury Norov
2016-01-07 23:34   ` Yury Norov
2016-01-07 23:45   ` Yury Norov
2016-01-07 23:45     ` Yury Norov
2016-01-08  9:08   ` Arnd Bergmann [this message]
2016-01-08  9:08     ` Arnd Bergmann
2016-01-12 16:46     ` Yury Norov
2016-01-12 16:46       ` Yury Norov
2016-01-12 23:05       ` Arnd Bergmann
2016-01-12 23:05         ` Arnd Bergmann
2016-01-07 23:34 ` [PATCH v6 12/21] arm64:ilp32: share HWCAP between LP64 and ILP32 Yury Norov
2016-01-07 23:34   ` Yury Norov
2016-01-08  8:58   ` Arnd Bergmann
2016-01-08  8:58     ` Arnd Bergmann
2016-01-07 23:34 ` [PATCH v6 13/21] arm64: ptrace: handle ptrace_request differently for aarch32 and ilp32 Yury Norov
2016-01-07 23:34   ` Yury Norov
2016-01-08  9:01   ` Arnd Bergmann
2016-01-08  9:01     ` Arnd Bergmann
2016-01-07 23:34 ` [PATCH v6 14/21] arm64:ilp32: add sys_ilp32.c and a separate table (in entry.S) to use it Yury Norov
2016-01-07 23:34   ` Yury Norov
2016-01-08  9:04   ` Arnd Bergmann
2016-01-08  9:04     ` Arnd Bergmann
2016-01-08  9:21   ` Arnd Bergmann
2016-01-08  9:21     ` Arnd Bergmann
2016-01-08 11:13     ` Yury Norov
2016-01-08 11:13       ` Yury Norov
2016-01-08 16:45       ` Arnd Bergmann
2016-01-08 16:45         ` Arnd Bergmann
2016-01-13 16:21     ` Yury Norov
2016-01-13 16:21       ` Yury Norov
2016-01-07 23:34 ` [PATCH v6 15/21] arm64: signal: wrap struct ucontext, fp and lr with struct sigframe Yury Norov
2016-01-07 23:34   ` Yury Norov
2016-01-07 23:34 ` [PATCH v6 16/21] arm64: signal: share lp64 signal routines to ilp32 Yury Norov
2016-01-07 23:34   ` Yury Norov
2016-01-07 23:34 ` [PATCH v6 17/21] arm64: signal32: move ilp32 and aarch32 common code to separated file Yury Norov
2016-01-07 23:34   ` Yury Norov
2016-01-07 23:34 ` [PATCH v6 18/21] arm64: ilp32: introduce ilp32-specific handlers for sigframe Yury Norov
2016-01-07 23:34   ` Yury Norov
2016-01-07 23:34 ` [PATCH v6 19/21] arm64:ilp32: add vdso-ilp32 and use for signal return Yury Norov
2016-01-07 23:34   ` Yury Norov
2016-01-07 23:34 ` [PATCH v6 20/21] arm64:ilp32: change COMPAT_ELF_PLATFORM to report a a subplatform for ILP32 Yury Norov
2016-01-07 23:34   ` Yury Norov
2016-01-08  9:05   ` Arnd Bergmann
2016-01-08  9:05     ` Arnd Bergmann
2016-01-07 23:34 ` [PATCH v6 21/21] arm64:ilp32: add ARM64_ILP32 to Kconfig Yury Norov
2016-01-07 23:34   ` Yury Norov
2016-01-14 17:22 [RFC5 PATCH v6 00/21] ILP32 for ARM64 Yury Norov
2016-01-14 17:23 ` [PATCH v6 11/21] arm64: ilp32: introduce binfmt_ilp32.c Yury Norov
2016-01-14 17:23   ` Yury Norov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5115829.mX1Uk4EoYk@wuerfel \
    --to=arnd@arndb.de \
    --cc=Nathan_Lynch@mentor.com \
    --cc=Prasun.Kapoor@caviumnetworks.com \
    --cc=agraf@suse.de \
    --cc=bamvor.zhangjian@huawei.com \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=christoph.muellner@theobroma-systems.com \
    --cc=ddaney.cavm@gmail.com \
    --cc=jan.dakinevich@gmail.com \
    --cc=joseph@codesourcery.com \
    --cc=klimov.linux@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=philipp.tomsich@theobroma-systems.com \
    --cc=pinskia@gmail.com \
    --cc=schwab@suse.de \
    --cc=ynorov@caviumnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.