From: Josh Wu <josh.wu@atmel.com> To: Olof Johansson <olof@lixom.net> Cc: Arnd Bergmann <arnd@arndb.de>, Artem Bityutskiy <dedekind1@gmail.com>, Nicolas Ferre <nicolas.ferre@atmel.com>, linux-mtd@lists.infradead.org, plagnioj@jcrosoft.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 0/5 v3] at91: PMECC: enable PMECC in dt for at91sam9x5ek, at91sam9n12ek Date: Mon, 11 Feb 2013 11:44:01 +0800 [thread overview] Message-ID: <51186901.9060400@atmel.com> (raw) In-Reply-To: <20130210004010.GE16278@quad.lixom.net> Hi, Olof On 2/10/2013 8:40 AM, Olof Johansson wrote: > On Thu, Feb 07, 2013 at 05:16:07PM +0100, Nicolas Ferre wrote: >> On 01/23/2013 01:47 PM, Josh Wu : >>> Those patches will enable PMECC in dt parameters for at91sam9x5ek and >>> at91sam9n12ek. >>> >>> The PMECC driver will check minimum required ecc on ONFI parameter from NAND >>> flash. >>> >>> If pmecc-cap, pmecc-sector-size in dts file is specified, use those two. >>> otherwise, set those according to NAND flash ONFI parameters. >>> >>> If the pmecc-cap, pmecc-sector-size in dts are different with ecc requirement >>> in ONFI, print out a warning. >>> >>> >>> For the following compile error: >>> ERROR (phandle_references): Reference to non-existent node or label "pinctrl_ssc0_tx" >>> >>> ERROR: Input tree has errors, aborting (use -f to force output) >>> make[2]: *** [arch/arm/boot/dts/at91sam9g20ek.dtb] Error 2 >>> >>> the fixes are already merged in Linux mainline in v3.8-rc4. >>> you can find in: >>> 544ae6b2e676c3c37fb8c93ef9327932fc2e5bc2 (ARM: at91/dts: add pinctrl support for SSC peripheral) >>> ea03c81521bde526570e1dec96eaa21fe5ac84a2 (ASoC: atmel-ssc: add pinctrl selection to driver) >> Artem, >> >> I propose to take patches 2 and 3/5 of this series via arm-soc git tree. >> I will specify to merge them at the end of the merge-window so that the >> Device Tree properties will not be out-of-sync with driver modifications >> (may not cause big issues anyway). > I'm not cc:d on the patches, but if it's just new properties then there's > no reason to hold off to "late in the merge window". There's actually no > way for you to hold that off yourself, since we won't accept new patches > to arm-soc that late. > > I don't see any cc to devicetree-discuss of the device tree bindings > though, and no update of Documentation/device-tree/bindings/, so the > patches are not ready to go in yet. Since in my commit: a41b51a1f7c15a1b00f30a3ad2d0373ad51b883d (mtd: at91: add dt parameters for Atmel PMECC), it already added following properties to DT documentation: atmel,pmecc-cap atmel,pmecc-sector-size atmel,pmecc-lookup-table-offset so in this patches series, NO. 2 and 3 just add it to at91 board's dts file according to the DT documentation. Indeed, this patch series make a little bit different from the DT documentation, that is: the ROM code mapping size are smaller than the DT documentation example. But original DT documentation example still works. So I think the DT documentation's explanation are proper for this patch series. It seems I don't have to update the DT documentation so far. > > > -Olof Best Regards, Josh Wu
WARNING: multiple messages have this Message-ID (diff)
From: josh.wu@atmel.com (Josh Wu) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 0/5 v3] at91: PMECC: enable PMECC in dt for at91sam9x5ek, at91sam9n12ek Date: Mon, 11 Feb 2013 11:44:01 +0800 [thread overview] Message-ID: <51186901.9060400@atmel.com> (raw) In-Reply-To: <20130210004010.GE16278@quad.lixom.net> Hi, Olof On 2/10/2013 8:40 AM, Olof Johansson wrote: > On Thu, Feb 07, 2013 at 05:16:07PM +0100, Nicolas Ferre wrote: >> On 01/23/2013 01:47 PM, Josh Wu : >>> Those patches will enable PMECC in dt parameters for at91sam9x5ek and >>> at91sam9n12ek. >>> >>> The PMECC driver will check minimum required ecc on ONFI parameter from NAND >>> flash. >>> >>> If pmecc-cap, pmecc-sector-size in dts file is specified, use those two. >>> otherwise, set those according to NAND flash ONFI parameters. >>> >>> If the pmecc-cap, pmecc-sector-size in dts are different with ecc requirement >>> in ONFI, print out a warning. >>> >>> >>> For the following compile error: >>> ERROR (phandle_references): Reference to non-existent node or label "pinctrl_ssc0_tx" >>> >>> ERROR: Input tree has errors, aborting (use -f to force output) >>> make[2]: *** [arch/arm/boot/dts/at91sam9g20ek.dtb] Error 2 >>> >>> the fixes are already merged in Linux mainline in v3.8-rc4. >>> you can find in: >>> 544ae6b2e676c3c37fb8c93ef9327932fc2e5bc2 (ARM: at91/dts: add pinctrl support for SSC peripheral) >>> ea03c81521bde526570e1dec96eaa21fe5ac84a2 (ASoC: atmel-ssc: add pinctrl selection to driver) >> Artem, >> >> I propose to take patches 2 and 3/5 of this series via arm-soc git tree. >> I will specify to merge them at the end of the merge-window so that the >> Device Tree properties will not be out-of-sync with driver modifications >> (may not cause big issues anyway). > I'm not cc:d on the patches, but if it's just new properties then there's > no reason to hold off to "late in the merge window". There's actually no > way for you to hold that off yourself, since we won't accept new patches > to arm-soc that late. > > I don't see any cc to devicetree-discuss of the device tree bindings > though, and no update of Documentation/device-tree/bindings/, so the > patches are not ready to go in yet. Since in my commit: a41b51a1f7c15a1b00f30a3ad2d0373ad51b883d (mtd: at91: add dt parameters for Atmel PMECC), it already added following properties to DT documentation: atmel,pmecc-cap atmel,pmecc-sector-size atmel,pmecc-lookup-table-offset so in this patches series, NO. 2 and 3 just add it to at91 board's dts file according to the DT documentation. Indeed, this patch series make a little bit different from the DT documentation, that is: the ROM code mapping size are smaller than the DT documentation example. But original DT documentation example still works. So I think the DT documentation's explanation are proper for this patch series. It seems I don't have to update the DT documentation so far. > > > -Olof Best Regards, Josh Wu
next prev parent reply other threads:[~2013-02-11 3:44 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-01-23 12:47 [PATCH 0/5 v3] at91: PMECC: enable PMECC in dt for at91sam9x5ek, at91sam9n12ek Josh Wu 2013-01-23 12:47 ` Josh Wu 2013-01-23 12:47 ` [PATCH 1/5] MTD: atmel_nand: avoid to report an error when lookup table offset is 0 Josh Wu 2013-01-23 12:47 ` Josh Wu 2013-01-23 12:47 ` [PATCH 2/5] ARM: at91: at91sam9x5: add DT parameters to enable PMECC Josh Wu 2013-01-23 12:47 ` Josh Wu 2013-01-23 12:47 ` [PATCH 3/5] ARM: at91: at91sam9n12: " Josh Wu 2013-01-23 12:47 ` Josh Wu 2013-01-23 12:47 ` [PATCH 4/5] MTD: atmel_nand: make pmecc-cap, pmecc-sector-size in dts is optional Josh Wu 2013-01-23 12:47 ` Josh Wu 2013-01-23 12:47 ` [PATCH 5/5] MTD: at91: atmel_nand: for PMECC, add code to check the ONFI parameter ECC requirement Josh Wu 2013-01-23 12:47 ` Josh Wu 2013-02-07 3:04 ` [PATCH 0/5 v3] at91: PMECC: enable PMECC in dt for at91sam9x5ek, at91sam9n12ek Josh Wu 2013-02-07 3:04 ` Josh Wu 2013-02-07 16:16 ` Nicolas Ferre 2013-02-07 16:16 ` Nicolas Ferre 2013-02-08 16:57 ` Jean-Christophe PLAGNIOL-VILLARD 2013-02-08 16:57 ` Jean-Christophe PLAGNIOL-VILLARD 2013-02-10 0:40 ` Olof Johansson 2013-02-10 0:40 ` Olof Johansson 2013-02-11 3:44 ` Josh Wu [this message] 2013-02-11 3:44 ` Josh Wu 2013-02-12 15:01 ` Artem Bityutskiy 2013-02-12 15:01 ` Artem Bityutskiy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=51186901.9060400@atmel.com \ --to=josh.wu@atmel.com \ --cc=arnd@arndb.de \ --cc=dedekind1@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-mtd@lists.infradead.org \ --cc=nicolas.ferre@atmel.com \ --cc=olof@lixom.net \ --cc=plagnioj@jcrosoft.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.