[PATCH] platform/x86: pcengines-apuv2: Add missing terminating entries to gpio-lookup tables

[PATCH] platform/x86: pcengines-apuv2: Add missing terminating entries to gpio-lookup tables

[Hans de Goede]

The gpiod_lookup_table.table passed to gpiod_add_lookup_table() must
be terminated with an empty entry, add this.

Note we have likely been getting away with this not being present because
the GPIO lookup code first matches on the dev_id, causing most lookups to
skip checking the table and the lookups which do check the table will
find a matching entry before reaching the end. With that said, terminating
these tables properly still is obviously the correct thing to do.

Fixes: f8eb0235f659 ("x86: pcengines apuv2 gpio/leds/keys platform driver")
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/platform/x86/pcengines-apuv2.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/platform/x86/pcengines-apuv2.c b/drivers/platform/x86/pcengines-apuv2.c
index c37349f97bb8..d063d91db9bc 100644
--- a/drivers/platform/x86/pcengines-apuv2.c
+++ b/drivers/platform/x86/pcengines-apuv2.c
@@ -94,6 +94,7 @@ static struct gpiod_lookup_table gpios_led_table = {
 				NULL, 1, GPIO_ACTIVE_LOW),
 		GPIO_LOOKUP_IDX(AMD_FCH_GPIO_DRIVER_NAME, APU2_GPIO_LINE_LED3,
 				NULL, 2, GPIO_ACTIVE_LOW),
+		{} /* Terminating entry */
 	}
 };
 
@@ -123,6 +124,7 @@ static struct gpiod_lookup_table gpios_key_table = {
 	.table = {
 		GPIO_LOOKUP_IDX(AMD_FCH_GPIO_DRIVER_NAME, APU2_GPIO_LINE_MODESW,
 				NULL, 0, GPIO_ACTIVE_LOW),
+		{} /* Terminating entry */
 	}
 };
 
-- 
2.31.1

Re: [PATCH] platform/x86: pcengines-apuv2: Add missing terminating entries to gpio-lookup tables

[Hans de Goede]

Hi,

On 8/6/21 1:55 PM, Hans de Goede wrote:
> The gpiod_lookup_table.table passed to gpiod_add_lookup_table() must
> be terminated with an empty entry, add this.
> 
> Note we have likely been getting away with this not being present because
> the GPIO lookup code first matches on the dev_id, causing most lookups to
> skip checking the table and the lookups which do check the table will
> find a matching entry before reaching the end. With that said, terminating
> these tables properly still is obviously the correct thing to do.
> 
> Fixes: f8eb0235f659 ("x86: pcengines apuv2 gpio/leds/keys platform driver")
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

I've added this to my review-hans and the pdx86/fixes branches now.

Regards,

Hans


> ---
>  drivers/platform/x86/pcengines-apuv2.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/platform/x86/pcengines-apuv2.c b/drivers/platform/x86/pcengines-apuv2.c
> index c37349f97bb8..d063d91db9bc 100644
> --- a/drivers/platform/x86/pcengines-apuv2.c
> +++ b/drivers/platform/x86/pcengines-apuv2.c
> @@ -94,6 +94,7 @@ static struct gpiod_lookup_table gpios_led_table = {
>  				NULL, 1, GPIO_ACTIVE_LOW),
>  		GPIO_LOOKUP_IDX(AMD_FCH_GPIO_DRIVER_NAME, APU2_GPIO_LINE_LED3,
>  				NULL, 2, GPIO_ACTIVE_LOW),
> +		{} /* Terminating entry */
>  	}
>  };
>  
> @@ -123,6 +124,7 @@ static struct gpiod_lookup_table gpios_key_table = {
>  	.table = {
>  		GPIO_LOOKUP_IDX(AMD_FCH_GPIO_DRIVER_NAME, APU2_GPIO_LINE_MODESW,
>  				NULL, 0, GPIO_ACTIVE_LOW),
> +		{} /* Terminating entry */
>  	}
>  };
>  
>