All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] qt: install QML imports on target
@ 2013-02-20 10:18 Daniel Nyström
  2013-02-25 10:31 ` Daniel Nyström
  2013-02-27 22:58 ` Peter Korsgaard
  0 siblings, 2 replies; 6+ messages in thread
From: Daniel Nyström @ 2013-02-20 10:18 UTC (permalink / raw)
  To: buildroot

When selecting the Qt declarative module, all the QML imports was
built and installed to staging, but never installed to the target.

Signed-off-by: Daniel Nystr?m <daniel.nystrom@timeterminal.se>
---
 package/qt/qt.mk |   10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/package/qt/qt.mk b/package/qt/qt.mk
index ee1a88b..3767810 100644
--- a/package/qt/qt.mk
+++ b/package/qt/qt.mk
@@ -498,6 +498,7 @@ define QT_CONFIGURE_CMDS
 		-no-separate-debug-info \
 		-prefix /usr \
 		-plugindir /usr/lib/qt/plugins \
+		-importdir /usr/lib/qt/imports \
 		-hostprefix $(STAGING_DIR) \
 		-fast \
 		-no-rpath \
@@ -610,6 +611,14 @@ define QT_INSTALL_TARGET_PLUGINS
 	fi
 endef
 
+# Import installation
+define QT_INSTALL_TARGET_IMPORTS
+	if [ -d $(STAGING_DIR)/usr/lib/qt/imports/ ] ; then \
+		mkdir -p $(TARGET_DIR)/usr/lib/qt/imports ; \
+		cp -dpfr $(STAGING_DIR)/usr/lib/qt/imports/* $(TARGET_DIR)/usr/lib/qt/imports ; \
+	fi
+endef
+
 # Fonts installation
 ifneq ($(QT_FONTS),)
 define QT_INSTALL_TARGET_FONTS
@@ -628,6 +637,7 @@ endif
 define QT_INSTALL_TARGET_CMDS
 	$(QT_INSTALL_TARGET_LIBS)
 	$(QT_INSTALL_TARGET_PLUGINS)
+	$(QT_INSTALL_TARGET_IMPORTS)
 	$(QT_INSTALL_TARGET_FONTS)
 	$(QT_INSTALL_TARGET_FONTS_TTF)
 endef
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] qt: install QML imports on target
  2013-02-20 10:18 [Buildroot] [PATCH] qt: install QML imports on target Daniel Nyström
@ 2013-02-25 10:31 ` Daniel Nyström
  2013-02-25 21:15   ` Peter Korsgaard
  2013-02-27 22:58 ` Peter Korsgaard
  1 sibling, 1 reply; 6+ messages in thread
From: Daniel Nyström @ 2013-02-25 10:31 UTC (permalink / raw)
  To: buildroot

On Wed, Feb 20, 2013 at 11:18 AM, Daniel Nystr?m <
daniel.nystrom@timeterminal.se> wrote:

> When selecting the Qt declarative module, all the QML imports was
> built and installed to staging, but never installed to the target.
>
> Signed-off-by: Daniel Nystr?m <daniel.nystrom@timeterminal.se>
>

Bumping this patch as I think this is a good candidate for the 2013.02
release. Currently QtDeclarative is supported by Buildroot, but the QML
imports are not installed to target. The current imports are:

./QtWebKit/libqmlwebkitplugin.so
./Qt/labs/folderlistmodel/libqmlfolderlistmodelplugin.so
./Qt/labs/gestures/libqmlgesturesplugin.so
./Qt/labs/particles/libqmlparticlesplugin.so

(note that the webkitplugin is built even when "WebKit Module" is unchecked
in menuconfig!)

Maybe imports installation should be optional in the future, but right now
many QML examples and demos depends on their existance.

Best regards
Daniel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20130225/fe1720cb/attachment.html>

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] qt: install QML imports on target
  2013-02-25 10:31 ` Daniel Nyström
@ 2013-02-25 21:15   ` Peter Korsgaard
  2013-02-26  6:23     ` Alexander Lukichev
  2013-02-27 19:15     ` Arnout Vandecappelle
  0 siblings, 2 replies; 6+ messages in thread
From: Peter Korsgaard @ 2013-02-25 21:15 UTC (permalink / raw)
  To: buildroot

>>>>> "Daniel" == Daniel Nystr?m <daniel.nystrom@timeterminal.se> writes:

 Daniel> On Wed, Feb 20, 2013 at 11:18 AM, Daniel Nystr?m <
 Daniel> daniel.nystrom at timeterminal.se> wrote:

 Daniel>     When selecting the Qt declarative module, all the QML imports was
 Daniel>     built and installed to staging, but never installed to the target.

 Daniel>     Signed-off-by: Daniel Nystr?m <daniel.nystrom@timeterminal.se>


 Daniel> Bumping this patch as I think this is a good candidate for the
 Daniel> 2013.02 release.  Currently QtDeclarative is supported by
 Daniel> Buildroot, but the QML imports are not installed to target. The
 Daniel> current imports are:

 Daniel> ./QtWebKit/libqmlwebkitplugin.so
 Daniel> ./Qt/labs/folderlistmodel/libqmlfolderlistmodelplugin.so
 Daniel> ./Qt/labs/gestures/libqmlgesturesplugin.so
 Daniel> ./Qt/labs/particles/libqmlparticlesplugin.so

It would be good if someone who knows anything about Qt can ack this
patch for 2013.02.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] qt: install QML imports on target
  2013-02-25 21:15   ` Peter Korsgaard
@ 2013-02-26  6:23     ` Alexander Lukichev
  2013-02-27 19:15     ` Arnout Vandecappelle
  1 sibling, 0 replies; 6+ messages in thread
From: Alexander Lukichev @ 2013-02-26  6:23 UTC (permalink / raw)
  To: buildroot

Hi, Daniel, Peter, All!

On 02/25/2013 11:15 PM, Peter Korsgaard wrote:
>  Daniel>     When selecting the Qt declarative module, all the QML imports was
>  Daniel>     built and installed to staging, but never installed to the target.
>  Daniel>     Signed-off-by: Daniel Nystr?m <daniel.nystrom@timeterminal.se>
>  Daniel> Bumping this patch as I think this is a good candidate for the
>  Daniel> 2013.02 release.  Currently QtDeclarative is supported by
> It would be good if someone who knows anything about Qt can ack this
> patch for 2013.02.

  I don't yet have much reputation here but looks a nice thing to add to 2013.02,
and implemented just as should be. At least, I had to do exactly the same thing
a couple of months ago (based on Buildroot 2012.08) when doing a QML project, and
wished it were in the next release :) So here it comes.

  Acked-by: Alexander Lukichev <alexander.lukichev@gmail.com>

--
Best regards,
  Alexander Lukichev

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] qt: install QML imports on target
  2013-02-25 21:15   ` Peter Korsgaard
  2013-02-26  6:23     ` Alexander Lukichev
@ 2013-02-27 19:15     ` Arnout Vandecappelle
  1 sibling, 0 replies; 6+ messages in thread
From: Arnout Vandecappelle @ 2013-02-27 19:15 UTC (permalink / raw)
  To: buildroot

On 25/02/13 22:15, Peter Korsgaard wrote:
>>>>>> "Daniel" == Daniel Nystr?m<daniel.nystrom@timeterminal.se>  writes:
>   Daniel> On Wed, Feb 20, 2013 at 11:18 AM, Daniel Nystr?m <
>   Daniel>daniel.nystrom at timeterminal.se> wrote:
>
>   Daniel>     When selecting the Qt declarative module, all the QML imports was
>   Daniel>     built and installed to staging, but never installed to the target.
>
>   Daniel>     Signed-off-by: Daniel Nystr?m<daniel.nystrom@timeterminal.se>
>
>
>   Daniel> Bumping this patch as I think this is a good candidate for the
>   Daniel> 2013.02 release.  Currently QtDeclarative is supported by
>   Daniel> Buildroot, but the QML imports are not installed to target. The
>   Daniel> current imports are:
>
>   Daniel> ./QtWebKit/libqmlwebkitplugin.so
>   Daniel> ./Qt/labs/folderlistmodel/libqmlfolderlistmodelplugin.so
>   Daniel> ./Qt/labs/gestures/libqmlgesturesplugin.so
>   Daniel> ./Qt/labs/particles/libqmlparticlesplugin.so
>
> It would be good if someone who knows anything about Qt can ack this
> patch for 2013.02.

  Basic QML works without this patch. (Actually, I can't be 100% sure 
because the display on my board is currently broken, but at least the 
application doesn't report an error when I start it.) So I don't think 
this is really needed for 2013.02.

  This patch is only necessary if you want to use one of those plugins in 
your QML application. I therefore don't agree with always installing 
them. There should be a configure option to enable it. Although, maybe 
making this 200K installation configurable for a package that already 
consumes 15M is perhaps a bit silly... Therefore:

Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
  (for next)

Tested-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
  (build-test)

  Regards,
  Arnout

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] qt: install QML imports on target
  2013-02-20 10:18 [Buildroot] [PATCH] qt: install QML imports on target Daniel Nyström
  2013-02-25 10:31 ` Daniel Nyström
@ 2013-02-27 22:58 ` Peter Korsgaard
  1 sibling, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2013-02-27 22:58 UTC (permalink / raw)
  To: buildroot

>>>>> "Daniel" == Daniel Nystr?m <daniel.nystrom@timeterminal.se> writes:

 Daniel> When selecting the Qt declarative module, all the QML imports was
 Daniel> built and installed to staging, but never installed to the target.

Committed to next, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-02-27 22:58 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-20 10:18 [Buildroot] [PATCH] qt: install QML imports on target Daniel Nyström
2013-02-25 10:31 ` Daniel Nyström
2013-02-25 21:15   ` Peter Korsgaard
2013-02-26  6:23     ` Alexander Lukichev
2013-02-27 19:15     ` Arnout Vandecappelle
2013-02-27 22:58 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.