ticks_disappear option in circular_progress has no default value

ticks_disappear option in circular_progress has no default value

[Vladimir Testov]

[-- Attachment #1: Type: text/plain, Size: 201 bytes --]

ticks_disappear option in circular_progress has no default value

And it's no good.

fix included
-- 
With best regards,
_______________________________
Vladimir Testov, ROSA Laboratory.
www.rosalab.ru

[-- Attachment #2: grub2-ticks-disappear-default.patch --]
[-- Type: text/x-patch, Size: 466 bytes --]

diff -Naur grub-new/grub-core/gfxmenu/gui_circular_progress.c grub-new2/grub-core/gfxmenu/gui_circular_progress.c
--- grub-new/grub-core/gfxmenu/gui_circular_progress.c	2010-12-01 17:45:43.000000000 +0300
+++ grub-new2/grub-core/gfxmenu/gui_circular_progress.c	2013-02-06 20:31:14.198825969 +0400
@@ -303,6 +303,7 @@
   self->visible = 1;
   self->num_ticks = 64;
   self->start_angle = -64;
+  self->ticks_disappear = 1;
 
   return (grub_gui_component_t) self;
 }

Re: ticks_disappear option in circular_progress has no default value

[Vladimir 'φ-coder/phcoder' Serbinenko]

[-- Attachment #1: Type: text/plain, Size: 463 bytes --]

On 06.02.2013 17:35, Vladimir Testov wrote:

> ticks_disappear option in circular_progress has no default value
> 

It does. The whole structure is allocated with zalloc so all members are
set to 0, so 0 is default value for ticks_disappear.

> And it's no good.
> 
> fix included
> 
> 
> 
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel




[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]

Re: ticks_disappear option in circular_progress has no default value

[Vladimir Testov]

[-- Attachment #1: Type: text/plain, Size: 814 bytes --]

My last mesage about this problem wasn't answered.

Maybe I should write more detailed message.

There is parameter for circular progress bar, which hasn't a default value.

ticks_disappear

If it set to "0" in terms of source code ("true" in terms of grub2 theme) then 
ticks will APPEAR.
If it set to "1" in terms of source code ("false" in terms of grub2 theme) 
then ticks will DISAPPEAR.

Two patches are included for making some value to be default (grub2-ticks-
appear-default.patch and grub2-ticks-disappear-default.patch)

One of them should be used. (In current situations there is no default value 
and I see some kind of instability if none "ticks_disappear" was mentioned in 
a theme.)

Thanks. )

-- 
With best regards,
_______________________________
Vladimir Testov, ROSA Laboratory.
www.rosalab.ru

[-- Attachment #2: grub2-ticks-appear-default.patch --]
[-- Type: text/x-patch, Size: 466 bytes --]

diff -Naur grub-new/grub-core/gfxmenu/gui_circular_progress.c grub-new2/grub-core/gfxmenu/gui_circular_progress.c
--- grub-new/grub-core/gfxmenu/gui_circular_progress.c	2010-12-01 17:45:43.000000000 +0300
+++ grub-new2/grub-core/gfxmenu/gui_circular_progress.c	2013-02-06 20:31:14.198825969 +0400
@@ -303,6 +303,7 @@
   self->visible = 1;
   self->num_ticks = 64;
   self->start_angle = -64;
+  self->ticks_disappear = 0;
 
   return (grub_gui_component_t) self;
 }

[-- Attachment #3: grub2-ticks-disappear-default.patch --]
[-- Type: text/x-patch, Size: 466 bytes --]

diff -Naur grub-new/grub-core/gfxmenu/gui_circular_progress.c grub-new2/grub-core/gfxmenu/gui_circular_progress.c
--- grub-new/grub-core/gfxmenu/gui_circular_progress.c	2010-12-01 17:45:43.000000000 +0300
+++ grub-new2/grub-core/gfxmenu/gui_circular_progress.c	2013-02-06 20:31:14.198825969 +0400
@@ -303,6 +303,7 @@
   self->visible = 1;
   self->num_ticks = 64;
   self->start_angle = -64;
+  self->ticks_disappear = 1;
 
   return (grub_gui_component_t) self;
 }