[GIT PULL] ACPI and power management fixes for v3.9-rc1

[GIT PULL] ACPI and power management fixes for v3.9-rc1

[Rafael J. Wysocki]

Hi Linus,

Please pull from the git repository at

  git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git pm+acpi-fixes-3.9-rc1

to receive ACPI and power management fixes for v3.9-rc1 with top-most commit
4383822020c54c21eb2eb939a3233b44a51e8ca0

  Merge branch 'acpi-pm' into fixes

on top of commit a0b1c42951dd06ec83cc1bc2c9788131d9fefcd8

  Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next

The changes below fix problems introduced by the new ACPI and PM
commits merged earlier and one older build issue.

Included are:

- Fixes for blackfin and microblaze build problems introduced by the
  removal of global pm_idle.  From Lars-Peter Clausen.

- OPP core build fix from Shawn Guo.

- Error condition check fix for the new imx6q-cpufreq driver from
  Wei Yongjun.

- Fix for an AER driver crash related to the lack of APEI
  initialization for acpi=off.  From yours truly.

- Fix for the USB breakage on Thinkpad T430 related to ACPI power
  resources and PCI wakeup reported by Dave and Fabio (you know
  about this one).

Thanks!

---------------

Lars-Peter Clausen (2):
      blackfin idle: Fix compile error
      microblaze idle: Fix compile error

Rafael J. Wysocki (2):
      ACPI / APEI: Fix crash in apei_hest_parse() for acpi=off
      ACPI / PM: Take unusual configurations of power resources into account

Shawn Guo (1):
      PM / OPP: fix condition for empty of_init_opp_table()

Wei Yongjun (1):
      imx6q-cpufreq: fix return value check in imx6q_cpufreq_probe()

---------------

 arch/blackfin/kernel/process.c   |    4 +-
 arch/microblaze/kernel/process.c |    5 +--
 drivers/acpi/apei/hest.c         |    5 +--
 drivers/acpi/internal.h          |    2 +-
 drivers/acpi/power.c             |  112 +++++++++++++++++++++++++++++++++++-----------
 drivers/acpi/scan.c              |    9 +++-
 drivers/cpufreq/imx6q-cpufreq.c  |    2 +-
 include/linux/opp.h              |   18 ++++----
 8 files changed, 107 insertions(+), 50 deletions(-)

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

Re: [GIT PULL] ACPI and power management fixes for v3.9-rc1

[Rafael J. Wysocki]

Hi Linus,

I wonder if this went unnoticed or there's anything wrong with it or it just
needs to wait for some more time?

Rafael


On Sunday, February 24, 2013 03:29:25 PM Rafael J. Wysocki wrote:
> Hi Linus,
> 
> Please pull from the git repository at
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git pm+acpi-fixes-3.9-rc1
> 
> to receive ACPI and power management fixes for v3.9-rc1 with top-most commit
> 4383822020c54c21eb2eb939a3233b44a51e8ca0
> 
>   Merge branch 'acpi-pm' into fixes
> 
> on top of commit a0b1c42951dd06ec83cc1bc2c9788131d9fefcd8
> 
>   Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next
> 
> The changes below fix problems introduced by the new ACPI and PM
> commits merged earlier and one older build issue.
> 
> Included are:
> 
> - Fixes for blackfin and microblaze build problems introduced by the
>   removal of global pm_idle.  From Lars-Peter Clausen.
> 
> - OPP core build fix from Shawn Guo.
> 
> - Error condition check fix for the new imx6q-cpufreq driver from
>   Wei Yongjun.
> 
> - Fix for an AER driver crash related to the lack of APEI
>   initialization for acpi=off.  From yours truly.
> 
> - Fix for the USB breakage on Thinkpad T430 related to ACPI power
>   resources and PCI wakeup reported by Dave and Fabio (you know
>   about this one).
> 
> Thanks!
> 
> ---------------
> 
> Lars-Peter Clausen (2):
>       blackfin idle: Fix compile error
>       microblaze idle: Fix compile error
> 
> Rafael J. Wysocki (2):
>       ACPI / APEI: Fix crash in apei_hest_parse() for acpi=off
>       ACPI / PM: Take unusual configurations of power resources into account
> 
> Shawn Guo (1):
>       PM / OPP: fix condition for empty of_init_opp_table()
> 
> Wei Yongjun (1):
>       imx6q-cpufreq: fix return value check in imx6q_cpufreq_probe()
> 
> ---------------
> 
>  arch/blackfin/kernel/process.c   |    4 +-
>  arch/microblaze/kernel/process.c |    5 +--
>  drivers/acpi/apei/hest.c         |    5 +--
>  drivers/acpi/internal.h          |    2 +-
>  drivers/acpi/power.c             |  112 +++++++++++++++++++++++++++++++++++-----------
>  drivers/acpi/scan.c              |    9 +++-
>  drivers/cpufreq/imx6q-cpufreq.c  |    2 +-
>  include/linux/opp.h              |   18 ++++----
>  8 files changed, 107 insertions(+), 50 deletions(-)
> 
> 
-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

Re: [GIT PULL] ACPI and power management fixes for v3.9-rc1

[Linus Torvalds]

On Mon, Feb 25, 2013 at 7:17 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
>
> I wonder if this went unnoticed or there's anything wrong with it or it just
> needs to wait for some more time?

Just going through things slowly. It's merged in my tree now.

Oh, and a request: _please_ don't use unknown TLA's like OPP. This has
become a huge problem, to the point that we have a
"Documentation/power/opp.txt" file THAT NEVER CLEARLY STATES WHAT THE
F*CK OPP ACTUALLY MEANS! What nice "documentation".

Ok, I can look up things like this and find that it is "Operating
Performance Points". At least in this context. But no, it's not some
kind of generic standard, and no, it's not something people should be
expected to know in general. Please stop doing "explanations" of
things that use TLA's like this. And people shouldn't have to even
wonder.

                   Linus

Re: [GIT PULL] ACPI and power management fixes for v3.9-rc1

[Rafael J. Wysocki]

On Monday, February 25, 2013 09:31:45 PM Linus Torvalds wrote:
> On Mon, Feb 25, 2013 at 7:17 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> >
> > I wonder if this went unnoticed or there's anything wrong with it or it just
> > needs to wait for some more time?
> 
> Just going through things slowly. It's merged in my tree now.

Thanks!

> Oh, and a request: _please_ don't use unknown TLA's like OPP.

Sure, sorry about that.

> This has become a huge problem, to the point that we have a
> "Documentation/power/opp.txt" file THAT NEVER CLEARLY STATES WHAT THE
> F*CK OPP ACTUALLY MEANS! What nice "documentation".

It says that in "Introduction", but it would be clearer if the title of the
doc was something like "Operating Performance Points (OPP) Library".  Nishanth?

> Ok, I can look up things like this and find that it is "Operating
> Performance Points". At least in this context. But no, it's not some
> kind of generic standard, and no, it's not something people should be
> expected to know in general. Please stop doing "explanations" of
> things that use TLA's like this. And people shouldn't have to even
> wonder.

I agree.

Rafael


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

Re: [GIT PULL] ACPI and power management fixes for v3.9-rc1

[Nishanth Menon]

On 16:55-20130226, Rafael J. Wysocki wrote:
> On Monday, February 25, 2013 09:31:45 PM Linus Torvalds wrote:
> > On Mon, Feb 25, 2013 at 7:17 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
[..]
> 
> > This has become a huge problem, to the point that we have a
> > "Documentation/power/opp.txt" file THAT NEVER CLEARLY STATES WHAT THE
> > F*CK OPP ACTUALLY MEANS! What nice "documentation".
> 
> It says that in "Introduction", but it would be clearer if the title of the
> doc was something like "Operating Performance Points (OPP) Library".  Nishanth?
Yes indeed. Will the following help? I can post it as an official patch
if the direction is proper.
diff --git a/Documentation/power/opp.txt b/Documentation/power/opp.txt
index 3035d00..4a17443 100644
--- a/Documentation/power/opp.txt
+++ b/Documentation/power/opp.txt
@@ -1,5 +1,5 @@
 *=============*
-* OPP Library *
+* Operating Performance Points (OPP) Library *
 *=============*
 
 (C) 2009-2010 Nishanth Menon <nm@ti.com>, Texas Instruments Incorporated
@@ -16,6 +16,8 @@ Contents
 
 1. Introduction
 ===============
+1.1 What is an Operating Performance Point (OPP)?
+
 Complex SoCs of today consists of a multiple sub-modules working in conjunction.
 In an operational system executing varied use cases, not all modules in the SoC
 need to function at their highest performing frequency all the time. To
@@ -25,6 +27,16 @@ more. The set of discrete tuples consisting of frequency and voltage pairs that
 the device will support per domain are called Operating Performance Points or
 OPPs.
 
+As an example:
+MPU device supports {300MHz at minimum voltage of 1V}, {800MHz at minimum
+voltage of 1.2V}, {1GHz at minimum voltage of 1.3V}
+We can represent these as three OPPs
+{300000, 1000000}
+{800000, 1200000}
+{1000000, 1300000}
+
+1.2 Operating Performance Points Library
+
 OPP library provides a set of helper functions to organize and query the OPP
 information. The library is located in drivers/base/power/opp.c and the header
 is located in include/linux/opp.h. OPP library can be enabled by enabling

-- 
Regards,
Nishanth Menon

Re: [GIT PULL] ACPI and power management fixes for v3.9-rc1

[Linus Torvalds]

On Tue, Feb 26, 2013 at 8:10 AM, Nishanth Menon <nm@ti.com> wrote:
> On 16:55-20130226, Rafael J. Wysocki wrote:
>>
>> It says that in "Introduction", but it would be clearer if the title of the
>> doc was something like "Operating Performance Points (OPP) Library".  Nishanth?
>
> Yes indeed. Will the following help? I can post it as an official patch
> if the direction is proper

Yes, this will definitely help. I didn't even find it in the
introduction (Rafael is correct that it is indeed there), because it's
hard to see when you don't know what to scan for and it's in a big
block of text.

I am also happy to note that it is in the Kconfig help and single-line
description. Which wasn't true for the new SATA_ZPODD ("Zero Power
ODD" - what the heck is ODD?) which was another new entry I wondered
about.

It turns out that ODD is an odd TLA for "Optical Disk Drive". I'm sure
it makes perfect sense if you are a SATA person, but it sure doesn't
for any normal human being, even otherwise highly technical ones.

Aaron, Tejun, Jeff, can I ask you to also not use specialized TLA's
without explaining them? Especially in help text and "documentation",
it's very unhelpful to have TLA's that aren't common.

We don't have to explain *all* TLA's, since there's a lot that really
are rather widespread. But there's a big difference between something
like CPU or TLB that have been in generic literature for decades, wrt
OPP and ODD that are specialized terms used inside a very particular
group and haven't been around for very long either.

              Linus

Re: [GIT PULL] ACPI and power management fixes for v3.9-rc1

[Linus Torvalds]

Ugh. Forgot to actually add the ODD people to the list...

             Linus

On Tue, Feb 26, 2013 at 8:27 AM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
> On Tue, Feb 26, 2013 at 8:10 AM, Nishanth Menon <nm@ti.com> wrote:
>> On 16:55-20130226, Rafael J. Wysocki wrote:
>>>
>>> It says that in "Introduction", but it would be clearer if the title of the
>>> doc was something like "Operating Performance Points (OPP) Library".  Nishanth?
>>
>> Yes indeed. Will the following help? I can post it as an official patch
>> if the direction is proper
>
> Yes, this will definitely help. I didn't even find it in the
> introduction (Rafael is correct that it is indeed there), because it's
> hard to see when you don't know what to scan for and it's in a big
> block of text.
>
> I am also happy to note that it is in the Kconfig help and single-line
> description. Which wasn't true for the new SATA_ZPODD ("Zero Power
> ODD" - what the heck is ODD?) which was another new entry I wondered
> about.
>
> It turns out that ODD is an odd TLA for "Optical Disk Drive". I'm sure
> it makes perfect sense if you are a SATA person, but it sure doesn't
> for any normal human being, even otherwise highly technical ones.
>
> Aaron, Tejun, Jeff, can I ask you to also not use specialized TLA's
> without explaining them? Especially in help text and "documentation",
> it's very unhelpful to have TLA's that aren't common.
>
> We don't have to explain *all* TLA's, since there's a lot that really
> are rather widespread. But there's a big difference between something
> like CPU or TLB that have been in generic literature for decades, wrt
> OPP and ODD that are specialized terms used inside a very particular
> group and haven't been around for very long either.
>
>               Linus

Re: [GIT PULL] ACPI and power management fixes for v3.9-rc1

[Tejun Heo]

On Tue, Feb 26, 2013 at 08:28:56AM -0800, Linus Torvalds wrote:
> > Aaron, Tejun, Jeff, can I ask you to also not use specialized TLA's
> > without explaining them? Especially in help text and "documentation",
> > it's very unhelpful to have TLA's that aren't common.
> >
> > We don't have to explain *all* TLA's, since there's a lot that really
> > are rather widespread. But there's a big difference between something
> > like CPU or TLB that have been in generic literature for decades, wrt
> > OPP and ODD that are specialized terms used inside a very particular
> > group and haven't been around for very long either.

Aye aye, captain.

One interesting bit, for me (and possibly Aaron too), ODD is much more
closer to an everyday term.  For some reason, at least in Korea, ODD
is a popular term.  For exmple, the likes of newegg would use it along
with CPU, SSD or VGA to label product categories, so that probably is
why ODD never registered as something which needed explanation, and
that we all are pretty familiar with ATA jargons.  Anyways, yeah, no
ODDs without expansion nearby.

Thanks.

-- 
tejun

Re: [GIT PULL] ACPI and power management fixes for v3.9-rc1

[Linus Torvalds]

On Tue, Feb 26, 2013 at 8:37 AM, Tejun Heo <tj@kernel.org> wrote:
>
> One interesting bit, for me (and possibly Aaron too), ODD is much more
> closer to an everyday term.  For some reason, at least in Korea, ODD
> is a popular term.  For exmple, the likes of newegg would use it along
> with CPU, SSD or VGA to label product categories

Just checked newegg in the US. If you look for "ODD" here, you get a
very odd response.

For example,

  Fairly Odd Parents By Nickelodeon Bubble Bath 7 Oz
  Model #: 692237016543

shows up fairly high. Not an actual optican disk drive in sight, but
there are DVD's and "ODD bay"s there.

Searching for "optical disk drive" works. But then I never see
anything called "ODD" anywhere. I did find it in the "Technical
Specifications" for one of the drives, though.

Anyway, in the US it is definitely not a common term for normal people.

                 Linus

Re: [GIT PULL] ACPI and power management fixes for v3.9-rc1

[Tejun Heo]

On Tue, Feb 26, 2013 at 08:47:30AM -0800, Linus Torvalds wrote:
> Anyway, in the US it is definitely not a common term for normal people.

Googling "odd" doesn't give anything on optical drives on the first
page.  On the other hand, >70% is about optical drives on naver.com.
The discrepancy is funny given that most computer terms in Korea come
from US.  Maybe it's because the character combination "odd" doesn't
have any other meaning.  Even then, I'm surprised there's no optical
drive result at all in the first page of google search.  Definitely
doesn't seem like a common term in US.

-- 
tejun

Re: [GIT PULL] ACPI and power management fixes for v3.9-rc1

[Jeff Garzik]

On 02/26/2013 11:58 AM, Tejun Heo wrote:
> On Tue, Feb 26, 2013 at 08:47:30AM -0800, Linus Torvalds wrote:
>> Anyway, in the US it is definitely not a common term for normal people.
>
> Googling "odd" doesn't give anything on optical drives on the first
> page.  On the other hand, >70% is about optical drives on naver.com.
> The discrepancy is funny given that most computer terms in Korea come
> from US.  Maybe it's because the character combination "odd" doesn't
> have any other meaning.  Even then, I'm surprised there's no optical
> drive result at all in the first page of google search.  Definitely
> doesn't seem like a common term in US.

There is just a lot more "odd" goings-on in the US.  Korea is simply 
less odd than the US :)

Will send a patch to fix...

	Jeff

[PATCH] [libata] Avoid specialized TLA's in ZPODD's Kconfig

[Aaron Lu]

ODD is not a common TLA for non-ATA people so they will get confused
by its meaning when they are configuring the kernel. This patch fixed
this problem by using ODD only after stating what it is.

Signed-off-by: Aaron Lu <aaron.lu@intel.com>
---
 drivers/ata/Kconfig | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 3e751b7..d7d210e 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -59,15 +59,16 @@ config ATA_ACPI
 	  option libata.noacpi=1
 
 config SATA_ZPODD
-	bool "SATA Zero Power ODD Support"
+	bool "SATA Zero Power Optical Disc Drive(ZPODD) support"
 	depends on ATA_ACPI
 	default n
 	help
-	  This option adds support for SATA ZPODD. It requires both
-	  ODD and the platform support, and if enabled, will automatically
-	  power on/off the ODD when certain condition is satisfied. This
-	  does not impact user's experience of the ODD, only power is saved
-	  when ODD is not in use(i.e. no disc inside).
+	  This option adds support for SATA Zero Power Optical Disc
+	  Drive(ZPODD). It requires both the ODD and the platform
+	  support, and if enabled, will automatically power on/off the
+	  ODD when certain condition is satisfied. This does not impact
+	  end user's experience of the ODD, only power is saved when
+	  the ODD is not in use(i.e. no disc inside).
 
 	  If unsure, say N.
 
-- 
1.8.1.2

Re: [PATCH] [libata] Avoid specialized TLA's in ZPODD's Kconfig

[Sergei Shtylyov]

Hello.

On 01-03-2013 5:32, Aaron Lu wrote:

> ODD is not a common TLA for non-ATA people so they will get confused
> by its meaning when they are configuring the kernel. This patch fixed
> this problem by using ODD only after stating what it is.

> Signed-off-by: Aaron Lu <aaron.lu@intel.com>
> ---
>   drivers/ata/Kconfig | 13 +++++++------
>   1 file changed, 7 insertions(+), 6 deletions(-)

> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index 3e751b7..d7d210e 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -59,15 +59,16 @@ config ATA_ACPI
>   	  option libata.noacpi=1
>
>   config SATA_ZPODD
> -	bool "SATA Zero Power ODD Support"
> +	bool "SATA Zero Power Optical Disc Drive(ZPODD) support"

    Need a space before open paren.

>   	depends on ATA_ACPI
>   	default n
>   	help
> -	  This option adds support for SATA ZPODD. It requires both
> -	  ODD and the platform support, and if enabled, will automatically
> -	  power on/off the ODD when certain condition is satisfied. This
> -	  does not impact user's experience of the ODD, only power is saved
> -	  when ODD is not in use(i.e. no disc inside).
> +	  This option adds support for SATA Zero Power Optical Disc
> +	  Drive(ZPODD). It requires both the ODD and the platform

    Same here.

> +	  support, and if enabled, will automatically power on/off the
> +	  ODD when certain condition is satisfied. This does not impact
> +	  end user's experience of the ODD, only power is saved when
> +	  the ODD is not in use(i.e. no disc inside).

   And here.

MBR, Sergei

[PATCH v2] [libata] Avoid specialized TLA's in ZPODD's Kconfig

[Aaron Lu]

ODD is not a common TLA for non-ATA people so they will get confused
by its meaning when they are configuring the kernel. This patch fixed
this problem by using ODD only after stating what it is.

Signed-off-by: Aaron Lu <aaron.lu@intel.com>
---
v2:
Add a space before open paren as suggested by Sergei Shtylyov.

 drivers/ata/Kconfig | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 3e751b7..a5a3ebc 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -59,15 +59,16 @@ config ATA_ACPI
 	  option libata.noacpi=1
 
 config SATA_ZPODD
-	bool "SATA Zero Power ODD Support"
+	bool "SATA Zero Power Optical Disc Drive (ZPODD) support"
 	depends on ATA_ACPI
 	default n
 	help
-	  This option adds support for SATA ZPODD. It requires both
-	  ODD and the platform support, and if enabled, will automatically
-	  power on/off the ODD when certain condition is satisfied. This
-	  does not impact user's experience of the ODD, only power is saved
-	  when ODD is not in use(i.e. no disc inside).
+	  This option adds support for SATA Zero Power Optical Disc
+	  Drive (ZPODD). It requires both the ODD and the platform
+	  support, and if enabled, will automatically power on/off the
+	  ODD when certain condition is satisfied. This does not impact
+	  end user's experience of the ODD, only power is saved when
+	  the ODD is not in use (i.e. no disc inside).
 
 	  If unsure, say N.
 
-- 
1.8.1.2

Re: [PATCH v2] [libata] Avoid specialized TLA's in ZPODD's Kconfig

[Jeff Garzik]

On 03/02/2013 12:00 AM, Aaron Lu wrote:
> ODD is not a common TLA for non-ATA people so they will get confused
> by its meaning when they are configuring the kernel. This patch fixed
> this problem by using ODD only after stating what it is.
>
> Signed-off-by: Aaron Lu <aaron.lu@intel.com>
> ---
> v2:
> Add a space before open paren as suggested by Sergei Shtylyov.
>
>   drivers/ata/Kconfig | 13 +++++++------
>   1 file changed, 7 insertions(+), 6 deletions(-)

applied

Re: [GIT PULL] ACPI and power management fixes for v3.9-rc1

[Aaron Lu]

On 02/27/2013 12:28 AM, Linus Torvalds wrote:
> Ugh. Forgot to actually add the ODD people to the list...
> 
>              Linus
> 
> On Tue, Feb 26, 2013 at 8:27 AM, Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
>> On Tue, Feb 26, 2013 at 8:10 AM, Nishanth Menon <nm@ti.com> wrote:
>>> On 16:55-20130226, Rafael J. Wysocki wrote:
>>>>
>>>> It says that in "Introduction", but it would be clearer if the title of the
>>>> doc was something like "Operating Performance Points (OPP) Library".  Nishanth?
>>>
>>> Yes indeed. Will the following help? I can post it as an official patch
>>> if the direction is proper
>>
>> Yes, this will definitely help. I didn't even find it in the
>> introduction (Rafael is correct that it is indeed there), because it's
>> hard to see when you don't know what to scan for and it's in a big
>> block of text.
>>
>> I am also happy to note that it is in the Kconfig help and single-line
>> description. Which wasn't true for the new SATA_ZPODD ("Zero Power
>> ODD" - what the heck is ODD?) which was another new entry I wondered
>> about.

Sorry about this.

>>
>> It turns out that ODD is an odd TLA for "Optical Disk Drive". I'm sure
>> it makes perfect sense if you are a SATA person, but it sure doesn't
>> for any normal human being, even otherwise highly technical ones.
>>
>> Aaron, Tejun, Jeff, can I ask you to also not use specialized TLA's
>> without explaining them? Especially in help text and "documentation",
>> it's very unhelpful to have TLA's that aren't common.

OK.
I hope the following is better, if so, I'll send out a patch.

diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 9b58d32..b75efb0b 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -59,15 +59,16 @@ config ATA_ACPI
 	  option libata.noacpi=1
 
 config SATA_ZPODD
-	bool "SATA Zero Power ODD Support"
+	bool "SATA Zero Power Optical Disc Drive(ZPODD) support"
 	depends on ATA_ACPI
 	default n
 	help
-	  This option adds support for SATA ZPODD. It requires both
-	  ODD and the platform support, and if enabled, will automatically
-	  power on/off the ODD when certain condition is satisfied. This
-	  does not impact user's experience of the ODD, only power is saved
-	  when ODD is not in use(i.e. no disc inside).
+	  This option adds support for SATA Zero Power Optical Disc
+	  Drive(ZPODD). It requires both the ODD and the platform
+	  support, and if enabled, will automatically power on/off the
+	  ODD when certain condition is satisfied. This does not impact
+	  end user's experience of the ODD, only power is saved when
+	  the ODD is not in use(i.e. no disc inside).
 
 	  If unsure, say N.
 
 
Thanks,
Aaron