* [Buildroot] [git commit] busybox: 1.21.1 fix for move_to_unaligned16()
@ 2013-02-27 14:57 Peter Korsgaard
2013-02-27 19:29 ` Arnout Vandecappelle
0 siblings, 1 reply; 4+ messages in thread
From: Peter Korsgaard @ 2013-02-27 14:57 UTC (permalink / raw)
To: buildroot
commit: http://git.buildroot.net/buildroot/commit/?id=d8024d2d87864eb0ba381291e0e2986f7643c8dc
branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master
Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
---
.../busybox-1.21.0/busybox-1.21.0-platform.patch | 11 +++++++++++
1 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/package/busybox/busybox-1.21.0/busybox-1.21.0-platform.patch b/package/busybox/busybox-1.21.0/busybox-1.21.0-platform.patch
new file mode 100644
index 0000000..2401b86
--- /dev/null
+++ b/package/busybox/busybox-1.21.0/busybox-1.21.0-platform.patch
@@ -0,0 +1,11 @@
+--- busybox-1.21.0/include/platform.h
++++ busybox-1.21.0-platform/include/platform.h
+@@ -228,7 +228,7 @@ typedef uint32_t bb__aliased_uint32_t FI
+ # define move_from_unaligned32(v, u32p) (memcpy(&(v), (u32p), 4))
+ # define move_to_unaligned16(u16p, v) do { \
+ uint16_t __t = (v); \
+- memcpy((u16p), &__t, 4); \
++ memcpy((u16p), &__t, 2); \
+ } while (0)
+ # define move_to_unaligned32(u32p, v) do { \
+ uint32_t __t = (v); \
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [git commit] busybox: 1.21.1 fix for move_to_unaligned16()
2013-02-27 14:57 [Buildroot] [git commit] busybox: 1.21.1 fix for move_to_unaligned16() Peter Korsgaard
@ 2013-02-27 19:29 ` Arnout Vandecappelle
2013-02-27 20:50 ` Peter Korsgaard
0 siblings, 1 reply; 4+ messages in thread
From: Arnout Vandecappelle @ 2013-02-27 19:29 UTC (permalink / raw)
To: buildroot
On 27/02/13 15:57, Peter Korsgaard wrote:
> commit: http://git.buildroot.net/buildroot/commit/?id=d8024d2d87864eb0ba381291e0e2986f7643c8dc
> branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master
>
> Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
> ---
> .../busybox-1.21.0/busybox-1.21.0-platform.patch | 11 +++++++++++
> 1 files changed, 11 insertions(+), 0 deletions(-)
>
> diff --git a/package/busybox/busybox-1.21.0/busybox-1.21.0-platform.patch b/package/busybox/busybox-1.21.0/busybox-1.21.0-platform.patch
> new file mode 100644
> index 0000000..2401b86
> --- /dev/null
> +++ b/package/busybox/busybox-1.21.0/busybox-1.21.0-platform.patch
> @@ -0,0 +1,11 @@
Why do we bother to tell our contributors to add a patch description
and Signed-off-by if our maintainer doesn't even do it? :-)
Regards,
Arnout
> +--- busybox-1.21.0/include/platform.h
> ++++ busybox-1.21.0-platform/include/platform.h
> +@@ -228,7 +228,7 @@ typedef uint32_t bb__aliased_uint32_t FI
> + # define move_from_unaligned32(v, u32p) (memcpy(&(v), (u32p), 4))
> + # define move_to_unaligned16(u16p, v) do { \
> + uint16_t __t = (v); \
> +- memcpy((u16p), &__t, 4); \
> ++ memcpy((u16p), &__t, 2); \
> + } while (0)
> + # define move_to_unaligned32(u32p, v) do { \
> + uint32_t __t = (v); \
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [git commit] busybox: 1.21.1 fix for move_to_unaligned16()
2013-02-27 19:29 ` Arnout Vandecappelle
@ 2013-02-27 20:50 ` Peter Korsgaard
2013-02-27 21:19 ` Arnout Vandecappelle
0 siblings, 1 reply; 4+ messages in thread
From: Peter Korsgaard @ 2013-02-27 20:50 UTC (permalink / raw)
To: buildroot
>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:
Arnout> On 27/02/13 15:57, Peter Korsgaard wrote:
>> commit: http://git.buildroot.net/buildroot/commit/?id=d8024d2d87864eb0ba381291e0e2986f7643c8dc
>> branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master
>>
>> Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
>> ---
>> .../busybox-1.21.0/busybox-1.21.0-platform.patch | 11 +++++++++++
>> 1 files changed, 11 insertions(+), 0 deletions(-)
>>
>> diff --git a/package/busybox/busybox-1.21.0/busybox-1.21.0-platform.patch b/package/busybox/busybox-1.21.0/busybox-1.21.0-platform.patch
>> new file mode 100644
>> index 0000000..2401b86
>> --- /dev/null
>> +++ b/package/busybox/busybox-1.21.0/busybox-1.21.0-platform.patch
>> @@ -0,0 +1,11 @@
Arnout> Why do we bother to tell our contributors to add a patch description
Arnout> and Signed-off-by if our maintainer doesn't even do it? :-)
Mainly because busybox upstream unfortunately doesn't do it even though
he has been asked.
But ok, I guess I could dig through busybox git and come up with a
description or atleast link to the upstream location.
Upstream unfortunately also updates these files without renaming them.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [git commit] busybox: 1.21.1 fix for move_to_unaligned16()
2013-02-27 20:50 ` Peter Korsgaard
@ 2013-02-27 21:19 ` Arnout Vandecappelle
0 siblings, 0 replies; 4+ messages in thread
From: Arnout Vandecappelle @ 2013-02-27 21:19 UTC (permalink / raw)
To: buildroot
On 27/02/13 21:50, Peter Korsgaard wrote:
>>>>>> >>>>>"Arnout" == Arnout Vandecappelle<arnout@mind.be> writes:
> Arnout> On 27/02/13 15:57, Peter Korsgaard wrote:
> >> commit:http://git.buildroot.net/buildroot/commit/?id=d8024d2d87864eb0ba381291e0e2986f7643c8dc
> >> branch:http://git.buildroot.net/buildroot/commit/?id=refs/heads/master
> >>
> >> Signed-off-by: Peter Korsgaard<jacmet@sunsite.dk>
> >> ---
> >> .../busybox-1.21.0/busybox-1.21.0-platform.patch | 11 +++++++++++
> >> 1 files changed, 11 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/package/busybox/busybox-1.21.0/busybox-1.21.0-platform.patch b/package/busybox/busybox-1.21.0/busybox-1.21.0-platform.patch
> >> new file mode 100644
> >> index 0000000..2401b86
> >> --- /dev/null
> >> +++ b/package/busybox/busybox-1.21.0/busybox-1.21.0-platform.patch
> >> @@ -0,0 +1,11 @@
>
> Arnout> Why do we bother to tell our contributors to add a patch description
> Arnout> and Signed-off-by if our maintainer doesn't even do it?:-)
>
> Mainly because busybox upstream unfortunately doesn't do it even though
> he has been asked.
>
> But ok, I guess I could dig through busybox git and come up with a
> description
In that case you could even do a format-patch.
> or atleast link to the upstream location.
That's what I mean:
- copy your own commit message text into the patch;
- mention the upstream URL
http://busybox.net/downloads/fixes-1.21.0/busybox-1.21.0-platform.patch
- Add your Sob.
Actually, I don't even really want to claim that this is the way it
_should_ be done. Rather, it is what I as a reviewer tell our
contributors, because that's what I understand our policy is.
> Upstream unfortunately also updates these files without renaming them.
That is... unfortunate. Otherwise we could apply them directly with
BUSYBOX_PATCH (after the patch that allows foreign URLs has been applied).
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-02-27 21:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-27 14:57 [Buildroot] [git commit] busybox: 1.21.1 fix for move_to_unaligned16() Peter Korsgaard
2013-02-27 19:29 ` Arnout Vandecappelle
2013-02-27 20:50 ` Peter Korsgaard
2013-02-27 21:19 ` Arnout Vandecappelle
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.