* [Qemu-devel] [PATCH] qemu-ga: make guest-sync-delimited available during fsfreeze
@ 2013-03-01 17:53 Michael Roth
2013-03-01 18:10 ` Eric Blake
2013-03-04 19:28 ` mdroth
0 siblings, 2 replies; 3+ messages in thread
From: Michael Roth @ 2013-03-01 17:53 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-stable
We currently maintain a whitelist of commands that are safe during
fsfreeze. During fsfreeze, we disable all commands that aren't part of
that whitelist.
guest-sync-delimited meets the criteria for being whitelisted, and is
also required for qemu-ga clients that rely on guest-sync-delimited for
re-syncing the channel after a timeout.
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Cc: qemu-stable@nongnu.org
---
qga/main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/qga/main.c b/qga/main.c
index db281a5..ad75171 100644
--- a/qga/main.c
+++ b/qga/main.c
@@ -85,6 +85,7 @@ static const char *ga_freeze_whitelist[] = {
"guest-ping",
"guest-info",
"guest-sync",
+ "guest-sync-delimited",
"guest-fsfreeze-status",
"guest-fsfreeze-thaw",
NULL
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] qemu-ga: make guest-sync-delimited available during fsfreeze
2013-03-01 17:53 [Qemu-devel] [PATCH] qemu-ga: make guest-sync-delimited available during fsfreeze Michael Roth
@ 2013-03-01 18:10 ` Eric Blake
2013-03-04 19:28 ` mdroth
1 sibling, 0 replies; 3+ messages in thread
From: Eric Blake @ 2013-03-01 18:10 UTC (permalink / raw)
To: Michael Roth; +Cc: qemu-devel, qemu-stable
[-- Attachment #1: Type: text/plain, Size: 1084 bytes --]
On 03/01/2013 10:53 AM, Michael Roth wrote:
> We currently maintain a whitelist of commands that are safe during
> fsfreeze. During fsfreeze, we disable all commands that aren't part of
> that whitelist.
>
> guest-sync-delimited meets the criteria for being whitelisted, and is
> also required for qemu-ga clients that rely on guest-sync-delimited for
> re-syncing the channel after a timeout.
>
> Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
> Cc: qemu-stable@nongnu.org
> ---
> qga/main.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> diff --git a/qga/main.c b/qga/main.c
> index db281a5..ad75171 100644
> --- a/qga/main.c
> +++ b/qga/main.c
> @@ -85,6 +85,7 @@ static const char *ga_freeze_whitelist[] = {
> "guest-ping",
> "guest-info",
> "guest-sync",
> + "guest-sync-delimited",
> "guest-fsfreeze-status",
> "guest-fsfreeze-thaw",
> NULL
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] qemu-ga: make guest-sync-delimited available during fsfreeze
2013-03-01 17:53 [Qemu-devel] [PATCH] qemu-ga: make guest-sync-delimited available during fsfreeze Michael Roth
2013-03-01 18:10 ` Eric Blake
@ 2013-03-04 19:28 ` mdroth
1 sibling, 0 replies; 3+ messages in thread
From: mdroth @ 2013-03-04 19:28 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-stable
On Fri, Mar 01, 2013 at 11:53:40AM -0600, Michael Roth wrote:
> We currently maintain a whitelist of commands that are safe during
> fsfreeze. During fsfreeze, we disable all commands that aren't part of
> that whitelist.
>
> guest-sync-delimited meets the criteria for being whitelisted, and is
> also required for qemu-ga clients that rely on guest-sync-delimited for
> re-syncing the channel after a timeout.
>
> Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
> Cc: qemu-stable@nongnu.org
Thanks, applied to qga branch.
> ---
> qga/main.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/qga/main.c b/qga/main.c
> index db281a5..ad75171 100644
> --- a/qga/main.c
> +++ b/qga/main.c
> @@ -85,6 +85,7 @@ static const char *ga_freeze_whitelist[] = {
> "guest-ping",
> "guest-info",
> "guest-sync",
> + "guest-sync-delimited",
> "guest-fsfreeze-status",
> "guest-fsfreeze-thaw",
> NULL
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-03-04 19:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-01 17:53 [Qemu-devel] [PATCH] qemu-ga: make guest-sync-delimited available during fsfreeze Michael Roth
2013-03-01 18:10 ` Eric Blake
2013-03-04 19:28 ` mdroth
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.