From: Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> To: Glauber Costa <glommer@parallels.com> Cc: linux-mm@kvack.org, cgroups@vger.kernel.org, Tejun Heo <tj@kernel.org>, Andrew Morton <akpm@linux-foundation.org>, Michal Hocko <mhocko@suse.cz>, handai.szj@gmail.com, anton.vorontsov@linaro.org, Johannes Weiner <hannes@cmpxchg.org> Subject: Re: [PATCH v2 1/5] memcg: make nocpu_base available for non hotplug Date: Wed, 06 Mar 2013 09:04:52 +0900 [thread overview] Message-ID: <51368824.7050601@jp.fujitsu.com> (raw) In-Reply-To: <1362489058-3455-2-git-send-email-glommer@parallels.com> (2013/03/05 22:10), Glauber Costa wrote: > We are using nocpu_base to accumulate charges on the main counters > during cpu hotplug. I have a similar need, which is transferring charges > to the root cgroup when lazily enabling memcg. Because system wide > information is not kept per-cpu, it is hard to distribute it. This field > works well for this. So we need to make it available for all usages, not > only hotplug cases. > > Signed-off-by: Glauber Costa <glommer@parallels.com> > Cc: Michal Hocko <mhocko@suse.cz> > Cc: Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> > Cc: Johannes Weiner <hannes@cmpxchg.org> > Cc: Tejun Heo <tj@kernel.org> Acked-by: KAMEZAWA Hiroyuki<kamezawa.hiroyu@jp.fujitsu.com> Hmm..comments on nocpu_base definition will be updated in later patch ? > --- > mm/memcontrol.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 669d16a..b8b363f 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -921,11 +921,11 @@ static long mem_cgroup_read_stat(struct mem_cgroup *memcg, > get_online_cpus(); > for_each_online_cpu(cpu) > val += per_cpu(memcg->stat->count[idx], cpu); > -#ifdef CONFIG_HOTPLUG_CPU > + > spin_lock(&memcg->pcp_counter_lock); > val += memcg->nocpu_base.count[idx]; > spin_unlock(&memcg->pcp_counter_lock); > -#endif > + > put_online_cpus(); > return val; > } > @@ -945,11 +945,11 @@ static unsigned long mem_cgroup_read_events(struct mem_cgroup *memcg, > > for_each_online_cpu(cpu) > val += per_cpu(memcg->stat->events[idx], cpu); > -#ifdef CONFIG_HOTPLUG_CPU > + > spin_lock(&memcg->pcp_counter_lock); > val += memcg->nocpu_base.events[idx]; > spin_unlock(&memcg->pcp_counter_lock); > -#endif > + > return val; > } > > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Kamezawa Hiroyuki <kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org> To: Glauber Costa <glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org> Cc: linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>, Michal Hocko <mhocko-AlSwsSmVLrQ@public.gmane.org>, handai.szj-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, anton.vorontsov-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org> Subject: Re: [PATCH v2 1/5] memcg: make nocpu_base available for non hotplug Date: Wed, 06 Mar 2013 09:04:52 +0900 [thread overview] Message-ID: <51368824.7050601@jp.fujitsu.com> (raw) In-Reply-To: <1362489058-3455-2-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org> (2013/03/05 22:10), Glauber Costa wrote: > We are using nocpu_base to accumulate charges on the main counters > during cpu hotplug. I have a similar need, which is transferring charges > to the root cgroup when lazily enabling memcg. Because system wide > information is not kept per-cpu, it is hard to distribute it. This field > works well for this. So we need to make it available for all usages, not > only hotplug cases. > > Signed-off-by: Glauber Costa <glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org> > Cc: Michal Hocko <mhocko-AlSwsSmVLrQ@public.gmane.org> > Cc: Kamezawa Hiroyuki <kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org> > Cc: Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org> > Cc: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Acked-by: KAMEZAWA Hiroyuki<kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org> Hmm..comments on nocpu_base definition will be updated in later patch ? > --- > mm/memcontrol.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 669d16a..b8b363f 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -921,11 +921,11 @@ static long mem_cgroup_read_stat(struct mem_cgroup *memcg, > get_online_cpus(); > for_each_online_cpu(cpu) > val += per_cpu(memcg->stat->count[idx], cpu); > -#ifdef CONFIG_HOTPLUG_CPU > + > spin_lock(&memcg->pcp_counter_lock); > val += memcg->nocpu_base.count[idx]; > spin_unlock(&memcg->pcp_counter_lock); > -#endif > + > put_online_cpus(); > return val; > } > @@ -945,11 +945,11 @@ static unsigned long mem_cgroup_read_events(struct mem_cgroup *memcg, > > for_each_online_cpu(cpu) > val += per_cpu(memcg->stat->events[idx], cpu); > -#ifdef CONFIG_HOTPLUG_CPU > + > spin_lock(&memcg->pcp_counter_lock); > val += memcg->nocpu_base.events[idx]; > spin_unlock(&memcg->pcp_counter_lock); > -#endif > + > return val; > } > >
next prev parent reply other threads:[~2013-03-06 0:05 UTC|newest] Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-03-05 13:10 [PATCH v2 0/5] bypass root memcg charges if no memcgs are possible Glauber Costa 2013-03-05 13:10 ` Glauber Costa 2013-03-05 13:10 ` [PATCH v2 1/5] memcg: make nocpu_base available for non hotplug Glauber Costa 2013-03-05 13:10 ` Glauber Costa 2013-03-06 0:04 ` Kamezawa Hiroyuki [this message] 2013-03-06 0:04 ` Kamezawa Hiroyuki 2013-03-19 11:07 ` Michal Hocko 2013-03-05 13:10 ` [PATCH v2 2/5] memcg: provide root figures from system totals Glauber Costa 2013-03-05 13:10 ` Glauber Costa 2013-03-06 0:27 ` Kamezawa Hiroyuki 2013-03-06 8:30 ` Glauber Costa 2013-03-06 8:30 ` Glauber Costa 2013-03-06 10:45 ` Kamezawa Hiroyuki 2013-03-06 10:45 ` Kamezawa Hiroyuki 2013-03-06 10:52 ` Glauber Costa 2013-03-06 10:52 ` Glauber Costa 2013-03-06 10:59 ` Kamezawa Hiroyuki 2013-03-06 10:59 ` Kamezawa Hiroyuki 2013-03-13 6:58 ` Sha Zhengju 2013-03-13 6:58 ` Sha Zhengju 2013-03-13 9:15 ` Kamezawa Hiroyuki 2013-03-13 9:15 ` Kamezawa Hiroyuki 2013-03-13 9:59 ` Sha Zhengju 2013-03-14 0:03 ` Kamezawa Hiroyuki 2013-03-14 0:03 ` Kamezawa Hiroyuki 2013-03-06 10:50 ` Kamezawa Hiroyuki 2013-03-06 10:50 ` Kamezawa Hiroyuki 2013-03-19 12:46 ` Michal Hocko 2013-03-19 12:46 ` Michal Hocko 2013-03-19 12:55 ` Michal Hocko 2013-03-19 12:55 ` Michal Hocko 2013-03-20 7:03 ` Glauber Costa 2013-03-20 8:03 ` Michal Hocko 2013-03-20 8:03 ` Michal Hocko 2013-03-20 8:08 ` Glauber Costa 2013-03-20 8:18 ` Michal Hocko 2013-03-20 8:18 ` Michal Hocko 2013-03-20 8:34 ` Glauber Costa 2013-03-20 8:58 ` Michal Hocko 2013-03-20 9:30 ` Glauber Costa 2013-03-21 6:08 ` Kamezawa Hiroyuki 2013-03-21 6:08 ` Kamezawa Hiroyuki 2013-03-20 16:40 ` Anton Vorontsov 2013-03-20 16:40 ` Anton Vorontsov 2013-03-20 7:04 ` Glauber Costa 2013-03-05 13:10 ` [PATCH v2 3/5] memcg: make it suck faster Glauber Costa 2013-03-05 13:10 ` Glauber Costa 2013-03-06 0:46 ` Kamezawa Hiroyuki 2013-03-06 0:46 ` Kamezawa Hiroyuki 2013-03-06 8:38 ` Glauber Costa 2013-03-06 10:54 ` Kamezawa Hiroyuki 2013-03-06 10:54 ` Kamezawa Hiroyuki 2013-03-13 8:08 ` Sha Zhengju 2013-03-13 8:08 ` Sha Zhengju 2013-03-20 7:13 ` Glauber Costa 2013-03-20 7:13 ` Glauber Costa 2013-03-19 13:58 ` Michal Hocko 2013-03-19 13:58 ` Michal Hocko 2013-03-20 7:00 ` Glauber Costa 2013-03-20 8:13 ` Michal Hocko 2013-03-20 8:13 ` Michal Hocko 2013-03-05 13:10 ` [PATCH v2 4/5] memcg: do not call page_cgroup_init at system_boot Glauber Costa 2013-03-05 13:10 ` Glauber Costa 2013-03-06 1:07 ` Kamezawa Hiroyuki 2013-03-06 1:07 ` Kamezawa Hiroyuki 2013-03-06 8:22 ` Glauber Costa 2013-03-06 8:22 ` Glauber Costa 2013-03-19 14:06 ` Michal Hocko 2013-03-05 13:10 ` [PATCH v2 5/5] memcg: do not walk all the way to the root for memcg Glauber Costa 2013-03-05 13:10 ` Glauber Costa 2013-03-06 1:08 ` Kamezawa Hiroyuki 2013-03-06 1:08 ` Kamezawa Hiroyuki
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=51368824.7050601@jp.fujitsu.com \ --to=kamezawa.hiroyu@jp.fujitsu.com \ --cc=akpm@linux-foundation.org \ --cc=anton.vorontsov@linaro.org \ --cc=cgroups@vger.kernel.org \ --cc=glommer@parallels.com \ --cc=handai.szj@gmail.com \ --cc=hannes@cmpxchg.org \ --cc=linux-mm@kvack.org \ --cc=mhocko@suse.cz \ --cc=tj@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.