From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Zev Weiss <zev@bewilderbeest.net>
Cc: Guenter Roeck <linux@roeck-us.net>,
Jean Delvare <jdelvare@suse.com>,
linux-hwmon@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, Renze Nicolai <renze@rnplus.nl>,
Oleksandr Natalenko <oleksandr@natalenko.name>,
openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/7] dt-bindings: hwmon: Add nuvoton,nct6775
Date: Wed, 27 Apr 2022 18:37:20 +0200 [thread overview]
Message-ID: <5139dc9f-96c3-9f20-4c62-feee902cb5e6@linaro.org> (raw)
In-Reply-To: <YmjmWNUpCAFYesyk@hatter.bewilderbeest.net>
On 27/04/2022 08:44, Zev Weiss wrote:
>>> + reg:
>>> + maxItems: 1
>>> +
>>> + nuvoton,tsi-channel-mask:
>>> + description:
>>> + Bitmask indicating which TSI temperature sensor channels are
>>> + active. LSB is TSI0, bit 1 is TSI1, etc.
>>
>> Need a type/ref.
>>
>
> Ack, thanks.
Did you test the bindings after the changes? Using reviewers time
instead of testing by yourself with an automated tool is quite a waste.
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Zev Weiss <zev@bewilderbeest.net>
Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
Jean Delvare <jdelvare@suse.com>,
linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org,
Oleksandr Natalenko <oleksandr@natalenko.name>,
Renze Nicolai <renze@rnplus.nl>, Rob Herring <robh+dt@kernel.org>,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH v4 1/7] dt-bindings: hwmon: Add nuvoton,nct6775
Date: Wed, 27 Apr 2022 18:37:20 +0200 [thread overview]
Message-ID: <5139dc9f-96c3-9f20-4c62-feee902cb5e6@linaro.org> (raw)
In-Reply-To: <YmjmWNUpCAFYesyk@hatter.bewilderbeest.net>
On 27/04/2022 08:44, Zev Weiss wrote:
>>> + reg:
>>> + maxItems: 1
>>> +
>>> + nuvoton,tsi-channel-mask:
>>> + description:
>>> + Bitmask indicating which TSI temperature sensor channels are
>>> + active. LSB is TSI0, bit 1 is TSI1, etc.
>>
>> Need a type/ref.
>>
>
> Ack, thanks.
Did you test the bindings after the changes? Using reviewers time
instead of testing by yourself with an automated tool is quite a waste.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-04-27 16:37 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 1:01 [PATCH v4 0/7] hwmon: (nct6775) Convert to regmap, add i2c support Zev Weiss
2022-04-27 1:01 ` Zev Weiss
2022-04-27 1:01 ` [PATCH v4 1/7] dt-bindings: hwmon: Add nuvoton,nct6775 Zev Weiss
2022-04-27 1:01 ` Zev Weiss
2022-04-27 6:04 ` Krzysztof Kozlowski
2022-04-27 6:04 ` Krzysztof Kozlowski
2022-04-27 6:44 ` Zev Weiss
2022-04-27 6:44 ` Zev Weiss
2022-04-27 7:00 ` Krzysztof Kozlowski
2022-04-27 7:00 ` Krzysztof Kozlowski
2022-04-27 16:37 ` Krzysztof Kozlowski [this message]
2022-04-27 16:37 ` Krzysztof Kozlowski
2022-04-27 20:05 ` Zev Weiss
2022-04-27 20:05 ` Zev Weiss
2022-04-27 14:18 ` Rob Herring
2022-04-27 14:18 ` Rob Herring
2022-04-27 1:01 ` [PATCH v4 2/7] hwmon: (nct6775) Convert register access to regmap API Zev Weiss
2022-04-27 1:01 ` Zev Weiss
2022-04-27 1:01 ` [PATCH v4 3/7] hwmon: (nct6775) Rearrange attr-group initialization Zev Weiss
2022-04-27 1:01 ` Zev Weiss
2022-04-27 1:01 ` [PATCH v4 4/7] hwmon: (nct6775) Add read-only mode Zev Weiss
2022-04-27 1:01 ` Zev Weiss
2022-04-27 1:01 ` [PATCH v4 5/7] hwmon: (nct6775) Convert S_I* permissions macros to octal Zev Weiss
2022-04-27 1:01 ` Zev Weiss
2022-04-27 1:01 ` [PATCH v4 6/7] hwmon: (nct6775) Split core and platform driver Zev Weiss
2022-04-27 1:01 ` Zev Weiss
2022-04-27 1:01 ` [PATCH v4 7/7] hwmon: (nct6775) Add i2c driver Zev Weiss
2022-04-27 1:01 ` Zev Weiss
2022-04-27 13:37 ` [PATCH v4 0/7] hwmon: (nct6775) Convert to regmap, add i2c support Guenter Roeck
2022-04-27 13:37 ` Guenter Roeck
2022-05-01 15:18 ` Oleksandr Natalenko
2022-05-01 15:18 ` Oleksandr Natalenko
2022-05-02 3:50 ` Guenter Roeck
2022-05-02 3:50 ` Guenter Roeck
2022-05-02 6:06 ` Oleksandr Natalenko
2022-05-02 6:06 ` Oleksandr Natalenko
2022-05-02 18:42 ` Guenter Roeck
2022-05-02 18:42 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5139dc9f-96c3-9f20-4c62-feee902cb5e6@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=oleksandr@natalenko.name \
--cc=openbmc@lists.ozlabs.org \
--cc=renze@rnplus.nl \
--cc=robh+dt@kernel.org \
--cc=zev@bewilderbeest.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.