Re: [Qemu-devel] [PATCH V8 03/20] block: move bdrv_snapshot_find() to block/snapshot.c

[Wenchao Xia <xiawenc@linux.vnet.ibm.com>]

 > On 03/06/2013 11:07 PM, Wenchao Xia wrote:
>>    This patch also fix small code style error reported by check script.
>>
>> Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
>> ---
>>   block/snapshot.c         |   23 +++++++++++++++++++++++
>>   include/block/snapshot.h |    9 +++++++++
>>   savevm.c                 |   23 +----------------------
>>   3 files changed, 33 insertions(+), 22 deletions(-)
>>
>
>> +++ b/include/block/snapshot.h
>> @@ -1,4 +1,13 @@
>>   #ifndef SNAPSHOT_H
>>   #define SNAPSHOT_H
>>
>> +#include "qemu-common.h"
>> +/*
>> + * block.h is needed for QEMUSnapshotInfo, it can be removed when define is
>> + * moved here.
>> + */
>> +#include "block.h"
>
> Why not move QEMUSnapshotInfo here as part of this patch, and/or reorder
> the series to do the code motion of that type before you move the function?
>
   This is along serial which modify the file several times, so I
placed the important parts first, to avoid trouble if later patch need
modification. You can see patches 1 to 16 are clear and closely related
small patches, each of which do one step to archieve the goal, but 17
to 20 are "cleaning" patches, I'd rather drop them to make the serial
shorter, instead of move them front.

> That said, this looks like an accurate code motion patch.  But see my
> comments earlier in the series about merging this with 1/20.
>


-- 
Best Regards

Wenchao Xia