* [PATCH] ARM:net: an issue for k which is u32, never < 0
@ 2013-03-10 2:15 ` Chen Gang
0 siblings, 0 replies; 16+ messages in thread
From: Chen Gang @ 2013-03-10 2:15 UTC (permalink / raw)
To: Russell King - ARM Linux, mgherzan, nschichan, daniel.borkmann
Cc: David Miller, linux-arm-kernel,
linux-kernel@vger.kernel.org >>
"linux-kernel@vger.kernel.org"
k is u32 which never < 0, need type cast, or cause issue.
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
arch/arm/net/bpf_jit_32.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/net/bpf_jit_32.c b/arch/arm/net/bpf_jit_32.c
index 6828ef6..a0bd8a7 100644
--- a/arch/arm/net/bpf_jit_32.c
+++ b/arch/arm/net/bpf_jit_32.c
@@ -576,7 +576,7 @@ load_ind:
/* x = ((*(frame + k)) & 0xf) << 2; */
ctx->seen |= SEEN_X | SEEN_DATA | SEEN_CALL;
/* the interpreter should deal with the negative K */
- if (k < 0)
+ if ((int)k < 0)
return -1;
/* offset in r1: we might have to take the slow path */
emit_mov_i(r_off, k, ctx);
--
1.7.7.6
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH] ARM:net: an issue for k which is u32, never < 0
@ 2013-03-10 2:15 ` Chen Gang
0 siblings, 0 replies; 16+ messages in thread
From: Chen Gang @ 2013-03-10 2:15 UTC (permalink / raw)
To: linux-arm-kernel
k is u32 which never < 0, need type cast, or cause issue.
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
arch/arm/net/bpf_jit_32.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/net/bpf_jit_32.c b/arch/arm/net/bpf_jit_32.c
index 6828ef6..a0bd8a7 100644
--- a/arch/arm/net/bpf_jit_32.c
+++ b/arch/arm/net/bpf_jit_32.c
@@ -576,7 +576,7 @@ load_ind:
/* x = ((*(frame + k)) & 0xf) << 2; */
ctx->seen |= SEEN_X | SEEN_DATA | SEEN_CALL;
/* the interpreter should deal with the negative K */
- if (k < 0)
+ if ((int)k < 0)
return -1;
/* offset in r1: we might have to take the slow path */
emit_mov_i(r_off, k, ctx);
--
1.7.7.6
^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH] ARM:net: an issue for k which is u32, never < 0
2013-03-10 2:15 ` Chen Gang
@ 2013-03-10 21:12 ` David Miller
-1 siblings, 0 replies; 16+ messages in thread
From: David Miller @ 2013-03-10 21:12 UTC (permalink / raw)
To: gang.chen
Cc: linux, mgherzan, nschichan, daniel.borkmann, linux-arm-kernel,
linux-kernel
From: Chen Gang <gang.chen@asianux.com>
Date: Sun, 10 Mar 2013 10:15:54 +0800
>
> k is u32 which never < 0, need type cast, or cause issue.
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
Who will apply this, ARM folks or me?
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH] ARM:net: an issue for k which is u32, never < 0
@ 2013-03-10 21:12 ` David Miller
0 siblings, 0 replies; 16+ messages in thread
From: David Miller @ 2013-03-10 21:12 UTC (permalink / raw)
To: linux-arm-kernel
From: Chen Gang <gang.chen@asianux.com>
Date: Sun, 10 Mar 2013 10:15:54 +0800
>
> k is u32 which never < 0, need type cast, or cause issue.
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
Who will apply this, ARM folks or me?
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] ARM:net: an issue for k which is u32, never < 0
2013-03-10 21:12 ` David Miller
@ 2013-03-11 4:53 ` Chen Gang
-1 siblings, 0 replies; 16+ messages in thread
From: Chen Gang @ 2013-03-11 4:53 UTC (permalink / raw)
To: David Miller
Cc: linux, mgherzan, nschichan, daniel.borkmann, linux-arm-kernel,
linux-kernel
于 2013年03月11日 05:12, David Miller 写道:
> From: Chen Gang <gang.chen@asianux.com>
> Date: Sun, 10 Mar 2013 10:15:54 +0800
>
>> >
>> > k is u32 which never < 0, need type cast, or cause issue.
>> >
>> > Signed-off-by: Chen Gang <gang.chen@asianux.com>
> Who will apply this, ARM folks or me?
>
>
sorry I don't know, either. I get the mail addresses by
./scripts/get_maintainers.pl. it includes you.
if no others reply within a week, I hope you can help to check and
apply it.
thanks.
--
Chen Gang
Asianux Corporation
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH] ARM:net: an issue for k which is u32, never < 0
@ 2013-03-11 4:53 ` Chen Gang
0 siblings, 0 replies; 16+ messages in thread
From: Chen Gang @ 2013-03-11 4:53 UTC (permalink / raw)
To: linux-arm-kernel
? 2013?03?11? 05:12, David Miller ??:
> From: Chen Gang <gang.chen@asianux.com>
> Date: Sun, 10 Mar 2013 10:15:54 +0800
>
>> >
>> > k is u32 which never < 0, need type cast, or cause issue.
>> >
>> > Signed-off-by: Chen Gang <gang.chen@asianux.com>
> Who will apply this, ARM folks or me?
>
>
sorry I don't know, either. I get the mail addresses by
./scripts/get_maintainers.pl. it includes you.
if no others reply within a week, I hope you can help to check and
apply it.
thanks.
--
Chen Gang
Asianux Corporation
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] ARM:net: an issue for k which is u32, never < 0
2013-03-10 21:12 ` David Miller
@ 2013-03-11 16:47 ` Russell King - ARM Linux
-1 siblings, 0 replies; 16+ messages in thread
From: Russell King - ARM Linux @ 2013-03-11 16:47 UTC (permalink / raw)
To: David Miller
Cc: gang.chen, mgherzan, nschichan, daniel.borkmann,
linux-arm-kernel, linux-kernel
On Sun, Mar 10, 2013 at 05:12:38PM -0400, David Miller wrote:
> From: Chen Gang <gang.chen@asianux.com>
> Date: Sun, 10 Mar 2013 10:15:54 +0800
>
> >
> > k is u32 which never < 0, need type cast, or cause issue.
> >
> > Signed-off-by: Chen Gang <gang.chen@asianux.com>
>
> Who will apply this, ARM folks or me?
I'm happy if you wish to take the patch:
Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>
Thanks.
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH] ARM:net: an issue for k which is u32, never < 0
@ 2013-03-11 16:47 ` Russell King - ARM Linux
0 siblings, 0 replies; 16+ messages in thread
From: Russell King - ARM Linux @ 2013-03-11 16:47 UTC (permalink / raw)
To: linux-arm-kernel
On Sun, Mar 10, 2013 at 05:12:38PM -0400, David Miller wrote:
> From: Chen Gang <gang.chen@asianux.com>
> Date: Sun, 10 Mar 2013 10:15:54 +0800
>
> >
> > k is u32 which never < 0, need type cast, or cause issue.
> >
> > Signed-off-by: Chen Gang <gang.chen@asianux.com>
>
> Who will apply this, ARM folks or me?
I'm happy if you wish to take the patch:
Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>
Thanks.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] ARM:net: an issue for k which is u32, never < 0
2013-03-10 2:15 ` Chen Gang
@ 2013-03-11 16:54 ` Mircea Gherzan
-1 siblings, 0 replies; 16+ messages in thread
From: Mircea Gherzan @ 2013-03-11 16:54 UTC (permalink / raw)
To: Chen Gang
Cc: Russell King - ARM Linux, nschichan, daniel.borkmann,
David Miller, linux-arm-kernel,
linux-kernel@vger.kernel.org >>
linux-kernel@vger.kernel.org
2013/3/10 Chen Gang <gang.chen@asianux.com>:
>
> k is u32 which never < 0, need type cast, or cause issue.
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> ---
> arch/arm/net/bpf_jit_32.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/net/bpf_jit_32.c b/arch/arm/net/bpf_jit_32.c
> index 6828ef6..a0bd8a7 100644
> --- a/arch/arm/net/bpf_jit_32.c
> +++ b/arch/arm/net/bpf_jit_32.c
> @@ -576,7 +576,7 @@ load_ind:
> /* x = ((*(frame + k)) & 0xf) << 2; */
> ctx->seen |= SEEN_X | SEEN_DATA | SEEN_CALL;
> /* the interpreter should deal with the negative K */
> - if (k < 0)
> + if ((int)k < 0)
> return -1;
> /* offset in r1: we might have to take the slow path */
> emit_mov_i(r_off, k, ctx);
> --
> 1.7.7.6
Acked-by: Mircea Gherzan <mgherzan@gmail.com>
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH] ARM:net: an issue for k which is u32, never < 0
@ 2013-03-11 16:54 ` Mircea Gherzan
0 siblings, 0 replies; 16+ messages in thread
From: Mircea Gherzan @ 2013-03-11 16:54 UTC (permalink / raw)
To: linux-arm-kernel
2013/3/10 Chen Gang <gang.chen@asianux.com>:
>
> k is u32 which never < 0, need type cast, or cause issue.
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> ---
> arch/arm/net/bpf_jit_32.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/net/bpf_jit_32.c b/arch/arm/net/bpf_jit_32.c
> index 6828ef6..a0bd8a7 100644
> --- a/arch/arm/net/bpf_jit_32.c
> +++ b/arch/arm/net/bpf_jit_32.c
> @@ -576,7 +576,7 @@ load_ind:
> /* x = ((*(frame + k)) & 0xf) << 2; */
> ctx->seen |= SEEN_X | SEEN_DATA | SEEN_CALL;
> /* the interpreter should deal with the negative K */
> - if (k < 0)
> + if ((int)k < 0)
> return -1;
> /* offset in r1: we might have to take the slow path */
> emit_mov_i(r_off, k, ctx);
> --
> 1.7.7.6
Acked-by: Mircea Gherzan <mgherzan@gmail.com>
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] ARM:net: an issue for k which is u32, never < 0
2013-03-11 16:47 ` Russell King - ARM Linux
@ 2013-03-12 0:01 ` Chen Gang
-1 siblings, 0 replies; 16+ messages in thread
From: Chen Gang @ 2013-03-12 0:01 UTC (permalink / raw)
To: Russell King - ARM Linux
Cc: David Miller, mgherzan, nschichan, daniel.borkmann,
linux-arm-kernel, linux-kernel
于 2013年03月12日 00:47, Russell King - ARM Linux 写道:
> On Sun, Mar 10, 2013 at 05:12:38PM -0400, David Miller wrote:
>> > From: Chen Gang <gang.chen@asianux.com>
>> > Date: Sun, 10 Mar 2013 10:15:54 +0800
>> >
>>> > >
>>> > > k is u32 which never < 0, need type cast, or cause issue.
>>> > >
>>> > > Signed-off-by: Chen Gang <gang.chen@asianux.com>
>> >
>> > Who will apply this, ARM folks or me?
> I'm happy if you wish to take the patch:
>
> Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>
>
> Thanks.
>
>
thank you very much.
:-)
--
Chen Gang
Asianux Corporation
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH] ARM:net: an issue for k which is u32, never < 0
@ 2013-03-12 0:01 ` Chen Gang
0 siblings, 0 replies; 16+ messages in thread
From: Chen Gang @ 2013-03-12 0:01 UTC (permalink / raw)
To: linux-arm-kernel
? 2013?03?12? 00:47, Russell King - ARM Linux ??:
> On Sun, Mar 10, 2013 at 05:12:38PM -0400, David Miller wrote:
>> > From: Chen Gang <gang.chen@asianux.com>
>> > Date: Sun, 10 Mar 2013 10:15:54 +0800
>> >
>>> > >
>>> > > k is u32 which never < 0, need type cast, or cause issue.
>>> > >
>>> > > Signed-off-by: Chen Gang <gang.chen@asianux.com>
>> >
>> > Who will apply this, ARM folks or me?
> I'm happy if you wish to take the patch:
>
> Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>
>
> Thanks.
>
>
thank you very much.
:-)
--
Chen Gang
Asianux Corporation
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] ARM:net: an issue for k which is u32, never < 0
2013-03-11 16:54 ` Mircea Gherzan
@ 2013-03-12 0:01 ` Chen Gang
-1 siblings, 0 replies; 16+ messages in thread
From: Chen Gang @ 2013-03-12 0:01 UTC (permalink / raw)
To: Mircea Gherzan
Cc: Russell King - ARM Linux, nschichan, daniel.borkmann,
David Miller, linux-arm-kernel,
linux-kernel@vger.kernel.org >>
linux-kernel@vger.kernel.org
于 2013年03月12日 00:54, Mircea Gherzan 写道:
> 2013/3/10 Chen Gang <gang.chen@asianux.com>:
>> >
>> > k is u32 which never < 0, need type cast, or cause issue.
>> >
>> > Signed-off-by: Chen Gang <gang.chen@asianux.com>
>> > ---
>> > arch/arm/net/bpf_jit_32.c | 2 +-
>> > 1 files changed, 1 insertions(+), 1 deletions(-)
>> >
>> > diff --git a/arch/arm/net/bpf_jit_32.c b/arch/arm/net/bpf_jit_32.c
>> > index 6828ef6..a0bd8a7 100644
>> > --- a/arch/arm/net/bpf_jit_32.c
>> > +++ b/arch/arm/net/bpf_jit_32.c
>> > @@ -576,7 +576,7 @@ load_ind:
>> > /* x = ((*(frame + k)) & 0xf) << 2; */
>> > ctx->seen |= SEEN_X | SEEN_DATA | SEEN_CALL;
>> > /* the interpreter should deal with the negative K */
>> > - if (k < 0)
>> > + if ((int)k < 0)
>> > return -1;
>> > /* offset in r1: we might have to take the slow path */
>> > emit_mov_i(r_off, k, ctx);
>> > --
>> > 1.7.7.6
> Acked-by: Mircea Gherzan <mgherzan@gmail.com>
>
>
thank you very much.
:-)
--
Chen Gang
Asianux Corporation
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH] ARM:net: an issue for k which is u32, never < 0
@ 2013-03-12 0:01 ` Chen Gang
0 siblings, 0 replies; 16+ messages in thread
From: Chen Gang @ 2013-03-12 0:01 UTC (permalink / raw)
To: linux-arm-kernel
? 2013?03?12? 00:54, Mircea Gherzan ??:
> 2013/3/10 Chen Gang <gang.chen@asianux.com>:
>> >
>> > k is u32 which never < 0, need type cast, or cause issue.
>> >
>> > Signed-off-by: Chen Gang <gang.chen@asianux.com>
>> > ---
>> > arch/arm/net/bpf_jit_32.c | 2 +-
>> > 1 files changed, 1 insertions(+), 1 deletions(-)
>> >
>> > diff --git a/arch/arm/net/bpf_jit_32.c b/arch/arm/net/bpf_jit_32.c
>> > index 6828ef6..a0bd8a7 100644
>> > --- a/arch/arm/net/bpf_jit_32.c
>> > +++ b/arch/arm/net/bpf_jit_32.c
>> > @@ -576,7 +576,7 @@ load_ind:
>> > /* x = ((*(frame + k)) & 0xf) << 2; */
>> > ctx->seen |= SEEN_X | SEEN_DATA | SEEN_CALL;
>> > /* the interpreter should deal with the negative K */
>> > - if (k < 0)
>> > + if ((int)k < 0)
>> > return -1;
>> > /* offset in r1: we might have to take the slow path */
>> > emit_mov_i(r_off, k, ctx);
>> > --
>> > 1.7.7.6
> Acked-by: Mircea Gherzan <mgherzan@gmail.com>
>
>
thank you very much.
:-)
--
Chen Gang
Asianux Corporation
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] ARM:net: an issue for k which is u32, never < 0
2013-03-11 16:47 ` Russell King - ARM Linux
@ 2013-03-12 15:33 ` David Miller
-1 siblings, 0 replies; 16+ messages in thread
From: David Miller @ 2013-03-12 15:33 UTC (permalink / raw)
To: linux
Cc: gang.chen, mgherzan, nschichan, daniel.borkmann,
linux-arm-kernel, linux-kernel
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
Date: Mon, 11 Mar 2013 16:47:41 +0000
> On Sun, Mar 10, 2013 at 05:12:38PM -0400, David Miller wrote:
>> From: Chen Gang <gang.chen@asianux.com>
>> Date: Sun, 10 Mar 2013 10:15:54 +0800
>>
>> >
>> > k is u32 which never < 0, need type cast, or cause issue.
>> >
>> > Signed-off-by: Chen Gang <gang.chen@asianux.com>
>>
>> Who will apply this, ARM folks or me?
>
> I'm happy if you wish to take the patch:
>
> Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>
Great, applied, thanks.
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH] ARM:net: an issue for k which is u32, never < 0
@ 2013-03-12 15:33 ` David Miller
0 siblings, 0 replies; 16+ messages in thread
From: David Miller @ 2013-03-12 15:33 UTC (permalink / raw)
To: linux-arm-kernel
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
Date: Mon, 11 Mar 2013 16:47:41 +0000
> On Sun, Mar 10, 2013 at 05:12:38PM -0400, David Miller wrote:
>> From: Chen Gang <gang.chen@asianux.com>
>> Date: Sun, 10 Mar 2013 10:15:54 +0800
>>
>> >
>> > k is u32 which never < 0, need type cast, or cause issue.
>> >
>> > Signed-off-by: Chen Gang <gang.chen@asianux.com>
>>
>> Who will apply this, ARM folks or me?
>
> I'm happy if you wish to take the patch:
>
> Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>
Great, applied, thanks.
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2013-03-12 15:33 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-10 2:15 [PATCH] ARM:net: an issue for k which is u32, never < 0 Chen Gang
2013-03-10 2:15 ` Chen Gang
2013-03-10 21:12 ` David Miller
2013-03-10 21:12 ` David Miller
2013-03-11 4:53 ` Chen Gang
2013-03-11 4:53 ` Chen Gang
2013-03-11 16:47 ` Russell King - ARM Linux
2013-03-11 16:47 ` Russell King - ARM Linux
2013-03-12 0:01 ` Chen Gang
2013-03-12 0:01 ` Chen Gang
2013-03-12 15:33 ` David Miller
2013-03-12 15:33 ` David Miller
2013-03-11 16:54 ` Mircea Gherzan
2013-03-11 16:54 ` Mircea Gherzan
2013-03-12 0:01 ` Chen Gang
2013-03-12 0:01 ` Chen Gang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.