From: Laxman Dewangan <ldewangan@nvidia.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"a.zummo@towertech.it" <a.zummo@towertech.it>,
"rtc-linux@googlegroups.com" <rtc-linux@googlegroups.com>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/5] rtc: tegra: use module_platform_driver_probe for module init/exit
Date: Tue, 12 Mar 2013 00:59:41 +0530 [thread overview]
Message-ID: <513E30A5.8020104@nvidia.com> (raw)
In-Reply-To: <513E1153.20207@wwwdotorg.org>
On Monday 11 March 2013 10:46 PM, Stephen Warren wrote:
> On 03/09/2013 11:09 AM, Laxman Dewangan wrote:
>> Use macro module_platform_driver_probe() to reduce some of the
>> boilerplate code in the driver.
>>
>> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
>> ---
>> drivers/rtc/rtc-tegra.c | 12 +-----------
>> 1 files changed, 1 insertions(+), 11 deletions(-)
>>
>> diff --git a/drivers/rtc/rtc-tegra.c b/drivers/rtc/rtc-tegra.c
>> index f7718de..4cba10d 100644
>> --- a/drivers/rtc/rtc-tegra.c
>> +++ b/drivers/rtc/rtc-tegra.c
>> @@ -451,17 +451,7 @@ static struct platform_driver tegra_rtc_driver = {
>> },
>> };
>>
>> -static int __init tegra_rtc_init(void)
>> -{
>> - return platform_driver_probe(&tegra_rtc_driver, tegra_rtc_probe);
>> -}
>> -module_init(tegra_rtc_init);
>> -
>> -static void __exit tegra_rtc_exit(void)
>> -{
>> - platform_driver_unregister(&tegra_rtc_driver);
>> -}
>> -module_exit(tegra_rtc_exit);
>> +module_platform_driver_probe(tegra_rtc_driver, tegra_rtc_probe);
> Out of curiosity here, why not just module_platform_driver(); can't the
> instantiation of the RTC device be driven by the presence of the DT
> node, and hence the creation of the platform device object, just like
> any other driver/device?
Theoretically it should work but I will work with John (original author)
about using the platform_driver_probe().
If he agrees then I will send patch to convert it to
module_platform_driver().
next prev parent reply other threads:[~2013-03-11 19:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-09 18:09 [PATCH 0/5] rtc: tegra: cleanups to remove warning/code lines Laxman Dewangan
2013-03-09 18:09 ` Laxman Dewangan
[not found] ` <1362852588-13362-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-03-09 18:09 ` [PATCH 1/5] rtc: tegra: protect suspend/resume callbacks with CONFIG_PM_SLEEP Laxman Dewangan
2013-03-09 18:09 ` Laxman Dewangan
[not found] ` <1362852588-13362-2-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-03-10 22:30 ` Thierry Reding
2013-03-10 22:30 ` Thierry Reding
2013-03-09 18:09 ` [PATCH 2/5] rtc: tegra: Use struct dev_pm_ops for power management Laxman Dewangan
2013-03-09 18:09 ` Laxman Dewangan
[not found] ` <1362852588-13362-3-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-03-10 22:32 ` Thierry Reding
2013-03-10 22:32 ` Thierry Reding
2013-03-09 18:09 ` [PATCH 3/5] rtc: tegra: use module_platform_driver_probe for module init/exit Laxman Dewangan
2013-03-09 18:09 ` Laxman Dewangan
[not found] ` <1362852588-13362-4-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-03-10 22:34 ` Thierry Reding
2013-03-10 22:34 ` Thierry Reding
2013-03-11 17:16 ` Stephen Warren
2013-03-11 17:16 ` Stephen Warren
2013-03-11 19:29 ` Laxman Dewangan [this message]
[not found] ` <513E30A5.8020104-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-03-11 19:46 ` Stephen Warren
2013-03-11 19:46 ` Stephen Warren
2013-03-09 18:09 ` [PATCH 4/5] rtc: tegra: set irq name as device name Laxman Dewangan
2013-03-09 18:09 ` Laxman Dewangan
[not found] ` <1362852588-13362-5-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-03-10 22:34 ` Thierry Reding
2013-03-10 22:34 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513E30A5.8020104@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=a.zummo@towertech.it \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.