From: Laxman Dewangan <ldewangan@nvidia.com> To: akpm@linux-foundation.org, a.zummo@towertech.it Cc: swarren@wwwdotorg.org, rtc-linux@googlegroups.com, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, Laxman Dewangan <ldewangan@nvidia.com> Subject: [PATCH 2/5] rtc: tegra: Use struct dev_pm_ops for power management Date: Sat, 9 Mar 2013 23:39:46 +0530 [thread overview] Message-ID: <1362852588-13362-3-git-send-email-ldewangan@nvidia.com> (raw) In-Reply-To: <1362852588-13362-1-git-send-email-ldewangan@nvidia.com> Make the Tegra RTC controller driver define its PM callbacks through a struct dev_pm_ops object rather than by using legacy PM hooks in struct platform_driver. Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com> --- drivers/rtc/rtc-tegra.c | 19 +++++++++---------- 1 files changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/rtc/rtc-tegra.c b/drivers/rtc/rtc-tegra.c index d64cde6..f7718de 100644 --- a/drivers/rtc/rtc-tegra.c +++ b/drivers/rtc/rtc-tegra.c @@ -391,10 +391,9 @@ static int __exit tegra_rtc_remove(struct platform_device *pdev) } #ifdef CONFIG_PM_SLEEP -static int tegra_rtc_suspend(struct platform_device *pdev, pm_message_t state) +static int tegra_rtc_suspend(struct device *dev) { - struct device *dev = &pdev->dev; - struct tegra_rtc_info *info = platform_get_drvdata(pdev); + struct tegra_rtc_info *info = dev_get_drvdata(dev); tegra_rtc_wait_while_busy(dev); @@ -416,10 +415,9 @@ static int tegra_rtc_suspend(struct platform_device *pdev, pm_message_t state) return 0; } -static int tegra_rtc_resume(struct platform_device *pdev) +static int tegra_rtc_resume(struct device *dev) { - struct device *dev = &pdev->dev; - struct tegra_rtc_info *info = platform_get_drvdata(pdev); + struct tegra_rtc_info *info = dev_get_drvdata(dev); dev_vdbg(dev, "Resume (device_may_wakeup=%d)\n", device_may_wakeup(dev)); @@ -431,6 +429,10 @@ static int tegra_rtc_resume(struct platform_device *pdev) } #endif +static const struct dev_pm_ops tegra_rtc_pm_ops = { + SET_SYSTEM_SLEEP_PM_OPS(tegra_rtc_suspend, tegra_rtc_resume) +}; + static void tegra_rtc_shutdown(struct platform_device *pdev) { dev_vdbg(&pdev->dev, "disabling interrupts.\n"); @@ -445,11 +447,8 @@ static struct platform_driver tegra_rtc_driver = { .name = "tegra_rtc", .owner = THIS_MODULE, .of_match_table = tegra_rtc_dt_match, + .pm = &tegra_rtc_pm_ops, }, -#ifdef CONFIG_PM_SLEEP - .suspend = tegra_rtc_suspend, - .resume = tegra_rtc_resume, -#endif }; static int __init tegra_rtc_init(void) -- 1.7.1.1
WARNING: multiple messages have this Message-ID (diff)
From: Laxman Dewangan <ldewangan@nvidia.com> To: <akpm@linux-foundation.org>, <a.zummo@towertech.it> Cc: <swarren@wwwdotorg.org>, <rtc-linux@googlegroups.com>, <linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>, Laxman Dewangan <ldewangan@nvidia.com> Subject: [PATCH 2/5] rtc: tegra: Use struct dev_pm_ops for power management Date: Sat, 9 Mar 2013 23:39:46 +0530 [thread overview] Message-ID: <1362852588-13362-3-git-send-email-ldewangan@nvidia.com> (raw) In-Reply-To: <1362852588-13362-1-git-send-email-ldewangan@nvidia.com> Make the Tegra RTC controller driver define its PM callbacks through a struct dev_pm_ops object rather than by using legacy PM hooks in struct platform_driver. Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com> --- drivers/rtc/rtc-tegra.c | 19 +++++++++---------- 1 files changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/rtc/rtc-tegra.c b/drivers/rtc/rtc-tegra.c index d64cde6..f7718de 100644 --- a/drivers/rtc/rtc-tegra.c +++ b/drivers/rtc/rtc-tegra.c @@ -391,10 +391,9 @@ static int __exit tegra_rtc_remove(struct platform_device *pdev) } #ifdef CONFIG_PM_SLEEP -static int tegra_rtc_suspend(struct platform_device *pdev, pm_message_t state) +static int tegra_rtc_suspend(struct device *dev) { - struct device *dev = &pdev->dev; - struct tegra_rtc_info *info = platform_get_drvdata(pdev); + struct tegra_rtc_info *info = dev_get_drvdata(dev); tegra_rtc_wait_while_busy(dev); @@ -416,10 +415,9 @@ static int tegra_rtc_suspend(struct platform_device *pdev, pm_message_t state) return 0; } -static int tegra_rtc_resume(struct platform_device *pdev) +static int tegra_rtc_resume(struct device *dev) { - struct device *dev = &pdev->dev; - struct tegra_rtc_info *info = platform_get_drvdata(pdev); + struct tegra_rtc_info *info = dev_get_drvdata(dev); dev_vdbg(dev, "Resume (device_may_wakeup=%d)\n", device_may_wakeup(dev)); @@ -431,6 +429,10 @@ static int tegra_rtc_resume(struct platform_device *pdev) } #endif +static const struct dev_pm_ops tegra_rtc_pm_ops = { + SET_SYSTEM_SLEEP_PM_OPS(tegra_rtc_suspend, tegra_rtc_resume) +}; + static void tegra_rtc_shutdown(struct platform_device *pdev) { dev_vdbg(&pdev->dev, "disabling interrupts.\n"); @@ -445,11 +447,8 @@ static struct platform_driver tegra_rtc_driver = { .name = "tegra_rtc", .owner = THIS_MODULE, .of_match_table = tegra_rtc_dt_match, + .pm = &tegra_rtc_pm_ops, }, -#ifdef CONFIG_PM_SLEEP - .suspend = tegra_rtc_suspend, - .resume = tegra_rtc_resume, -#endif }; static int __init tegra_rtc_init(void) -- 1.7.1.1
next prev parent reply other threads:[~2013-03-09 18:09 UTC|newest] Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-03-09 18:09 [PATCH 0/5] rtc: tegra: cleanups to remove warning/code lines Laxman Dewangan 2013-03-09 18:09 ` Laxman Dewangan [not found] ` <1362852588-13362-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2013-03-09 18:09 ` [PATCH 1/5] rtc: tegra: protect suspend/resume callbacks with CONFIG_PM_SLEEP Laxman Dewangan 2013-03-09 18:09 ` Laxman Dewangan [not found] ` <1362852588-13362-2-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2013-03-10 22:30 ` Thierry Reding 2013-03-10 22:30 ` Thierry Reding 2013-03-09 18:09 ` Laxman Dewangan [this message] 2013-03-09 18:09 ` [PATCH 2/5] rtc: tegra: Use struct dev_pm_ops for power management Laxman Dewangan [not found] ` <1362852588-13362-3-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2013-03-10 22:32 ` Thierry Reding 2013-03-10 22:32 ` Thierry Reding 2013-03-09 18:09 ` [PATCH 3/5] rtc: tegra: use module_platform_driver_probe for module init/exit Laxman Dewangan 2013-03-09 18:09 ` Laxman Dewangan [not found] ` <1362852588-13362-4-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2013-03-10 22:34 ` Thierry Reding 2013-03-10 22:34 ` Thierry Reding 2013-03-11 17:16 ` Stephen Warren 2013-03-11 17:16 ` Stephen Warren 2013-03-11 19:29 ` Laxman Dewangan [not found] ` <513E30A5.8020104-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2013-03-11 19:46 ` Stephen Warren 2013-03-11 19:46 ` Stephen Warren 2013-03-09 18:09 ` [PATCH 4/5] rtc: tegra: set irq name as device name Laxman Dewangan 2013-03-09 18:09 ` Laxman Dewangan [not found] ` <1362852588-13362-5-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2013-03-10 22:34 ` Thierry Reding 2013-03-10 22:34 ` Thierry Reding
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1362852588-13362-3-git-send-email-ldewangan@nvidia.com \ --to=ldewangan@nvidia.com \ --cc=a.zummo@towertech.it \ --cc=akpm@linux-foundation.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-tegra@vger.kernel.org \ --cc=rtc-linux@googlegroups.com \ --cc=swarren@wwwdotorg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.