From: Eric Sandeen <sandeen@redhat.com> To: Rich Johnston <rjohnston@sgi.com> Cc: xfs@oss.sgi.com, linux-btrfs@vger.kernel.org Subject: Re: [PATCH 2/3] xfstests: keep newlines out of SCRATCH_DEV_POOL Date: Wed, 13 Mar 2013 12:45:52 -0500 [thread overview] Message-ID: <5140BB50.9080403@redhat.com> (raw) In-Reply-To: <5140BAAC.4050508@sgi.com> On 3/13/13 12:43 PM, Rich Johnston wrote: > On 03/13/2013 09:57 AM, Eric Sandeen wrote: >> SCRATCH_DEV_POOL processing actually takes the first >> device out for SCRATCH_DEV and leaves the rest in >> SCRATCH_DEV_POOL. >> >> I'm not totally sold on that behavior, but for now, >> at least don't populate SCRATCH_DEV_POOL with newlines. > >> >> Cc: linux-btrfs@vger.kernel.org >> Signed-off-by: Eric Sandeen <sandeen@redhat.com> >> --- >> common.config | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/common.config b/common.config >> index ed0f44c..5ac58bf 100644 >> --- a/common.config >> +++ b/common.config >> @@ -258,7 +258,7 @@ if [ ! -z "$SCRATCH_DEV_POOL" ]; then >> exit 1 >> fi >> SCRATCH_DEV=`echo $SCRATCH_DEV_POOL | awk '{print $1}'` >> - SCRATCH_DEV_POOL=`echo $SCRATCH_DEV_POOL | awk '{ for (i = 2; i <= NF; i++) print $i}'` >> + SCRATCH_DEV_POOL=`echo $SCRATCH_DEV_POOL | awk '{ ORS=" "; for (i = 2; i <= NF; i++) print $i}'` >> fi >> >> echo $SCRATCH_DEV | grep -q ":" > /dev/null 2>&1 >> > > Is the purpose of this patch is so future improvements will be able to parse/use SCRATCH_DEV_POOL easier from within bash? Yep, and just generally since it's used as an argument, feeding a string w/ newlines to any command is just a bit odd. -Eric > Looks good Eric. > > Reviewed-by: <rjohnston@sgi.com> > > Regards > --Rich
WARNING: multiple messages have this Message-ID (diff)
From: Eric Sandeen <sandeen@redhat.com> To: Rich Johnston <rjohnston@sgi.com> Cc: linux-btrfs@vger.kernel.org, xfs@oss.sgi.com Subject: Re: [PATCH 2/3] xfstests: keep newlines out of SCRATCH_DEV_POOL Date: Wed, 13 Mar 2013 12:45:52 -0500 [thread overview] Message-ID: <5140BB50.9080403@redhat.com> (raw) In-Reply-To: <5140BAAC.4050508@sgi.com> On 3/13/13 12:43 PM, Rich Johnston wrote: > On 03/13/2013 09:57 AM, Eric Sandeen wrote: >> SCRATCH_DEV_POOL processing actually takes the first >> device out for SCRATCH_DEV and leaves the rest in >> SCRATCH_DEV_POOL. >> >> I'm not totally sold on that behavior, but for now, >> at least don't populate SCRATCH_DEV_POOL with newlines. > >> >> Cc: linux-btrfs@vger.kernel.org >> Signed-off-by: Eric Sandeen <sandeen@redhat.com> >> --- >> common.config | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/common.config b/common.config >> index ed0f44c..5ac58bf 100644 >> --- a/common.config >> +++ b/common.config >> @@ -258,7 +258,7 @@ if [ ! -z "$SCRATCH_DEV_POOL" ]; then >> exit 1 >> fi >> SCRATCH_DEV=`echo $SCRATCH_DEV_POOL | awk '{print $1}'` >> - SCRATCH_DEV_POOL=`echo $SCRATCH_DEV_POOL | awk '{ for (i = 2; i <= NF; i++) print $i}'` >> + SCRATCH_DEV_POOL=`echo $SCRATCH_DEV_POOL | awk '{ ORS=" "; for (i = 2; i <= NF; i++) print $i}'` >> fi >> >> echo $SCRATCH_DEV | grep -q ":" > /dev/null 2>&1 >> > > Is the purpose of this patch is so future improvements will be able to parse/use SCRATCH_DEV_POOL easier from within bash? Yep, and just generally since it's used as an argument, feeding a string w/ newlines to any command is just a bit odd. -Eric > Looks good Eric. > > Reviewed-by: <rjohnston@sgi.com> > > Regards > --Rich _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-03-13 17:45 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-03-13 14:57 [PATCH 0/3] xfstests patches Eric Sandeen 2013-03-13 14:57 ` [PATCH 1/3] xfstests: add 274 to the prealloc group Eric Sandeen 2013-03-13 17:36 ` Rich Johnston 2013-03-13 14:57 ` [PATCH 2/3] xfstests: keep newlines out of SCRATCH_DEV_POOL Eric Sandeen 2013-03-13 14:57 ` Eric Sandeen 2013-03-13 17:43 ` Rich Johnston 2013-03-13 17:43 ` Rich Johnston 2013-03-13 17:45 ` Eric Sandeen [this message] 2013-03-13 17:45 ` Eric Sandeen 2013-03-13 14:57 ` [PATCH 3/3] xfstests: btrfs tests for basic informational commands Eric Sandeen 2013-03-13 14:57 ` Eric Sandeen 2013-03-13 15:32 ` Stefan Behrens 2013-03-13 15:32 ` Stefan Behrens 2013-03-13 16:17 ` Eric Sandeen 2013-03-13 16:17 ` Eric Sandeen 2013-03-13 17:47 ` Rich Johnston 2013-03-13 17:47 ` Rich Johnston 2013-03-13 16:38 ` [PATCH 3/3 V2] " Eric Sandeen 2013-03-13 16:38 ` Eric Sandeen 2013-03-13 18:53 ` [PATCH 3/3 V3] " Eric Sandeen 2013-03-13 18:53 ` Eric Sandeen 2013-03-13 19:00 ` Stefan Behrens 2013-03-13 19:00 ` Stefan Behrens 2013-03-13 19:01 ` [PATCH 3/3 V4] " Eric Sandeen 2013-03-13 19:01 ` Eric Sandeen 2013-03-14 13:01 ` Rich Johnston 2013-03-14 13:01 ` Rich Johnston 2013-03-14 13:35 ` Stefan Behrens 2013-03-14 13:35 ` Stefan Behrens 2013-03-15 10:16 ` Dave Chinner 2013-03-15 10:16 ` Dave Chinner 2013-03-15 13:46 ` Eric Sandeen 2013-03-15 13:46 ` Eric Sandeen 2013-03-15 14:23 ` Rich Johnston 2013-03-15 14:23 ` Rich Johnston 2013-03-15 14:36 ` Eric Sandeen 2013-03-15 14:36 ` Eric Sandeen 2013-03-18 13:30 ` Rich Johnston 2013-03-18 13:30 ` Rich Johnston 2013-03-19 14:15 ` Rich Johnston 2013-03-19 14:15 ` Rich Johnston 2013-03-14 17:16 ` [PATCH 0/3] xfstests patches Rich Johnston 2013-03-15 5:43 ` Dave Chinner 2013-03-15 13:38 ` Rich Johnston
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5140BB50.9080403@redhat.com \ --to=sandeen@redhat.com \ --cc=linux-btrfs@vger.kernel.org \ --cc=rjohnston@sgi.com \ --cc=xfs@oss.sgi.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.