* [PATCH] IB/ipoib: correct tx lockup patch
@ 2013-02-26 15:46 Mike Marciniszyn
[not found] ` <20130226154627.3775.35111.stgit-K+u1se/DcYrLESAwzcoQNrvm/XP+8Wra@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Mike Marciniszyn @ 2013-02-26 15:46 UTC (permalink / raw)
To: roland-BHEL68pLQRGGvPXPguhicg; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA
Commit f0dc117 ("IPoIB: Fix TX queue lockup with mixed UD/CM traffic")
attempts to solve an issue were unprocessed UD send cq completions
can deadlock the netdev.
The patch doesn't fully resolve the issue because if more than
half the tx_outstanding's were UD and all of the destinations
are RC reachable, arming the CQ doesn't solve the issue.
This patch uses the IB_CQ_REPORT_MISSED_EVENTS on the
ib_req_notify_cq(). If the rc is above 0, the UD send cq
completion callback is called directly to re-arm the send
completion timer.
This issue is seen in very large parallel filesystem deployments
and has been show to correct the issue.
Cc: <stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Reviewed-by: Dean Luick <dean.luick-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Signed-off-by: Mike Marciniszyn <mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---
drivers/infiniband/ulp/ipoib/ipoib_cm.c | 8 ++++++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/ulp/ipoib/ipoib_cm.c b/drivers/infiniband/ulp/ipoib/ipoib_cm.c
index 67b0c1d..1ef880d 100644
--- a/drivers/infiniband/ulp/ipoib/ipoib_cm.c
+++ b/drivers/infiniband/ulp/ipoib/ipoib_cm.c
@@ -758,9 +758,13 @@ void ipoib_cm_send(struct net_device *dev, struct sk_buff *skb, struct ipoib_cm_
if (++priv->tx_outstanding == ipoib_sendq_size) {
ipoib_dbg(priv, "TX ring 0x%x full, stopping kernel net queue\n",
tx->qp->qp_num);
- if (ib_req_notify_cq(priv->send_cq, IB_CQ_NEXT_COMP))
- ipoib_warn(priv, "request notify on send CQ failed\n");
netif_stop_queue(dev);
+ rc = ib_req_notify_cq(priv->send_cq,
+ IB_CQ_NEXT_COMP | IB_CQ_REPORT_MISSED_EVENTS);
+ if (rc < 0)
+ ipoib_warn(priv, "request notify on send CQ failed\n");
+ else if (rc)
+ ipoib_send_comp_handler(priv->send_cq, dev);
}
}
}
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] IB/ipoib: correct tx lockup patch
[not found] ` <20130226154627.3775.35111.stgit-K+u1se/DcYrLESAwzcoQNrvm/XP+8Wra@public.gmane.org>
@ 2013-02-26 19:35 ` Roland Dreier
[not found] ` <CAL1RGDUZVybRbrVyFVqRomWXYtGZOAgOT7+GT5Pn-ZDv0k3AYQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Roland Dreier @ 2013-02-26 19:35 UTC (permalink / raw)
To: Mike Marciniszyn; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA
Nice! queued up for my next pull request, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] IB/ipoib: correct tx lockup patch
[not found] ` <CAL1RGDUZVybRbrVyFVqRomWXYtGZOAgOT7+GT5Pn-ZDv0k3AYQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2013-02-26 19:40 ` Marciniszyn, Mike
2013-03-18 8:44 ` Or Gerlitz
1 sibling, 0 replies; 4+ messages in thread
From: Marciniszyn, Mike @ 2013-02-26 19:40 UTC (permalink / raw)
To: Roland Dreier; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA
> Nice! queued up for my next pull request, thanks.
It was really Eli's excellent description on the original patch I'm refining that gave me the clue!
So that him too!
Mike
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] IB/ipoib: correct tx lockup patch
[not found] ` <CAL1RGDUZVybRbrVyFVqRomWXYtGZOAgOT7+GT5Pn-ZDv0k3AYQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-02-26 19:40 ` Marciniszyn, Mike
@ 2013-03-18 8:44 ` Or Gerlitz
1 sibling, 0 replies; 4+ messages in thread
From: Or Gerlitz @ 2013-03-18 8:44 UTC (permalink / raw)
To: Roland Dreier
Cc: Mike Marciniszyn, linux-rdma-u79uwXL29TY76Z2rM5mHXA, Shlomo Pongratz
On 26/02/2013 21:35, Roland Dreier wrote:
> Nice! queued up for my next pull request, thanks.
Hi Roland,
Are you picking this? we'd like to adopt the RSS patches on top of this fix
Or.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-03-18 8:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-26 15:46 [PATCH] IB/ipoib: correct tx lockup patch Mike Marciniszyn
[not found] ` <20130226154627.3775.35111.stgit-K+u1se/DcYrLESAwzcoQNrvm/XP+8Wra@public.gmane.org>
2013-02-26 19:35 ` Roland Dreier
[not found] ` <CAL1RGDUZVybRbrVyFVqRomWXYtGZOAgOT7+GT5Pn-ZDv0k3AYQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-02-26 19:40 ` Marciniszyn, Mike
2013-03-18 8:44 ` Or Gerlitz
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.