All of lore.kernel.org
 help / color / mirror / Atom feed
From: George Dunlap <george.dunlap@eu.citrix.com>
To: Alex Bligh <alex@alex.org.uk>
Cc: Ian Campbell <Ian.Campbell@citrix.com>,
	Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	xen-devel <xen-devel@lists.xen.org>,
	Anthony Liguori <anthony@codemonkey.ws>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCHv3] QEMU(upstream): Disable xen's use of O_DIRECT by default as it results in crashes.
Date: Mon, 18 Mar 2013 17:38:54 +0000	[thread overview]
Message-ID: <5147512E.5050501@eu.citrix.com> (raw)
In-Reply-To: <861AFE1A9C44444FD8BAEE16@Ximines.local>

On 18/03/13 16:53, Alex Bligh wrote:
> Paolo,
>
> --On 18 March 2013 17:19:14 +0100 Paolo Bonzini <pbonzini@redhat.com> wrote:
>
>> I remembered this incorrectly, sorry.  It's not from a previous run,
>> it's from the beginning of this run.  See
>> http://wiki.qemu.org/Migration/Storage for more information.
>>
>> A VM has a disk backed by NFS. It runs on node A, at which point pages
>> are introduced to the page cache. It then migrates to node B, which
>> entails starting the VM on node B while it is still running on node A.
>> Closing has yet to happen on node A, but the file is already open on
>> node B; anything that is cached on node B will never be invalidated.
>>
>> Thus, any changes done to the disk on node A during migration may not
>> become visible on node B.
> This might be a difference between Xen and KVM. On Xen migration is
> made to a server in a paused state, and it's only unpaused when
> the migration to B is complete. There's a sort of extra handshake at
> the end.

I think what you mean is that all the memory is handled by Xen and the 
toolstack, not by qemu.  The qemu state is sent as the very last thing, 
after all of the memory, and therefore (you are arguing) that qemu is 
not started, and the files cannot be opened, until after the migration 
is nearly complete, and certainly until after the file is closed on the 
sending side.

(In KVM this isn't the case because I assume it's qemu that handles the 
memory transition, and so it is likely to open the files on the 
receiving side when the migration starts.)

If so I think that should answer Paolo's argument -- but let me go 
through and verify that first.

It will have to wait until tomorrow, however. :-)

  -George

WARNING: multiple messages have this Message-ID (diff)
From: George Dunlap <george.dunlap@eu.citrix.com>
To: Alex Bligh <alex@alex.org.uk>
Cc: Ian Campbell <Ian.Campbell@citrix.com>,
	Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	xen-devel <xen-devel@lists.xen.org>,
	Anthony Liguori <anthony@codemonkey.ws>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCHv3] QEMU(upstream): Disable xen's use of O_DIRECT by default as it results in crashes.
Date: Mon, 18 Mar 2013 17:38:54 +0000	[thread overview]
Message-ID: <5147512E.5050501@eu.citrix.com> (raw)
In-Reply-To: <861AFE1A9C44444FD8BAEE16@Ximines.local>

On 18/03/13 16:53, Alex Bligh wrote:
> Paolo,
>
> --On 18 March 2013 17:19:14 +0100 Paolo Bonzini <pbonzini@redhat.com> wrote:
>
>> I remembered this incorrectly, sorry.  It's not from a previous run,
>> it's from the beginning of this run.  See
>> http://wiki.qemu.org/Migration/Storage for more information.
>>
>> A VM has a disk backed by NFS. It runs on node A, at which point pages
>> are introduced to the page cache. It then migrates to node B, which
>> entails starting the VM on node B while it is still running on node A.
>> Closing has yet to happen on node A, but the file is already open on
>> node B; anything that is cached on node B will never be invalidated.
>>
>> Thus, any changes done to the disk on node A during migration may not
>> become visible on node B.
> This might be a difference between Xen and KVM. On Xen migration is
> made to a server in a paused state, and it's only unpaused when
> the migration to B is complete. There's a sort of extra handshake at
> the end.

I think what you mean is that all the memory is handled by Xen and the 
toolstack, not by qemu.  The qemu state is sent as the very last thing, 
after all of the memory, and therefore (you are arguing) that qemu is 
not started, and the files cannot be opened, until after the migration 
is nearly complete, and certainly until after the file is closed on the 
sending side.

(In KVM this isn't the case because I assume it's qemu that handles the 
memory transition, and so it is likely to open the files on the 
receiving side when the migration starts.)

If so I think that should answer Paolo's argument -- but let me go 
through and verify that first.

It will have to wait until tomorrow, however. :-)

  -George

  reply	other threads:[~2013-03-18 17:39 UTC|newest]

Thread overview: 99+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-18 12:18 [Qemu-devel] [PATCHv3] QEMU(upstream): Disable xen's use of O_DIRECT by default as it results in crashes Alex Bligh
2013-03-18 12:18 ` Alex Bligh
2013-03-18 13:03 ` [Qemu-devel] " Stefan Hajnoczi
2013-03-18 13:03 ` Stefan Hajnoczi
2013-03-18 13:19   ` Alex Bligh
2013-03-18 13:32 ` Paolo Bonzini
2013-03-18 13:49   ` Alex Bligh
2013-03-18 13:49   ` Alex Bligh
2013-03-18 14:05     ` Paolo Bonzini
2013-03-18 14:30       ` Alex Bligh
2013-03-18 14:49         ` Paolo Bonzini
2013-03-18 15:40           ` Alex Bligh
2013-03-18 15:40           ` [Qemu-devel] " Alex Bligh
2013-03-18 16:19             ` Paolo Bonzini
2013-03-18 16:19             ` [Qemu-devel] " Paolo Bonzini
2013-03-18 16:53               ` Alex Bligh
2013-03-18 16:53                 ` Alex Bligh
2013-03-18 17:38                 ` George Dunlap [this message]
2013-03-18 17:38                   ` George Dunlap
2013-03-18 17:47                   ` [Qemu-devel] " Alex Bligh
2013-03-18 17:47                     ` Alex Bligh
2013-03-18 18:00                   ` [Qemu-devel] " Paolo Bonzini
2013-03-19 10:06                     ` George Dunlap
2013-03-19 10:06                     ` [Qemu-devel] [Xen-devel] " George Dunlap
2013-03-19 10:43                       ` Paolo Bonzini
2013-03-19 10:43                       ` [Qemu-devel] [Xen-devel] " Paolo Bonzini
2013-03-19 10:51                         ` George Dunlap
2013-03-19 11:14                           ` Paolo Bonzini
2013-03-19 11:14                           ` [Qemu-devel] [Xen-devel] " Paolo Bonzini
2013-03-19 11:21                             ` George Dunlap
2013-03-19 11:21                               ` George Dunlap
2013-03-19 15:12                               ` George Dunlap
2013-03-19 15:12                               ` [Qemu-devel] [Xen-devel] " George Dunlap
2013-03-19 15:29                                 ` George Dunlap
2013-03-19 15:29                                 ` [Qemu-devel] [Xen-devel] " George Dunlap
2013-03-19 19:15                                   ` [Qemu-devel] " Alex Bligh
2013-03-19 19:15                                   ` [Qemu-devel] [Xen-devel] " Alex Bligh
2013-03-20 10:24                                     ` Stefano Stabellini
2013-03-20 10:37                                       ` [Qemu-devel] " George Dunlap
2013-03-20 10:37                                       ` [Qemu-devel] [Xen-devel] " George Dunlap
2013-03-20 11:08                                         ` Paolo Bonzini
2013-03-20 11:20                                           ` Alex Bligh
2013-03-20 11:20                                           ` [Qemu-devel] [Xen-devel] " Alex Bligh
2013-03-20 11:08                                         ` Paolo Bonzini
2013-03-20 11:57                                       ` [Qemu-devel] [Xen-devel] " David Scott
2013-03-20 11:57                                         ` [Qemu-devel] " David Scott
2013-03-20 10:24                                     ` Stefano Stabellini
2013-03-19 11:44                             ` [Qemu-devel] [Xen-devel] " Alex Bligh
2013-03-19 11:49                               ` Paolo Bonzini
2013-03-19 11:49                               ` [Qemu-devel] [Xen-devel] " Paolo Bonzini
2013-03-19 11:44                             ` Alex Bligh
2013-03-19 10:51                         ` George Dunlap
2013-03-19 15:13                         ` [Qemu-devel] [Xen-devel] " Stefano Stabellini
2013-03-19 16:53                           ` Paolo Bonzini
2013-03-19 17:03                             ` Stefano Stabellini
2013-03-19 17:03                             ` Stefano Stabellini
2013-03-19 16:53                           ` Paolo Bonzini
2013-03-20  8:33                           ` [Qemu-devel] [Xen-devel] " Alex Bligh
2013-03-20  8:33                             ` Alex Bligh
2013-03-20  9:26                             ` Paolo Bonzini
2013-03-20  9:26                             ` [Qemu-devel] [Xen-devel] " Paolo Bonzini
2013-03-29 17:19                               ` Stefano Stabellini
2013-03-29 17:19                                 ` Stefano Stabellini
2013-03-31 19:53                                 ` Alex Bligh
2013-03-31 19:53                                 ` [Qemu-devel] [Xen-devel] " Alex Bligh
2013-04-01 15:32                                   ` [Qemu-devel] [PATCH] [RFC] Xen PV backend: Move call to bdrv_new from blk_init to blk_connect Alex Bligh
2013-04-01 15:32                                     ` Alex Bligh
2013-04-01 15:44                                     ` [Qemu-devel] " Stefano Stabellini
2013-04-01 20:56                                       ` Alex Bligh
2013-04-01 20:56                                       ` [Qemu-devel] " Alex Bligh
2013-04-02 11:08                                         ` Stefano Stabellini
2013-04-02 11:08                                         ` [Qemu-devel] " Stefano Stabellini
2013-04-05 10:31                                           ` [PATCHv2 1/2] " Alex Bligh
2013-04-05 10:31                                           ` [Qemu-devel] " Alex Bligh
2013-04-05 10:31                                             ` [PATCHv2 2/2] Xen PV backend: Disable use of O_DIRECT by default as it results in crashes Alex Bligh
2013-04-05 10:31                                             ` [Qemu-devel] " Alex Bligh
2013-04-05 14:22                                             ` [PATCHv2 1/2] Xen PV backend: Move call to bdrv_new from blk_init to blk_connect Stefano Stabellini
2013-04-05 14:22                                             ` [Qemu-devel] " Stefano Stabellini
2013-04-05 15:42                                               ` [PATCHv3 " Alex Bligh
2013-04-05 15:42                                               ` [Qemu-devel] " Alex Bligh
2013-04-05 15:42                                                 ` [PATCHv3 2/2] Xen PV backend: Disable use of O_DIRECT by default as it results in crashes Alex Bligh
2013-04-05 15:42                                                 ` [Qemu-devel] " Alex Bligh
2013-04-05 15:43                                               ` [Qemu-devel] [PATCHv2 1/2] Xen PV backend: Move call to bdrv_new from blk_init to blk_connect Alex Bligh
2013-04-05 15:43                                               ` Alex Bligh
2013-04-05 10:32                                           ` [PATCHv2 1/2] Xen PV backend (for qemu-upstream-4.2-testing): " Alex Bligh
2013-04-05 10:32                                           ` [Qemu-devel] " Alex Bligh
2013-04-05 10:32                                             ` [PATCHv2 2/2] Xen PV backend (for qemu-upstream-4.2-testing): Disable use of O_DIRECT by default as it results in crashes Alex Bligh
2013-04-05 10:32                                             ` [Qemu-devel] " Alex Bligh
2013-04-05 10:34                                           ` [PATCH] [RFC] Xen PV backend: Move call to bdrv_new from blk_init to blk_connect Alex Bligh
2013-04-05 10:34                                           ` [Qemu-devel] " Alex Bligh
2013-04-01 15:44                                     ` Stefano Stabellini
2013-04-01 16:35                                   ` [Qemu-devel] [Xen-devel] [PATCHv3] QEMU(upstream): Disable xen's use of O_DIRECT by default as it results in crashes Alex Bligh
2013-04-01 16:35                                     ` Alex Bligh
2013-03-19 15:13                         ` Stefano Stabellini
2013-03-18 18:00                   ` Paolo Bonzini
2013-03-18 14:49         ` Paolo Bonzini
2013-03-18 14:30       ` [Qemu-devel] " Alex Bligh
2013-03-18 14:05     ` Paolo Bonzini
2013-03-18 13:32 ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5147512E.5050501@eu.citrix.com \
    --to=george.dunlap@eu.citrix.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=Stefano.Stabellini@eu.citrix.com \
    --cc=alex@alex.org.uk \
    --cc=anthony@codemonkey.ws \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.