All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: Mark Brown
	<broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
Cc: "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
	"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"lrg-l0cyMroinI0@public.gmane.org"
	<lrg-l0cyMroinI0@public.gmane.org>
Subject: Re: [PATCH 2/2] regulator: palmas: add input supply names
Date: Wed, 20 Mar 2013 18:24:54 +0530	[thread overview]
Message-ID: <5149B19E.90400@nvidia.com> (raw)
In-Reply-To: <20130320123128.GM28775-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>

On Wednesday 20 March 2013 06:01 PM, Mark Brown wrote:
> * PGP Signed by an unknown key
>
> On Mon, Mar 18, 2013 at 02:59:48PM +0530, Laxman Dewangan wrote:
>
> There's something odd about several recent patch serieses you've posted,
> they end up with patch 2 before instead of after patch 1.  Anyway...

I generally send a patches on single git-send command
git send-emal --to=ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org 0000.patch 0001.patch

So file names are in seq but not sure why it is not on seq. Something 
mail exchange  resuffle.
Probably I need to send one by one...


>
>> +		if (config.init_data)
>> +			pmic->desc[id].supply_name = palmas_regs_info[id].sname;
>> +
> This looks wrong...  why is it conditional on init_data?

Some of the rails are not used in board and hence their inputs are also 
left floating (unconnected). In this case, during DT population, I did 
not put entry
i.e. if ldo1 is not used then ldo1-in is not connected on board and hence
entry on DT

ldo1-in-supply=<&xyzreg>;

is not there.

The regulator core register the regulator even if there is NULL 
init_data and in this case, it tries to findout the input-supply 
(provided through desc->supply_name) and it fails to find out the supply 
handle and so regulator register fails cause all regulator registration 
to fail.

So providing the dec->supply_name only in case of valid init_data.

WARNING: multiple messages have this Message-ID (diff)
From: Laxman Dewangan <ldewangan@nvidia.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Stephen Warren <swarren@nvidia.com>,
	"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
	"lrg@ti.com" <lrg@ti.com>
Subject: Re: [PATCH 2/2] regulator: palmas: add input supply names
Date: Wed, 20 Mar 2013 18:24:54 +0530	[thread overview]
Message-ID: <5149B19E.90400@nvidia.com> (raw)
In-Reply-To: <20130320123128.GM28775@opensource.wolfsonmicro.com>

On Wednesday 20 March 2013 06:01 PM, Mark Brown wrote:
> * PGP Signed by an unknown key
>
> On Mon, Mar 18, 2013 at 02:59:48PM +0530, Laxman Dewangan wrote:
>
> There's something odd about several recent patch serieses you've posted,
> they end up with patch 2 before instead of after patch 1.  Anyway...

I generally send a patches on single git-send command
git send-emal --to=ldewangan@nvidia.com 0000.patch 0001.patch

So file names are in seq but not sure why it is not on seq. Something 
mail exchange  resuffle.
Probably I need to send one by one...


>
>> +		if (config.init_data)
>> +			pmic->desc[id].supply_name = palmas_regs_info[id].sname;
>> +
> This looks wrong...  why is it conditional on init_data?

Some of the rails are not used in board and hence their inputs are also 
left floating (unconnected). In this case, during DT population, I did 
not put entry
i.e. if ldo1 is not used then ldo1-in is not connected on board and hence
entry on DT

ldo1-in-supply=<&xyzreg>;

is not there.

The regulator core register the regulator even if there is NULL 
init_data and in this case, it tries to findout the input-supply 
(provided through desc->supply_name) and it fails to find out the supply 
handle and so regulator register fails cause all regulator registration 
to fail.

So providing the dec->supply_name only in case of valid init_data.




  parent reply	other threads:[~2013-03-20 12:54 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-18  9:29 [PATCH 2/2] regulator: palmas: add input supply names Laxman Dewangan
2013-03-18  9:29 ` Laxman Dewangan
2013-03-18  9:29 ` [PATCH 1/2] regulator: palmas: rename probe/remove callback functions Laxman Dewangan
2013-03-18  9:29   ` Laxman Dewangan
     [not found] ` <20130320123128.GM28775@opensource.wolfsonmicro.com>
     [not found]   ` <20130320123128.GM28775-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2013-03-20 12:54     ` Laxman Dewangan [this message]
2013-03-20 12:54       ` [PATCH 2/2] regulator: palmas: add input supply names Laxman Dewangan
     [not found]       ` <20130320132531.GO28775@opensource.wolfsonmicro.com>
     [not found]         ` <20130320132531.GO28775-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2013-03-20 13:32           ` Laxman Dewangan
2013-03-20 13:32             ` Laxman Dewangan
     [not found]       ` <5149B19E.90400-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-03-20 16:07         ` Stephen Warren
2013-03-20 16:07           ` Stephen Warren
     [not found]           ` <20130320163833.GT28775@opensource.wolfsonmicro.com>
     [not found]             ` <20130320163833.GT28775-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2013-03-20 16:42               ` Stephen Warren
2013-03-20 16:42                 ` Stephen Warren
     [not found]                 ` <20130320165227.GU28775@opensource.wolfsonmicro.com>
     [not found]                   ` <20130320165227.GU28775-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2013-03-20 16:56                     ` Stephen Warren
2013-03-20 16:56                       ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5149B19E.90400@nvidia.com \
    --to=ldewangan-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
    --cc=broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=lrg-l0cyMroinI0@public.gmane.org \
    --cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.