From: Konstantin Khlebnikov <khlebnikov@openvz.org> To: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> Cc: Andrew Morton <akpm@linux-foundation.org>, Mel Gorman <mgorman@suse.de>, Hugh Dickins <hughd@google.com>, Rik van Riel <riel@redhat.com>, KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] hugetlbfs: stop setting VM_DONTDUMP in initializing vma(VM_HUGETLB) Date: Thu, 28 Mar 2013 21:03:16 +0400 [thread overview] Message-ID: <515477D4.1060206@openvz.org> (raw) In-Reply-To: <1364485358-8745-2-git-send-email-n-horiguchi@ah.jp.nec.com> Naoya Horiguchi wrote: > Currently we fail to include any data on hugepages into coredump, > because VM_DONTDUMP is set on hugetlbfs's vma. This behavior was recently > introduced by commit 314e51b98 "mm: kill vma flag VM_RESERVED and > mm->reserved_vm counter". This looks to me a serious regression, > so let's fix it. That was introduced in my patch? Really? Here was VM_RESERVED and it had the same effect as VM_DONTDUMP. At least I thought so. > > Signed-off-by: Naoya Horiguchi<n-horiguchi@ah.jp.nec.com> > Cc: Konstantin Khlebnikov<khlebnikov@openvz.org> > --- > fs/hugetlbfs/inode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git v3.9-rc3.orig/fs/hugetlbfs/inode.c v3.9-rc3/fs/hugetlbfs/inode.c > index 84e3d85..523464e 100644 > --- v3.9-rc3.orig/fs/hugetlbfs/inode.c > +++ v3.9-rc3/fs/hugetlbfs/inode.c > @@ -110,7 +110,7 @@ static int hugetlbfs_file_mmap(struct file *file, struct vm_area_struct *vma) > * way when do_mmap_pgoff unwinds (may be important on powerpc > * and ia64). > */ > - vma->vm_flags |= VM_HUGETLB | VM_DONTEXPAND | VM_DONTDUMP; > + vma->vm_flags |= VM_HUGETLB | VM_DONTEXPAND; > vma->vm_ops =&hugetlb_vm_ops; > > if (vma->vm_pgoff& (~huge_page_mask(h)>> PAGE_SHIFT))
WARNING: multiple messages have this Message-ID (diff)
From: Konstantin Khlebnikov <khlebnikov@openvz.org> To: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> Cc: Andrew Morton <akpm@linux-foundation.org>, Mel Gorman <mgorman@suse.de>, Hugh Dickins <hughd@google.com>, Rik van Riel <riel@redhat.com>, KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] hugetlbfs: stop setting VM_DONTDUMP in initializing vma(VM_HUGETLB) Date: Thu, 28 Mar 2013 21:03:16 +0400 [thread overview] Message-ID: <515477D4.1060206@openvz.org> (raw) In-Reply-To: <1364485358-8745-2-git-send-email-n-horiguchi@ah.jp.nec.com> Naoya Horiguchi wrote: > Currently we fail to include any data on hugepages into coredump, > because VM_DONTDUMP is set on hugetlbfs's vma. This behavior was recently > introduced by commit 314e51b98 "mm: kill vma flag VM_RESERVED and > mm->reserved_vm counter". This looks to me a serious regression, > so let's fix it. That was introduced in my patch? Really? Here was VM_RESERVED and it had the same effect as VM_DONTDUMP. At least I thought so. > > Signed-off-by: Naoya Horiguchi<n-horiguchi@ah.jp.nec.com> > Cc: Konstantin Khlebnikov<khlebnikov@openvz.org> > --- > fs/hugetlbfs/inode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git v3.9-rc3.orig/fs/hugetlbfs/inode.c v3.9-rc3/fs/hugetlbfs/inode.c > index 84e3d85..523464e 100644 > --- v3.9-rc3.orig/fs/hugetlbfs/inode.c > +++ v3.9-rc3/fs/hugetlbfs/inode.c > @@ -110,7 +110,7 @@ static int hugetlbfs_file_mmap(struct file *file, struct vm_area_struct *vma) > * way when do_mmap_pgoff unwinds (may be important on powerpc > * and ia64). > */ > - vma->vm_flags |= VM_HUGETLB | VM_DONTEXPAND | VM_DONTDUMP; > + vma->vm_flags |= VM_HUGETLB | VM_DONTEXPAND; > vma->vm_ops =&hugetlb_vm_ops; > > if (vma->vm_pgoff& (~huge_page_mask(h)>> PAGE_SHIFT)) -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-03-28 17:03 UTC|newest] Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-03-28 15:42 [PATCH 0/2] fix hugepage coredump Naoya Horiguchi 2013-03-28 15:42 ` [PATCH 1/2] hugetlbfs: stop setting VM_DONTDUMP in initializing vma(VM_HUGETLB) Naoya Horiguchi 2013-03-28 15:42 ` Naoya Horiguchi 2013-03-28 15:51 ` Greg KH 2013-03-28 15:51 ` Greg KH 2013-03-28 16:04 ` Naoya Horiguchi 2013-03-28 16:04 ` Naoya Horiguchi 2013-03-28 19:39 ` Ben Hutchings 2013-03-28 19:39 ` Ben Hutchings 2013-03-28 19:47 ` Naoya Horiguchi 2013-03-28 19:47 ` Naoya Horiguchi 2013-03-28 17:03 ` Konstantin Khlebnikov [this message] 2013-03-28 17:03 ` Konstantin Khlebnikov 2013-03-28 18:29 ` Naoya Horiguchi 2013-03-28 18:29 ` Naoya Horiguchi 2013-03-29 5:30 ` Konstantin Khlebnikov 2013-03-29 5:30 ` Konstantin Khlebnikov 2013-03-29 12:09 ` Konstantin Khlebnikov 2013-03-29 12:09 ` Konstantin Khlebnikov 2013-03-29 16:59 ` Naoya Horiguchi 2013-03-29 16:59 ` Naoya Horiguchi 2013-03-29 13:47 ` Michal Hocko 2013-03-29 13:47 ` Michal Hocko 2013-03-28 15:42 ` [PATCH 2/2] hugetlbfs: add swap entry check in follow_hugetlb_page() Naoya Horiguchi 2013-03-28 15:42 ` Naoya Horiguchi 2013-03-29 13:57 ` Michal Hocko 2013-03-29 13:57 ` Michal Hocko 2013-03-29 17:23 ` Naoya Horiguchi 2013-03-29 17:23 ` Naoya Horiguchi 2013-04-02 9:24 ` Michal Hocko 2013-04-02 9:24 ` Michal Hocko 2013-04-02 14:35 ` Naoya Horiguchi 2013-04-02 14:35 ` Naoya Horiguchi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=515477D4.1060206@openvz.org \ --to=khlebnikov@openvz.org \ --cc=akpm@linux-foundation.org \ --cc=hughd@google.com \ --cc=kosaki.motohiro@jp.fujitsu.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mgorman@suse.de \ --cc=n-horiguchi@ah.jp.nec.com \ --cc=riel@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.