From: Simon Jeons <simon.jeons@gmail.com> To: David Rientjes <rientjes@google.com> Cc: Zhouping Liu <zliu@redhat.com>, Andrea Arcangeli <aarcange@redhat.com>, Hugh Dickins <hughd@google.com>, Mel Gorman <mgorman@suse.de>, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Amos Kong <akong@redhat.com> Subject: Re: THP: AnonHugePages in /proc/[pid]/smaps is correct or not? Date: Wed, 03 Apr 2013 07:58:25 +0800 [thread overview] Message-ID: <515B70A1.3040200@gmail.com> (raw) In-Reply-To: <alpine.DEB.2.02.1304021106190.17138@chino.kir.corp.google.com> Hi David, On 04/03/2013 02:09 AM, David Rientjes wrote: > On Tue, 2 Apr 2013, Simon Jeons wrote: > >> Both thp and hugetlb pages should be 2MB aligned, correct? >> > To answer this question and your followup reply at the same time: they > come from one level higher in the page table so they will naturally need > to be 2MB aligned. When I hacking arch/x86/mm/hugetlbpage.c like this, diff --git a/arch/x86/mm/hugetlbpage.c b/arch/x86/mm/hugetlbpage.c index ae1aa71..87f34ee 100644 --- a/arch/x86/mm/hugetlbpage.c +++ b/arch/x86/mm/hugetlbpage.c @@ -354,14 +354,13 @@ hugetlb_get_unmapped_area(struct file *file, unsigned long addr, #endif /*HAVE_ARCH_HUGETLB_UNMAPPED_AREA*/ -#ifdef CONFIG_X86_64 static __init int setup_hugepagesz(char *opt) { unsigned long ps = memparse(opt, &opt); if (ps == PMD_SIZE) { hugetlb_add_hstate(PMD_SHIFT - PAGE_SHIFT); - } else if (ps == PUD_SIZE && cpu_has_gbpages) { - hugetlb_add_hstate(PUD_SHIFT - PAGE_SHIFT); + } else if (ps == PUD_SIZE) { + hugetlb_add_hstate(PMD_SHIFT - PAGE_SHIFT+4); } else { printk(KERN_ERR "hugepagesz: Unsupported page size %lu M\n", ps >> 20); I set boot=hugepagesz=1G hugepages=10, then I got 10 32MB huge pages. What's the difference between these pages which I hacking and normal huge pages?
WARNING: multiple messages have this Message-ID (diff)
From: Simon Jeons <simon.jeons@gmail.com> To: David Rientjes <rientjes@google.com> Cc: Zhouping Liu <zliu@redhat.com>, Andrea Arcangeli <aarcange@redhat.com>, Hugh Dickins <hughd@google.com>, Mel Gorman <mgorman@suse.de>, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Amos Kong <akong@redhat.com> Subject: Re: THP: AnonHugePages in /proc/[pid]/smaps is correct or not? Date: Wed, 03 Apr 2013 07:58:25 +0800 [thread overview] Message-ID: <515B70A1.3040200@gmail.com> (raw) In-Reply-To: <alpine.DEB.2.02.1304021106190.17138@chino.kir.corp.google.com> Hi David, On 04/03/2013 02:09 AM, David Rientjes wrote: > On Tue, 2 Apr 2013, Simon Jeons wrote: > >> Both thp and hugetlb pages should be 2MB aligned, correct? >> > To answer this question and your followup reply at the same time: they > come from one level higher in the page table so they will naturally need > to be 2MB aligned. When I hacking arch/x86/mm/hugetlbpage.c like this, diff --git a/arch/x86/mm/hugetlbpage.c b/arch/x86/mm/hugetlbpage.c index ae1aa71..87f34ee 100644 --- a/arch/x86/mm/hugetlbpage.c +++ b/arch/x86/mm/hugetlbpage.c @@ -354,14 +354,13 @@ hugetlb_get_unmapped_area(struct file *file, unsigned long addr, #endif /*HAVE_ARCH_HUGETLB_UNMAPPED_AREA*/ -#ifdef CONFIG_X86_64 static __init int setup_hugepagesz(char *opt) { unsigned long ps = memparse(opt, &opt); if (ps == PMD_SIZE) { hugetlb_add_hstate(PMD_SHIFT - PAGE_SHIFT); - } else if (ps == PUD_SIZE && cpu_has_gbpages) { - hugetlb_add_hstate(PUD_SHIFT - PAGE_SHIFT); + } else if (ps == PUD_SIZE) { + hugetlb_add_hstate(PMD_SHIFT - PAGE_SHIFT+4); } else { printk(KERN_ERR "hugepagesz: Unsupported page size %lu M\n", ps >> 20); I set boot=hugepagesz=1G hugepages=10, then I got 10 32MB huge pages. What's the difference between these pages which I hacking and normal huge pages? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-04-02 23:58 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <1207916095.642011.1364800448075.JavaMail.root@redhat.com> 2013-04-01 8:00 ` THP: AnonHugePages in /proc/[pid]/smaps is correct or not? Zhouping Liu 2013-04-01 8:00 ` Zhouping Liu 2013-04-01 22:23 ` David Rientjes 2013-04-01 22:23 ` David Rientjes 2013-04-02 3:09 ` Zhouping Liu 2013-04-02 3:09 ` Zhouping Liu 2013-04-02 3:40 ` Lin Feng 2013-04-02 3:40 ` Lin Feng 2013-04-02 3:44 ` David Rientjes 2013-04-02 3:44 ` David Rientjes 2013-04-02 3:48 ` Zhouping Liu 2013-04-02 3:48 ` Zhouping Liu 2013-04-02 12:23 ` Simon Jeons 2013-04-02 12:23 ` Simon Jeons 2013-04-02 18:09 ` David Rientjes 2013-04-02 18:09 ` David Rientjes 2013-04-02 23:58 ` Simon Jeons [this message] 2013-04-02 23:58 ` Simon Jeons 2013-04-02 12:26 ` Simon Jeons 2013-04-02 12:26 ` Simon Jeons
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=515B70A1.3040200@gmail.com \ --to=simon.jeons@gmail.com \ --cc=aarcange@redhat.com \ --cc=akong@redhat.com \ --cc=hughd@google.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mgorman@suse.de \ --cc=rientjes@google.com \ --cc=zliu@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.