All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: rjw@sisk.pl
Cc: deepthi@linux.vnet.ibm.com, linaro-kernel@lists.linaro.org,
	linux@arm.linux.org.uk, swarren@wwwdotorg.org,
	patches@linaro.org, linux-pm@vger.kernel.org, rnayak@ti.com,
	nsekhar@ti.com, josephl@nvidia.com, linux-tegra@vger.kernel.org,
	horms+renesas@verge.net.au, linux-arm-kernel@lists.infradead.org,
	lenb@kernel.org
Subject: Re: [PATCH 1/9] ARM: cpuidle: remove useless declaration
Date: Wed, 03 Apr 2013 14:23:23 +0200	[thread overview]
Message-ID: <515C1F3B.5040008@linaro.org> (raw)
In-Reply-To: <1364991322-20585-1-git-send-email-daniel.lezcano@linaro.org>

On 04/03/2013 02:15 PM, Daniel Lezcano wrote:
> The noop functions code is not necessary because the header file is
> included in files which are compiled when CONFIG_CPU_IDLE is on.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>

I have been involved in the development of this file. I know Rob is no
longer working on this neither monitoring the code.

Russell are you ok with this patch ? Rafael needs your ack to take this
patch into its tree.

Thanks

-- Daniel

> ---
>  arch/arm/include/asm/cpuidle.h |    7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/arch/arm/include/asm/cpuidle.h b/arch/arm/include/asm/cpuidle.h
> index 2fca60a..7367787 100644
> --- a/arch/arm/include/asm/cpuidle.h
> +++ b/arch/arm/include/asm/cpuidle.h
> @@ -1,13 +1,8 @@
>  #ifndef __ASM_ARM_CPUIDLE_H
>  #define __ASM_ARM_CPUIDLE_H
>  
> -#ifdef CONFIG_CPU_IDLE
>  extern int arm_cpuidle_simple_enter(struct cpuidle_device *dev,
> -		struct cpuidle_driver *drv, int index);
> -#else
> -static inline int arm_cpuidle_simple_enter(struct cpuidle_device *dev,
> -		struct cpuidle_driver *drv, int index) { return -ENODEV; }
> -#endif
> +				    struct cpuidle_driver *drv, int index);
>  
>  /* Common ARM WFI state */
>  #define ARM_CPUIDLE_WFI_STATE_PWR(p) {\


-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog


WARNING: multiple messages have this Message-ID (diff)
From: daniel.lezcano@linaro.org (Daniel Lezcano)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/9] ARM: cpuidle: remove useless declaration
Date: Wed, 03 Apr 2013 14:23:23 +0200	[thread overview]
Message-ID: <515C1F3B.5040008@linaro.org> (raw)
In-Reply-To: <1364991322-20585-1-git-send-email-daniel.lezcano@linaro.org>

On 04/03/2013 02:15 PM, Daniel Lezcano wrote:
> The noop functions code is not necessary because the header file is
> included in files which are compiled when CONFIG_CPU_IDLE is on.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>

I have been involved in the development of this file. I know Rob is no
longer working on this neither monitoring the code.

Russell are you ok with this patch ? Rafael needs your ack to take this
patch into its tree.

Thanks

-- Daniel

> ---
>  arch/arm/include/asm/cpuidle.h |    7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/arch/arm/include/asm/cpuidle.h b/arch/arm/include/asm/cpuidle.h
> index 2fca60a..7367787 100644
> --- a/arch/arm/include/asm/cpuidle.h
> +++ b/arch/arm/include/asm/cpuidle.h
> @@ -1,13 +1,8 @@
>  #ifndef __ASM_ARM_CPUIDLE_H
>  #define __ASM_ARM_CPUIDLE_H
>  
> -#ifdef CONFIG_CPU_IDLE
>  extern int arm_cpuidle_simple_enter(struct cpuidle_device *dev,
> -		struct cpuidle_driver *drv, int index);
> -#else
> -static inline int arm_cpuidle_simple_enter(struct cpuidle_device *dev,
> -		struct cpuidle_driver *drv, int index) { return -ENODEV; }
> -#endif
> +				    struct cpuidle_driver *drv, int index);
>  
>  /* Common ARM WFI state */
>  #define ARM_CPUIDLE_WFI_STATE_PWR(p) {\


-- 
 <http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

  parent reply	other threads:[~2013-04-03 12:23 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-03 12:15 [PATCH 1/9] ARM: cpuidle: remove useless declaration Daniel Lezcano
2013-04-03 12:15 ` Daniel Lezcano
     [not found] ` <1364991322-20585-1-git-send-email-daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2013-04-03 12:15   ` [PATCH 2/9] ARM: shmobile: pm: fix init sections Daniel Lezcano
2013-04-03 12:15     ` Daniel Lezcano
2013-04-03 12:15   ` [PATCH 3/9] ARM: shmobile: cpuidle: remove useless WFI function Daniel Lezcano
2013-04-03 12:15     ` Daniel Lezcano
2013-04-03 12:15   ` [PATCH 6/9] ARM: davinci: cpuidle: fix wrong enter function Daniel Lezcano
2013-04-03 12:15     ` Daniel Lezcano
2013-04-04  7:16     ` Sekhar Nori
2013-04-04  7:16       ` Sekhar Nori
2013-04-03 12:15   ` [PATCH 9/9] POWERPC: pseries: cpuidle: use time keeping flag Daniel Lezcano
2013-04-03 12:15     ` Daniel Lezcano
     [not found]     ` <1364991322-20585-9-git-send-email-daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2013-04-03 14:25       ` Daniel Lezcano
2013-04-03 14:25         ` Daniel Lezcano
2013-04-04 11:01         ` Deepthi Dharwar
2013-04-04 11:01           ` Deepthi Dharwar
2013-04-04 22:30   ` [PATCH 1/9] ARM: cpuidle: remove useless declaration Rafael J. Wysocki
2013-04-04 22:30     ` Rafael J. Wysocki
2013-04-03 12:15 ` [PATCH 4/9] ARM: tegra2: cpuidle: change driver initialization Daniel Lezcano
2013-04-03 12:15   ` Daniel Lezcano
2013-04-03 12:15 ` [PATCH 5/9] ARM: tegra: cpuidle: remove useless initialization Daniel Lezcano
2013-04-03 12:15   ` Daniel Lezcano
2013-04-03 12:15 ` [PATCH 7/9] intel: cpuidle: remove stop/start critical timings Daniel Lezcano
2013-04-03 12:15   ` Daniel Lezcano
     [not found]   ` <1364991322-20585-7-git-send-email-daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2013-04-04 22:31     ` Rafael J. Wysocki
2013-04-04 22:31       ` Rafael J. Wysocki
     [not found]       ` <3375360.P4DAA9Jd5Y-sKB8Sp2ER+y1GS7QM15AGw@public.gmane.org>
2013-04-07 20:52         ` Daniel Lezcano
2013-04-07 20:52           ` Daniel Lezcano
     [not found]           ` <5161DC9C.3020703-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2013-04-08 17:40             ` Daniel Lezcano
2013-04-08 17:40               ` Daniel Lezcano
     [not found]               ` <51630115.6040205-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2013-04-08 19:27                 ` Rafael J. Wysocki
2013-04-08 19:27                   ` Rafael J. Wysocki
2013-04-08 19:27                   ` Daniel Lezcano
2013-04-08 19:27                     ` Daniel Lezcano
2013-04-19 22:02     ` Len Brown
2013-04-19 22:02       ` Len Brown
2013-04-03 12:15 ` [PATCH 8/9] ARM: omap3: cpuidle: enable time keeping Daniel Lezcano
2013-04-03 12:15   ` Daniel Lezcano
2013-04-03 17:47   ` Kevin Hilman
2013-04-03 17:47     ` Kevin Hilman
     [not found]     ` <87zjxfzetw.fsf-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2013-04-03 20:49       ` Daniel Lezcano
2013-04-03 20:49         ` Daniel Lezcano
     [not found]         ` <515C95BF.6030103-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2013-04-03 21:43           ` Kevin Hilman
2013-04-03 21:43             ` Kevin Hilman
2013-04-03 12:23 ` Daniel Lezcano [this message]
2013-04-03 12:23   ` [PATCH 1/9] ARM: cpuidle: remove useless declaration Daniel Lezcano
2013-04-08 20:50   ` Rafael J. Wysocki
2013-04-08 20:50     ` Rafael J. Wysocki
2013-04-08 20:53     ` Daniel Lezcano
2013-04-08 20:53       ` Daniel Lezcano
2013-04-18 14:13   ` Russell King - ARM Linux
2013-04-18 14:13     ` Russell King - ARM Linux
2013-04-18 14:31     ` Daniel Lezcano
2013-04-18 14:31       ` Daniel Lezcano
2013-04-18 15:42       ` Russell King - ARM Linux
2013-04-18 15:42         ` Russell King - ARM Linux
     [not found]         ` <20130418154236.GY14496-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2013-04-18 15:47           ` Daniel Lezcano
2013-04-18 15:47             ` Daniel Lezcano
  -- strict thread matches above, loose matches on Subject: below --
2013-04-03 10:56 Daniel Lezcano
2013-04-03 10:56 ` Daniel Lezcano
     [not found] ` <515C0AFB.80203-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2013-04-03 11:07   ` Rafael J. Wysocki
2013-04-03 11:07     ` Rafael J. Wysocki
2013-04-03 11:04     ` Daniel Lezcano
2013-04-03 11:04       ` Daniel Lezcano
2013-03-29 10:31 Daniel Lezcano
2013-03-29 10:31 ` Daniel Lezcano
     [not found] ` <1364553095-25110-1-git-send-email-daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2013-03-29 11:40   ` Santosh Shilimkar
2013-03-29 11:40     ` Santosh Shilimkar
     [not found]     ` <51557DC6.5060104-l0cyMroinI0@public.gmane.org>
2013-03-29 11:53       ` Daniel Lezcano
2013-03-29 11:53         ` Daniel Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=515C1F3B.5040008@linaro.org \
    --to=daniel.lezcano@linaro.org \
    --cc=deepthi@linux.vnet.ibm.com \
    --cc=horms+renesas@verge.net.au \
    --cc=josephl@nvidia.com \
    --cc=lenb@kernel.org \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=nsekhar@ti.com \
    --cc=patches@linaro.org \
    --cc=rjw@sisk.pl \
    --cc=rnayak@ti.com \
    --cc=swarren@wwwdotorg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.