* [PATCH] at91sam9260.dtsi: fix u(s)art pinctrl encoding
@ 2013-04-04 13:04 Douglas Gilbert
2013-04-04 16:04 ` Nicolas Ferre
2013-04-04 16:27 ` Nicolas Ferre
0 siblings, 2 replies; 4+ messages in thread
From: Douglas Gilbert @ 2013-04-04 13:04 UTC (permalink / raw)
To: linux-arm-kernel
A pattern is emerging with sloppy at91 dts(i) files
with pinctrls: the comments are correct and the
corresponding encoding is wrong. The other example that
I fixed was at91sam9x5.dtsi . Makes you wonder how many
people are using this DT stuff in anger ...
This problem was found with AT91SAM9G20 SoCs (Acme's FoxG20).
The attached is against lk 3.9.0-rc5 .
Doug Gilbert
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sam9260_390rc5dg1.patch
Type: text/x-patch
Size: 1443 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130404/fd268187/attachment.bin>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] at91sam9260.dtsi: fix u(s)art pinctrl encoding
2013-04-04 13:04 [PATCH] at91sam9260.dtsi: fix u(s)art pinctrl encoding Douglas Gilbert
@ 2013-04-04 16:04 ` Nicolas Ferre
2013-04-04 16:27 ` Nicolas Ferre
1 sibling, 0 replies; 4+ messages in thread
From: Nicolas Ferre @ 2013-04-04 16:04 UTC (permalink / raw)
To: linux-arm-kernel
On 04/04/2013 03:04 PM, Douglas Gilbert :
> A pattern is emerging with sloppy at91 dts(i) files
> with pinctrls: the comments are correct and the
> corresponding encoding is wrong. The other example that
> I fixed was at91sam9x5.dtsi . Makes you wonder how many
> people are using this DT stuff in anger ...
>
> This problem was found with AT91SAM9G20 SoCs (Acme's FoxG20).
> The attached is against lk 3.9.0-rc5 .
>
> pinctrl_usart3_rts: usart3_rts-0 {
> atmel,pins =
> - <3 8 0x2 0x0>; /* PB8 periph B */
> + <1 8 0x2 0x0>; /* PB8 periph B */
Here both the comment and the encoding were wrong:
it is PC8 periph B ==> <2 8 0x2 0x0>
> };
>
> pinctrl_usart3_cts: usart3_cts-0 {
> atmel,pins =
> - <3 10 0x2 0x0>; /* PB10 periph B */
> + <1 10 0x2 0x0>; /* PB10 periph B */
Same here:
it is PC10 periph B ==> <2 10 0x2 0x0>
> };
> };
I correct this in your patch and submit it right now.
Thanks, best regards,
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] ARM: at91/at91sam9260.dtsi: fix u(s)art pinctrl encoding
2013-04-04 13:04 [PATCH] at91sam9260.dtsi: fix u(s)art pinctrl encoding Douglas Gilbert
@ 2013-04-04 16:27 ` Nicolas Ferre
2013-04-04 16:27 ` Nicolas Ferre
1 sibling, 0 replies; 4+ messages in thread
From: Nicolas Ferre @ 2013-04-04 16:27 UTC (permalink / raw)
To: linux-arm-kernel, Jean-Christophe PLAGNIOL-VILLARD, dgilbert,
robertcnelson
Cc: jhovold, Ludovic Desroches, linux-kernel, Nicolas Ferre
From: Douglas Gilbert <dgilbert@interlog.com>
Signed-off-by: Douglas Gilbert <dgilbert@interlog.com>
[nicolas.ferre@atmel.com: fix rts/cts for usart3]
Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: stable <stable@vger.kernel.org> #3.8+
---
Hi,
v2: - add commit message
- correct rts/cts for usart3
- add stable tag
arch/arm/boot/dts/at91sam9260.dtsi | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/arch/arm/boot/dts/at91sam9260.dtsi b/arch/arm/boot/dts/at91sam9260.dtsi
index 367a604..3e2adfb 100644
--- a/arch/arm/boot/dts/at91sam9260.dtsi
+++ b/arch/arm/boot/dts/at91sam9260.dtsi
@@ -158,8 +158,8 @@
usart1 {
pinctrl_usart1: usart1-0 {
atmel,pins =
- <2 6 0x1 0x1 /* PB6 periph A with pullup */
- 2 7 0x1 0x0>; /* PB7 periph A */
+ <1 6 0x1 0x1 /* PB6 periph A with pullup */
+ 1 7 0x1 0x0>; /* PB7 periph A */
};
pinctrl_usart1_rts: usart1_rts-0 {
@@ -194,18 +194,18 @@
usart3 {
pinctrl_usart3: usart3-0 {
atmel,pins =
- <2 10 0x1 0x1 /* PB10 periph A with pullup */
- 2 11 0x1 0x0>; /* PB11 periph A */
+ <1 10 0x1 0x1 /* PB10 periph A with pullup */
+ 1 11 0x1 0x0>; /* PB11 periph A */
};
pinctrl_usart3_rts: usart3_rts-0 {
atmel,pins =
- <3 8 0x2 0x0>; /* PB8 periph B */
+ <2 8 0x2 0x0>; /* PC8 periph B */
};
pinctrl_usart3_cts: usart3_cts-0 {
atmel,pins =
- <3 10 0x2 0x0>; /* PB10 periph B */
+ <2 10 0x2 0x0>; /* PC10 periph B */
};
};
@@ -220,8 +220,8 @@
uart1 {
pinctrl_uart1: uart1-0 {
atmel,pins =
- <2 12 0x1 0x1 /* PB12 periph A with pullup */
- 2 13 0x1 0x0>; /* PB13 periph A */
+ <1 12 0x1 0x1 /* PB12 periph A with pullup */
+ 1 13 0x1 0x0>; /* PB13 periph A */
};
};
--
1.8.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2] ARM: at91/at91sam9260.dtsi: fix u(s)art pinctrl encoding
@ 2013-04-04 16:27 ` Nicolas Ferre
0 siblings, 0 replies; 4+ messages in thread
From: Nicolas Ferre @ 2013-04-04 16:27 UTC (permalink / raw)
To: linux-arm-kernel
From: Douglas Gilbert <dgilbert@interlog.com>
Signed-off-by: Douglas Gilbert <dgilbert@interlog.com>
[nicolas.ferre at atmel.com: fix rts/cts for usart3]
Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: stable <stable@vger.kernel.org> #3.8+
---
Hi,
v2: - add commit message
- correct rts/cts for usart3
- add stable tag
arch/arm/boot/dts/at91sam9260.dtsi | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/arch/arm/boot/dts/at91sam9260.dtsi b/arch/arm/boot/dts/at91sam9260.dtsi
index 367a604..3e2adfb 100644
--- a/arch/arm/boot/dts/at91sam9260.dtsi
+++ b/arch/arm/boot/dts/at91sam9260.dtsi
@@ -158,8 +158,8 @@
usart1 {
pinctrl_usart1: usart1-0 {
atmel,pins =
- <2 6 0x1 0x1 /* PB6 periph A with pullup */
- 2 7 0x1 0x0>; /* PB7 periph A */
+ <1 6 0x1 0x1 /* PB6 periph A with pullup */
+ 1 7 0x1 0x0>; /* PB7 periph A */
};
pinctrl_usart1_rts: usart1_rts-0 {
@@ -194,18 +194,18 @@
usart3 {
pinctrl_usart3: usart3-0 {
atmel,pins =
- <2 10 0x1 0x1 /* PB10 periph A with pullup */
- 2 11 0x1 0x0>; /* PB11 periph A */
+ <1 10 0x1 0x1 /* PB10 periph A with pullup */
+ 1 11 0x1 0x0>; /* PB11 periph A */
};
pinctrl_usart3_rts: usart3_rts-0 {
atmel,pins =
- <3 8 0x2 0x0>; /* PB8 periph B */
+ <2 8 0x2 0x0>; /* PC8 periph B */
};
pinctrl_usart3_cts: usart3_cts-0 {
atmel,pins =
- <3 10 0x2 0x0>; /* PB10 periph B */
+ <2 10 0x2 0x0>; /* PC10 periph B */
};
};
@@ -220,8 +220,8 @@
uart1 {
pinctrl_uart1: uart1-0 {
atmel,pins =
- <2 12 0x1 0x1 /* PB12 periph A with pullup */
- 2 13 0x1 0x0>; /* PB13 periph A */
+ <1 12 0x1 0x1 /* PB12 periph A with pullup */
+ 1 13 0x1 0x0>; /* PB13 periph A */
};
};
--
1.8.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-04-04 16:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-04-04 13:04 [PATCH] at91sam9260.dtsi: fix u(s)art pinctrl encoding Douglas Gilbert
2013-04-04 16:04 ` Nicolas Ferre
2013-04-04 16:27 ` [PATCH v2] ARM: at91/at91sam9260.dtsi: " Nicolas Ferre
2013-04-04 16:27 ` Nicolas Ferre
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.